Skip to contentSkip to conversation

MAINTAINERS: Name and email address change

PATCH Superseded Hanna Reitz 3 participants 7 messages Aug 10, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Name and email address change

I have changed my name and email address. Update the MAINTAINERS file to match.

---
 MAINTAINERS | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
MAINTAINERS +4 -4
index 37b1a8e442..694973ed23 100644
@@ -2270,7 +2270,7 @@ F: tests/qtest/fuzz-sb16-test.c
 
 Block layer core
 M: Kevin Wolf <[email protected]>
-M: Max Reitz <[email protected]>
+M: Hanna Reitz <[email protected]>
 L: [email protected]
 S: Supported
 F: block*
@@ -3265,7 +3265,7 @@ F: stubs/io_uring.c
 
 qcow2
 M: Kevin Wolf <[email protected]>
-M: Max Reitz <[email protected]>
+M: Hanna Reitz <[email protected]>
 L: [email protected]
 S: Supported
 F: block/qcow2*
@@ -3279,7 +3279,7 @@ F: block/qcow.c
 
 blkdebug
 M: Kevin Wolf <[email protected]>
-M: Max Reitz <[email protected]>
+M: Hanna Reitz <[email protected]>
 L: [email protected]
 S: Supported
 F: block/blkdebug.c
@@ -3314,7 +3314,7 @@ F: tests/qtest/vhost-user-blk-test.c
 F: util/vhost-user-server.c
 
 FUSE block device exports
-M: Max Reitz <[email protected]>
+M: Hanna Reitz <[email protected]>
 L: [email protected]
 S: Supported
 F: block/export/fuse.c
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Hanna Reitz

I have changed my name and email address. Update the MAINTAINERS file to match.

---
 MAINTAINERS | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

I'd recommend you to also add an entry in .mailmap:

-- >8 --

.mailmap +0 -0
index 082ff893ab3..504839c84d3 100644
@@ -53,6 +53,7 @@ Anthony Liguori <[email protected]> Anthony

Liguori <[email protected]>
Filip Bozuta <[email protected]> <[email protected]> Frederic Konrad <[email protected]> <[email protected]> Greg Kurz <[email protected]> <[email protected]>
+Hanna Reitz <[email protected]> <[email protected]>
Huacai Chen <[email protected]> <[email protected]> Huacai Chen <[email protected]> <[email protected]> James Hogan <[email protected]> <[email protected]>
---

As it or with .mailmap modified:

#2 lore raw
Quoted 17 lines · Philippe Mathieu-Daudé
Quoted 7 lines · Hanna Reitz

I have changed my name and email address. Update the MAINTAINERS file to match.

---
  MAINTAINERS | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

I'd recommend you to also add an entry in .mailmap:

-- >8 --

.mailmap +0 -0
index 082ff893ab3..504839c84d3 100644
@@ -53,6 +53,7 @@ Anthony Liguori <[email protected]> Anthony

Liguori <[email protected]>

Quoted 8 lines

Filip Bozuta <[email protected]> <[email protected]> Frederic Konrad <[email protected]> <[email protected]> Greg Kurz <[email protected]> <[email protected]>
+Hanna Reitz <[email protected]> <[email protected]>
Huacai Chen <[email protected]> <[email protected]> Huacai Chen <[email protected]> <[email protected]> James Hogan <[email protected]> <[email protected]>
---

Hu, I didn’t know there is such a thing.  Looks like I could even do

Hanna Reitz <[email protected]> Max Reitz <[email protected]>

Feels a bit like cheating, though...?

Quoted 2 lines

As it or with .mailmap modified:

#3 lore raw
Quoted 29 lines · Hanna Reitz
Quoted 17 lines · Philippe Mathieu-Daudé
Quoted 7 lines · Hanna Reitz

I have changed my name and email address.  Update the MAINTAINERS file to match.

---
  MAINTAINERS | 8 ++++----

  1 file changed, 4 insertions(+), 4 deletions(-)

I'd recommend you to also add an entry in .mailmap:

-- >8 --

.mailmap +0 -0
index 082ff893ab3..504839c84d3 100644
@@ -53,6 +53,7 @@ Anthony Liguori <[email protected]> Anthony

Liguori <[email protected]>

Quoted 8 lines

  Filip Bozuta <[email protected]> <[email protected]> Frederic Konrad <[email protected]> <[email protected]> Greg Kurz <[email protected]> <[email protected]> +Hanna Reitz <[email protected]> <[email protected]> Huacai Chen <[email protected]> <[email protected]> Huacai Chen <[email protected]> <[email protected]> James Hogan <[email protected]> <[email protected]>
---

Hu, I didn’t know there is such a thing.  Looks like I could even do

Quoted 1 line

Hanna Reitz <[email protected]> Max Reitz <[email protected]>

If you want to restrict to 'Max Reitz', but without it it will simply take all mails from <mreitz@>. IMO KISS, no need to filter by name in your case :)

Quoted 1 line

Feels a bit like cheating, though...?

No, why? The "preferred name forms" section seems adequate.

Quoted 2 lines
Quoted 2 lines

As it or with .mailmap modified:

What is nice with .mailmap is the combination with ./get_maintainers.pl, in particular when it defaults looking at commit history. If you Sob/Acked a commit as Max, the script (call by git-send-email) will replace it by Hanna.

For the contribution statistics, all your previous contributions as Max will be directly shown as Hanna (along with your future ones).

#4 lore raw
Quoted 29 lines · Philippe Mathieu-Daudé
Quoted 28 lines · Hanna Reitz
Quoted 17 lines · Philippe Mathieu-Daudé
Quoted 7 lines · Hanna Reitz

I have changed my name and email address.  Update the MAINTAINERS file to match.

---
   MAINTAINERS | 8 ++++----
   1 file changed, 4 insertions(+), 4 deletions(-)

I'd recommend you to also add an entry in .mailmap:

-- >8 --

.mailmap +0 -0
index 082ff893ab3..504839c84d3 100644
@@ -53,6 +53,7 @@ Anthony Liguori <[email protected]> Anthony

Liguori <[email protected]>

Quoted 8 lines

  Filip Bozuta <[email protected]> <[email protected]> Frederic Konrad <[email protected]> <[email protected]> Greg Kurz <[email protected]> <[email protected]>
+Hanna Reitz <[email protected]> <[email protected]>
  Huacai Chen <[email protected]> <[email protected]> Huacai Chen <[email protected]> <[email protected]> James Hogan <[email protected]> <[email protected]>
---

Hu, I didn’t know there is such a thing.  Looks like I could even do

Quoted 4 lines
Quoted 1 line

Hanna Reitz <[email protected]> Max Reitz <[email protected]>

If you want to restrict to 'Max Reitz', but without it it will simply take all mails from <mreitz@>. IMO KISS, no need to filter by name in your case :)

Oh, right.  I thought not giving the name would only replace the email address, for some reason.

Quoted 2 lines
Quoted 1 line

Feels a bit like cheating, though...?

No, why? The "preferred name forms" section seems adequate.

Well.  It’s not exactly a preferred name form, is it.

But it is a case of “git author config” change, so I suppose it fits best.

Quoted 6 lines
Quoted 2 lines
Quoted 2 lines

As it or with .mailmap modified:

What is nice with .mailmap is the combination with ./get_maintainers.pl, in particular when it defaults looking at commit history. If you Sob/Acked a commit as Max, the script (call by git-send-email) will replace it by Hanna.

That almost sounds like a reason not to do it.  You know, so I can deny any involvement on maintainer-less files. O:)

Quoted 2 lines

For the contribution statistics, all your previous contributions as Max will be directly shown as Hanna (along with your future ones).

OK, well, if you insist. :)

Hanna

#5 lore raw
In reply to Hanna Reitz
Quoted 29 lines · Hanna Reitz
Quoted 17 lines · Philippe Mathieu-Daudé
Quoted 7 lines · Hanna Reitz

I have changed my name and email address. Update the MAINTAINERS file to match.

---
  MAINTAINERS | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

I'd recommend you to also add an entry in .mailmap:

-- >8 --

.mailmap +0 -0
index 082ff893ab3..504839c84d3 100644
@@ -53,6 +53,7 @@ Anthony Liguori <[email protected]> Anthony

Liguori <[email protected]>

Quoted 8 lines

Filip Bozuta <[email protected]> <[email protected]> Frederic Konrad <[email protected]> <[email protected]> Greg Kurz <[email protected]> <[email protected]>
+Hanna Reitz <[email protected]> <[email protected]>
Huacai Chen <[email protected]> <[email protected]> Huacai Chen <[email protected]> <[email protected]> James Hogan <[email protected]> <[email protected]>
---

Hu, I didn’t know there is such a thing.  Looks like I could even do

Quoted 1 line

Hanna Reitz <[email protected]> Max Reitz <[email protected]>

With the line Philippe suggested, the rewrite will happen any time the original email is seen. With this line, the rewrite will only happen if both original name + email match. In practice this is functionally the same, unless someone had variations in the spelling of their real name over time, so either would work.

Quoted 1 line

Feels a bit like cheating, though...?

I wouldn't call it cheating. It is just an input for canonicalizing contributors' identities, where there were changes in name or email over time. It gives a more useful view to tools like 'git shortlog' and 'git-dm' stats reports, such that all work over time will be grouped together instead of split.

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#6 lore raw
Quoted 29 lines · Daniel P. Berrangé
Quoted 28 lines · Hanna Reitz
Quoted 17 lines · Philippe Mathieu-Daudé
Quoted 7 lines · Hanna Reitz

I have changed my name and email address. Update the MAINTAINERS file to match.

---
   MAINTAINERS | 8 ++++----
   1 file changed, 4 insertions(+), 4 deletions(-)

I'd recommend you to also add an entry in .mailmap:

-- >8 --

.mailmap +0 -0
index 082ff893ab3..504839c84d3 100644
@@ -53,6 +53,7 @@ Anthony Liguori <[email protected]> Anthony

Liguori <[email protected]>

Quoted 8 lines

Filip Bozuta <[email protected]> <[email protected]> Frederic Konrad <[email protected]> <[email protected]> Greg Kurz <[email protected]> <[email protected]>
+Hanna Reitz <[email protected]> <[email protected]>
Huacai Chen <[email protected]> <[email protected]> Huacai Chen <[email protected]> <[email protected]> James Hogan <[email protected]> <[email protected]>
---

Hu, I didn’t know there is such a thing.  Looks like I could even do

Quoted 6 lines
Quoted 1 line

Hanna Reitz <[email protected]> Max Reitz <[email protected]>

With the line Philippe suggested, the rewrite will happen any time the original email is seen. With this line, the rewrite will only happen if both original name + email match. In practice this is functionally the same, unless someone had variations in the spelling of their real name over time, so either would work.

Ah, yes, I somehow believed that not specifying the old name would just replace the email address.  You’re right.

Quoted 6 lines
Quoted 1 line

Feels a bit like cheating, though...?

I wouldn't call it cheating. It is just an input for canonicalizing contributors' identities, where there were changes in name or email over time. It gives a more useful view to tools like 'git shortlog' and 'git-dm' stats reports, such that all work over time will be grouped together instead of split.

Alright.

Hanna