Skip to contentSkip to conversation

drm/gpuvm: Dual-licence the drm_gpuvm code GPL-2.0 OR MIT

PATCH In review Thomas Hellström 3 participants 4 messages Oct 10, 2023 – Oct 17, 2023

Subsystems (3)
lore
Share & tools
lore

Thomas Hellström

author reviewer
#0 lore raw

PATCH 1/1 drm/gpuvm: Dual-licence the drm_gpuvm code GPL-2.0 OR MIT

Dual-licence in order to make it possible for other non-GPL os'es to re-implement the code. The use of EXPORT_SYMBOL_GPL() is intentionally left untouched to prevent use of drm_gpuvm as a proxy for non-GPL drivers to access GPL-only kernel symbols.

Much of the ideas and algorithms used in the drm_gpuvm code is already present in one way or another in MIT-licensed code.

---
 drivers/gpu/drm/drm_gpuvm.c | 2 +-
 include/drm/drm_gpuvm.h     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_gpuvm.c +1 -1
index 02ce6baacdad..08c088319652 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0-only
+// SPDX-License-Identifier: GPL-2.0 OR MIT
 /*
  * Copyright (c) 2022 Red Hat.
  *
include/drm/drm_gpuvm.h +1 -1
index 361fea5cb849..21bbf11415b3 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
+/* SPDX-License-Identifier: GPL-2.0 OR MIT */
 
 #ifndef __DRM_GPUVM_H__
 #define __DRM_GPUVM_H__
Signature · 1 line
2.41.0
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Thomas Hellström

Dual-licence in order to make it possible for other non-GPL os'es to re-implement the code. The use of EXPORT_SYMBOL_GPL() is intentionally left untouched to prevent use of drm_gpuvm as a proxy for non-GPL drivers to access GPL-only kernel symbols.

Quoted 8 lines

Much of the ideas and algorithms used in the drm_gpuvm code is already present in one way or another in MIT-licensed code.

Quoted 28 lines
---
 drivers/gpu/drm/drm_gpuvm.c | 2 +-
 include/drm/drm_gpuvm.h     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_gpuvm.c +1 -1
index 02ce6baacdad..08c088319652 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0-only
+// SPDX-License-Identifier: GPL-2.0 OR MIT
 /*
  * Copyright (c) 2022 Red Hat.
  *
include/drm/drm_gpuvm.h +1 -1
index 361fea5cb849..21bbf11415b3 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
+/* SPDX-License-Identifier: GPL-2.0 OR MIT */
 
 #ifndef __DRM_GPUVM_H__
 #define __DRM_GPUVM_H__
Signature · 1 line
2.41.0
author reviewer
#2 lore raw
Quoted 9 lines · Danilo Krummrich
Quoted 8 lines · Thomas Hellström

Dual-licence in order to make it possible for other non-GPL os'es to re-implement the code. The use of EXPORT_SYMBOL_GPL() is intentionally left untouched to prevent use of drm_gpuvm as a proxy for non-GPL drivers to access GPL-only kernel symbols.

Much of the ideas and algorithms used in the drm_gpuvm code is already present in one way or another in MIT-licensed code.

Quoted 6 lines
Quoted 5 lines

Thanks, Danilo

Thomas

Quoted 29 lines
Quoted 29 lines
---
  drivers/gpu/drm/drm_gpuvm.c | 2 +-
  include/drm/drm_gpuvm.h     | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_gpuvm.c +1 -1
index 02ce6baacdad..08c088319652 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0-only
+// SPDX-License-Identifier: GPL-2.0 OR MIT
  /*
   * Copyright (c) 2022 Red Hat.
   *
include/drm/drm_gpuvm.h +1 -1
index 361fea5cb849..21bbf11415b3 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
+/* SPDX-License-Identifier: GPL-2.0 OR MIT */
 
  #ifndef __DRM_GPUVM_H__
  #define __DRM_GPUVM_H__
Signature · 1 line
2.41.0
Reviewed-by
#3 lore raw
Quoted 11 lines · Thomas Hellström
Quoted 9 lines · Danilo Krummrich
Quoted 8 lines · Thomas Hellström

Dual-licence in order to make it possible for other non-GPL os'es to re-implement the code. The use of EXPORT_SYMBOL_GPL() is intentionally left untouched to prevent use of drm_gpuvm as a proxy for non-GPL drivers to access GPL-only kernel symbols.

Much of the ideas and algorithms used in the drm_gpuvm code is already present in one way or another in MIT-licensed code.

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

As this was acked by author:

Quoted 34 lines

Thanks, Danilo

Thomas

Quoted 28 lines
Quoted 28 lines
---
  drivers/gpu/drm/drm_gpuvm.c | 2 +-
  include/drm/drm_gpuvm.h     | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_gpuvm.c +1 -1
index 02ce6baacdad..08c088319652 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0-only
+// SPDX-License-Identifier: GPL-2.0 OR MIT
  /*
   * Copyright (c) 2022 Red Hat.
   *
include/drm/drm_gpuvm.h +1 -1
index 361fea5cb849..21bbf11415b3 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
+/* SPDX-License-Identifier: GPL-2.0 OR MIT */
  #ifndef __DRM_GPUVM_H__
  #define __DRM_GPUVM_H__
Signature · 1 line
2.41.0