Skip to contentSkip to conversation

ASoC: Enable built-in microphone on Lenovo ThinkPad P14s Gen 4 (AMD)

PATCH NAK Michael T. Kloos 2 participants 3 messages Dec 11, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Enable built-in microphone on Lenovo ThinkPad P14s Gen 4 (AMD)

Added System Board to Quirks List using model number prefix. Replaced/Removed a duplicate entry in the list.
Added Yellow Carp Coprocessor Revision number to PCI revision check.

---
 sound/soc/amd/yc/acp6x-mach.c | 2 +-
 sound/soc/amd/yc/pci-acp6x.c  | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
sound/soc/amd/yc/acp6x-mach.c +1 -1
index d83cb6e4c62a..c08605d99bc9 100644
@@ -56,7 +56,7 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 		.driver_data = &acp6x_card,
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "21K5"),
 		}
 	},
 	{
sound/soc/amd/yc/pci-acp6x.c +1 -0
index 7af6a349b1d4..694b8e313902 100644
@@ -162,6 +162,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
 	/* Yellow Carp device check */
 	switch (pci->revision) {
 	case 0x60:
+	case 0x63:
 	case 0x6f:
 		break;
 	default:
Signature · 1 line
2.42.0
#1 lore raw
Quoted 5 lines · Michael T. Kloos

Added System Board to Quirks List using model number prefix. Replaced/Removed a duplicate entry in the list.
Added Yellow Carp Coprocessor Revision number to PCI revision check.

NAK.

This is supposed to be supported by ACP 6.3 (Pink Sardine). Did you enable that driver?

Can you please share more about your problem?

Quoted 30 lines
---
  sound/soc/amd/yc/acp6x-mach.c | 2 +-
  sound/soc/amd/yc/pci-acp6x.c  | 1 +
  2 files changed, 2 insertions(+), 1 deletion(-)
sound/soc/amd/yc/acp6x-mach.c +1 -1
index d83cb6e4c62a..c08605d99bc9 100644
@@ -56,7 +56,7 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
  		.driver_data = &acp6x_card,
  		.matches = {
  			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "21K5"),
  		}
  	},
  	{
sound/soc/amd/yc/pci-acp6x.c +1 -0
index 7af6a349b1d4..694b8e313902 100644
@@ -162,6 +162,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
  	/* Yellow Carp device check */
  	switch (pci->revision) {
  	case 0x60:
+	case 0x63:
  	case 0x6f:
  		break;
  	default:
#2 lore raw
Quoted 3 lines

This is supposed to be supported by ACP 6.3 (Pink Sardine).  Did you enable that driver?
Can you please share more about your problem?

Enabled it and it is now working. I wish I knew that 24 hours ago. Would have saved a lot of time and effort. Haha. Disregard the patch. Thank you, Mario.