Skip to contentSkip to conversation

Add common1 register space for TI Keystone displays

PATCH In review Devarsh Thakkar 5 participants 13 messages Jan 15, 2024 – Feb 14, 2024

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

cover Add common1 register space for TI Keystone displays

Add common1 register space for SoC's supporting TI Keystone displays present in AM65x and AM62x SoCs. This is required to support use-cases where Linux may want to use common1 region instead of common region with the latter being controlled by another processing core.

The enumeration of common1 region in device-tree bindings seem to be a miss as ideally bindings should enumerate all supported register spaces as done in Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml which also uses TI Keystone display subsystem albeit with some more features.

Devarsh Thakkar (2):
dt-bindings: display: ti,am65x-dss: Add support for common1 region
arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs

 .../devicetree/bindings/display/ti/ti,am65x-dss.yaml       | 7 +++++--
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi                   | 5 +++--
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi                   | 5 +++--
 3 files changed, 11 insertions(+), 6 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/2 dt-bindings: display: ti,am65x-dss: Add support for common1 region

TI keystone display subsystem present in AM65 and other SoCs such as AM62 support two separate register spaces namely "common" and "common1" which can be used by two separate hosts to program the display controller as described in respective Technical Reference Manuals [1].

The common1 register space has similar set of configuration registers as supported in common register space except the global configuration registers which are exclusive to common region.

This adds binding for "common1" register region too as supported by the hardware.

[1]:
AM62x TRM:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)

AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)

---
 .../devicetree/bindings/display/ti/ti,am65x-dss.yaml       | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +5 -2
index b6767ef0d24d..55e3e490d0e6 100644
@@ -37,6 +37,7 @@ properties:
       - description: OVR2 overlay manager for vp2
       - description: VP1 video port 1
       - description: VP2 video port 2
+      - description: common1 DSS register area
 
   reg-names:
     items:
@@ -47,6 +48,7 @@ properties:
       - const: ovr2
       - const: vp1
       - const: vp2
+      - const: common1
 
   clocks:
     items:
@@ -147,9 +149,10 @@ examples:
                     <0x04a07000 0x1000>, /* ovr1 */
                     <0x04a08000 0x1000>, /* ovr2 */
                     <0x04a0a000 0x1000>, /* vp1 */
-                    <0x04a0b000 0x1000>; /* vp2 */
+                    <0x04a0b000 0x1000>, /* vp2 */
+                    <0x04a01000 0x1000>; /* common1 */
             reg-names = "common", "vidl1", "vid",
-                    "ovr1", "ovr2", "vp1", "vp2";
+                    "ovr1", "ovr2", "vp1", "vp2", "common1";
             ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>;
             power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>;
             clocks =        <&k3_clks 67 1>,
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region

Quoted 1 line · Devarsh Thakkar

TI keystone display subsystem present in AM65 and other SoCs such as AM62

Do all 3 SoCs supported by this binding (am625 am62a7 am65x) have this common1 register? If not, you should limit it the platforms that do have it.

Thanks,
Conor.

Quoted 59 lines

support two separate register spaces namely "common" and "common1" which can be used by two separate hosts to program the display controller as described in respective Technical Reference Manuals [1].

The common1 register space has similar set of configuration registers as supported in common register space except the global configuration registers which are exclusive to common region.

This adds binding for "common1" register region too as supported by the hardware.

[1]:
AM62x TRM:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)

AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)

---
 .../devicetree/bindings/display/ti/ti,am65x-dss.yaml       | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +5 -2
index b6767ef0d24d..55e3e490d0e6 100644
@@ -37,6 +37,7 @@ properties:
       - description: OVR2 overlay manager for vp2
       - description: VP1 video port 1
       - description: VP2 video port 2
+      - description: common1 DSS register area
 
   reg-names:
     items:
@@ -47,6 +48,7 @@ properties:
       - const: ovr2
       - const: vp1
       - const: vp2
+      - const: common1
 
   clocks:
     items:
@@ -147,9 +149,10 @@ examples:
                     <0x04a07000 0x1000>, /* ovr1 */
                     <0x04a08000 0x1000>, /* ovr2 */
                     <0x04a0a000 0x1000>, /* vp1 */
-                    <0x04a0b000 0x1000>; /* vp2 */
+                    <0x04a0b000 0x1000>, /* vp2 */
+                    <0x04a01000 0x1000>; /* common1 */
             reg-names = "common", "vidl1", "vid",
-                    "ovr1", "ovr2", "vp1", "vp2";
+                    "ovr1", "ovr2", "vp1", "vp2", "common1";
             ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>;
             power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>;
             clocks =        <&k3_clks 67 1>,
Signature · 1 line
2.34.1
#3 lore raw

Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region

Hi Conor,

Thanks for the review.

Quoted 7 lines · Conor Dooley
Quoted 1 line · Devarsh Thakkar

TI keystone display subsystem present in AM65 and other SoCs such as AM62

Do all 3 SoCs supported by this binding (am625 am62a7 am65x) have this common1 register? If not, you should limit it the platforms that do have it.

Yes all 3 SoCs supported by binding have common1 register space supported.

AM62x TRM:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)

AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)

AM62A TRM:
https://www.ti.com/lit/pdf/spruj16 (Section 14.9.9.1 DSS Registers)

Regards
Devarsh

Quoted 62 lines

Thanks,
Conor.

Quoted 59 lines

support two separate register spaces namely "common" and "common1" which can be used by two separate hosts to program the display controller as described in respective Technical Reference Manuals [1].

The common1 register space has similar set of configuration registers as supported in common register space except the global configuration registers which are exclusive to common region.

This adds binding for "common1" register region too as supported by the hardware.

[1]:
AM62x TRM:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)

AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)

---
 .../devicetree/bindings/display/ti/ti,am65x-dss.yaml       | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +5 -2
index b6767ef0d24d..55e3e490d0e6 100644
@@ -37,6 +37,7 @@ properties:
       - description: OVR2 overlay manager for vp2
       - description: VP1 video port 1
       - description: VP2 video port 2
+      - description: common1 DSS register area
 
   reg-names:
     items:
@@ -47,6 +48,7 @@ properties:
       - const: ovr2
       - const: vp1
       - const: vp2
+      - const: common1
 
   clocks:
     items:
@@ -147,9 +149,10 @@ examples:
                     <0x04a07000 0x1000>, /* ovr1 */
                     <0x04a08000 0x1000>, /* ovr2 */
                     <0x04a0a000 0x1000>, /* vp1 */
-                    <0x04a0b000 0x1000>; /* vp2 */
+                    <0x04a0b000 0x1000>, /* vp2 */
+                    <0x04a01000 0x1000>; /* common1 */
             reg-names = "common", "vidl1", "vid",
-                    "ovr1", "ovr2", "vp1", "vp2";
+                    "ovr1", "ovr2", "vp1", "vp2", "common1";
             ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>;
             power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>;
             clocks =        <&k3_clks 67 1>,
Signature · 1 line
2.34.1
Acked-by
#4 lore raw

Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region

Quoted 6 lines · Devarsh Thakkar

Hi Conor,

Thanks for the review.

Quoted 1 line · Conor Dooley

On Mon, Jan 15, 2024 at 06:27:15PM +0530, Devarsh Thakkar wrote:

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

TI keystone display subsystem present in AM65 and other SoCs such as AM62

Do all 3 SoCs supported by this binding (am625 am62a7 am65x) have this common1 register? If not, you should limit it the platforms that do have it.

Yes all 3 SoCs supported by binding have common1 register space supported.

Okay, thanks.

Cheers,
Conor.

maintainer
#5 lore raw

Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region

In reply to Devarsh Thakkar

Hi,

Quoted 47 lines · Devarsh Thakkar

TI keystone display subsystem present in AM65 and other SoCs such as AM62 support two separate register spaces namely "common" and "common1" which can be used by two separate hosts to program the display controller as described in respective Technical Reference Manuals [1].

The common1 register space has similar set of configuration registers as supported in common register space except the global configuration registers which are exclusive to common region.

This adds binding for "common1" register region too as supported by the hardware.

[1]:
AM62x TRM:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)

AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)

---
  .../devicetree/bindings/display/ti/ti,am65x-dss.yaml       | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +2 -0
index b6767ef0d24d..55e3e490d0e6 100644
@@ -37,6 +37,7 @@ properties:
        - description: OVR2 overlay manager for vp2
        - description: VP1 video port 1
        - description: VP2 video port 2
+      - description: common1 DSS register area
 
    reg-names:
      items:
@@ -47,6 +48,7 @@ properties:
        - const: ovr2
        - const: vp1
        - const: vp2
+      - const: common1
 
    clocks:
      items:
@@ -147,9 +149,10 @@ examples:
                      <0x04a07000 0x1000>, /* ovr1 */
                      <0x04a08000 0x1000>, /* ovr2 */

Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml examples: · line 158

Quoted 10 lines
Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +3 -2
                      <0x04a0a000 0x1000>, /* vp1 */
-                    <0x04a0b000 0x1000>; /* vp2 */
+                    <0x04a0b000 0x1000>, /* vp2 */
+                    <0x04a01000 0x1000>; /* common1 */
              reg-names = "common", "vidl1", "vid",
-                    "ovr1", "ovr2", "vp1", "vp2";
+                    "ovr1", "ovr2", "vp1", "vp2", "common1";
              ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>;
              power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>;
              clocks =        <&k3_clks 67 1>,

Looks fine to me, I'll apply to drm-misc-next.

Tomi

maintainer
#6 lore raw

Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region

Quoted 52 lines · Tomi Valkeinen

Hi,

Quoted 49 lines · Devarsh Thakkar

TI keystone display subsystem present in AM65 and other SoCs such as AM62 support two separate register spaces namely "common" and "common1" which can be used by two separate hosts to program the display controller as described in respective Technical Reference Manuals [1].

The common1 register space has similar set of configuration registers as supported in common register space except the global configuration registers which are exclusive to common region.

This adds binding for "common1" register region too as supported by the hardware.

[1]:
AM62x TRM:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)

AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)

---
  .../devicetree/bindings/display/ti/ti,am65x-dss.yaml       | 7 +++++--

  1 file changed, 5 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +0 -0
index b6767ef0d24d..55e3e490d0e6 100644
@@ -37,6 +37,7 @@ properties:

        - description: OVR2 overlay manager for vp2
        - description: VP1 video port 1
        - description: VP2 video port 2
+      - description: common1 DSS register area reg-names:
      items:

Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +0 -0
@@ -47,6 +48,7 @@ properties:

        - const: ovr2
        - const: vp1
        - const: vp2
+      - const: common1
    clocks:
      items:

Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +0 -0
@@ -147,9 +149,10 @@ examples:

                      <0x04a07000 0x1000>, /* ovr1 */ <0x04a08000 0x1000>, /* ovr2 */ <0x04a0a000 0x1000>, /* vp1 */ -                    <0x04a0b000 0x1000>; /* vp2 */ +                    <0x04a0b000 0x1000>, /* vp2 */ +                    <0x04a01000 0x1000>; /* common1 */

Quoted 8 lines
Quoted 6 lines

              reg-names = "common", "vidl1", "vid",
-                    "ovr1", "ovr2", "vp1", "vp2";
+                    "ovr1", "ovr2", "vp1", "vp2", "common1"; ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>; power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>; clocks =        <&k3_clks 67 1>,

Looks fine to me, I'll apply to drm-misc-next.

Hmm, now thinking about this, doesn't this cause dtb checks to start failing, as the dtbs are missing one entry? Is it better to merge these kind of changes with the dts changes? Or does it matter?

Tomi

#7 lore raw

Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region

Hi Tomi, Vignesh,

Quoted 63 lines · Tomi Valkeinen
Quoted 53 lines · Tomi Valkeinen

Hi,

Quoted 50 lines · Devarsh Thakkar

TI keystone display subsystem present in AM65 and other SoCs such as AM62 support two separate register spaces namely "common" and "common1" which can be used by two separate hosts to program the display controller as described in respective Technical Reference Manuals [1].

The common1 register space has similar set of configuration registers as supported in common register space except the global configuration registers which are exclusive to common region.

This adds binding for "common1" register region too as supported by the hardware.

[1]:
AM62x TRM:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)

AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)

---
  .../devicetree/bindings/display/ti/ti,am65x-dss.yaml       | 7 +++++--

  1 file changed, 5 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +0 -0
index b6767ef0d24d..55e3e490d0e6 100644
@@ -37,6 +37,7 @@ properties:

        - description: OVR2 overlay manager for vp2
        - description: VP1 video port 1
        - description: VP2 video port 2
+      - description: common1 DSS register area reg-names:
      items:

Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +0 -0
@@ -47,6 +48,7 @@ properties:

        - const: ovr2
        - const: vp1
        - const: vp2
+      - const: common1
    clocks:
      items:

Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +0 -0
@@ -147,9 +149,10 @@ examples:

                      <0x04a07000 0x1000>, /* ovr1 */ <0x04a08000 0x1000>, /* ovr2 */ <0x04a0a000 0x1000>, /* vp1 */ -                    <0x04a0b000 0x1000>; /* vp2 */ +                    <0x04a0b000 0x1000>, /* vp2 */ +                    <0x04a01000 0x1000>; /* common1 */

Quoted 8 lines
Quoted 6 lines

              reg-names = "common", "vidl1", "vid",
-                    "ovr1", "ovr2", "vp1", "vp2";
+                    "ovr1", "ovr2", "vp1", "vp2", "common1"; ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>; power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>; clocks =        <&k3_clks 67 1>,

Looks fine to me, I'll apply to drm-misc-next.

Quoted 4 lines

Hmm, now thinking about this, doesn't this cause dtb checks to start failing, as the dtbs are missing one entry? Is it better to merge these kind of changes with the dts changes? Or does it matter?

Yes if one get's applied and other doesn't then there will be such issues. I am sending shortly both the dt-binding and device-tree patches together, as long as both look fine and ready to be accepted by respective maintainers, I think both can get merged to respective trees and land in linux-next without causing any issues.

Regards
Devarsh

Quoted 2 lines

 Tomi

#8 lore raw

PATCH 2/2 arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs

In reply to Devarsh Thakkar

This adds common1 register space for AM62x and AM65x SoC's which are using TI's Keystone display hardware and supporting it as described in Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml.

This region is documented in respective Technical Reference Manuals [1].

[1]:
AM62x TRM:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)

AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)

---
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 5 +++--
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-am62-main.dtsi +3 -2
index 464b7565d085..298bf8d5de8c 100644
@@ -779,9 +779,10 @@ dss: dss@30200000 {
 		      <0x00 0x30207000 0x00 0x1000>, /* ovr1 */
 		      <0x00 0x30208000 0x00 0x1000>, /* ovr2 */
 		      <0x00 0x3020a000 0x00 0x1000>, /* vp1: Used for OLDI */
-		      <0x00 0x3020b000 0x00 0x1000>; /* vp2: Used as DPI Out */
+		      <0x00 0x3020b000 0x00 0x1000>, /* vp2: Used as DPI Out */
+		      <0x00 0x30201000 0x00 0x1000>; /* common1 */
 		reg-names = "common", "vidl1", "vid",
-			    "ovr1", "ovr2", "vp1", "vp2";
+			    "ovr1", "ovr2", "vp1", "vp2", "common1";
 		power-domains = <&k3_pds 186 TI_SCI_PD_EXCLUSIVE>;
 		clocks = <&k3_clks 186 6>,
 			 <&dss_vp1_clk>,
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +3 -2
index fcea54465636..5b2d4365b911 100644
@@ -1019,9 +1019,10 @@ dss: dss@4a00000 {
 		      <0x0 0x04a07000 0x0 0x1000>, /* ovr1 */
 		      <0x0 0x04a08000 0x0 0x1000>, /* ovr2 */
 		      <0x0 0x04a0a000 0x0 0x1000>, /* vp1 */
-		      <0x0 0x04a0b000 0x0 0x1000>; /* vp2 */
+		      <0x0 0x04a0b000 0x0 0x1000>, /* vp2 */
+		      <0x0 0x04a01000 0x0 0x1000>; /* common1 */
 		reg-names = "common", "vidl1", "vid",
-			"ovr1", "ovr2", "vp1", "vp2";
+			"ovr1", "ovr2", "vp1", "vp2", "common1";
 
 		ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>;
 
Signature · 1 line
2.34.1
#9 lore raw

Re: [DO NOT MERGE PATCH 2/2] arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs

Quoted 10 lines · Devarsh Thakkar

This adds common1 register space for AM62x and AM65x SoC's which are using TI's Keystone display hardware and supporting it as described in Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml.

This region is documented in respective Technical Reference Manuals [1].

[1]:
AM62x TRM:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)

Quoted 5 lines

AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)

---

"[DO NOT MERGE PATCH 2/2]" but no rationale here as to why this cannot be merged? What's the problem with it?

Cheers,
Conor.

Quoted 41 lines
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 5 +++--
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-am62-main.dtsi +3 -2
index 464b7565d085..298bf8d5de8c 100644
@@ -779,9 +779,10 @@ dss: dss@30200000 {
 		      <0x00 0x30207000 0x00 0x1000>, /* ovr1 */
 		      <0x00 0x30208000 0x00 0x1000>, /* ovr2 */
 		      <0x00 0x3020a000 0x00 0x1000>, /* vp1: Used for OLDI */
-		      <0x00 0x3020b000 0x00 0x1000>; /* vp2: Used as DPI Out */
+		      <0x00 0x3020b000 0x00 0x1000>, /* vp2: Used as DPI Out */
+		      <0x00 0x30201000 0x00 0x1000>; /* common1 */
 		reg-names = "common", "vidl1", "vid",
-			    "ovr1", "ovr2", "vp1", "vp2";
+			    "ovr1", "ovr2", "vp1", "vp2", "common1";
 		power-domains = <&k3_pds 186 TI_SCI_PD_EXCLUSIVE>;
 		clocks = <&k3_clks 186 6>,
 			 <&dss_vp1_clk>,
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +3 -2
index fcea54465636..5b2d4365b911 100644
@@ -1019,9 +1019,10 @@ dss: dss@4a00000 {
 		      <0x0 0x04a07000 0x0 0x1000>, /* ovr1 */
 		      <0x0 0x04a08000 0x0 0x1000>, /* ovr2 */
 		      <0x0 0x04a0a000 0x0 0x1000>, /* vp1 */
-		      <0x0 0x04a0b000 0x0 0x1000>; /* vp2 */
+		      <0x0 0x04a0b000 0x0 0x1000>, /* vp2 */
+		      <0x0 0x04a01000 0x0 0x1000>; /* common1 */
 		reg-names = "common", "vidl1", "vid",
-			"ovr1", "ovr2", "vp1", "vp2";
+			"ovr1", "ovr2", "vp1", "vp2", "common1";
 
 		ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>;
 
Signature · 1 line
2.34.1
#10 lore raw

Re: [DO NOT MERGE PATCH 2/2] arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs

Hi Conor,

Thanks for the review.

Quoted 11 lines · Conor Dooley
Quoted 10 lines · Devarsh Thakkar

This adds common1 register space for AM62x and AM65x SoC's which are using TI's Keystone display hardware and supporting it as described in Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml.

This region is documented in respective Technical Reference Manuals [1].

[1]:
AM62x TRM:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)

Quoted 9 lines
Quoted 5 lines

AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)

---

"[DO NOT MERGE PATCH 2/2]" but no rationale here as to why this cannot be merged? What's the problem with it?

No problem as such from my point of view, but this is the process I follow since maintainer trees for device-tree file and bindings are different. I generally mark a [DO NOT MERGE] tag for device-tree file patches until binding patch gets merged so that the device-tree patches don't get applied by mistake if binding patch has some pending comments.

Once binding patch gets merged, I re-send the device-tree file patches again to respective list.

Regards
Devarsh

Quoted 44 lines

Cheers,
Conor.

Quoted 41 lines
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 5 +++--
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-am62-main.dtsi +3 -2
index 464b7565d085..298bf8d5de8c 100644
@@ -779,9 +779,10 @@ dss: dss@30200000 {
 		      <0x00 0x30207000 0x00 0x1000>, /* ovr1 */
 		      <0x00 0x30208000 0x00 0x1000>, /* ovr2 */
 		      <0x00 0x3020a000 0x00 0x1000>, /* vp1: Used for OLDI */
-		      <0x00 0x3020b000 0x00 0x1000>; /* vp2: Used as DPI Out */
+		      <0x00 0x3020b000 0x00 0x1000>, /* vp2: Used as DPI Out */
+		      <0x00 0x30201000 0x00 0x1000>; /* common1 */
 		reg-names = "common", "vidl1", "vid",
-			    "ovr1", "ovr2", "vp1", "vp2";
+			    "ovr1", "ovr2", "vp1", "vp2", "common1";
 		power-domains = <&k3_pds 186 TI_SCI_PD_EXCLUSIVE>;
 		clocks = <&k3_clks 186 6>,
 			 <&dss_vp1_clk>,
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +3 -2
index fcea54465636..5b2d4365b911 100644
@@ -1019,9 +1019,10 @@ dss: dss@4a00000 {
 		      <0x0 0x04a07000 0x0 0x1000>, /* ovr1 */
 		      <0x0 0x04a08000 0x0 0x1000>, /* ovr2 */
 		      <0x0 0x04a0a000 0x0 0x1000>, /* vp1 */
-		      <0x0 0x04a0b000 0x0 0x1000>; /* vp2 */
+		      <0x0 0x04a0b000 0x0 0x1000>, /* vp2 */
+		      <0x0 0x04a01000 0x0 0x1000>; /* common1 */
 		reg-names = "common", "vidl1", "vid",
-			"ovr1", "ovr2", "vp1", "vp2";
+			"ovr1", "ovr2", "vp1", "vp2", "common1";
 
 		ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>;
 
Signature · 1 line
2.34.1
#11 lore raw

Re: [DO NOT MERGE PATCH 2/2] arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs

Quoted 26 lines · Devarsh Thakkar

Hi Conor,

Thanks for the review.

Quoted 11 lines · Conor Dooley
Quoted 10 lines · Devarsh Thakkar

This adds common1 register space for AM62x and AM65x SoC's which are using TI's Keystone display hardware and supporting it as described in Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml.

This region is documented in respective Technical Reference Manuals [1].

[1]:
AM62x TRM:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)

Quoted 9 lines
Quoted 5 lines

AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)

---

"[DO NOT MERGE PATCH 2/2]" but no rationale here as to why this cannot be merged? What's the problem with it?

Quoted 8 lines

No problem as such from my point of view, but this is the process I follow since maintainer trees for device-tree file and bindings are different. I generally mark a [DO NOT MERGE] tag for device-tree file patches until binding patch gets merged so that the device-tree patches don't get applied by mistake if binding patch has some pending comments.

Once binding patch gets merged, I re-send the device-tree file patches again to respective list.

I see. Please note this in your patches, under the --- line, in the future to avoid confusion.

maintainer
#12 lore raw

Re: [DO NOT MERGE PATCH 2/2] arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs

In reply to Devarsh Thakkar
Quoted 26 lines · Devarsh Thakkar

Hi Conor,

Thanks for the review.

Quoted 11 lines · Conor Dooley
Quoted 10 lines · Devarsh Thakkar

This adds common1 register space for AM62x and AM65x SoC's which are using TI's Keystone display hardware and supporting it as described in Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml.

This region is documented in respective Technical Reference Manuals [1].

[1]:
AM62x TRM:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)

Quoted 9 lines
Quoted 5 lines

AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)

---

"[DO NOT MERGE PATCH 2/2]" but no rationale here as to why this cannot be merged? What's the problem with it?

Quoted 5 lines

No problem as such from my point of view, but this is the process I follow since maintainer trees for device-tree file and bindings are different. I generally mark a [DO NOT MERGE] tag for device-tree file patches until binding patch gets merged so that the device-tree patches don't get applied by mistake if binding patch has some pending comments.

RFC is the tag for "don't merge". Don't make-up your own tags.

Rob