tests/xe/debugfs: fix double-free in test_base
PATCH 1/1 tests/xe/debugfs: fix double-free in test_base
Looks to incorrectly free the xe_dev->config, even though there is still a cached entry pointing to it. The test fixture will also call xe_device_put() at the end, freeing the same pointer (might now point to valid memory), which hopefully explains why we see strange looking crashes in CI:
Starting subtest: base
Subtest base: SUCCESS (0.005s)
Received signal SIGABRT.
Stack trace:
#0 [fatal_sig_handler+0x10f]
#1 [killpg+0x40]
#2 [gsignal+0xcb]
#3 [abort+0x12b]
#4 [__fsetlocking+0x42e]
#5 [pthread_attr_setschedparam+0x54c]
#6 [pthread_attr_setschedparam+0xd28]
#7 [pthread_attr_setschedparam+0x2ed3]
#8 [__libc_malloc+0x74]
#9 [_IO_file_doallocate+0x94]
#10 [_IO_doallocbuf+0x50]
#11 [_IO_file_overflow+0x1b0]
#12 [_IO_file_xsputn+0xe5]
#13 [psiginfo+0x13512]
#14 [igt_kmsg+0xc9]
#15 [igt_exit+0xd3]
#16 [main+0x44]
#17 [__libc_start_main+0xf3]
#18 [_start+0x2e]
Keep the xe_device stuff in test_base, since that looks be the only user here.
--- tests/xe/xe_debugfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
tests/xe/xe_debugfs.c +1 -3
@@ -146,7 +146,7 @@ test_base(int fd)validate_entries (fd,"" , expected_files,ARRAY_SIZE (expected_files)); -free (config); +xe_device_put (fd); }/**
@@ -250,7 +250,6 @@ igt_main_args("", long_options, help_str, opt_handler, NULL) igt_fixture { fd =drm_open_driver (DRIVER_XE ); -xe_device_get (fd);__igt_debugfs_dump (fd,"info" ,IGT_LOG_INFO ); }
@@ -272,7 +271,6 @@ igt_main_args("", long_options, help_str, opt_handler, NULL) } igt_fixture { -xe_device_put (fd);close (fd); } }
Signature · 1 line
2.39.2
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/xe/debugfs: fix double-free in test_base
== Series Details ==
== Series Details ==
Series: tests/xe/debugfs: fix double-free in test_base
URL : https://patchwork.freedesktop.org/series/115208/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12864 -> IGTPW_8613
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/index.html
Participating hosts (38 -> 37)
------------------------------
Additional (1): bat-atsm-1
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8613 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@eof:
- bat-atsm-1: NOTRUN -> [SKIP][1] ([i915#2582]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/bat-atsm-1/igt@[email protected]
* igt@gem_mmap@basic:
- bat-atsm-1: NOTRUN -> [SKIP][2] ([i915#4083])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/bat-atsm-1/igt@[email protected]
* igt@gem_sync@basic-each:
- bat-atsm-1: NOTRUN -> [FAIL][3] ([i915#8062]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/bat-atsm-1/igt@[email protected]
* igt@gem_tiled_fence_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][4] ([i915#4077]) +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/bat-atsm-1/igt@[email protected]
* igt@gem_tiled_pread_basic:
- bat-atsm-1: NOTRUN -> [SKIP][5] ([i915#4079]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/bat-atsm-1/igt@gem_tiled_pread_basic.html
* igt@i915_hangman@error-state-basic:
- bat-atsm-1: NOTRUN -> [ABORT][6] ([i915#8060])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/bat-atsm-1/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][7] -> [ABORT][8] ([i915#7911] / [i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/fi-bsw-nick/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/fi-bsw-nick/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@migrate:
- bat-adlp-9: [PASS][9] -> [DMESG-FAIL][10] ([i915#7699])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/bat-adlp-9/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/bat-adlp-9/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-FAIL][11] ([i915#6367])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-1: NOTRUN -> [SKIP][12] ([i915#7828])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/bat-rpls-1/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-1: NOTRUN -> [SKIP][13] ([i915#1845])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/bat-rpls-1/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][14] ([i915#4983]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/bat-rpls-1/igt@i915_selftest@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/bat-rpls-1/igt@i915_selftest@[email protected]
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#8060]: https://gitlab.freedesktop.org/drm/intel/issues/8060
[i915#8062]: https://gitlab.freedesktop.org/drm/intel/issues/8062
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7196 -> IGTPW_8613
CI-20190529: 20190529
CI_DRM_12864: efb4d3263a1932187dd525628e8b35d327f17a6f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8613: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/index.html
IGT_7196: 9b8c5dbe8cd82163ee198c43b81222d2b9b75fd4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/index.html
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for tests/xe/debugfs: fix double-free in test_base
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: tests/xe/debugfs: fix double-free in test_base
URL : https://patchwork.freedesktop.org/series/115208/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12864_full -> IGTPW_8613_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/index.html
Participating hosts (8 -> 7)
------------------------------
Missing (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8613_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-lmem0:
- {shard-dg1}: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-dg1-16/igt@i915_pm_rpm@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-dg1-15/igt@i915_pm_rpm@[email protected]
* igt@kms_async_flips@crc@pipe-c-hdmi-a-1:
- {shard-dg1}: NOTRUN -> [FAIL][3] +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-dg1-14/igt@kms_async_flips@[email protected]
* {igt@kms_plane_scaling@planes-downscale-factor-0-5-upscale-0-25}:
- {shard-tglu}: NOTRUN -> [SKIP][4] +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-tglu-10/igt@[email protected]
Known issues
------------
Here are the changes found in IGTPW_8613_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2842]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-glk5/igt@gem_exec_fair@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-glk4/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@verify:
- shard-apl: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl4/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][8] -> [SKIP][9] ([fdo#109271])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-apl6/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl4/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-glk: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#1937])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-glk5/igt@i915_pm_lpsp@[email protected]
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#3886]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl7/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#3886]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-glk6/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium_color@ctm-0-75:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271]) +76 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl7/igt@[email protected]
* igt@kms_content_protection@atomic@pipe-a-dp-1:
- shard-apl: NOTRUN -> [TIMEOUT][14] ([i915#7173])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl1/igt@kms_content_protection@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: NOTRUN -> [ABORT][15] ([i915#180])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl7/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-glk: NOTRUN -> [SKIP][16] ([fdo#109271]) +38 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-glk1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_plane_alpha_blend@alpha-basic@pipe-a-dp-1:
- shard-apl: NOTRUN -> [FAIL][17] ([i915#7862]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl7/igt@kms_plane_alpha_blend@[email protected]
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#658])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl6/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#658])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-glk2/igt@[email protected]
#### Possible fixes ####
* igt@fbdev@info:
- {shard-rkl}: [SKIP][20] ([i915#2582]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-4/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-4/igt@[email protected]
- {shard-tglu}: [SKIP][22] ([i915#2582]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-tglu-9/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-tglu-5/igt@[email protected]
* igt@gem_ctx_isolation@preservation-s3@vecs0:
- shard-apl: [DMESG-WARN][24] ([i915#180]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-apl3/igt@gem_ctx_isolation@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl2/igt@gem_ctx_isolation@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [FAIL][26] ([i915#2842]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-glk2/igt@gem_exec_fair@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-glk1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][28] ([i915#2842]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-apl3/igt@gem_exec_fair@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- {shard-rkl}: [FAIL][30] ([i915#2842]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-1/igt@gem_exec_fair@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-gtt-wc-noreloc:
- {shard-rkl}: [SKIP][32] ([i915#3281]) -> [PASS][33] +7 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-6/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-5/igt@[email protected]
* igt@gem_mmap_wc@set-cache-level:
- {shard-tglu}: [SKIP][34] ([i915#1850]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-tglu-9/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-tglu-8/igt@[email protected]
* igt@gem_partial_pwrite_pread@write-uncached:
- {shard-rkl}: [SKIP][36] ([i915#3282]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-1/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-5/igt@[email protected]
* igt@gem_ppgtt@shrink-vs-evict-any:
- {shard-rkl}: [ABORT][38] -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-2/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-1/igt@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- {shard-rkl}: [ABORT][40] ([i915#5122]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-4/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-6/igt@[email protected]
- {shard-tglu}: [ABORT][42] ([i915#5122]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-tglu-10/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-tglu-4/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [ABORT][44] ([i915#5566]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-apl2/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl4/igt@[email protected]
* igt@gen9_exec_parse@bb-start-cmd:
- {shard-rkl}: [SKIP][46] ([i915#2527]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-4/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-5/igt@[email protected]
* igt@i915_pipe_stress@stress-xrgb8888-untiled:
- {shard-rkl}: [SKIP][48] ([i915#4098]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-1/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-6/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- {shard-tglu}: [FAIL][50] ([i915#3989] / [i915#454]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-tglu-8/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-tglu-9/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-dg1}: [SKIP][52] ([i915#1937]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-dg1-18/igt@i915_pm_lpsp@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-dg1-14/igt@i915_pm_lpsp@[email protected]
* igt@i915_pm_rpm@cursor:
- {shard-rkl}: [SKIP][54] ([i915#1849]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-1/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@drm-resources-equal:
- {shard-rkl}: [SKIP][56] ([fdo#109308]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-4/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp:
- {shard-dg1}: [SKIP][58] ([i915#1397]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-dg1-14/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-dg1-17/igt@[email protected]
* igt@i915_pm_rpm@system-suspend-modeset:
- {shard-tglu}: [SKIP][60] ([i915#3547]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-tglu-10/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-tglu-4/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [DMESG-FAIL][62] ([i915#5334]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_atomic@plane-overlay-legacy:
- {shard-rkl}: [SKIP][64] ([i915#1845] / [i915#4098]) -> [PASS][65] +20 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-5/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-6/igt@[email protected]
* igt@kms_dp_aux_dev:
- {shard-rkl}: [SKIP][66] ([i915#1257]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-5/igt@kms_dp_aux_dev.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-6/igt@kms_dp_aux_dev.html
* igt@kms_draw_crc@fill-fb:
- {shard-tglu}: [SKIP][68] ([i915#1845]) -> [PASS][69] +31 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-tglu-9/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-tglu-2/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][70] ([i915#4767]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-apl6/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- {shard-tglu}: [SKIP][72] ([i915#1849]) -> [PASS][73] +16 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-tglu-9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt:
- {shard-rkl}: [SKIP][74] ([i915#1849] / [i915#4098]) -> [PASS][75] +10 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-1/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-6/igt@[email protected]
* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- {shard-tglu}: [SKIP][76] ([i915#1849] / [i915#3558]) -> [PASS][77] +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-tglu-10/igt@kms_plane@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-tglu-2/igt@kms_plane@[email protected]
* igt@kms_psr@cursor_mmap_gtt:
- {shard-rkl}: [SKIP][78] ([i915#1072]) -> [PASS][79] +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-1/igt@kms_psr@cursor_mmap_gtt.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-6/igt@kms_psr@cursor_mmap_gtt.html
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-a:
- {shard-tglu}: [SKIP][80] ([fdo#109274]) -> [PASS][81] +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-tglu-10/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-tglu-8/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [ABORT][82] ([i915#180]) -> [PASS][83] +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-apl2/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-apl1/igt@[email protected]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- {shard-tglu}: [SKIP][84] ([i915#1845] / [i915#7651]) -> [PASS][85] +21 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-tglu-9/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-tglu-3/igt@[email protected]
* igt@perf@gen12-oa-tlb-invalidate:
- {shard-rkl}: [SKIP][86] ([fdo#109289]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-5/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-2/igt@[email protected]
* igt@perf@polling-small-buf:
- {shard-tglu}: [FAIL][88] ([i915#1722]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-tglu-10/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-tglu-5/igt@[email protected]
- {shard-rkl}: [FAIL][90] ([i915#1722]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12864/shard-rkl-4/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/shard-rkl-5/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5115]: https://gitlab.freedesktop.org/drm/intel/issues/5115
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5431]: https://gitlab.freedesktop.org/drm/intel/issues/5431
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6530]: https://gitlab.freedesktop.org/drm/intel/issues/6530
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7862]: https://gitlab.freedesktop.org/drm/intel/issues/7862
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
[i915#8018]: https://gitlab.freedesktop.org/drm/intel/issues/8018
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
[i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8282]: https://gitlab.freedesktop.org/drm/intel/issues/8282
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7196 -> IGTPW_8613
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12864: efb4d3263a1932187dd525628e8b35d327f17a6f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8613: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/index.html
IGT_7196: 9b8c5dbe8cd82163ee198c43b81222d2b9b75fd4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8613/index.html
Quoted 31 lines · Matthew Auld
Looks to incorrectly free the
xe_dev->config, even though there is still a cached entry pointing to it. The test fixture will also callxe_device_put()at the end, freeing the same pointer (might now point to valid memory), which hopefully explains why we see strange looking crashes in CI:Starting subtest: base
Subtest base: SUCCESS (0.005s)
Received signal SIGABRT.
Stack trace:
#0 [fatal_sig_handler+0x10f]
#1 [killpg+0x40]
#2 [gsignal+0xcb]
#3 [abort+0x12b]
#4 [__fsetlocking+0x42e]
#5 [pthread_attr_setschedparam+0x54c]
#6 [pthread_attr_setschedparam+0xd28]
#7 [pthread_attr_setschedparam+0x2ed3]
#8 [__libc_malloc+0x74]
#9 [_IO_file_doallocate+0x94]
#10 [_IO_doallocbuf+0x50]
#11 [_IO_file_overflow+0x1b0]
#12 [_IO_file_xsputn+0xe5]
#13 [psiginfo+0x13512]
#14 [igt_kmsg+0xc9]
#15 [igt_exit+0xd3]
#16 [main+0x44]
#17 [__libc_start_main+0xf3]
#18 [_start+0x2e]
Quoted 6 lines
Keep the
xe_devicestuff intest_base, since that looks be the only user here.Signed-off-by Matthew Auld <[email protected]>Cc Zbigniew Kempczynski <[email protected]>Cc Mauro Carvalho Chehab <[email protected]>
Ping? Any takers for this one?
Quoted 36 lines
--- tests/xe/xe_debugfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)tests/xe/xe_debugfs.c +1
-4@@ -146,7 +146,7 @@ test_base(int fd)validate_entries (fd,"" , expected_files,ARRAY_SIZE (expected_files)); -free (config); +xe_device_put (fd); }/** @@ -250,7 +250,6 @@ igt_main_args("", long_options, help_str, opt_handler, NULL) igt_fixture { fd =drm_open_driver (DRIVER_XE ); -xe_device_get (fd);__igt_debugfs_dump (fd,"info" ,IGT_LOG_INFO ); }@@ -272,7 +271,6 @@ igt_main_args("", long_options, help_str, opt_handler, NULL) } igt_fixture { -xe_device_put (fd );close (fd); } } --2.39.2
Maarten Lankhorst
Reviewed-byHey,
Change looks good.
Quoted 75 lines · Matthew Auld
Quoted 30 lines · Matthew Auld
Looks to incorrectly free the
xe_dev->config, even though there is still a cached entry pointing to it. The test fixture will also callxe_device_put()at the end, freeing the same pointer (might now point to valid memory), which hopefully explains why we see strange looking crashes in CI:Starting subtest: base
Subtest base: SUCCESS (0.005s)
Received signal SIGABRT.
Stack trace:
#0 [fatal_sig_handler+0x10f]
#1 [killpg+0x40]
#2 [gsignal+0xcb]
#3 [abort+0x12b]
#4 [__fsetlocking+0x42e]
#5 [pthread_attr_setschedparam+0x54c]
#6 [pthread_attr_setschedparam+0xd28]
#7 [pthread_attr_setschedparam+0x2ed3]
#8 [__libc_malloc+0x74]
#9 [_IO_file_doallocate+0x94]
#10 [_IO_doallocbuf+0x50]
#11 [_IO_file_overflow+0x1b0]
#12 [_IO_file_xsputn+0xe5]
#13 [psiginfo+0x13512]
#14 [igt_kmsg+0xc9]
#15 [igt_exit+0xd3]
#16 [main+0x44]
#17 [__libc_start_main+0xf3]
#18 [_start+0x2e]Quoted 6 lines
Keep the
xe_devicestuff intest_base, since that looks be the only user here.Signed-off-by Matthew Auld <[email protected]>Cc Zbigniew Kempczynski <[email protected]>Cc Mauro Carvalho Chehab <[email protected]>Ping? Any takers for this one?
Quoted 36 lines
--- tests/xe/xe_debugfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)tests/xe/xe_debugfs.c +1
-4@@ -146,7 +146,7 @@ test_base(int fd)validate_entries (fd,"" , expected_files,ARRAY_SIZE (expected_files)); -free (config); +xe_device_put (fd); }/** @@ -250,7 +250,6 @@ igt_main_args("", long_options, help_str, opt_handler, NULL) igt_fixture { fd =drm_open_driver (DRIVER_XE ); -xe_device_get (fd);__igt_debugfs_dump (fd,"info" ,IGT_LOG_INFO ); }@@ -272,7 +271,6 @@ igt_main_args("", long_options, help_str, opt_handler, NULL) } igt_fixture { -xe_device_put (fd );close (fd); } } --2.39.2
Quoted 5 lines · Maarten Lankhorst
Hey,
Change looks good.
Reviewed-by Maarten Lankhorst <[email protected]>
Thanks.
Quoted 79 lines · Matthew Auld
Quoted 77 lines · Matthew Auld
Quoted 30 lines
Looks to incorrectly free the
xe_dev->config, even though there is still a cached entry pointing to it. The test fixture will also callxe_device_put()at the end, freeing the same pointer (might now point to valid memory), which hopefully explains why we see strange looking crashes in CI:Starting subtest: base
Subtest base: SUCCESS (0.005s)
Received signal SIGABRT.
Stack trace:
#0 [fatal_sig_handler+0x10f]
#1 [killpg+0x40]
#2 [gsignal+0xcb]
#3 [abort+0x12b]
#4 [__fsetlocking+0x42e]
#5 [pthread_attr_setschedparam+0x54c]
#6 [pthread_attr_setschedparam+0xd28]
#7 [pthread_attr_setschedparam+0x2ed3]
#8 [__libc_malloc+0x74]
#9 [_IO_file_doallocate+0x94]
#10 [_IO_doallocbuf+0x50]
#11 [_IO_file_overflow+0x1b0]
#12 [_IO_file_xsputn+0xe5]
#13 [psiginfo+0x13512]
#14 [igt_kmsg+0xc9]
#15 [igt_exit+0xd3]
#16 [main+0x44]
#17 [__libc_start_main+0xf3]
#18 [_start+0x2e]Quoted 6 lines
Keep the
xe_devicestuff intest_base, since that looks be the only user here.Signed-off-by Matthew Auld <[email protected]>Cc Zbigniew Kempczynski <[email protected]>Cc Mauro Carvalho Chehab <[email protected]>Ping? Any takers for this one?
Quoted 38 lines
---
tests/xe/xe_debugfs.c| 4 +---1 file changed, 1 insertion(+), 3 deletions(-)tests/xe/xe_debugfs.c +1
-3@@ -146,7 +146,7 @@ test_base(int fd) validate_entries(fd, "", expected_files, ARRAY_SIZE(expected_files)); - free(config); + xe_device_put(fd); } /**@@ -250,7 +250,6 @@ igt_main_args("", long_options, help_str, opt_handler, NULL) igt_fixture { fd = drm_open_driver(DRIVER_XE); - xe_device_get(fd); __igt_debugfs_dump(fd, "info", IGT_LOG_INFO); }@@ -272,7 +271,6 @@ igt_main_args("", long_options, help_str, opt_handler, NULL) } igt_fixture { - xe_device_put(fd); close(fd); }}
Signature · 1 line
2.39.2