Skip to contentSkip to conversation

proc.5: update the obsolete column name in net section

PATCH In review Maxim Petrov 2 participants 3 messages Nov 16, 2021 – Nov 18, 2021 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 proc.5: update the obsolete column name in net section

In the net section, 'rexmits' name is still used. Change it to 'retrnsmt' to match the modern kernel and fix the column order in /proc/net/udp.

---
 man5/proc.5 | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
man5/proc.5 +5 -5
index c6684620e..cb9960c4b 100644
@@ -3957,7 +3957,7 @@ the "local_address" is the local address and protocol number pair.
 the internal status of the socket.
 The "tx_queue" and "rx_queue" are the
 outgoing and incoming data queue in terms of kernel memory usage.
-The "tr", "tm\->when", and "rexmits" fields are not used by RAW.
+The "tr", "tm\->when", and "retrnsmt" fields are not used by RAW.
 The "uid"
 field holds the effective UID of the creator of the socket.
 .\" .TP
@@ -3981,7 +3981,7 @@ The "rem_address" is the remote address and port number pair
 \&"St" is the internal status of the socket.
 The "tx_queue" and "rx_queue" are the
 outgoing and incoming data queue in terms of kernel memory usage.
-The "tr", "tm\->when", and "rexmits" fields hold internal information of
+The "tr", "tm\->when", and "retrnsmt" fields hold internal information of
 the kernel socket state and are useful only for debugging.
 The "uid"
 field holds the effective UID of the creator of the socket.
@@ -3997,16 +3997,16 @@ The "rem_address" is the remote address and port number pair
 "St" is the internal status of the socket.
 The "tx_queue" and "rx_queue" are the outgoing and incoming data queue
 in terms of kernel memory usage.
-The "tr", "tm\->when", and "rexmits" fields
+The "tr", "tm\->when", and "retrnsmt" fields
 are not used by UDP.
 The "uid"
 field holds the effective UID of the creator of the socket.
 The format is:
 .IP
 .EX
-sl  local_address rem_address   st tx_queue rx_queue tr rexmits  tm\->when uid
+sl  local_address rem_address   st tx_queue rx_queue tr tm\->when retrnsmt uid
  1: 01642C89:0201 0C642C89:03FF 01 00000000:00000001 01:000071BA 00000000 0
- 1: 00000000:0801 00000000:0000 0A 00000000:00000000 00:00000000 6F000100 0
+ 1: 00000000:0801 00000000:0000 0A 00000000:00000000 00:00000000 00000000 0
  1: 00000000:0201 00000000:0000 0A 00000000:00000000 00:00000000 00000000 0
 .EE
 .TP
Signature · 1 line
2.25.1
#1 lore raw

Hello Maxim,

Quoted 2 lines · Maxim Petrov

In the net section, 'rexmits' name is still used. Change it to 'retrnsmt' to match the modern kernel and fix the column order in /proc/net/udp.

Could you please elaborate a bit on the commit message?

I don't know what the removed field was,
and can't find anything in the kernel source code
(it seems to predate git).

Why did it change?
When?
How?

Thanks,
Alex

Signature · 3 lines
Alejandro Colomar
Linux man-pages comaintainer; http://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
#2 lore raw
Quoted 5 lines · Alejandro Colomar (man-pages)

Could you please elaborate a bit on the commit message?

I don't know what the removed field was,
and can't find anything in the kernel source code
(it seems to predate git).

I tried to do my best, but I haven't got the good answer.

I searched on Bootlin's cross-referencer and noticed that there was a change in the /proc/net/* content header between 1.3.98 [0] and 1.3.99 [1] kernel. The "retrnsmt" column name has been added, but no "rexmits" column is mentioned here at all. Moreover, the amount of retransmitted packets ('sp->retransmits') was printed in 1.3.98 and earlier, despite the absense of the column name in the header. As these changes have been done in pre-git era, I cannot determine who is the author and what is the actual patch content.

For the man-pages project itself the first commit introduced "rexmits" is:
fea681daf (Import of man-pages 1.70) which seems to be an initial commit.

Can it be just an error and the "rexmits" did never exist in the kernel?

[0] https://elixir.bootlin.com/linux/1.3.98/source/net/ipv4/proc.c#L74
[1] https://elixir.bootlin.com/linux/1.3.99/source/net/ipv4/proc.c#L77