Skip to contentSkip to conversation

Lower i2c speed on bus 1 for LDP.

PATCH In review Dominic Curran 3 participants 3 messages Nov 12, 2008 – Nov 13, 2008

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Dominic Curran

author
#0 lore raw

PATCH 1/3 Lower i2c speed on bus 1 for LDP.

Resending patch with more descriptive comment.

Lower i2c bus 1 speed to 400KHz for LDP.
At 2600KHz i2c reads from twl4030 keypad driver are returning incorrect data. Reason unknown. Lowering bus speed as temporary fix to get LDP keypad working.

Signed-off-by Dominic Curran <[email protected]>
---
 arch/arm/mach-omap2/board-ldp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-ldp.c +1 -1
index d889ce8..b2e8c9c 100755
@@ -797,7 +797,7 @@ static struct i2c_board_info __initdata ldp_i2c_boardinfo_2[] = {
 
 static int __init omap_i2c_init(void)
 {
-	omap_register_i2c_bus(1, 2600, ldp_i2c_boardinfo,
+	omap_register_i2c_bus(1, 400, ldp_i2c_boardinfo,
 			ARRAY_SIZE(ldp_i2c_boardinfo));
 	omap_register_i2c_bus(2, 100, ldp_i2c_boardinfo_2,
 			ARRAY_SIZE(ldp_i2c_boardinfo_2));
Signature · 1 line
1.5.4.1
#1 lore raw

----- Original Message ----- From: "Dominic Curran" <[email protected]>
To: <[email protected]>
Sent: Thursday, November 13, 2008 1:51 AM
Subject: [PATCH 1/3] [OMAPZOOM] Lower i2c speed on bus 1 for LDP.

Quoted 17 lines

Resending patch with more descriptive comment.

Lower i2c bus 1 speed to 400KHz for LDP.
At 2600KHz i2c reads from twl4030 keypad driver are returning incorrect data. Reason unknown. Lowering bus speed as temporary fix to get LDP keypad working.

Signed-off-by Dominic Curran <[email protected]>

---
arch/arm/mach-omap2/board-ldp.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-ldp.c +0 -0
index d889ce8..b2e8c9c 100755

arch/arm/mach-omap2/board-ldp.c static struct i2c_board_info __initdata · line 802

Quoted 7 lines
arch/arm/mach-omap2/board-ldp.c +1 -1
@@ -797,7 +797,7 @@ static struct i2c_board_info __initdata 
 ldp_i2c_boardinfo_2[] = {
 
 static int __init omap_i2c_init(void)
 {
- omap_register_i2c_bus(1, 2600, ldp_i2c_boardinfo,
+ omap_register_i2c_bus(1, 400, ldp_i2c_boardinfo,
 ARRAY_SIZE(ldp_i2c_boardinfo));

Last time i checked we were getting few errors (returning incorrect values) even at 400k , and no error at 100k. Have you seen any at 400k?

Quoted 10 lines
arch/arm/mach-omap2/board-ldp.c +0 -0
 omap_register_i2c_bus(2, 100, ldp_i2c_boardinfo_2,

ARRAY_SIZE(ldp_i2c_boardinfo_2));

Signature · 6 lines
1.5.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw

I noticed that l-o updated divisors the other day.

It might be some sync'ing pulled in bad dividers?

Regards,
Richard W.

Quoted 63 lines

-----Original Message-----
From: [email protected] [mailto:linux-omap- [email protected]] On Behalf Of shekhar, chandra
Sent: Wednesday, November 12, 2008 8:50 PM
To: Curran, Dominic; [email protected]
Subject: Re: [PATCH 1/3] [OMAPZOOM] Lower i2c speed on bus 1 for LDP.

----- Original Message -----
From: "Dominic Curran" <[email protected]>
To: <[email protected]>
Sent: Thursday, November 13, 2008 1:51 AM
Subject: [PATCH 1/3] [OMAPZOOM] Lower i2c speed on bus 1 for LDP.

arch/arm/mach-

Quoted 13 lines

Resending patch with more descriptive comment.

Lower i2c bus 1 speed to 400KHz for LDP.
At 2600KHz i2c reads from twl4030 keypad driver are returning incorrect data. Reason unknown. Lowering bus speed as temporary fix to get LDP keypad working.

Signed-off-by Dominic Curran <[email protected]>

---
arch/arm/mach-omap2/board-ldp.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-omap2/board-ldp.c +0 -0

omap2/board-ldp.c

arch/arm/mach-omap2/board-ldp.c static struct i2c_board_info __initdata · line 802

Quoted 11 lines

index d889ce8..b2e8c9c 100755

arch/arm/mach-omap2/board-ldp.c +1 -1
@@ -797,7 +797,7 @@ static struct i2c_board_info __initdata
 ldp_i2c_boardinfo_2[] = {
 
 static int __init omap_i2c_init(void)
 {
- omap_register_i2c_bus(1, 2600, ldp_i2c_boardinfo,
+ omap_register_i2c_bus(1, 400, ldp_i2c_boardinfo,
 ARRAY_SIZE(ldp_i2c_boardinfo));

Last time i checked we were getting few errors (returning incorrect values) even
at 400k , and no error at 100k.
Have you seen any at 400k?

Quoted 10 lines
arch/arm/mach-omap2/board-ldp.c +0 -0
 omap_register_i2c_bus(2, 100, ldp_i2c_boardinfo_2,

ARRAY_SIZE(ldp_i2c_boardinfo_2));
--
1.5.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html