mm/mglru: Update MG-LRU proactive reclaim statistics only to memcg
Subsystems (3)
PATCH 1/1 mm/mglru: Update MG-LRU proactive reclaim statistics only to memcg
From: Hao Jia <[email protected]>
Users can use /sys/kernel/debug/lru_gen to trigger proactive memory reclaim of a specified memcg. Currently, statistics such as pgrefill, pgscan and pgsteal will be updated to the /proc/vmstat system memory statistics.
This will confuse some system memory pressure monitoring tools, making it difficult to determine whether pgscan and pgsteal are caused by system-level pressure or by proactive memory reclaim of some specific memory cgroup.
Therefore, make this interface behave similarly to memory.reclaim. Update proactive memory reclaim statistics only to its memory cgroup.
--- mm/vmscan.c | 2 ++ 1 file changed, 2 insertions(+)
mm/vmscan.c +2 -0
@@ -5545,6 +5545,7 @@ static int run_cmd(char cmd, int memcg_id, int nid, unsigned long seq,if (memcg_id !=mem_cgroup_id (memcg)) goto done; + sc->target_mem_cgroup = memcg; lruvec =get_lruvec (memcg, nid);if (swappiness <MIN_SWAPPINESS )
@@ -5581,6 +5582,7 @@ static ssize_t lru_gen_seq_write(struct file *file, const char __user *src, .may_swap = true, .reclaim_idx = MAX_NR_ZONES - 1, .gfp_mask = GFP_KERNEL, + .proactive = true, }; buf =kvmalloc (len +1 ,GFP_KERNEL );
Signature · 1 line
2.34.1
Shakeel Butt
reviewerHi Hao,
Quoted 4 lines · Hao Jia
From: Hao Jia <[email protected]>
Users can use
/sys/kernel/debug/lru_gento trigger proactive memory reclaim of a specified memcg.
Are you using this interface for proactively reclaiming a specific memcg? I see run_cmd() using mem_cgroup_from_id() to get memcg from a given id but I don't think we expose ids from mem_cgroup_ids to the userspace. Usually we use cgroup_id which is just an inode number for the cgroup folder. I wonder if the current users of this interface are providing memcg id.
Quoted 8 lines
Currently, statistics such as pgrefill, pgscan and
pgsteal will be updated to the/proc/vmstatsystem memory statistics.This will confuse some system memory pressure monitoring tools, making it difficult to determine whether pgscan and pgsteal are caused by system-level pressure or by proactive memory reclaim of some specific memory cgroup.
Quoted 4 lines
Therefore, make this interface behave similarly to memory.reclaim. Update proactive memory reclaim statistics only to its memory cgroup.
Signed-off-by Hao Jia <[email protected]>
The patch looks fine though.
Quoted 27 lines
--- mm/vmscan.c | 2 ++ 1 file changed, 2 insertions(+)mm/vmscan.c +2
-0@@ -5545,6 +5545,7 @@ static int run_cmd(char cmd, int memcg_id, int nid, unsigned long seq,if (memcg_id !=mem_cgroup_id (memcg)) goto done; + sc->target_mem_cgroup = memcg; lruvec =get_lruvec (memcg, nid);if (swappiness <MIN_SWAPPINESS )@@ -5581,6 +5582,7 @@ static ssize_t lru_gen_seq_write(struct file *file, const char __user *src, .may_swap = true, .reclaim_idx = MAX_NR_ZONES - 1, .gfp_mask = GFP_KERNEL, + .proactive = true, }; buf =kvmalloc (len +1 ,GFP_KERNEL );Signature · 1 line
2.34.1
Quoted 8 lines · Shakeel Butt
Hi Hao,
Quoted 4 lines · Hao Jia
From: Hao Jia <[email protected]>
Users can use
/sys/kernel/debug/lru_gento trigger proactive memory reclaim of a specified memcg.
Hi Shakeel,
Quoted 2 lines
Are you using this interface for proactively reclaiming a specific memcg?
I am comparing using /sys/kernel/debug/lru_gen or cgroup.reclaim to trigger memory reclaim when MG-LRU is enabled. For user-mode agents, the two interfaces can achieve the same function.
I see run_cmd() using mem_cgroup_from_id() to get memcg from a
Quoted 4 lines
given id but I don't think we expose ids from
mem_cgroup_idsto the userspace. Usually we usecgroup_idwhich is just an inode number for the cgroup folder. I wonder if the current users of this interface are providing memcg id.
We can get memcg id through cat /sys/kernel/debug/lru_gen .
Thanks,
Hao
Quoted 12 lines
Quoted 12 lines
Currently, statistics such as pgrefill, pgscan and
pgsteal will be updated to the/proc/vmstatsystem memory statistics.This will confuse some system memory pressure monitoring tools, making it difficult to determine whether pgscan and pgsteal are caused by system-level pressure or by proactive memory reclaim of some specific memory cgroup.
Therefore, make this interface behave similarly to memory.reclaim. Update proactive memory reclaim statistics only to its memory cgroup.
Yuanchu Xie
reviewerHi Hao,
Quoted 6 lines · Hao Jia
From: Hao Jia <[email protected]>
Users can use
/sys/kernel/debug/lru_gento trigger proactive memory reclaim of a specified memcg. Currently, statistics such as pgrefill, pgscan and pgsteal will be updated to the/proc/vmstatsystem memory statistics.
This is a debugfs interface and it's not meant for use in production or provide a stable ABI. Does memory.reclaim not work for your needs?
I'm not against the change; I just hope you don't depend on it continuing to exist/behave a certain way.
Shakeel's comment is accurate. The lru_gen interface uses the internal memcg id which is not usually used to interface with the userspace. Reading this file does show the cgroup path and memcg id association.
Quoted 10 lines
This will confuse some system memory pressure monitoring tools, making it difficult to determine whether pgscan and pgsteal are caused by system-level pressure or by proactive memory reclaim of some specific memory cgroup.
Therefore, make this interface behave similarly to memory.reclaim. Update proactive memory reclaim statistics only to its memory cgroup.
Signed-off-by Hao Jia <[email protected]>
The patch looks okay to me too.
Thanks,
Yuanchu
On 2025/7/18 04:18, Yuanchu Xie wrote:
Hi Yuanchu,
Quoted 4 lines
Hi Hao,
Quoted 1 line · Hao Jia
Quoted 9 lines
Quoted 5 lines
From: Hao Jia <[email protected]>
Users can use
/sys/kernel/debug/lru_gento trigger proactive memory reclaim of a specified memcg. Currently, statistics such as pgrefill, pgscan and pgsteal will be updated to the/proc/vmstatsystem memory statistics.This is a debugfs interface and it's not meant for use in production or provide a stable ABI. Does memory.reclaim not work for your needs?
No, I am comparing the two interfaces.
Thanks for your reminder, but I want to use this interface run_aging() to age folios, and separate proactive memory reclamation from multiple walk_mm() by combining it with BIT(LRU_GEN_MM_WALK).
For example, user-space agent, enable LRU_GEN_MM_WALK, and then trigger run_aging(). Then turn off LRU_GEN_MM_WALK and use cgroup.reclaim to trigger proactive reclamation. Avoid the long latency caused by walk_mm().
Maybe it would be more reasonable to put walk_mm() in workqueues?
I don't know if my idea is reasonable, any suggestions are welcome.
Thanks,
Hao
Quoted 22 lines
I'm not against the change; I just hope you don't depend on it continuing to exist/behave a certain way.
Shakeel's comment is accurate. The
lru_geninterface uses the internal memcg id which is not usually used to interface with the userspace. Reading this file does show the cgroup path and memcg id association.Quoted 10 lines
This will confuse some system memory pressure monitoring tools, making it difficult to determine whether pgscan and pgsteal are caused by system-level pressure or by proactive memory reclaim of some specific memory cgroup.
Therefore, make this interface behave similarly to memory.reclaim. Update proactive memory reclaim statistics only to its memory cgroup.
Signed-off-by Hao Jia <[email protected]>The patch looks okay to me too.
Thanks,
Yuanchu