Skip to contentSkip to conversation

xserver-xorg: add missing libtirpc dependency

PATCH In review Alexander Kanavin 3 participants 5 messages Nov 11, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xserver-xorg: add missing libtirpc dependency

This wasn't a problem in poky, but was exposed with a nodistro build.

---
 meta/recipes-graphics/xorg-xserver/xserver-xorg.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +1 -1
index 4a7048aced..71c934ef38 100644
@@ -28,7 +28,7 @@ inherit meson pkgconfig
 inherit features_check
 REQUIRED_DISTRO_FEATURES = "x11"
 
-LIB_DEPS = "pixman libxfont2 xtrans libxau libxext libxdmcp libdrm libxkbfile libpciaccess libxcvt"
+LIB_DEPS = "pixman libxfont2 xtrans libxau libxext libxdmcp libdrm libxkbfile libpciaccess libxcvt libtirpc"
 DEPENDS = "xorgproto ${LIB_DEPS} font-util"
 
 # Split out some modules and extensions from the main package
Signature · 1 line
2.20.1
#1 lore raw
Quoted 17 lines · Alexander Kanavin

This wasn't a problem in poky, but was exposed with a nodistro build.

---
 meta/recipes-graphics/xorg-xserver/xserver-xorg.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +0 -1
index 4a7048aced..71c934ef38 100644
@@ -28,7 +28,7 @@ inherit meson pkgconfig
 inherit features_check
 REQUIRED_DISTRO_FEATURES = "x11"
 
-LIB_DEPS = "pixman libxfont2 xtrans libxau libxext libxdmcp libdrm
Quoted 3 lines

libxkbfile libpciaccess libxcvt"
+LIB_DEPS = "pixman libxfont2 xtrans libxau libxext libxdmcp libdrm libxkbfile libpciaccess libxcvt libtirpc"

Interesting. Do we know what the difference is?
Perhaps a distro feature gap ? We should try to get poky close to no distro as it’s reference distro
Less work in maintaining nodistro would be beneficial

Quoted 19 lines

DEPENDS = "xorgproto ${LIB_DEPS} font-util"

# Split out some modules and extensions from the main package
--
2.20.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#158153):
https://lists.openembedded.org/g/openembedded-core/message/158153
Mute This Topic: https://lists.openembedded.org/mt/86978200/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 20 lines · Khem Raj
Quoted 16 lines · Alexander Kanavin

This wasn't a problem in poky, but was exposed with a nodistro build.

---
 meta/recipes-graphics/xorg-xserver/xserver-xorg.inc | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +0 -0
index 4a7048aced..71c934ef38 100644
@@ -28,7 +28,7 @@ inherit meson pkgconfig

 inherit features_check
 REQUIRED_DISTRO_FEATURES = "x11"

Quoted 13 lines
Quoted 7 lines

-LIB_DEPS = "pixman libxfont2 xtrans libxau libxext libxdmcp libdrm libxkbfile
libpciaccess libxcvt"
+LIB_DEPS = "pixman libxfont2 xtrans libxau libxext libxdmcp libdrm libxkbfile
libpciaccess libxcvt libtirpc"

Interesting. Do we know what the difference is?
Perhaps a distro feature gap ? We should try to get poky close to no distro as it’s reference distro
Less work in maintaining nodistro would be beneficial

The difference is enable/disable of opengl. They are already very close, that is one of the few major differences and in some ways it is useful to test both.

Cheers,

Richard

Quoted 1 line
#3 lore raw
Quoted 36 lines · Richard Purdie
Quoted 20 lines · Khem Raj
Quoted 16 lines · Alexander Kanavin

This wasn't a problem in poky, but was exposed with a nodistro build.

---
 meta/recipes-graphics/xorg-xserver/xserver-xorg.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +0 -0
index 4a7048aced..71c934ef38 100644
@@ -28,7 +28,7 @@ inherit meson pkgconfig
 inherit features_check
 REQUIRED_DISTRO_FEATURES = "x11"
 
Quoted 13 lines
Quoted 7 lines
meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +0 -1
-LIB_DEPS = "pixman libxfont2 xtrans libxau libxext libxdmcp libdrm

libxkbfile
libpciaccess libxcvt"
+LIB_DEPS = "pixman libxfont2 xtrans libxau libxext libxdmcp libdrm libxkbfile
libpciaccess libxcvt libtirpc"

Interesting. Do we know what the difference is?
Perhaps a distro feature gap ? We should try to get poky close to no distro as it’s reference distro
Less work in maintaining nodistro would be beneficial

Quoted 2 lines

The difference is enable/disable of opengl. They are already very close, that is one of the few major differences and in some ways it is useful to test both.

I see. yes it is important to test opengl and non-opengl case.

Quoted 7 lines

Cheers,

Richard

Quoted 1 line
#4 lore raw

FWIW, once the next LTS is out, I'm going to propose the following (I already have the patches):

- nodistro/default oe-core set gets opengl/wayland features (but not vulkan just yet :)
- AB's config.json gets a 'only-x11' configuration where those features are removed, and sato images/SDKs are built and tested
- everything else is transitioned to weston, and perhaps phosh :)

http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=akanavin/transition-to-weston
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder-helper/log/?h=contrib/akanavin/transition-to-weston

Alex

Quoted 55 lines · Khem Raj
Quoted 5 lines · Richard Purdie
Quoted 3 lines · Khem Raj

On Thu, Nov 11, 2021 at 2:05 AM Alexander Kanavin <

[email protected]>

Quoted 17 lines
Quoted 17 lines
Quoted 16 lines · wrote:

This wasn't a problem in poky, but was exposed with a nodistro build.

---
 meta/recipes-graphics/xorg-xserver/xserver-xorg.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +0 -0
index 4a7048aced..71c934ef38 100644
@@ -28,7 +28,7 @@ inherit meson pkgconfig
 inherit features_check
 REQUIRED_DISTRO_FEATURES = "x11"
 
Quoted 11 lines
Quoted 11 lines
Quoted 7 lines
meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +0 -1
-LIB_DEPS = "pixman libxfont2 xtrans libxau libxext libxdmcp libdrm

libxkbfile
libpciaccess libxcvt"
+LIB_DEPS = "pixman libxfont2 xtrans libxau libxext libxdmcp libdrm libxkbfile
libpciaccess libxcvt libtirpc"

Interesting. Do we know what the difference is?
Perhaps a distro feature gap ? We should try to get poky close to no

distro as

Quoted 4 lines
Quoted 2 lines

it’s reference distro
Less work in maintaining nodistro would be beneficial

The difference is enable/disable of opengl. They are already very close,

that is

Quoted 1 line

one of the few major differences and in some ways it is useful to test

both.

I see. yes it is important to test opengl and non-opengl case.

Quoted 7 lines

Cheers,

Richard

Quoted 1 line