clk: at91: Use of_property_count_u32_elems() to get property length
Subsystems (2)
PATCH 1/1 clk: at91: Use of_property_count_u32_elems() to get property length
Replace of_get_property() with the type specific of_property_count_u32_elems() to get the property length.
This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.
--- drivers/clk/at91/dt-compat.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/clk/at91/dt-compat.c +3 -2
@@ -563,9 +563,10 @@ of_at91_clk_pll_get_characteristics(struct device_node *np)if (num_cells <2 || num_cells >4 )return NULL ; -if (!of_get_property (np,"atmel,pll-clk-output-ranges" , &tmp)) + num_output =of_property_count_u32_elems (np,"atmel,pll-clk-output-ranges" ); +if (num_output <=0 )return NULL ; - num_output = tmp / (sizeof (u32) * num_cells); + num_output /= num_cells; characteristics =kzalloc (sizeof (*characteristics),GFP_KERNEL );if (!characteristics)
Signature · 1 line
2.43.0
Quoting Rob Herring (Arm) (2024-07-31 13:14:02)
Quoted 10 lines
Replace
of_get_property()with the type specificof_property_count_u32_elems()to get the property length.This is part of a larger effort to remove callers of
of_get_property()and similar functions.of_get_property()leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.Signed-off-by Rob Herring (Arm) <[email protected]>---
Applied to clk-next