tools/xenstored: remove unneeded check in create_node()
PATCH 1/1 tools/xenstored: remove unneeded check in create_node()
create_node() is called only for issued xenstore commands. This means that the "conn" parameter is never NULL.
Remove checking whether "conn" is not NULL.
--- tools/xenstored/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/xenstored/core.c +1 -1
@@ -1524,7 +1524,7 @@ static struct node *create_node(struct connection *conn, const void *ctx,if (!node)return NULL ; -if (conn && conn->transaction) +if (conn->transaction)ta_node_created (conn->transaction); node->data = data;
Signature · 1 line
2.53.0
Quoted 6 lines · Juergen Gross
create_node()is called only for issued xenstore commands. This means that the "conn" parameter is never NULL.Remove checking whether "conn" is not NULL.
Signed-off-by Juergen Gross <[email protected]>
Should Coverity ID 1690859 perhaps be mentioned, as presumably addressed by this? (If it is addressed by the change, the question of possibly backporting would then also arise.)
Jan
Quoted 11 lines
tools/xenstored/core.c +1
-1@@ -1524,7 +1524,7 @@ static struct node *create_node(struct connection *conn, const void *ctx,if (!node)return NULL ; -if (conn && conn->transaction) +if (conn->transaction)ta_node_created (conn->transaction); node->data = data;
Quoted 11 lines · Jan Beulich
Quoted 6 lines · Juergen Gross
create_node()is called only for issued xenstore commands. This means that the "conn" parameter is never NULL.Remove checking whether "conn" is not NULL.
Signed-off-by Juergen Gross <[email protected]>Should Coverity ID 1690859 perhaps be mentioned, as presumably addressed by this? (If it is addressed by the change, the question of possibly backporting would then also arise.)
I'm not sure this will really address Coverity ID 1690859. It would be just an "educated guess".
And regarding backporting - this isn't fixing a bug, it is just a minor optimization.
It might even be that in older versions the check is needed. One would have to verify that there isn't any call patch with conn == NULL.
Juergen