Skip to contentSkip to conversation

x86: Add task_struct flag to force SIGBUS on MCE

PATCH RESEND In review Andrew Zaborowski 5 participants 16 messages Jul 23, 2024 – Aug 10, 2024 2 messages not in the archive

Subsystems (8)
Memory management x86 VFS Scheduler +4 more subsystems
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/3 x86: Add task_struct flag to force SIGBUS on MCE

Uncorrected memory errors for user pages are signaled to processes using SIGBUS or, if the error happens in a syscall, an error retval from the syscall. The SIGBUS is documented in Documentation/mm/hwpoison.rst#failure-recovery-modes

But there are corner cases where we cannot or don't want to return a plain error from the syscall. Subsequent commits covers two such cases:
execve and rseq. Current code, in both places, will kill the task with a SIGSEGV on error. While not explicitly stated, it can be argued that it should be a SIGBUS, for consistency and for the benefit of the userspace signal handlers. Even if the process cannot handle the signal, perhaps the parent process can. This was the case in the scenario that motivated this patch.

In both cases, the architecture's exception handler (MCE handler on x86) will queue a call to memory_failure. This doesn't work because the syscall-specific code sees the -EFAULT and terminates the task before the queued work runs.

To fix this: 1. let pending work run in the error cases in both places.

And 2. on MCE, ensure memory_failure() is passed MF_ACTION_REQUIRED so that the SIGBUS is queued. Normally when the MCE is in a syscall, a fixup of return IP and a call to kill_me_never() are what we want. But in this case it's necessary to queue kill_me_maybe() which will set MF_ACTION_REQUIRED which is checked by memory_failure().

To do this the syscall code will set current->kill_on_efault, a new task_struct flag. Check that flag in arch/x86/kernel/cpu/mce/core.c:do_machine_check()

Note: the flag is not x86 specific even if only x86 handling is being added here. The definition could be guarded by #ifdef CONFIG_MEMORY_FAILURE, but it would then need set/clear utilities.

---
Resending through an SMTP server that won't add the company footer.

This is a v2 of
https://lore.kernel.org/linux-mm/[email protected]/
In the v1 the existing flag current->in_execve was being reused instead of adding a new one. Kees Cook commented in
https://lore.kernel.org/linux-mm/202405010915.465AF19@keescook/ that current->in_execve is going away. Lacking a better idea and seeing that execve() and rseq() would benefit from using a common mechanism, I decided to add this new flag.

Perhaps with a better name current->kill_on_efault could replace brpm->point_of_no_return to offset the pain of having this extra flag.

---
 arch/x86/kernel/cpu/mce/core.c | 18 +++++++++++++++++-
 include/linux/sched.h          |  2 ++
 2 files changed, 19 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/mce/core.c +17 -1
index ad0623b65..13f2ace3d 100644
@@ -1611,7 +1611,7 @@ noinstr void do_machine_check(struct pt_regs *regs)
 			if (p)
 				SetPageHWPoison(p);
 		}
-	} else {
+	} else if (!current->kill_on_efault) {
 		/*
 		 * Handle an MCE which has happened in kernel space but from
 		 * which the kernel can recover: ex_has_fault_handler() has
@@ -1628,6 +1628,22 @@ noinstr void do_machine_check(struct pt_regs *regs)
 
 		if (m.kflags & MCE_IN_KERNEL_COPYIN)
 			queue_task_work(&m, msg, kill_me_never);
+	} else {
+		/*
+		 * Even with recovery code extra handling is required when
+		 * we're not returning to userspace after error (e.g. in
+		 * execve() beyond the point of no return) to ensure that
+		 * a SIGBUS is delivered.
+		 */
+		if (m.kflags & MCE_IN_KERNEL_RECOV) {
+			if (!fixup_exception(regs, X86_TRAP_MC, 0, 0))
+				mce_panic("Failed kernel mode recovery", &m, msg);
+		}
+
+		if (!mce_usable_address(&m))
+			queue_task_work(&m, msg, kill_me_now);
+		else
+			queue_task_work(&m, msg, kill_me_maybe);
 	}
 
 out:
include/linux/sched.h +2 -0
index 61591ac6e..0cde1ba11 100644
@@ -975,6 +975,8 @@ struct task_struct {
 	/* delay due to memory thrashing */
 	unsigned                        in_thrashing:1;
 #endif
+	/* Kill task on user memory access error */
+	unsigned                        kill_on_efault:1;
 
 	unsigned long			atomic_flags; /* Flags requiring atomic access. */
 
Signature · 1 line
2.43.0
#1 lore raw

PATCH RESEND 2/3 execve: Ensure SIGBUS delivered on memory failure

Uncorrected memory errors for user pages are signaled to processes using SIGBUS or, if the error happens in a syscall, an error retval from the syscall. The SIGBUS is documented in Documentation/mm/hwpoison.rst#failure-recovery-modes

In execve() there is a point of no return (bprm->point_of_no_return) after which the syscall... cannot return. The binary loading happens after this point so if the loader triggers a memory error reading user pages, and after control returns to bprm_execve(), that function reacts by sending a SIGSEGV.

Set the new current->kill_on_efault flag and run pending task work to ensure that a SIGBUS is queued in memory_failure()

---
 fs/exec.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)
fs/exec.c +12 -3
index 400731422..26c4efe1a 100644
@@ -68,6 +68,7 @@
 #include <linux/user_events.h>
 #include <linux/rseq.h>
 #include <linux/ksm.h>
+#include <linux/task_work.h>
 
 #include <linux/uaccess.h>
 #include <asm/mmu_context.h>
@@ -1290,6 +1291,7 @@ int begin_new_exec(struct linux_binprm * bprm)
 	 * Ensure all future errors are fatal.
 	 */
 	bprm->point_of_no_return = true;
+	me->kill_on_efault = true;
 
 	/*
 	 * Make this the only thread in the thread group.
@@ -1896,6 +1898,7 @@ static int bprm_execve(struct linux_binprm *bprm)
 	/* execve succeeded */
 	current->fs->in_exec = 0;
 	current->in_execve = 0;
+	current->kill_on_efault = false;
 	rseq_execve(current);
 	user_events_execve(current);
 	acct_update_integrals(current);
@@ -1907,14 +1910,20 @@ static int bprm_execve(struct linux_binprm *bprm)
 	 * If past the point of no return ensure the code never
 	 * returns to the userspace process.  Use an existing fatal
 	 * signal if present otherwise terminate the process with
-	 * SIGSEGV.
+	 * SIGSEGV.  Run pending work before that in case it is
+	 * terminating the process with a different signal.
 	 */
-	if (bprm->point_of_no_return && !fatal_signal_pending(current))
-		force_fatal_sig(SIGSEGV);
+	if (bprm->point_of_no_return) {
+		task_work_run();
+
+		if (!fatal_signal_pending(current))
+			force_fatal_sig(SIGSEGV);
+	}
 
 	sched_mm_cid_after_execve(current);
 	current->fs->in_exec = 0;
 	current->in_execve = 0;
+	current->kill_on_efault = false;
 
 	return retval;
 }
Signature · 1 line
2.43.0
#2 lore raw

PATCH RESEND 3/3 rseq: Ensure SIGBUS delivered on memory failure

In reply to Andrew Zaborowski

Uncorrected memory errors for user pages are signaled to processes using SIGBUS or, if the error happens in a syscall, an error retval from the syscall. The SIGBUS is documented in Documentation/mm/hwpoison.rst#failure-recovery-modes

Once a user task sets t->rseq in the rseq() syscall, if the kernel cannot access the memory pointed to by t->rseq->rseq_cs, that initial rseq() and all future syscalls should return an error so understandably the code just kills the task.

To ensure that SIGBUS is used set the new t->kill_on_efault flag and run queued task work on rseq_get_rseq_cs() errors to give memory_failure the chance to run.

Note: the rseq checks run inside resume_user_mode_work() so whenever _TIF_NOTIFY_RESUME is set. They do not run on every syscall exit so I'm not concerned that these extra flag operations are in a hot path, except with CONFIG_DEBUG_RSEQ.

---
 kernel/rseq.c | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)
kernel/rseq.c +21 -4
index 9de6e35fe..c5809cd13 100644
@@ -13,6 +13,7 @@
 #include <linux/syscalls.h>
 #include <linux/rseq.h>
 #include <linux/types.h>
+#include <linux/task_work.h>
 #include <asm/ptrace.h>
 
 #define CREATE_TRACE_POINTS
@@ -320,6 +321,8 @@ void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs)
 	if (unlikely(t->flags & PF_EXITING))
 		return;
 
+	t->kill_on_efault = true;
+
 	/*
 	 * regs is NULL if and only if the caller is in a syscall path.  Skip
 	 * fixup and leave rseq_cs as is so that rseq_sycall() will detect and
@@ -330,13 +333,18 @@ void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs)
 		if (unlikely(ret < 0))
 			goto error;
 	}
-	if (unlikely(rseq_update_cpu_node_id(t)))
-		goto error;
-	return;
+	if (likely(!rseq_update_cpu_node_id(t)))
+		goto out;
 
 error:
+	/* Allow task work to override signr */
+	task_work_run();
+
 	sig = ksig ? ksig->sig : 0;
 	force_sigsegv(sig);
+
+out:
+	t->kill_on_efault = false;
 }
 
 #ifdef CONFIG_DEBUG_RSEQ
@@ -353,8 +361,17 @@ void rseq_syscall(struct pt_regs *regs)
 
 	if (!t->rseq)
 		return;
-	if (rseq_get_rseq_cs(t, &rseq_cs) || in_rseq_cs(ip, &rseq_cs))
+
+	t->kill_on_efault = true;
+
+	if (rseq_get_rseq_cs(t, &rseq_cs) || in_rseq_cs(ip, &rseq_cs)) {
+		/* Allow task work to override signr */
+		task_work_run();
+
 		force_sig(SIGSEGV);
+	}
+
+	t->kill_on_efault = false;
 }
 
 #endif
Signature · 1 line
2.43.0
maintainer
#3 lore raw

Re: [RESEND][PATCH 3/3] rseq: Ensure SIGBUS delivered on memory failure

Quoted 14 lines · Andrew Zaborowski

Uncorrected memory errors for user pages are signaled to processes using SIGBUS or, if the error happens in a syscall, an error retval from the syscall. The SIGBUS is documented in Documentation/mm/hwpoison.rst#failure-recovery-modes

Once a user task sets t->rseq in the rseq() syscall, if the kernel cannot access the memory pointed to by t->rseq->rseq_cs, that initial rseq() and all future syscalls should return an error so understandably the code just kills the task.

To ensure that SIGBUS is used set the new t->kill_on_efault flag and run queued task work on rseq_get_rseq_cs() errors to give memory_failure the chance to run.

Quoted 8 lines

Note: the rseq checks run inside resume_user_mode_work() so whenever _TIF_NOTIFY_RESUME is set. They do not run on every syscall exit so I'm not concerned that these extra flag operations are in a hot path, except with CONFIG_DEBUG_RSEQ.

---
 kernel/rseq.c | 25 +++++++++++++++++++++----

Can an rseq maintainer please review this? I can carry it via the execve tree with the related patches...

-Kees

Quoted 67 lines
 1 file changed, 21 insertions(+), 4 deletions(-)
kernel/rseq.c +21 -4
index 9de6e35fe..c5809cd13 100644
@@ -13,6 +13,7 @@
 #include <linux/syscalls.h>
 #include <linux/rseq.h>
 #include <linux/types.h>
+#include <linux/task_work.h>
 #include <asm/ptrace.h>
 
 #define CREATE_TRACE_POINTS
@@ -320,6 +321,8 @@ void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs)
 	if (unlikely(t->flags & PF_EXITING))
 		return;
 
+	t->kill_on_efault = true;
+
 	/*
 	 * regs is NULL if and only if the caller is in a syscall path.  Skip
 	 * fixup and leave rseq_cs as is so that rseq_sycall() will detect and
@@ -330,13 +333,18 @@ void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs)
 		if (unlikely(ret < 0))
 			goto error;
 	}
-	if (unlikely(rseq_update_cpu_node_id(t)))
-		goto error;
-	return;
+	if (likely(!rseq_update_cpu_node_id(t)))
+		goto out;
 
 error:
+	/* Allow task work to override signr */
+	task_work_run();
+
 	sig = ksig ? ksig->sig : 0;
 	force_sigsegv(sig);
+
+out:
+	t->kill_on_efault = false;
 }
 
 #ifdef CONFIG_DEBUG_RSEQ
@@ -353,8 +361,17 @@ void rseq_syscall(struct pt_regs *regs)
 
 	if (!t->rseq)
 		return;
-	if (rseq_get_rseq_cs(t, &rseq_cs) || in_rseq_cs(ip, &rseq_cs))
+
+	t->kill_on_efault = true;
+
+	if (rseq_get_rseq_cs(t, &rseq_cs) || in_rseq_cs(ip, &rseq_cs)) {
+		/* Allow task work to override signr */
+		task_work_run();
+
 		force_sig(SIGSEGV);
+	}
+
+	t->kill_on_efault = false;
 }
 
 #endif
Signature · 1 line
2.43.0
Signature · 1 line
Kees Cook
maintainer
#4 lore raw

Re: [RESEND][PATCH 3/3] rseq: Ensure SIGBUS delivered on memory failure

Quoted 20 lines · Kees Cook
Quoted 19 lines · Andrew Zaborowski

Uncorrected memory errors for user pages are signaled to processes using SIGBUS or, if the error happens in a syscall, an error retval from the syscall. The SIGBUS is documented in Documentation/mm/hwpoison.rst#failure-recovery-modes

Once a user task sets t->rseq in the rseq() syscall, if the kernel cannot access the memory pointed to by t->rseq->rseq_cs, that initial rseq() and all future syscalls should return an error so understandably the code just kills the task.

To ensure that SIGBUS is used set the new t->kill_on_efault flag and run queued task work on rseq_get_rseq_cs() errors to give memory_failure the chance to run.

Note: the rseq checks run inside resume_user_mode_work() so whenever _TIF_NOTIFY_RESUME is set. They do not run on every syscall exit so I'm not concerned that these extra flag operations are in a hot path, except with CONFIG_DEBUG_RSEQ.

Quoted 6 lines
Quoted 3 lines
---
 kernel/rseq.c | 25 +++++++++++++++++++++----

Can an rseq maintainer please review this? I can carry it via the execve tree with the related patches...

*sigh*,.. because get_maintainers just doesn't work or something?

Anyway, I'm confused by the signal code (as always), why isn't the task_work_run() in get_signal() sufficient?

At some point we're going to run into trouble with sprinkling task_work_run() around willy nilly :/

Quoted 71 lines
Quoted 68 lines
 1 file changed, 21 insertions(+), 4 deletions(-)
kernel/rseq.c +21 -4
index 9de6e35fe..c5809cd13 100644
@@ -13,6 +13,7 @@
 #include <linux/syscalls.h>
 #include <linux/rseq.h>
 #include <linux/types.h>
+#include <linux/task_work.h>
 #include <asm/ptrace.h>
 
 #define CREATE_TRACE_POINTS
@@ -320,6 +321,8 @@ void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs)
 	if (unlikely(t->flags & PF_EXITING))
 		return;
 
+	t->kill_on_efault = true;
+
 	/*
 	 * regs is NULL if and only if the caller is in a syscall path.  Skip
 	 * fixup and leave rseq_cs as is so that rseq_sycall() will detect and
@@ -330,13 +333,18 @@ void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs)
 		if (unlikely(ret < 0))
 			goto error;
 	}
-	if (unlikely(rseq_update_cpu_node_id(t)))
-		goto error;
-	return;
+	if (likely(!rseq_update_cpu_node_id(t)))
+		goto out;
 
 error:
+	/* Allow task work to override signr */
+	task_work_run();
+
 	sig = ksig ? ksig->sig : 0;
 	force_sigsegv(sig);
+
+out:
+	t->kill_on_efault = false;
 }
 
 #ifdef CONFIG_DEBUG_RSEQ
@@ -353,8 +361,17 @@ void rseq_syscall(struct pt_regs *regs)
 
 	if (!t->rseq)
 		return;
-	if (rseq_get_rseq_cs(t, &rseq_cs) || in_rseq_cs(ip, &rseq_cs))
+
+	t->kill_on_efault = true;
+
+	if (rseq_get_rseq_cs(t, &rseq_cs) || in_rseq_cs(ip, &rseq_cs)) {
+		/* Allow task work to override signr */
+		task_work_run();
+
 		force_sig(SIGSEGV);
+	}
+
+	t->kill_on_efault = false;
 }
 
 #endif
Signature · 1 line
2.43.0
Signature · 1 line
Kees Cook
#5 lore raw

Re: [RESEND][PATCH 3/3] rseq: Ensure SIGBUS delivered on memory failure

Quoted 28 lines · Peter Zijlstra
Quoted 20 lines · Kees Cook
Quoted 19 lines · Andrew Zaborowski

Uncorrected memory errors for user pages are signaled to processes using SIGBUS or, if the error happens in a syscall, an error retval from the syscall. The SIGBUS is documented in Documentation/mm/hwpoison.rst#failure-recovery-modes

Once a user task sets t->rseq in the rseq() syscall, if the kernel cannot access the memory pointed to by t->rseq->rseq_cs, that initial rseq() and all future syscalls should return an error so understandably the code just kills the task.

To ensure that SIGBUS is used set the new t->kill_on_efault flag and run queued task work on rseq_get_rseq_cs() errors to give memory_failure the chance to run.

Note: the rseq checks run inside resume_user_mode_work() so whenever _TIF_NOTIFY_RESUME is set. They do not run on every syscall exit so I'm not concerned that these extra flag operations are in a hot path, except with CONFIG_DEBUG_RSEQ.

Quoted 6 lines
Quoted 3 lines
---
  kernel/rseq.c | 25 +++++++++++++++++++++----

Can an rseq maintainer please review this? I can carry it via the execve tree with the related patches...

Quoted 7 lines

*sigh*,.. because get_maintainers just doesn't work or something?

Anyway, I'm confused by the signal code (as always), why isn't the task_work_run() in get_signal() sufficient?

At some point we're going to run into trouble with sprinkling task_work_run() around willy nilly :/

I agree with Peter: adding explicit calls to task_work_run all over the kernel does not appear to be an elegant solution.

One thing I am missing is a clear motivation for adding this code:
what is the real-world use-case that benefits from getting this SIGBUS rather than a SIGSEGV or -EFAULT ?

Also, I feel like we should investigate turning SIGSEGV into SIGBUS at signal delivery rather than handle this here and there in the kernel code.

Thoughts ?

Thanks,

Mathieu

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
maintainer
#6 lore raw
In reply to Andrew Zaborowski
Quoted 48 lines · Andrew Zaborowski

Uncorrected memory errors for user pages are signaled to processes using SIGBUS or, if the error happens in a syscall, an error retval from the syscall. The SIGBUS is documented in Documentation/mm/hwpoison.rst#failure-recovery-modes

But there are corner cases where we cannot or don't want to return a plain error from the syscall. Subsequent commits covers two such cases:
execve and rseq. Current code, in both places, will kill the task with a SIGSEGV on error. While not explicitly stated, it can be argued that it should be a SIGBUS, for consistency and for the benefit of the userspace signal handlers. Even if the process cannot handle the signal, perhaps the parent process can. This was the case in the scenario that motivated this patch.

In both cases, the architecture's exception handler (MCE handler on x86) will queue a call to memory_failure. This doesn't work because the syscall-specific code sees the -EFAULT and terminates the task before the queued work runs.

To fix this: 1. let pending work run in the error cases in both places.

And 2. on MCE, ensure memory_failure() is passed MF_ACTION_REQUIRED so that the SIGBUS is queued. Normally when the MCE is in a syscall, a fixup of return IP and a call to kill_me_never() are what we want. But in this case it's necessary to queue kill_me_maybe() which will set MF_ACTION_REQUIRED which is checked by memory_failure().

To do this the syscall code will set current->kill_on_efault, a new task_struct flag. Check that flag in arch/x86/kernel/cpu/mce/core.c:do_machine_check()

Note: the flag is not x86 specific even if only x86 handling is being added here. The definition could be guarded by #ifdef CONFIG_MEMORY_FAILURE, but it would then need set/clear utilities.

---
Resending through an SMTP server that won't add the company footer.

This is a v2 of
https://lore.kernel.org/linux-mm/[email protected]/
In the v1 the existing flag current->in_execve was being reused instead of adding a new one. Kees Cook commented in
https://lore.kernel.org/linux-mm/202405010915.465AF19@keescook/ that current->in_execve is going away. Lacking a better idea and seeing that execve() and rseq() would benefit from using a common mechanism, I decided to add this new flag.

Quoted 4 lines

Perhaps with a better name current->kill_on_efault could replace brpm->point_of_no_return to offset the pain of having this extra flag.

---
 arch/x86/kernel/cpu/mce/core.c | 18 +++++++++++++++++-

Since this touches arch/x86/, can an x86 maintainer review this? I can carry this via the execve tree...

-Kees

Quoted 55 lines
 include/linux/sched.h          |  2 ++
 2 files changed, 19 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/mce/core.c +17 -1
index ad0623b65..13f2ace3d 100644
@@ -1611,7 +1611,7 @@ noinstr void do_machine_check(struct pt_regs *regs)
 			if (p)
 				SetPageHWPoison(p);
 		}
-	} else {
+	} else if (!current->kill_on_efault) {
 		/*
 		 * Handle an MCE which has happened in kernel space but from
 		 * which the kernel can recover: ex_has_fault_handler() has
@@ -1628,6 +1628,22 @@ noinstr void do_machine_check(struct pt_regs *regs)
 
 		if (m.kflags & MCE_IN_KERNEL_COPYIN)
 			queue_task_work(&m, msg, kill_me_never);
+	} else {
+		/*
+		 * Even with recovery code extra handling is required when
+		 * we're not returning to userspace after error (e.g. in
+		 * execve() beyond the point of no return) to ensure that
+		 * a SIGBUS is delivered.
+		 */
+		if (m.kflags & MCE_IN_KERNEL_RECOV) {
+			if (!fixup_exception(regs, X86_TRAP_MC, 0, 0))
+				mce_panic("Failed kernel mode recovery", &m, msg);
+		}
+
+		if (!mce_usable_address(&m))
+			queue_task_work(&m, msg, kill_me_now);
+		else
+			queue_task_work(&m, msg, kill_me_maybe);
 	}
 
 out:
include/linux/sched.h +2 -0
index 61591ac6e..0cde1ba11 100644
@@ -975,6 +975,8 @@ struct task_struct {
 	/* delay due to memory thrashing */
 	unsigned                        in_thrashing:1;
 #endif
+	/* Kill task on user memory access error */
+	unsigned                        kill_on_efault:1;
 
 	unsigned long			atomic_flags; /* Flags requiring atomic access. */
 
Signature · 1 line
2.43.0
Signature · 1 line
Kees Cook
maintainer
#7 lore raw
Quoted 2 lines · Kees Cook

Since this touches arch/x86/, can an x86 maintainer review this? I can carry this via the execve tree...

No, we can't until the smoke from the handwaving clears:

Quoted 5 lines
Quoted 5 lines

While not explicitly stated, it can be argued that it
should be a SIGBUS, for consistency and for the benefit of the userspace signal handlers. Even if the process cannot handle the signal, perhaps the parent process can. This was the case in the scenario that motivated this patch.

I have no clue what that is trying to tell me.

Signature · 1 line
Sent from a small device: formatting sucks and brevity is inevitable.

A message that is not in the archive (sent off-list or not yet received): SA1PR11MB69926BFE8EFDA7B3C3D84560E7B82@SA1PR11MB6992.namprd11.prod.outlook.com

#9 lore raw

[Sorry if I'm breaking threading]

Quoted 8 lines · Borislav Petkov
Quoted 5 lines · Kees Cook
Quoted 5 lines

While not explicitly stated, it can be argued that it
should be a SIGBUS, for consistency and for the benefit of the userspace signal handlers. Even if the process cannot handle the signal, perhaps the parent process can. This was the case in the scenario that motivated this patch.

I have no clue what that is trying to tell me.

Documentation/mm/hwpoison.rst#failure-recovery-modes documents the SIGBUS on memory failure behavior:

Send SIGBUS when the application runs into the corrupted page.

There may be other docs that specify this behavior but I didn't find them. To me this implies that when userspace code directly accesses poisoned memory it should receive a SIGBUS but not sure if the wording also implies a SIGBUS on a kernel access on behalf of userspace, i.e. in a syscall. Hence why I said "not explicitly stated".

Now I'm not sure it matters. Logically if a program wants to handle memory errors, or its parent process wants to know the child was killed because of a HW problem, it probably doesn't care whether the page was accessed directly or indirectly so it expects a SIGBUS always. Tony Luck also seemed to agree this was the expected behavior when commenting on this on a different forum.

Best regards

maintainer
#10 lore raw
Quoted 1 line · Andrew Zaborowski

Now I'm not sure it matters.

I'm not sure it matters either. You're adding all that code and task_struct member just because the kernel sends SIGBUS on a memory failure. Oh well.

How is that more beneficial for the overall recovery strategy than killing the current task? IOW, what is the real, practical advantage of this and why do we want to support it indefinitely?

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#11 lore raw
Quoted 7 lines · Borislav Petkov

I'm not sure it matters either. You're adding all that code and task_struct member just because the kernel sends SIGBUS on a memory failure. Oh well.

How is that more beneficial for the overall recovery strategy than killing the current task? IOW, what is the real, practical advantage of this and why do we want to support it indefinitely?

I don't have a "real world" use case, we hit these two bugs in HW testing. Qemu relies on the SIGBUS logic but the execve and rseq cases cannot be recovered from, the main benefit of sending the correct signal is perhaps information to the user.

If this cannot be fixed then optimally it should be documented.

As for "all that code", the memory failure handling code is of certain size and this is a comparatively tiny fix for a tiny issue.

Best regards

maintainer
#12 lore raw
Quoted 2 lines · Andrew Zaborowski

I don't have a "real world" use case, we hit these two bugs in HW testing.

You inject MCEs or what testing do you mean here?

In what pages? I presume user...

So instead of the process getting killed, you want to return SIGBUS because, "hey caller, your process encountered an MCE while being attempted to be executed"?

Quoted 3 lines

Qemu relies on the SIGBUS logic but the execve and rseq cases cannot be recovered from, the main benefit of sending the correct signal is perhaps information to the user.

You will have that info in the logs - we're usually very loud when we get an MCE...

Quoted 1 line

If this cannot be fixed then optimally it should be documented.

I'm not convinced at all that jumping through hoops you're doing, is worth the effort.

Quoted 2 lines

As for "all that code", the memory failure handling code is of certain size and this is a comparatively tiny fix for a tiny issue.

No, I didn't say anything about the memory failure code - it is about supporting that obscure use case and the additional logic you're adding to the #MC handler which looks like a real mess already and us having to support that use case indefinitely.

So why does it matter if a process which is being executed and gets an MCE beyond the point of no return absolutely needs to return SIGBUS vs it getting killed and you still get an MCE logged on the machine, in either case?

I mean, I would understand it when the parent process can do something meaningful about it but if not, why does it matter at all?

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

A message that is not in the archive (sent off-list or not yet received): SA1PR11MB69927AE28B46583DCB5C97DEE7BA2@SA1PR11MB6992.namprd11.prod.outlook.com

#14 lore raw
Quoted 3 lines · Borislav Petkov

So instead of the process getting killed, you want to return SIGBUS because, "hey caller, your process encountered an MCE while being attempted to be executed"?

The tests could be changed to expect the SIGSEGV but in this case it seemed that the test was good and the kernel was misbehaving. One of the authors of the MCE handling code confirmed that.

Quoted 7 lines
Quoted 4 lines

Qemu relies on the SIGBUS logic but the execve and rseq cases cannot be recovered from, the main benefit of sending the correct signal is perhaps information to the user.

You will have that info in the logs - we're usually very loud when we get an MCE...

True, though that's hard to link to a specific process crash. It's also hard to extract the page address in the process's address space from that, although I don't think there's a current use case.

Quoted 5 lines
Quoted 2 lines

If this cannot be fixed then optimally it should be documented.

I'm not convinced at all that jumping through hoops you're doing, is worth the effort.

That could be, again this could be fixed in the documentation instead.

Quoted 5 lines
Quoted 3 lines

As for "all that code", the memory failure handling code is of certain size and this is a comparatively tiny fix for a tiny issue.

No, I didn't say anything about the memory failure code - it is about

I was replying to your comment about the size of the change.

Quoted 3 lines

supporting that obscure use case and the additional logic you're adding to the #MC handler which looks like a real mess already and us having to support that use case indefinitely.

Supporting something generally includes supporting the common and the obscure cases. From the user's point of view the kernel has been committed to supporting these scenarios indefinitely or until the deprecation of the SIGBUS-on-memory-error logic, and simply has a bug.

Quoted 5 lines

So why does it matter if a process which is being executed and gets an MCE beyond the point of no return absolutely needs to return SIGBUS vs it getting killed and you still get an MCE logged on the machine, in either case?

A SIGSEGV strongly implies a problem with the program being run, not a specific instance of it. A SIGBUS could be not the program's fault, like in this case.

In these tests the workload was simply relaunched on a SIGBUS which sounded fair to me. A qemu VM could similarly be restarted on an unrecoverable MCE in a page that doesn't belong to the VM but to qemu itself.

Best regards

maintainer
#15 lore raw
Quoted 1 line · Andrew Zaborowski

True, though that's hard to link to a specific process crash.

The process name when the MCE gets reported is *actually* there in the
splat: current->comm.

Quoted 1 line

I was replying to your comment about the size of the change.

My comment was about the code you're adding:

 arch/x86/kernel/cpu/mce/core.c | 18 +++++++++++++++++-
 fs/exec.c                      | 15 ++++++++++++---
 include/linux/sched.h          |  2 ++
 kernel/rseq.c                  | 25 +++++++++++++++++++++----
 4 files changed, 52 insertions(+), 8 deletions(-)

If it is in drivers, I don't care. But it is in main paths and for a questionable use case.

Quoted 2 lines

Supporting something generally includes supporting the common and the obscure cases.

Bullshit. We certainly won't support some obscure use cases just because.

Quoted 3 lines

From the user's point of view the kernel has been committed to supporting these scenarios indefinitely or until the deprecation of the SIGBUS-on-memory-error logic, and simply has a bug.

And lemme repeat my question:

So why does it matter if a process which is being executed and gets an MCE beyond the point of no return absolutely needs to return SIGBUS vs it getting killed and you still get an MCE logged on the machine, in either case?

Bug which is seen by whom or what?

If a process dies, it dies.

Quoted 4 lines

In these tests the workload was simply relaunched on a SIGBUS which sounded fair to me. A qemu VM could similarly be restarted on an unrecoverable MCE in a page that doesn't belong to the VM but to qemu itself.

If an MCE hits at that particular point once in a blue moon, I don't care. If it is a special use case where you inject an MCE right then and there to test recovery actions, then that's perhaps a different story.

Usually, a lot of things can be done. As long as there's a valid use case to support. But since you hesitate to explain what exactly we're supporting, I can't help you.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#16 lore raw
Quoted 5 lines · Borislav Petkov
Quoted 1 line · Andrew Zaborowski

True, though that's hard to link to a specific process crash.

The process name when the MCE gets reported is *actually* there in the
splat: current->comm.

That's the current process. The list of processes to be signalled is determined later and not in a simple way.

Quoted 6 lines
Quoted 3 lines

Supporting something generally includes supporting the common and the obscure cases.

Bullshit. We certainly won't support some obscure use cases just because.

It's simple reliability, if you support something only sometimes no one can rely on it. Without a deep analysis of their kernel code snapshot at least.

Quoted 5 lines
Quoted 4 lines

From the user's point of view the kernel has been committed to supporting these scenarios indefinitely or until the deprecation of the SIGBUS-on-memory-error logic, and simply has a bug.

Quoted 8 lines

And lemme repeat my question:

So why does it matter if a process which is being executed and gets an MCE beyond the point of no return absolutely needs to return SIGBUS vs it getting killed and you still get an MCE logged on the machine, in either case?

Bug which is seen by whom or what?

In the case I know of, by the parent process, it's basing some decision on the signal number and the expected behavior from the kernel even if not unambiguously documented.

Like I said it can be worked around in userspace, my change doesn't *enable* the use case.

Best regards

maintainer
#17 lore raw

So,

to sum up the thread here:

1. Arguably, tasks which have encountered a memory error should get sent a SIGBUS.

2. if a valid use case appears, the proper fix should be not to sprinkle special-handling code in random syscalls in a whack-a-mole fashion but to note somewhere in the task struct that the task has encountered a memory error and then *override* the signal it gets sent to it with a SIGBUS one.

I.e., this should be a generic solution, if anything.

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette