perf sched: Introduce schedstat tool
cover perf sched: Introduce schedstat tool
MOTIVATION
----------
Existing perf sched is quite exhaustive and provides lot of insights into scheduler behavior but it quickly becomes impractical to use for long running or scheduler intensive workload. For ex, perf sched record has ~7.77% overhead on hackbench (with 25 groups each running 700K loops on a 2-socket 128 Cores 256 Threads 3rd Generation EPYC Server), and it generates huge 56G perf.data for which perf takes ~137 mins to prepare and write it to disk [1].
Unlike perf sched record, which hooks onto set of scheduler tracepoints and generates samples on a tracepoint hit, perf sched schedstat record takes snapshot of the /proc/schedstat file before and after the workload, i.e. there is zero interference on workload run. Also, it takes very minimal time to parse /proc/schedstat, convert it into perf samples and save those samples into perf.data file. Result perf.data file is much smaller. So, overall perf sched schedstat record is much more light- weight compare to perf sched record.
We, internally at AMD, have been using this (a variant of this, known as "sched-scoreboard"[2]) and found it to be very useful to analyse impact of any scheduler code changes[3][4].
Please note that, this is not a replacement of perf sched record/report. The intended users of the new tool are scheduler developers, not regular users.
USAGE
-----
# perf sched schedstat record # perf sched schedstat report
Note: Although perf schedstat tool supports workload profiling syntax (i.e. -- <workload> ), the recorded profile is still systemwide since the /proc/schedstat is a systemwide file.
HOW TO INTERPRET THE REPORT
---------------------------
The schedstat report starts with total time profiling was active in terms of jiffies:
----------------------------------------------------------------------------------------------------
Time elapsed (in jiffies) : 24537
----------------------------------------------------------------------------------------------------
Next is cpu scheduling statistics. These are simple diffs of /proc/schedstat cpu lines along with description. The report also prints % relative to base stat.
In the example below, schedule() left the cpu0 idle 98.19% of the time. 16.54% of total try_to_wake_up() was to wakeup local cpu. And, the total waittime by tasks on cpu0 is 0.49% of the total runtime by tasks on the same cpu.
----------------------------------------------------------------------------------------------------
cpu: cpu0
----------------------------------------------------------------------------------------------------
sched_yield() count : 0 Legacy counter can be ignored : 0 schedule() called : 17138 schedule() left the processor idle : 16827 ( 98.19% ) try_to_wake_up() was called : 508 try_to_wake_up() was called to wake up the local cpu : 84 ( 16.54% ) total runtime by tasks on this processor (in jiffies) : 2408959243 total waittime by tasks on this processor (in jiffies) : 11731825 ( 0.49% ) total timeslices run on this cpu : 311
----------------------------------------------------------------------------------------------------
Next is load balancing statistics. For each of the sched domains (eg: SMT, MC, DIE...), the scheduler computes statistics under the following three categories:
1) Idle Load Balance: Load balancing performed on behalf of a long idling cpu by some other cpu.
2) Busy Load Balance: Load balancing performed when the cpu was busy.
3) New Idle Balance : Load balancing performed when a cpu just became idle.
Under each of these three categories, schedstat report provides different load balancing statistics. Along with direct stats, the report also contains derived metrics prefixed with *. Example:
----------------------------------------------------------------------------------------------------
CPU 0 DOMAIN 0
----------------------------------------------------------------------------------------------------
------------------------------------------<Category idle>-------------------------------------------
load_balance() count on cpu idle : 50 $ 490.74 $ load_balance() found balanced on cpu idle : 42 $ 584.21 $ load_balance() move task failed on cpu idle : 8 $ 3067.12 $ imbalance sum on cpu idle : 8 pull_task() count on cpu idle : 0 pull_task() when target task was cache-hot on cpu idle : 0 load_balance() failed to find busier queue on cpu idle : 0 $ 0.00 $ load_balance() failed to find busier group on cpu idle : 42 $ 584.21 $ *load_balance() success count on cpu idle : 0 *avg task pulled per successful lb attempt (cpu idle) : 0.00 ------------------------------------------<Category busy>------------------------------------------- load_balance() count on cpu busy : 2 $ 12268.50 $ load_balance() found balanced on cpu busy : 2 $ 12268.50 $ load_balance() move task failed on cpu busy : 0 $ 0.00 $ imbalance sum on cpu busy : 0 pull_task() count on cpu busy : 0 pull_task() when target task was cache-hot on cpu busy : 0 load_balance() failed to find busier queue on cpu busy : 0 $ 0.00 $ load_balance() failed to find busier group on cpu busy : 1 $ 24537.00 $ *load_balance() success count on cpu busy : 0 *avg task pulled per successful lb attempt (cpu busy) : 0.00 -----------------------------------------<Category newidle>----------------------------------------- load_balance() count on cpu newly idle : 427 $ 57.46 $ load_balance() found balanced on cpu newly idle : 382 $ 64.23 $ load_balance() move task failed on cpu newly idle : 45 $ 545.27 $ imbalance sum on cpu newly idle : 48 pull_task() count on cpu newly idle : 0 pull_task() when target task was cache-hot on cpu newly idle : 0 load_balance() failed to find busier queue on cpu newly idle : 0 $ 0.00 $ load_balance() failed to find busier group on cpu newly idle : 382 $ 64.23 $ *load_balance() success count on cpu newly idle : 0 *avg task pulled per successful lb attempt (cpu newly idle) : 0.00
----------------------------------------------------------------------------------------------------
Consider following line:
load_balance() found balanced on cpu newly idle : 382 $ 64.23 $
While profiling was active, the load-balancer found 382 times the load needs to be balanced on a newly idle CPU 0. Following value encapsulated inside $ is average jiffies between two events (24537 / 382 = 64.23).
Next is active_load_balance() stats. alb did not trigger while I ran a workload so it's all 0s.
----------------------------------<Category active_load_balance()>----------------------------------
active_load_balance() count : 0 active_load_balance() move task failed : 0 active_load_balance() successfully moved a task : 0
----------------------------------------------------------------------------------------------------
Next are sched_balance_exec() and sched_balance_fork() stats. They are not used but we kept it in RFC just for legacy purpose. Unless opposed, we plan to remove them in next revision.
Next is wakeup statistics. For every domain, the report also shows task-wakeup statistics. Example:
--------------------------------------------<Wakeup Info>-------------------------------------------
try_to_wake_up() awoke a task that last ran on a diff cpu : 12070 try_to_wake_up() moved task because cache-cold on own cpu : 3324 try_to_wake_up() started passive balancing : 0
----------------------------------------------------------------------------------------------------
Same set of stats are reported for each cpu and each domain level.
TODO:
- This RFC series supports v15 layout of /proc/schedstat but v16 layout is already being pushed upstream. We are planning to include v16 as well in the next revision.
- Currently schedstat tool provides statistics of only one run but we are planning to add perf sched schedstat diff which can compare the data of two different runs (possibly good and bad) and highlight where scheduler decisions are impacting workload performance.
- perf sched schedstat records /proc/schedstat which is a cpu and domain level scheduler statistic. We are planning to add taskstat tool which reads task stats from procfs and generate scheduler statistic report at task granularity. this will probably a standalone tool, something like perf sched taskstat record/report.
- /proc/schedstat shows cpumask in domain line to indicate a group of cpus that belong to the domain. Since we are not using domain<->cpumask data anywhere, we are not capturing it as part of perf sample. But we are planning to include it in the next revision.
- We have tested the patch only on AMD machines, not on other platforms.
- Some of the perf related features can be added to the schedstat sub- command as well: for ex, pipemode, -p <pid> option to profile running process etc. We are not planning to add TUI support however.
- Code changes are for RFC and thus not optimal. Some of the places where code changes are not required for RFC are marked as /* FIXME */.
- Documenting details about schedstat tool in perf-sched man page will also be done in next revision.
- Checkpatch warnings are ignored for now.
Patches are prepared on perf-tools-next/perf-tools-next (37862d6fdced). Although all changes are in tools/perf/, kernel is important since it's using v15 of /proc/schedstat.
[1] https://youtu.be/lg-9aG2ajA0?t=283
[2] https://github.com/AMDESE/sched-scoreboard
[3] https://lore.kernel.org/lkml/[email protected]/
[4] https://lore.kernel.org/lkml/[email protected]/
Ravi Bangoria (2):
perf sched: Make struct perf_sched sched a global variable perf sched: Add template code for schedstat subcommand
Swapnil Sapkal (2):
perf sched schedstat: Add record and rawdump support perf sched schedstat: Add support for report subcommand
tools/lib/perf/Documentation/libperf.txt | 2 + tools/lib/perf/Makefile | 2 +- tools/lib/perf/include/perf/event.h | 37 ++ .../lib/perf/include/perf/schedstat-cpu-v15.h | 22 + .../perf/include/perf/schedstat-domain-v15.h | 121 ++++ tools/perf/builtin-inject.c | 2 + tools/perf/builtin-sched.c | 558 ++++++++++++++++-- tools/perf/util/event.c | 54 ++ tools/perf/util/event.h | 2 + tools/perf/util/session.c | 44 ++ tools/perf/util/synthetic-events.c | 170 ++++++ tools/perf/util/synthetic-events.h | 4 + tools/perf/util/tool.h | 4 +- 13 files changed, 965 insertions(+), 57 deletions(-) create mode 100644 tools/lib/perf/include/perf/schedstat-cpu-v15.h create mode 100644 tools/lib/perf/include/perf/schedstat-domain-v15.h
Signature · 1 line
2.44.0
RFC 1/4 perf sched: Make `struct perf_sched sched` a global variable
Currently it is function local. Followup changes will add new fields to this structure, and those new fields will be used by callback functions to which there is no way to pass a pointer of sched variable. So make it a global variable. Also, rename it to perf_sched to be consistent with other builtin-*.c subtools nomenclature.
--- tools/perf/builtin-sched.c | 109 +++++++++++++++++++------------------ 1 file changed, 55 insertions(+), 54 deletions(-)
tools/perf/builtin-sched.c +55 -54
@@ -3504,29 +3504,30 @@ static int __cmd_record(int argc, const char **argv)return ret; } +static const char default_sort_order[] ="avg, max, switch, runtime" ; +static struct perf_sched perf_sched = { + .tool = { + .sample = perf_sched__process_tracepoint_sample, + .comm = perf_sched__process_comm, + .namespaces = perf_event__process_namespaces, + .lost = perf_event__process_lost, + .fork = perf_sched__process_fork_event, + .ordered_events = true, + }, + .cmp_pid =LIST_HEAD_INIT (perf_sched.cmp_pid), + .sort_list =LIST_HEAD_INIT (perf_sched.sort_list), + .sort_order = default_sort_order, + .replay_repeat =10 , + .profile_cpu =-1 , + .next_shortname1 ='A' , + .next_shortname2 ='0' , + .skip_merge =0 , + .show_callchain =1 , + .max_stack =5 , +}; +int cmd_sched (int argc,const char **argv) { -static const char default_sort_order[] ="avg, max, switch, runtime" ; -struct perf_sched sched = { - .tool = { - .sample = perf_sched__process_tracepoint_sample, - .comm = perf_sched__process_comm, - .namespaces = perf_event__process_namespaces, - .lost = perf_event__process_lost, - .fork = perf_sched__process_fork_event, - .ordered_events = true, - }, - .cmp_pid =LIST_HEAD_INIT (sched.cmp_pid), - .sort_list =LIST_HEAD_INIT (sched.sort_list), - .sort_order = default_sort_order, - .replay_repeat =10 , - .profile_cpu =-1 , - .next_shortname1 ='A' , - .next_shortname2 ='0' , - .skip_merge =0 , - .show_callchain =1 , - .max_stack =5 , - };const struct option sched_options[] = {OPT_STRING ('i' ,"input" , &input_name,"file" ,"input file name" ),
@@ -3534,31 +3535,31 @@ int cmd_sched(int argc, const char **argv) "be more verbose (show symbol address, etc)"),OPT_BOOLEAN ('D' ,"dump-raw-trace" , &dump_trace,"dump raw trace in ASCII" ), -OPT_BOOLEAN ('f' ,"force" , &sched.force,"don't complain, do it" ), +OPT_BOOLEAN ('f' ,"force" , &perf_sched.force,"don't complain, do it" ),OPT_END () };const struct option latency_options[] = { -OPT_STRING ('s' ,"sort" , &sched.sort_order,"key[,key2...]" , +OPT_STRING ('s' ,"sort" , &perf_sched.sort_order,"key[,key2...]" ,"sort by key(s): runtime, switch, avg, max" ), -OPT_INTEGER ('C' ,"CPU" , &sched.profile_cpu, +OPT_INTEGER ('C' ,"CPU" , &perf_sched.profile_cpu,"CPU to profile on" ), -OPT_BOOLEAN ('p' ,"pids" , &sched.skip_merge, +OPT_BOOLEAN ('p' ,"pids" , &perf_sched.skip_merge,"latency stats per pid instead of per comm" ),OPT_PARENT (sched_options) };const struct option replay_options[] = { -OPT_UINTEGER ('r' ,"repeat" , &sched.replay_repeat, +OPT_UINTEGER ('r' ,"repeat" , &perf_sched.replay_repeat,"repeat the workload replay N times (-1: infinite)" ),OPT_PARENT (sched_options) };const struct option map_options[] = { -OPT_BOOLEAN (0 ,"compact" , &sched.map.comp, +OPT_BOOLEAN (0 ,"compact" , &perf_sched.map.comp,"map output in compact mode" ), -OPT_STRING (0 ,"color-pids" , &sched.map.color_pids_str,"pids" , +OPT_STRING (0 ,"color-pids" , &perf_sched.map.color_pids_str,"pids" ,"highlight given pids in map" ), -OPT_STRING (0 ,"color-cpus" , &sched.map.color_cpus_str,"cpus" , +OPT_STRING (0 ,"color-cpus" , &perf_sched.map.color_cpus_str,"cpus" ,"highlight given CPUs in map" ), -OPT_STRING (0 ,"cpus" , &sched.map.cpus_str,"cpus" , +OPT_STRING (0 ,"cpus" , &perf_sched.map.cpus_str,"cpus" ,"display given CPUs in map" ),OPT_PARENT (sched_options) };
@@ -3567,24 +3568,24 @@ int cmd_sched(int argc, const char **argv) "file", "vmlinux pathname"),OPT_STRING (0 ,"kallsyms" , &symbol_conf.kallsyms_name,"file" ,"kallsyms pathname" ), -OPT_BOOLEAN ('g' ,"call-graph" , &sched.show_callchain, +OPT_BOOLEAN ('g' ,"call-graph" , &perf_sched.show_callchain,"Display call chains if present (default on)" ), -OPT_UINTEGER (0 ,"max-stack" , &sched.max_stack, +OPT_UINTEGER (0 ,"max-stack" , &perf_sched.max_stack,"Maximum number of functions to display backtrace." ),OPT_STRING (0 ,"symfs" , &symbol_conf.symfs,"directory" ,"Look for files with symbols relative to this directory" ), -OPT_BOOLEAN ('s' ,"summary" , &sched.summary_only, +OPT_BOOLEAN ('s' ,"summary" , &perf_sched.summary_only,"Show only syscall summary with statistics" ), -OPT_BOOLEAN ('S' ,"with-summary" , &sched.summary, +OPT_BOOLEAN ('S' ,"with-summary" , &perf_sched.summary,"Show all syscalls and summary with statistics" ), -OPT_BOOLEAN ('w' ,"wakeups" , &sched.show_wakeups,"Show wakeup events" ), -OPT_BOOLEAN ('n' ,"next" , &sched.show_next,"Show next task" ), -OPT_BOOLEAN ('M' ,"migrations" , &sched.show_migrations,"Show migration events" ), -OPT_BOOLEAN ('V' ,"cpu-visual" , &sched.show_cpu_visual,"Add CPU visual" ), -OPT_BOOLEAN ('I' ,"idle-hist" , &sched.idle_hist,"Show idle events only" ), -OPT_STRING (0 ,"time" , &sched.time_str,"str" , +OPT_BOOLEAN ('w' ,"wakeups" , &perf_sched.show_wakeups,"Show wakeup events" ), +OPT_BOOLEAN ('n' ,"next" , &perf_sched.show_next,"Show next task" ), +OPT_BOOLEAN ('M' ,"migrations" , &perf_sched.show_migrations,"Show migration events" ), +OPT_BOOLEAN ('V' ,"cpu-visual" , &perf_sched.show_cpu_visual,"Add CPU visual" ), +OPT_BOOLEAN ('I' ,"idle-hist" , &perf_sched.idle_hist,"Show idle events only" ), +OPT_STRING (0 ,"time" , &perf_sched.time_str,"str" ,"Time span for analysis (start,stop)" ), -OPT_BOOLEAN (0 ,"state" , &sched.show_state,"Show task state when sched-out" ), +OPT_BOOLEAN (0 ,"state" , &perf_sched.show_state,"Show task state when sched-out" ),OPT_STRING ('p' ,"pid" , &symbol_conf.pid_list_str,"pid[,pid...]" ,"analyze events only for given process id(s)" ), OPT_STRING('t', "tid", &symbol_conf.tid_list_str, "tid[,tid...]",
@@ -3645,31 +3646,31 @@ int cmd_sched(int argc, const char **argv) }else if (strlen (argv[0 ]) >2 &&strstarts ("record" , argv[0 ])) {return __cmd_record (argc, argv); }else if (strlen (argv[0 ]) >2 &&strstarts ("latency" , argv[0 ])) { - sched.tp_handler = &lat_ops; + perf_sched.tp_handler = &lat_ops;if (argc >1 ) { argc =parse_options (argc, argv, latency_options, latency_usage,0 );if (argc)usage_with_options (latency_usage, latency_options); } -setup_sorting (&sched, latency_options, latency_usage); -return perf_sched__lat (&sched); +setup_sorting (&perf_sched, latency_options, latency_usage); +return perf_sched__lat (&perf_sched); }else if (!strcmp (argv[0 ],"map" )) {if (argc) { argc =parse_options (argc, argv, map_options, map_usage,0 );if (argc)usage_with_options (map_usage, map_options); } - sched.tp_handler = &map_ops; -setup_sorting (&sched, latency_options, latency_usage); -return perf_sched__map (&sched); + perf_sched.tp_handler = &map_ops; +setup_sorting (&perf_sched, latency_options, latency_usage); +return perf_sched__map (&perf_sched); }else if (strlen (argv[0 ]) >2 &&strstarts ("replay" , argv[0 ])) { - sched.tp_handler = &replay_ops; + perf_sched.tp_handler = &replay_ops;if (argc) { argc =parse_options (argc, argv, replay_options, replay_usage,0 );if (argc)usage_with_options (replay_usage, replay_options); } -return perf_sched__replay (&sched); +return perf_sched__replay (&perf_sched); }else if (!strcmp (argv[0 ],"timehist" )) {if (argc) { argc = parse_options(argc, argv, timehist_options,
@@ -3677,13 +3678,13 @@ int cmd_sched(int argc, const char **argv)if (argc)usage_with_options (timehist_usage, timehist_options); } -if ((sched.show_wakeups || sched.show_next) && - sched.summary_only) { +if ((perf_sched.show_wakeups || perf_sched.show_next) && + perf_sched.summary_only) {pr_err (" Error: -s and -[n|w] are mutually exclusive.\n" );parse_options_usage (timehist_usage, timehist_options,"s" , true); -if (sched.show_wakeups) +if (perf_sched.show_wakeups)parse_options_usage (NULL , timehist_options,"w" , true); -if (sched.show_next) +if (perf_sched.show_next)parse_options_usage (NULL , timehist_options,"n" , true);return -EINVAL ; }
@@ -3691,7 +3692,7 @@ int cmd_sched(int argc, const char **argv)if (ret)return ret; -return perf_sched__timehist (&sched); +return perf_sched__timehist (&perf_sched); }else {usage_with_options (sched_usage, sched_options); }
Signature · 1 line
2.44.0
RFC 2/4 perf sched: Add template code for schedstat subcommand
In reply to Ravi Bangoriaperf sched schedstat will allow user to record the profile with record subcommand and analyse it with report subcommand.
--- tools/perf/builtin-sched.c | 48 +++++++++++++++++++++++++++++++++++++- 1 file changed, 47 insertions(+), 1 deletion(-)
tools/perf/builtin-sched.c +47 -1
@@ -3504,6 +3504,21 @@ static int __cmd_record(int argc, const char **argv)return ret; } +/* perf.data or any other output file name used by schedstat subcommand (only). */ +const char *output_name; + +static int perf_sched__schedstat_record (struct perf_sched *sched__maybe_unused , +int argc__maybe_unused , +const char **argv__maybe_unused ) +{ +return 0 ; +} + +static int perf_sched__schedstat_report (struct perf_sched *sched__maybe_unused ) +{ +return 0 ; +} +static const char default_sort_order[] ="avg, max, switch, runtime" ;static struct perf_sched perf_sched = { .tool = {
@@ -3593,6 +3608,13 @@ int cmd_sched(int argc, const char **argv)OPT_STRING ('C' ,"cpu" , &cpu_list,"cpu" ,"list of cpus to profile" ),OPT_PARENT (sched_options) }; +const struct option schedstat_options[] = { +OPT_STRING ('i' ,"input" , &input_name,"file" , +"`schedstat report` with input filename" ), +OPT_STRING ('o' ,"output" , &output_name,"file" , +"`schedstat record` with output filename" ), +OPT_END () + };const char *const latency_usage[] = { "perf sched latency [<options>]",
@@ -3610,9 +3632,13 @@ int cmd_sched(int argc, const char **argv)"perf sched timehist [<options>]" ,NULL }; +const char *schedstat_usage[] = { +"perf sched schedstat {record|report} [<options>]" , +NULL + };const char *const sched_subcommands[] = {"record" ,"latency" ,"map" ,"replay" ,"script" , -"timehist" ,NULL }; +"timehist" ,"schedstat" ,NULL };const char *sched_usage[] = {NULL , NULL
@@ -3693,6 +3719,26 @@ int cmd_sched(int argc, const char **argv)return ret;return perf_sched__timehist (&perf_sched); + }else if (!strcmp (argv[0 ],"schedstat" )) { +const char *const schedstat_subcommands[] = {"record" ,"report" ,NULL }; + + argc =parse_options_subcommand (argc, argv, schedstat_options, + schedstat_subcommands, + schedstat_usage,0 ); + +if (argv[0 ] && !strcmp (argv[0 ],"record" )) { +if (argc) + argc =parse_options (argc, argv, schedstat_options, + schedstat_usage,0 ); + ret =perf_sched__schedstat_record (&perf_sched, argc, argv); + }else if (argv[0 ] && !strcmp (argv[0 ],"report" )) { +if (argc) + argc =parse_options (argc, argv, schedstat_options, + schedstat_usage,0 ); + ret =perf_sched__schedstat_report (&perf_sched); + }else { +usage_with_options (schedstat_usage, schedstat_options); + } }else {usage_with_options (sched_usage, sched_options); }
Signature · 1 line
2.44.0
RFC 3/4 perf sched schedstat: Add record and rawdump support
In reply to Ravi BangoriaFrom: Swapnil Sapkal <[email protected]>
Define new, perf tool only, sample types and their layouts. Add logic to parse /proc/schedstat, convert it to perf sample format and save samples to perf.data file with perf sched schedstat record subcommand. Also add logic to read perf.data file, interpret schedstat samples and print rawdump of samples with perf script -D.
Note that, /proc/schedstat file output is standardized with version number. The patch supports v15 but older or newer version can be added easily.
--- tools/lib/perf/Documentation/libperf.txt | 2 + tools/lib/perf/Makefile | 2 +- tools/lib/perf/include/perf/event.h | 37 ++++ .../lib/perf/include/perf/schedstat-cpu-v15.h | 13 ++ .../perf/include/perf/schedstat-domain-v15.h | 40 +++++ tools/perf/builtin-inject.c | 2 + tools/perf/builtin-sched.c | 157 +++++++++++++++- tools/perf/util/event.c | 54 ++++++ tools/perf/util/event.h | 2 + tools/perf/util/session.c | 44 +++++ tools/perf/util/synthetic-events.c | 170 ++++++++++++++++++ tools/perf/util/synthetic-events.h | 4 + tools/perf/util/tool.h | 4 +- 13 files changed, 525 insertions(+), 6 deletions(-) create mode 100644 tools/lib/perf/include/perf/schedstat-cpu-v15.h create mode 100644 tools/lib/perf/include/perf/schedstat-domain-v15.h
tools/lib/perf/Documentation/libperf.txt +2 -0
@@ -211,6 +211,8 @@ SYNOPSIS struct perf_record_time_conv; struct perf_record_header_feature; struct perf_record_compressed; + struct perf_record_schedstat_cpu; + struct perf_record_schedstat_domain; -- DESCRIPTION
tools/lib/perf/Makefile +1 -1
@@ -187,7 +187,7 @@ install_lib: libs $(call do_install_mkdir,$(libdir_SQ)); \ cp -fpR $(LIBPERF_ALL) $(DESTDIR)$(libdir_SQ) -HDRS := bpf_perf.h core.h cpumap.h threadmap.h evlist.h evsel.h event.h mmap.h +HDRS := bpf_perf.h core.h cpumap.h threadmap.h evlist.h evsel.h event.h mmap.h schedstat-cpu-v15.h schedstat-domain-v15.h INTERNAL_HDRS := cpumap.h evlist.h evsel.h lib.h mmap.h rc_check.h threadmap.h xyarray.h INSTALL_HDRS_PFX := $(DESTDIR)$(prefix)/include/perf
tools/lib/perf/include/perf/event.h +37 -0
@@ -451,6 +451,39 @@ struct perf_record_compressed {char data[]; }; +struct perf_record_schedstat_cpu_v15 { +#define CPU_FIELD (type, name) type name; +#include "schedstat-cpu-v15.h" +#undef CPU_FIELD +}; + +struct perf_record_schedstat_cpu { +struct perf_event_header header; +__u16 version; +__u64 timestamp; +__u32 cpu; +union { +struct perf_record_schedstat_cpu_v15 v15; + }; +}; + +struct perf_record_schedstat_domain_v15 { +#define DOMAIN_FIELD (type, name) type name; +#include "schedstat-domain-v15.h" +#undef DOMAIN_FIELD +}; + +struct perf_record_schedstat_domain { +struct perf_event_header header; +__u16 version; +__u64 timestamp; +__u32 cpu; +__u16 domain; +union { +struct perf_record_schedstat_domain_v15 v15; + }; +}; +enum perf_user_event_type {/* above any possible kernel type */ PERF_RECORD_USER_TYPE_START =64 ,PERF_RECORD_HEADER_ATTR =64 ,
@@ -472,6 +505,8 @@ enum perf_user_event_type { /* above any possible kernel type */PERF_RECORD_HEADER_FEATURE =80 ,PERF_RECORD_COMPRESSED =81 ,PERF_RECORD_FINISHED_INIT =82 , +PERF_RECORD_SCHEDSTAT_CPU =83 , +PERF_RECORD_SCHEDSTAT_DOMAIN =84 , PERF_RECORD_HEADER_MAX };
@@ -512,6 +547,8 @@ union perf_event {struct perf_record_time_conv time_conv;struct perf_record_header_feature feat;struct perf_record_compressed pack; +struct perf_record_schedstat_cpu schedstat_cpu; + struct perf_record_schedstat_domain schedstat_domain; };#endif /* __LIBPERF_EVENT_H */
tools/lib/perf/include/perf/schedstat-cpu-v15.h new file +13 -0
@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifdef CPU_FIELD +CPU_FIELD(__u32, yld_count) +CPU_FIELD(__u32, array_exp) +CPU_FIELD(__u32, sched_count) +CPU_FIELD(__u32, sched_goidle) +CPU_FIELD(__u32, ttwu_count) +CPU_FIELD(__u32, ttwu_local) +CPU_FIELD(__u64, rq_cpu_time) +CPU_FIELD(__u64, run_delay) +CPU_FIELD(__u64, pcount) +#endif
tools/lib/perf/include/perf/schedstat-domain-v15.h new file +40 -0
@@ -0,0 +1,40 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifdef DOMAIN_FIELD +DOMAIN_FIELD(__u32, idle_lb_count) +DOMAIN_FIELD(__u32, idle_lb_balanced) +DOMAIN_FIELD(__u32, idle_lb_failed) +DOMAIN_FIELD(__u32, idle_lb_imbalance) +DOMAIN_FIELD(__u32, idle_lb_gained) +DOMAIN_FIELD(__u32, idle_lb_hot_gained) +DOMAIN_FIELD(__u32, idle_lb_nobusyq) +DOMAIN_FIELD(__u32, idle_lb_nobusyg) +DOMAIN_FIELD(__u32, busy_lb_count) +DOMAIN_FIELD(__u32, busy_lb_balanced) +DOMAIN_FIELD(__u32, busy_lb_failed) +DOMAIN_FIELD(__u32, busy_lb_imbalance) +DOMAIN_FIELD(__u32, busy_lb_gained) +DOMAIN_FIELD(__u32, busy_lb_hot_gained) +DOMAIN_FIELD(__u32, busy_lb_nobusyq) +DOMAIN_FIELD(__u32, busy_lb_nobusyg) +DOMAIN_FIELD(__u32, newidle_lb_count) +DOMAIN_FIELD(__u32, newidle_lb_balanced) +DOMAIN_FIELD(__u32, newidle_lb_failed) +DOMAIN_FIELD(__u32, newidle_lb_imbalance) +DOMAIN_FIELD(__u32, newidle_lb_gained) +DOMAIN_FIELD(__u32, newidle_lb_hot_gained) +DOMAIN_FIELD(__u32, newidle_lb_nobusyq) +DOMAIN_FIELD(__u32, newidle_lb_nobusyg) +DOMAIN_FIELD(__u32, alb_count) +DOMAIN_FIELD(__u32, alb_failed) +DOMAIN_FIELD(__u32, alb_pushed) +DOMAIN_FIELD(__u32, sbe_count) +DOMAIN_FIELD(__u32, sbe_balanced) +DOMAIN_FIELD(__u32, sbe_pushed) +DOMAIN_FIELD(__u32, sbf_count) +DOMAIN_FIELD(__u32, sbf_balanced) +DOMAIN_FIELD(__u32, sbf_pushed) +DOMAIN_FIELD(__u32, ttwu_wake_remote) +DOMAIN_FIELD(__u32, ttwu_move_affine) +DOMAIN_FIELD(__u32, ttwu_move_balance) +#endif
tools/perf/builtin-inject.c +2 -0
@@ -2204,6 +2204,8 @@ int cmd_inject(int argc, const char **argv) .finished_init = perf_event__repipe_op2_synth, .compressed = perf_event__repipe_op4_synth, .auxtrace = perf_event__repipe_auxtrace, + .schedstat_cpu = perf_event__repipe_op2_synth, + .schedstat_domain = perf_event__repipe_op2_synth, }, .input_name = "-", .samples = LIST_HEAD_INIT(inject.samples),
tools/perf/builtin-sched.c +153 -4
181 lines not on this page · raw message
tools/perf/util/event.c +54 -0
66 lines not on this page · raw message
tools/perf/util/event.h +2 -0
@@ -356,6 +356,8 @@ size_t perf_event__fprintf_cgroup(union perf_event *event, FILE *fp);size_t perf_event__fprintf_ksymbol (union perf_event *event,FILE *fp);size_t perf_event__fprintf_bpf (union perf_event *event,FILE *fp);size_t perf_event__fprintf_text_poke (union perf_event *event,struct machine *machine,FILE *fp); +size_t perf_event__fprintf_schedstat_cpu (union perf_event *event,FILE *fp); +size_t perf_event__fprintf_schedstat_domain (union perf_event *event,FILE *fp);size_t perf_event__fprintf (union perf_event *event,struct machine *machine,FILE *fp); int kallsyms__get_function_start(const char *kallsyms_filename,
tools/perf/util/session.c +44 -0
74 lines not on this page · raw message
tools/perf/util/synthetic-events.c +170 -0
173 lines not on this page · raw message
tools/perf/util/synthetic-events.h +4 -0
@@ -122,4 +122,8 @@ int perf_event__synthesize_for_pipe(struct perf_tool *tool,struct perf_data *data, perf_event__handler_t process); +int perf_event__synthesize_schedstat (struct perf_tool *tool, +struct perf_session *session, +struct machine *machine, +perf_event__handler_t process);#endif // __PERF_SYNTHETIC_EVENTS_H
tools/perf/util/tool.h +3 -1
@@ -77,7 +77,9 @@ struct perf_tool { stat, stat_round, feature, - finished_init; + finished_init, + schedstat_cpu, + schedstat_domain;event_op4 compressed;event_op3 auxtrace;bool ordered_events;
Signature · 1 line
2.44.0
RFC 4/4 perf sched schedstat: Add support for report subcommand
In reply to Ravi BangoriaFrom: Swapnil Sapkal <[email protected]>
perf sched schedstat record captures two sets of samples. For workload profile, first set right before workload starts and second set after workload finishes. For the systemwide profile, first set at the beginning of profile and second set on receiving SIGINT signal.
Add perf sched schedstat report subcommand that will read both the set of samples, get the diff and render a final report. Final report prints scheduler stat at cpu granularity as well as sched domain granularity.
Usage example:
# perf sched schedstat record # perf sched schedstat report
--- tools/lib/perf/include/perf/event.h | 4 +- .../lib/perf/include/perf/schedstat-cpu-v15.h | 29 +- .../perf/include/perf/schedstat-domain-v15.h | 153 ++++++++--- tools/perf/builtin-sched.c | 254 +++++++++++++++++- tools/perf/util/event.c | 4 +- tools/perf/util/synthetic-events.c | 4 +- 6 files changed, 395 insertions(+), 53 deletions(-)
tools/lib/perf/include/perf/event.h +2 -2
@@ -452,7 +452,7 @@ struct perf_record_compressed { };struct perf_record_schedstat_cpu_v15 { -#define CPU_FIELD (type, name) type name; +#define CPU_FIELD (type, name, desc, format, is_pct, pct_of) type name;#include "schedstat-cpu-v15.h"#undef CPU_FIELD };
@@ -468,7 +468,7 @@ struct perf_record_schedstat_cpu { };struct perf_record_schedstat_domain_v15 { -#define DOMAIN_FIELD (type, name) type name; +#define DOMAIN_FIELD (type, name, desc, format, is_jiffies) type name;#include "schedstat-domain-v15.h"#undef DOMAIN_FIELD };
tools/lib/perf/include/perf/schedstat-cpu-v15.h +19 -10
@@ -1,13 +1,22 @@/* SPDX-License-Identifier: GPL-2.0 */ #ifdef CPU_FIELD -CPU_FIELD(__u32, yld_count) -CPU_FIELD(__u32, array_exp) -CPU_FIELD(__u32, sched_count) -CPU_FIELD(__u32, sched_goidle) -CPU_FIELD(__u32, ttwu_count) -CPU_FIELD(__u32, ttwu_local) -CPU_FIELD(__u64, rq_cpu_time) -CPU_FIELD(__u64, run_delay) -CPU_FIELD(__u64, pcount) -#endif +CPU_FIELD (__u32, yld_count,"sched_yield() count" , + "%11u", false, yld_count) +CPU_FIELD (__u32, array_exp,"Legacy counter can be ignored" , + "%11u", false, array_exp) +CPU_FIELD (__u32, sched_count,"schedule() called" , + "%11u", false, sched_count) +CPU_FIELD (__u32, sched_goidle,"schedule() left the processor idle" , + "%11u", true, sched_count) +CPU_FIELD (__u32, ttwu_count,"try_to_wake_up() was called" , + "%11u", false, ttwu_count) +CPU_FIELD (__u32, ttwu_local,"try_to_wake_up() was called to wake up the local cpu" , + "%11u", true, ttwu_count) +CPU_FIELD (__u64, rq_cpu_time,"total runtime by tasks on this processor (in jiffies)" , + "%11llu", false, rq_cpu_time) +CPU_FIELD (__u64, run_delay,"total waittime by tasks on this processor (in jiffies)" , + "%11llu", true, rq_cpu_time) +CPU_FIELD (__u64, pcount,"total timeslices run on this cpu" , + "%11llu", false, pcount) +#endif /* CPU_FIELD */
tools/lib/perf/include/perf/schedstat-domain-v15.h +117 -36
157 lines not on this page · raw message
tools/perf/builtin-sched.c +253 -1
264 lines not on this page · raw message
tools/perf/util/event.c +2 -2
@@ -597,7 +597,7 @@ static size_t __fprintf_schedstat_cpu_v15(union perf_event *event, FILE *fp) size =fprintf (fp,"\ncpu%u " , event->schedstat_cpu.cpu); csv15 = &event->schedstat_cpu.v15; -#define CPU_FIELD (type, name) \ +#define CPU_FIELD (type, name, desc, format, is_pct, pct_of) \ size += fprintf(fp, "%" PRIu64 " ", (unsigned long)csv15->name);#include <perf/schedstat-cpu-v15.h>
@@ -623,7 +623,7 @@ static size_t __fprintf_schedstat_domain_v15(union perf_event *event, FILE *fp) size =fprintf (fp,"\ndomain%u " , event->schedstat_domain.domain); dsv15 = &event->schedstat_domain.v15; -#define DOMAIN_FIELD (type, name) \ +#define DOMAIN_FIELD (type, name, desc, format, is_jiffies) \ size += fprintf(fp, "%" PRIu64 " ", (unsigned long)dsv15->name);#include <perf/schedstat-domain-v15.h>
tools/perf/util/synthetic-events.c +2 -2
@@ -2442,7 +2442,7 @@ static bool read_schedstat_cpu_v15(struct io *io,if (io__get_dec (io, (__u64 *) &cs->cpu) !=' ' )return false; -#define CPU_FIELD (type, name) \ +#define CPU_FIELD (type, name, desc, format, is_pct, pct_of) \ do { \ ch = io__get_dec(io, (__u64 *) &cs->v15.name); \ if (ch != ' ' && ch != '\n') \
@@ -2469,7 +2469,7 @@ static bool read_schedstat_domain_v15(struct io *io,while (io__get_char (io) !=' ' ); -#define DOMAIN_FIELD (type, name) \ +#define DOMAIN_FIELD (type, name, desc, format, is_jiffies) \ do { \ ch = io__get_dec(io, (__u64 *) &ds->v15.name); \ if (ch != ' ' && ch != '\n') \
Signature · 1 line
2.44.0
Re: [RFC 4/4] perf sched schedstat: Add support for report subcommand
Quoted 11 lines · Ravi Bangoria
From: Swapnil Sapkal <[email protected]>
perf sched schedstat recordcaptures two sets of samples. For workload profile, first set right before workload starts and second set after workload finishes. For the systemwide profile, first set at the beginning of profile and second set on receiving SIGINT signal.Add
perf sched schedstat reportsubcommand that will read both the set of samples, get the diff and render a final report. Final report prints scheduler stat at cpu granularity as well as sched domain granularity.
Quoted 9 lines
Usage example:
# perf sched schedstat record # perf sched schedstat reportCo-developed-by Ravi Bangoria <[email protected]>Signed-off-by Swapnil Sapkal <[email protected]>Signed-off-by Ravi Bangoria <[email protected]>
I've tested it on a 240 CPUs Xeon system and it looks very useful. Thanks!
1. Just to confirm, if we want to add new fields for debugging purpose, schedstat-domain-v1x.h and schedstat-cpu-v1x.h are the only files to be touched, right?
2. Although we can filter the output, is it applicable to only track some CPUs? Like perf sched schedstat -C 4 record
thanks,
Chenyu
Re: [RFC 4/4] perf sched schedstat: Add support for report subcommand
Quoted 17 lines · Chen Yu
Quoted 16 lines · Ravi Bangoria
From: Swapnil Sapkal <[email protected]>
perf sched schedstat recordcaptures two sets of samples. For workload profile, first set right before workload starts and second set after workload finishes. For the systemwide profile, first set at the beginning of profile and second set on receiving SIGINT signal.Add
perf sched schedstat reportsubcommand that will read both the set of samples, get the diff and render a final report. Final report prints scheduler stat at cpu granularity as well as sched domain granularity.Usage example:
# perf sched schedstat record # perf sched schedstat report
Quoted 6 lines
Quoted 4 lines
Co-developed-by Ravi Bangoria <[email protected]>Signed-off-by Swapnil Sapkal <[email protected]>Signed-off-by Ravi Bangoria <[email protected]>I've tested it on a 240 CPUs Xeon system and it looks very useful. Thanks!
Glad you found it useful!
Quoted 3 lines
1. Just to confirm, if we want to add new fields for debugging purpose,
schedstat-domain-v1x.handschedstat-cpu-v1x.hare the only files to be touched, right?
Correct.
Quoted 2 lines
2. Although we can filter the output, is it applicable to only track some CPUs? Like perf sched schedstat -C 4 record
Yes, adding filtering capabilities should be possible at both record and report time.
Thanks,
Ravi
Ian Rogers
reviewerQuoted 167 lines · Ravi Bangoria
MOTIVATION
----------Existing
perf schedis quite exhaustive and provides lot of insights into scheduler behavior but it quickly becomes impractical to use for long running or scheduler intensive workload. For ex,perf sched recordhas ~7.77% overhead on hackbench (with 25 groups each running 700K loops on a 2-socket 128 Cores 256 Threads 3rd Generation EPYC Server), and it generates huge 56G perf.data for which perf takes ~137 mins to prepare and write it to disk [1].Unlike
perf sched record, which hooks onto set of scheduler tracepoints and generates samples on a tracepoint hit,perf sched schedstat recordtakes snapshot of the/proc/schedstatfile before and after the workload, i.e. there is zero interference on workload run. Also, it takes very minimal time to parse/proc/schedstat, convert it into perf samples and save those samples into perf.data file. Result perf.data file is much smaller. So, overallperf sched schedstat recordis much more light- weight compare toperf sched record.We, internally at AMD, have been using this (a variant of this, known as "sched-scoreboard"[2]) and found it to be very useful to analyse impact of any scheduler code changes[3][4].
Please note that, this is not a replacement of perf sched record/report. The intended users of the new tool are scheduler developers, not regular users.
USAGE
-----# perf sched schedstat record # perf sched schedstat reportNote: Although perf schedstat tool supports workload profiling syntax (i.e. -- <workload> ), the recorded profile is still systemwide since the
/proc/schedstatis a systemwide file.HOW TO INTERPRET THE REPORT
---------------------------The schedstat report starts with total time profiling was active in terms of jiffies:
----------------------------------------------------------------------------------------------------
Time elapsed (in jiffies) : 24537
----------------------------------------------------------------------------------------------------Next is cpu scheduling statistics. These are simple diffs of
/proc/schedstatcpu lines along with description. The report also prints % relative to base stat.In the example below,
schedule()left the cpu0 idle 98.19% of the time. 16.54% of totaltry_to_wake_up()was to wakeup local cpu. And, the total waittime by tasks on cpu0 is 0.49% of the total runtime by tasks on the same cpu.----------------------------------------------------------------------------------------------------
cpu: cpu0
----------------------------------------------------------------------------------------------------sched_yield() count : 0 Legacy counter can be ignored : 0 schedule() called : 17138 schedule() left the processor idle : 16827 ( 98.19% ) try_to_wake_up() was called : 508 try_to_wake_up() was called to wake up the local cpu : 84 ( 16.54% ) total runtime by tasks on this processor (in jiffies) : 2408959243 total waittime by tasks on this processor (in jiffies) : 11731825 ( 0.49% ) total timeslices run on this cpu : 311----------------------------------------------------------------------------------------------------
Next is load balancing statistics. For each of the sched domains (eg:
SMT,MC,DIE...), the scheduler computes statistics under the following three categories:1) Idle Load Balance: Load balancing performed on behalf of a long idling cpu by some other cpu.
2) Busy Load Balance: Load balancing performed when the cpu was busy.
3) New Idle Balance : Load balancing performed when a cpu just became idle.Under each of these three categories, schedstat report provides different load balancing statistics. Along with direct stats, the report also contains derived metrics prefixed with *. Example:
----------------------------------------------------------------------------------------------------
CPU 0 DOMAIN 0
----------------------------------------------------------------------------------------------------
------------------------------------------<Category idle>-------------------------------------------load_balance() count on cpu idle : 50 $ 490.74 $ load_balance() found balanced on cpu idle : 42 $ 584.21 $ load_balance() move task failed on cpu idle : 8 $ 3067.12 $ imbalance sum on cpu idle : 8 pull_task() count on cpu idle : 0 pull_task() when target task was cache-hot on cpu idle : 0 load_balance() failed to find busier queue on cpu idle : 0 $ 0.00 $ load_balance() failed to find busier group on cpu idle : 42 $ 584.21 $ *load_balance() success count on cpu idle : 0 *avg task pulled per successful lb attempt (cpu idle) : 0.00 ------------------------------------------<Category busy>------------------------------------------- load_balance() count on cpu busy : 2 $ 12268.50 $ load_balance() found balanced on cpu busy : 2 $ 12268.50 $ load_balance() move task failed on cpu busy : 0 $ 0.00 $ imbalance sum on cpu busy : 0 pull_task() count on cpu busy : 0 pull_task() when target task was cache-hot on cpu busy : 0 load_balance() failed to find busier queue on cpu busy : 0 $ 0.00 $ load_balance() failed to find busier group on cpu busy : 1 $ 24537.00 $ *load_balance() success count on cpu busy : 0 *avg task pulled per successful lb attempt (cpu busy) : 0.00 -----------------------------------------<Category newidle>----------------------------------------- load_balance() count on cpu newly idle : 427 $ 57.46 $ load_balance() found balanced on cpu newly idle : 382 $ 64.23 $ load_balance() move task failed on cpu newly idle : 45 $ 545.27 $ imbalance sum on cpu newly idle : 48 pull_task() count on cpu newly idle : 0 pull_task() when target task was cache-hot on cpu newly idle : 0 load_balance() failed to find busier queue on cpu newly idle : 0 $ 0.00 $ load_balance() failed to find busier group on cpu newly idle : 382 $ 64.23 $ *load_balance() success count on cpu newly idle : 0 *avg task pulled per successful lb attempt (cpu newly idle) : 0.00----------------------------------------------------------------------------------------------------
Consider following line:
load_balance()found balanced on cpu newly idle : 382 $ 64.23 $While profiling was active, the load-balancer found 382 times the load needs to be balanced on a newly idle CPU 0. Following value encapsulated inside $ is average jiffies between two events (24537 / 382 = 64.23).
Next is
active_load_balance()stats. alb did not trigger while I ran a workload so it's all 0s.----------------------------------<Category active_load_balance()>----------------------------------
active_load_balance() count : 0 active_load_balance() move task failed : 0 active_load_balance() successfully moved a task : 0----------------------------------------------------------------------------------------------------
Next are
sched_balance_exec()andsched_balance_fork()stats. They are not used but we kept it in RFC just for legacy purpose. Unless opposed, we plan to remove them in next revision.Next is wakeup statistics. For every domain, the report also shows task-wakeup statistics. Example:
--------------------------------------------<Wakeup Info>-------------------------------------------
try_to_wake_up() awoke a task that last ran on a diff cpu : 12070 try_to_wake_up() moved task because cache-cold on own cpu : 3324 try_to_wake_up() started passive balancing : 0----------------------------------------------------------------------------------------------------
Same set of stats are reported for each cpu and each domain level.
TODO:
- This RFC series supports v15 layout of/proc/schedstatbut v16 layout is already being pushed upstream. We are planning to include v16 as well in the next revision.
- Currently schedstat tool provides statistics of only one run but we are planning to addperf sched schedstat diffwhich can compare the data of two different runs (possibly good and bad) and highlight where scheduler decisions are impacting workload performance.
- perf sched schedstat records/proc/schedstatwhich is a cpu and domain level scheduler statistic. We are planning to add taskstat tool which
Quoted 8 lines
reads task stats from procfs and generate scheduler statistic report at task granularity. this will probably a standalone tool, something like
perf sched taskstat record/report.
-/proc/schedstatshows cpumask in domain line to indicate a group of cpus that belong to the domain. Since we are not using domain<->cpumask data anywhere, we are not capturing it as part of perf sample. But we are planning to include it in the next revision.
- We have tested the patch only on AMD machines, not on other platforms.
This is great! Is it possible to add some basic shell script testing:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/tests/shell?h=perf-tools-next
for the sake of coverage, other platform testing, etc. ?
Thanks,
Ian
Quoted 46 lines
- Some of the perf related features can be added to the schedstat sub- command as well: for ex, pipemode, -p <pid> option to profile running process etc. We are not planning to add TUI support however.
- Code changes are for RFC and thus not optimal. Some of the places where code changes are not required for RFC are marked as /* FIXME */.
- Documenting details about schedstat tool in perf-sched man page will also be done in next revision.
- Checkpatch warnings are ignored for now.Patches are prepared on perf-tools-next/perf-tools-next (
37862d6fdced). Although all changes are intools/perf/, kernel is important since it's using v15 of/proc/schedstat.[1] https://youtu.be/lg-9aG2ajA0?t=283
[2] https://github.com/AMDESE/sched-scoreboard
[3] https://lore.kernel.org/lkml/[email protected]/
[4] https://lore.kernel.org/lkml/[email protected]/Ravi Bangoria (2):
perf sched: Makestruct perf_sched scheda global variable perf sched: Add template code for schedstat subcommandSwapnil Sapkal (2):
perf sched schedstat: Add record and rawdump support perf sched schedstat: Add support for report subcommandtools/lib/perf/Documentation/libperf.txt | 2 + tools/lib/perf/Makefile | 2 +- tools/lib/perf/include/perf/event.h | 37 ++ .../lib/perf/include/perf/schedstat-cpu-v15.h | 22 + .../perf/include/perf/schedstat-domain-v15.h | 121 ++++ tools/perf/builtin-inject.c | 2 + tools/perf/builtin-sched.c | 558 ++++++++++++++++-- tools/perf/util/event.c | 54 ++ tools/perf/util/event.h | 2 + tools/perf/util/session.c | 44 ++ tools/perf/util/synthetic-events.c | 170 ++++++ tools/perf/util/synthetic-events.h | 4 + tools/perf/util/tool.h | 4 +- 13 files changed, 965 insertions(+), 57 deletions(-) create mode 100644 tools/lib/perf/include/perf/schedstat-cpu-v15.h create mode 100644 tools/lib/perf/include/perf/schedstat-domain-v15.h--
2.44.0
Quoted 19 lines
Quoted 10 lines
TODO:
- This RFC series supports v15 layout of/proc/schedstatbut v16 layout is already being pushed upstream. We are planning to include v16 as well in the next revision.
- Currently schedstat tool provides statistics of only one run but we are planning to addperf sched schedstat diffwhich can compare the data of two different runs (possibly good and bad) and highlight where scheduler decisions are impacting workload performance.
- perf sched schedstat records/proc/schedstatwhich is a cpu and domain level scheduler statistic. We are planning to add taskstat tool whichQuoted 8 lines
reads task stats from procfs and generate scheduler statistic report at task granularity. this will probably a standalone tool, something like
perf sched taskstat record/report.
-/proc/schedstatshows cpumask in domain line to indicate a group of cpus that belong to the domain. Since we are not using domain<->cpumask data anywhere, we are not capturing it as part of perf sample. But we are planning to include it in the next revision.
- We have tested the patch only on AMD machines, not on other platforms.
Quoted 3 lines
This is great! Is it possible to add some basic shell script testing:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/tests/shell?h=perf-tools-next
for the sake of coverage, other platform testing, etc. ?
Sure, I will think about adding some simple tests.
Thanks,
Ravi
Namhyung Kim
maintainerHi Ravi,
Quoted 11 lines · Ravi Bangoria
MOTIVATION
----------Existing
perf schedis quite exhaustive and provides lot of insights into scheduler behavior but it quickly becomes impractical to use for long running or scheduler intensive workload. For ex,perf sched recordhas ~7.77% overhead on hackbench (with 25 groups each running 700K loops on a 2-socket 128 Cores 256 Threads 3rd Generation EPYC Server), and it generates huge 56G perf.data for which perf takes ~137 mins to prepare and write it to disk [1].
Right, this is painful.
Quoted 9 lines
Unlike
perf sched record, which hooks onto set of scheduler tracepoints and generates samples on a tracepoint hit,perf sched schedstat recordtakes snapshot of the/proc/schedstatfile before and after the workload, i.e. there is zero interference on workload run. Also, it takes very minimal time to parse/proc/schedstat, convert it into perf samples and save those samples into perf.data file. Result perf.data file is much smaller. So, overallperf sched schedstat recordis much more light- weight compare toperf sched record.
Nice work!
Quoted 8 lines
We, internally at AMD, have been using this (a variant of this, known as "sched-scoreboard"[2]) and found it to be very useful to analyse impact of any scheduler code changes[3][4].
Please note that, this is not a replacement of perf sched record/report. The intended users of the new tool are scheduler developers, not regular users.
Great, I think it's very useful.
Quoted 6 lines
USAGE
-----# perf sched schedstat record # perf sched schedstat report
Hmm. I think we can remove the duplication in 'sched'. :) Given you are thinking of taskstat, how about making it 'cpustat' instead?
Also I think it'd be easier if you also provide 'live' mode so that users can skip record + report steps and run the workload directly like uftrace does. :)
Something like this
# perf sched cpustat myworkload (result here ...)
Thanks,
Namhyung
Quoted 4 lines
Note: Although perf schedstat tool supports workload profiling syntax (i.e. -- <workload> ), the recorded profile is still systemwide since the
/proc/schedstatis a systemwide file.
Quoted 7 lines
Quoted 5 lines
USAGE
-----# perf sched schedstat record # perf sched schedstat reportHmm. I think we can remove the duplication in 'sched'. :)
You mean perf sched stat record/report ?
Quoted 2 lines
Given you are thinking of taskstat, how about making it 'cpustat' instead?
Sure. How about:
# perf sched stat --cpu --task record # perf sched stat report
Quoted 8 lines
Also I think it'd be easier if you also provide 'live' mode so that users can skip record + report steps and run the workload directly like uftrace does. :)
Something like this
# perf sched cpustat myworkload (result here ...)
Sure.
Thanks for the feedback,
Ravi
Namhyung Kim
maintainerQuoted 9 lines · Ravi Bangoria
Quoted 8 lines
Quoted 6 lines
USAGE
-----# perf sched schedstat record # perf sched schedstat reportHmm. I think we can remove the duplication in 'sched'. :)
Quoted 8 lines
You mean
perf sched stat record/report?Quoted 2 lines
Given you are thinking of taskstat, how about making it 'cpustat' instead?
Sure. How about:
# perf sched stat --cpu --task record
If you plan to support both cpu and task at the same time, then I'm ok with this. But if they're mutually exclusive, then probably you want to have them as sub-commands.
Thanks,
Namhyung
Quoted 15 lines
# perf sched stat reportQuoted 8 lines
Also I think it'd be easier if you also provide 'live' mode so that users can skip record + report steps and run the workload directly like uftrace does. :)
Something like this
# perf sched cpustat myworkload (result here ...)Sure.
Thanks for the feedback,
Ravi
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines
Quoted 5 lines
USAGE
-----# perf sched schedstat record # perf sched schedstat reportHmm. I think we can remove the duplication in 'sched'. :)
You mean
perf sched stat record/report?Quoted 2 lines
Given you are thinking of taskstat, how about making it 'cpustat' instead?
Quoted 7 lines
Quoted 3 lines
Sure. How about:
# perf sched stat --cpu --task recordIf you plan to support both cpu and task at the same time, then I'm ok with this. But if they're mutually exclusive, then probably you want to have them as sub-commands.
Sure, will think about it while preparing next version.
Thanks,
Ravi