mm/rmap: Move anon_vma initialization to anon_vma_ctor()
Subsystems (2)
PATCH 1/1 mm/rmap: Move anon_vma initialization to anon_vma_ctor()
From: Ye Liu <[email protected]>
Currently, some initialization of anon_vma is performed in anon_vma_alloc(). Move the initialization to anon_vma_ctor() so that all object setup is handled in one place.
--- mm/rmap.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-)
mm/rmap.c +10 -17
@@ -89,22 +89,7 @@ static struct kmem_cache *anon_vma_chain_cachep;static inline struct anon_vma *anon_vma_alloc (void ) { -struct anon_vma *anon_vma; - - anon_vma =kmem_cache_alloc (anon_vma_cachep,GFP_KERNEL ); -if (anon_vma) { -atomic_set (&anon_vma->refcount,1 ); - anon_vma->num_children =0 ; - anon_vma->num_active_vmas =0 ; - anon_vma->parent = anon_vma; -/* -* Initialise the anon_vma root to point to itself. If called -* from fork, the root will be reset to the parents anon_vma. -*/ - anon_vma->root = anon_vma; - } - -return anon_vma; +return kmem_cache_alloc (anon_vma_cachep,GFP_KERNEL ); }static inline void anon_vma_free (struct anon_vma *anon_vma)
@@ -453,8 +438,16 @@ static void anon_vma_ctor(void *data)struct anon_vma *anon_vma = data;init_rwsem (&anon_vma->rwsem); -atomic_set (&anon_vma->refcount,0 ); +atomic_set (&anon_vma->refcount,1 ); anon_vma->rb_root =RB_ROOT_CACHED ; + anon_vma->num_children =0 ; + anon_vma->num_active_vmas =0 ; + anon_vma->parent = anon_vma; +/* +* Initialise the anon_vma root to point to itself. If called +* from fork, the root will be reset to the parents anon_vma. +*/ + anon_vma->root = anon_vma; }void __init anon_vma_init (void )
Signature · 1 line
2.25.1
Quoted 8 lines · Ye Liu
From: Ye Liu <[email protected]>
Currently, some initialization of
anon_vmais performed inanon_vma_alloc(). Move the initialization toanon_vma_ctor()so that all object setup is handled in one place.Signed-off-by Ye Liu <[email protected]>---
NACK unless the patch explains how the object's initial state ('constructed state') is preserved between uses.
anon_vma_ctor() is a slab constructor. That means it is called only once when a slab (folio) is allocated, and not called again when an anon_vma is allocated from an existing slab (folio). In other words it is not called everytime an object allocated via kmem_cache_alloc() interface.
This patch looks very dangerous to me and makes me question whether you tested it before submission.
Signature · 2 lines
Cheers, Harry / Hyeonggon
Quoted 53 lines
mm/rmap.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-)mm/rmap.c +10
-17@@ -89,22 +89,7 @@ static struct kmem_cache *anon_vma_chain_cachep;static inline struct anon_vma *anon_vma_alloc (void ) { -struct anon_vma *anon_vma; - - anon_vma =kmem_cache_alloc (anon_vma_cachep,GFP_KERNEL ); -if (anon_vma) { -atomic_set (&anon_vma->refcount,1 ); - anon_vma->num_children =0 ; - anon_vma->num_active_vmas =0 ; - anon_vma->parent = anon_vma; -/* -* Initialise the anon_vma root to point to itself. If called -* from fork, the root will be reset to the parents anon_vma. -*/ - anon_vma->root = anon_vma; - } - -return anon_vma; +return kmem_cache_alloc (anon_vma_cachep,GFP_KERNEL ); }static inline void anon_vma_free (struct anon_vma *anon_vma)@@ -453,8 +438,16 @@ static void anon_vma_ctor(void *data)struct anon_vma *anon_vma = data;init_rwsem (&anon_vma->rwsem); -atomic_set (&anon_vma->refcount,0 ); +atomic_set (&anon_vma->refcount,1 ); anon_vma->rb_root =RB_ROOT_CACHED ; + anon_vma->num_children =0 ; + anon_vma->num_active_vmas =0 ; + anon_vma->parent = anon_vma; +/* +* Initialise the anon_vma root to point to itself. If called +* from fork, the root will be reset to the parents anon_vma. +*/ + anon_vma->root = anon_vma; }void __init anon_vma_init (void )Signature · 1 line
2.25.1
Quoted 9 lines · Harry Yoo
Quoted 8 lines · Ye Liu
From: Ye Liu <[email protected]>
Currently, some initialization of
anon_vmais performed inanon_vma_alloc(). Move the initialization toanon_vma_ctor()so that all object setup is handled in one place.Signed-off-by Ye Liu <[email protected]>---
Quoted 7 lines
NACK unless the patch explains how the object's initial state ('constructed state') is preserved between uses.
anon_vma_ctor()is a slab constructor. That means it is called only once when a slab (folio) is allocated, and not called again when ananon_vmais allocated from an existing slab (folio). In other words it is not called everytime an object allocated viakmem_cache_alloc()interface.
Thank you for the feedback. You're absolutely right — I misunderstood how the slab constructor (ctor) works. I had assumed it would be called every time an object is allocated via kmem_cache_alloc(), but I now realize it is only called once when a new slab is initialized, not on every object allocation.
Quoted 3 lines
This patch looks very dangerous to me and makes me question whether you tested it before submission.
Appreciate you catching this — and yes, I'll test it more thoroughly before submitting other patches.
Drop it.
Thanks,
Ye
+cc David, Liam
Quoted 26 lines · Ye Liu
Quoted 9 lines · Harry Yoo
Quoted 8 lines · Ye Liu
From: Ye Liu <[email protected]>
Currently, some initialization of
anon_vmais performed inanon_vma_alloc(). Move the initialization toanon_vma_ctor()so that all object setup is handled in one place.Signed-off-by Ye Liu <[email protected]>---
Quoted 7 lines
NACK unless the patch explains how the object's initial state ('constructed state') is preserved between uses.
anon_vma_ctor()is a slab constructor. That means it is called only once when a slab (folio) is allocated, and not called again when ananon_vmais allocated from an existing slab (folio). In other words it is not called everytime an object allocated viakmem_cache_alloc()interface.Thank you for the feedback. You're absolutely right — I misunderstood how the slab constructor (ctor) works. I had assumed it would be called every time an object is allocated via
kmem_cache_alloc(), but I now realize it is only called once when a new slab is initialized, not on every object allocation.Quoted 3 lines
This patch looks very dangerous to me and makes me question whether you tested it before submission.
Quoted 8 lines
Appreciate you catching this — and yes, I'll test it more thoroughly before submitting other patches.
Drop it.
Thanks,
Ye
I agree with Harry's assessment, also this is something that needs to be cc'd to other developers - I am more generally working on anon_vma at the moment and this is vma-adjacent even if slab-ish :)
It isn't your fault that you didn't, we need a MAINTAINERS entry for this which I will submit, but for any future revision, please do cc Harry, David, Liam, Vlastimil + myself.
I should be sending a MAINTAINERS patch later today which should correct this going forward!
Cheers, Lorenzo
Quoted 34 lines · Lorenzo Stoakes
+cc David, Liam
Quoted 31 lines · Ye Liu
Quoted 9 lines · Harry Yoo
Quoted 8 lines · Ye Liu
From: Ye Liu <[email protected]>
Currently, some initialization of
anon_vmais performed inanon_vma_alloc(). Move the initialization toanon_vma_ctor()so that all object setup is handled in one place.Signed-off-by Ye Liu <[email protected]>---
Quoted 7 lines
NACK unless the patch explains how the object's initial state ('constructed state') is preserved between uses.
anon_vma_ctor()is a slab constructor. That means it is called only once when a slab (folio) is allocated, and not called again when ananon_vmais allocated from an existing slab (folio). In other words it is not called everytime an object allocated viakmem_cache_alloc()interface.Thank you for the feedback. You're absolutely right — I misunderstood how the slab constructor (ctor) works. I had assumed it would be called every time an object is allocated via
kmem_cache_alloc(), but I now realize it is only called once when a new slab is initialized, not on every object allocation.Quoted 3 lines
This patch looks very dangerous to me and makes me question whether you tested it before submission.
Appreciate you catching this — and yes, I'll test it more thoroughly before submitting other patches.
Drop it.
Quoted 7 lines
Quoted 3 lines
Thanks,
YeI agree with Harry's assessment, also this is something that needs to be cc'd to other developers - I am more generally working on
anon_vmaat the moment and this is vma-adjacent even if slab-ish :)
I stumbled over this patch on linux-mm and agreed with Harry's assessment as well. :)
Signature · 3 lines
Cheers, David / dhildenb
Quoted 47 lines · Ye Liu
From: Ye Liu <[email protected]>
Currently, some initialization of
anon_vmais performed inanon_vma_alloc(). Move the initialization toanon_vma_ctor()so that all object setup is handled in one place.Signed-off-by Ye Liu <[email protected]>--- mm/rmap.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-)mm/rmap.c +3
-17@@ -89,22 +89,7 @@ static struct kmem_cache *anon_vma_chain_cachep;static inline struct anon_vma *anon_vma_alloc (void ) { -struct anon_vma *anon_vma; - - anon_vma =kmem_cache_alloc (anon_vma_cachep,GFP_KERNEL ); -if (anon_vma) { -atomic_set (&anon_vma->refcount,1 ); - anon_vma->num_children =0 ; - anon_vma->num_active_vmas =0 ; - anon_vma->parent = anon_vma; -/* -* Initialise the anon_vma root to point to itself. If called -* from fork, the root will be reset to the parents anon_vma. -*/ - anon_vma->root = anon_vma; - } - -return anon_vma; +return kmem_cache_alloc (anon_vma_cachep,GFP_KERNEL ); }static inline void anon_vma_free (struct anon_vma *anon_vma)@@ -453,8 +438,16 @@ static void anon_vma_ctor(void *data)struct anon_vma *anon_vma = data;init_rwsem (&anon_vma->rwsem); -atomic_set (&anon_vma->refcount,0 ); +atomic_set (&anon_vma->refcount,1 ); anon_vma->rb_root =RB_ROOT_CACHED ; + anon_vma->num_children =0 ;
mm/rmap.c static void anon_vma_ctor(void *data) · line 453
Quoted 10 lines
mm/rmap.c +7
-0+ anon_vma->num_active_vmas =0 ; + anon_vma->parent = anon_vma; +/* +* Initialise the anon_vma root to point to itself. If called +* from fork, the root will be reset to the parents anon_vma. +*/ + anon_vma->root = anon_vma; }void __init anon_vma_init (void )
As was pointed out by Harry this changes behavior: by shifting to ctor you make it only happen once instead of every time anon_vma_alloc() is called. By extension this assumes ->refcount is 1 and so on. By any chance did you assume ctor executes every time kmem_cache_alloc() is called?
When making changes of the sort I find it beneficial to place debug-only asserts in place of moved code at least during development.
So in particular in this case I would add checks like these:
VM_BUG_ON(anon_vma->num_children != 0);
and so on.
Then on a kernel compiled with DEBUG_MM this would validate the expected value is in place and blow up early and loudly if not.