Skip to contentSkip to conversation

gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON

PATCH Superseded Anuj Mittal 2 participants 6 messages Feb 19, 2020

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON

Use the correct variable so options actually get used and use the correct qt option name to prevent errors.

---
 .../gstreamer/gstreamer1.0-plugins-good_1.16.1.bb             | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb +2 -2
index a6eb9986dd..07a0bf5085 100644
@@ -55,7 +55,7 @@ PACKAGECONFIG[x11]        = "${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}"
 # This is better done in a separate qt5 layer (which then should add a "qt5" packageconfig
 # in a gstreamer1.0-plugins-good bbappend).
 
-EXTRA_OECONF += " \
+EXTRA_OEMESON += " \
     -Daalib=disabled \
     -Ddirectsound=disabled \
     -Ddv=disabled \
@@ -64,7 +64,7 @@ EXTRA_OECONF += " \
     -Doss4=disabled \
     -Dosxaudio=disabled \
     -Dosxvideo=disabled \
-    -Dqt=disabled \
+    -Dqt5=disabled \
     -Dshout2=disabled \
     -Dtwolame=disabled \
     -Dwaveform=disabled \
Signature · 1 line
2.24.1
#1 lore raw
Quoted 23 lines · Anuj Mittal

Use the correct variable so options actually get used and use the correct qt option name to prevent errors.

---
 .../gstreamer/gstreamer1.0-plugins-good_1.16.1.bb             | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb +1 -1
index a6eb9986dd..07a0bf5085 100644
@@ -55,7 +55,7 @@ PACKAGECONFIG[x11]        = "${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}"
 # This is better done in a separate qt5 layer (which then should add a "qt5" packageconfig
 # in a gstreamer1.0-plugins-good bbappend).
 
-EXTRA_OECONF += " \
+EXTRA_OEMESON += " \
     -Daalib=disabled \
     -Ddirectsound=disabled \
     -Ddv=disabled \

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb EXTRA_OECONF += " \ · line 67

Quoted 5 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb +1 -1
@@ -64,7 +64,7 @@ EXTRA_OECONF += " \
     -Doss4=disabled \
     -Dosxaudio=disabled \
     -Dosxvideo=disabled \
-    -Dqt=disabled \
+    -Dqt5=disabled \

this perhaps should be a packageconfig so people using meta-qt5 can enable it

Quoted 11 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb +0 -1
     -Dshout2=disabled \
     -Dtwolame=disabled \
     -Dwaveform=disabled \
--

2.24.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw
Quoted 25 lines · Khem Raj
Quoted 23 lines · Anuj Mittal

Use the correct variable so options actually get used and use the correct qt option name to prevent errors.

---
 .../gstreamer/gstreamer1.0-plugins-good_1.16.1.bb             | 4
++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

plugins-good_1.16.1.bb b/meta/recipes- multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb index a6eb9986dd..07a0bf5085 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- good_1.16.1.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- good_1.16.1.bb

(quoted diff) +0 -0
@@ -55,7 +55,7 @@ PACKAGECONFIG[x11]        =

"${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}"
# This is better done in a separate qt5 layer (which then should
add a "qt5" packageconfig

 # in a gstreamer1.0-plugins-good bbappend).
Quoted 14 lines

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb EXTRA_OECONF += " \ · line 67

Quoted 11 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb +2 -2
-EXTRA_OECONF += " \
+EXTRA_OEMESON += " \
     -Daalib=disabled \
     -Ddirectsound=disabled \
     -Ddv=disabled \
@@ -64,7 +64,7 @@ EXTRA_OECONF += " \
     -Doss4=disabled \
     -Dosxaudio=disabled \
     -Dosxvideo=disabled \
-    -Dqt=disabled \
+    -Dqt5=disabled \

this perhaps should be a packageconfig so people using meta-qt5 can enable it

Yes probably but in a separate change I think. This just ensures that the right options are used and nothing else is changed.

Thanks,

Anuj

Quoted 12 lines
Quoted 12 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb +0 -1
     -Dshout2=disabled \
     -Dtwolame=disabled \
     -Dwaveform=disabled \
--

2.24.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
Quoted 39 lines · Anuj
Quoted 25 lines · Khem Raj
Quoted 23 lines · Anuj Mittal

Use the correct variable so options actually get used and use the correct qt option name to prevent errors.

---
  .../gstreamer/gstreamer1.0-plugins-good_1.16.1.bb             | 4
++--
  1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

plugins-good_1.16.1.bb b/meta/recipes- multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb index a6eb9986dd..07a0bf5085 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- good_1.16.1.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- good_1.16.1.bb

(quoted diff) +0 -0
@@ -55,7 +55,7 @@ PACKAGECONFIG[x11]        =

"${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}"
# This is better done in a separate qt5 layer (which then should
add a "qt5" packageconfig

  # in a gstreamer1.0-plugins-good bbappend).
Quoted 13 lines

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb EXTRA_OECONF += " \ · line 67

Quoted 11 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb +2 -2
-EXTRA_OECONF += " \
+EXTRA_OEMESON += " \
      -Daalib=disabled \
      -Ddirectsound=disabled \
      -Ddv=disabled \
@@ -64,7 +64,7 @@ EXTRA_OECONF += " \
      -Doss4=disabled \
      -Dosxaudio=disabled \
      -Dosxvideo=disabled \
-    -Dqt=disabled \
+    -Dqt5=disabled \

this perhaps should be a packageconfig so people using meta-qt5 can enable it

Quoted 2 lines

Yes probably but in a separate change I think. This just ensures that the right options are used and nothing else is changed.

perhaps no, since it will regress meta-qt5 which already does something like this

https://github.com/meta-qt5/meta-qt5/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_%25.bbappend

this being wrong in OE-core was ok for meta-qt5.

Quoted 16 lines

Thanks,

Anuj

Quoted 11 lines
Quoted 11 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb +0 -1
      -Dshout2=disabled \
      -Dtwolame=disabled \
      -Dwaveform=disabled \
--

2.24.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw
Quoted 49 lines · Khem Raj
Quoted 44 lines · Anuj
Quoted 29 lines · Khem Raj
Quoted 26 lines · Anuj Mittal

Use the correct variable so options actually get used and use the
correct qt option name to prevent errors.

---
.../gstreamer/gstreamer1.0-plugins-
good_1.16.1.bb | 4
++--

  1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

plugins-good_1.16.1.bb b/meta/recipes- multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb index a6eb9986dd..07a0bf5085 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- good_1.16.1.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- good_1.16.1.bb

(quoted diff) +0 -0
@@ -55,7 +55,7 @@ PACKAGECONFIG[x11]        =

"${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}"
# This is better done in a separate qt5 layer (which then
should
add a "qt5" packageconfig

  # in a gstreamer1.0-plugins-good bbappend).
Quoted 14 lines

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb EXTRA_OECONF += " \ · line 67

Quoted 11 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb +2 -2
-EXTRA_OECONF += " \
+EXTRA_OEMESON += " \
      -Daalib=disabled \
      -Ddirectsound=disabled \
      -Ddv=disabled \
@@ -64,7 +64,7 @@ EXTRA_OECONF += " \
      -Doss4=disabled \
      -Dosxaudio=disabled \
      -Dosxvideo=disabled \
-    -Dqt=disabled \
+    -Dqt5=disabled \

this perhaps should be a packageconfig so people using meta-qt5 can
enable it

Quoted 3 lines

Yes probably but in a separate change I think. This just ensures that
the right options are used and nothing else is changed.

Quoted 8 lines

perhaps no, since it will regress meta-qt5 which already does something
like this

https://github.com/meta-qt5/meta-qt5/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_%25.bbappend

this being wrong in OE-core was ok for meta-qt5.

Okay, should that PACKAGECONFIG be added here? I don't use or test qt so can't test the change.

Thanks,

Anuj

#5 lore raw
Quoted 54 lines · Anuj
Quoted 53 lines · Khem Raj
Quoted 44 lines · Anuj
Quoted 29 lines · Khem Raj
Quoted 26 lines · Anuj Mittal

Use the correct variable so options actually get used and use the
correct qt option name to prevent errors.

---
.../gstreamer/gstreamer1.0-plugins-
good_1.16.1.bb | 4
++--

   1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

plugins-good_1.16.1.bb b/meta/recipes- multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb index a6eb9986dd..07a0bf5085 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- good_1.16.1.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- good_1.16.1.bb

(quoted diff) +0 -0
@@ -55,7 +55,7 @@ PACKAGECONFIG[x11]        =

"${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}"
# This is better done in a separate qt5 layer (which then
should
add a "qt5" packageconfig

   # in a gstreamer1.0-plugins-good bbappend).
Quoted 14 lines

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb EXTRA_OECONF += " \ · line 67

Quoted 11 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb +2 -2
-EXTRA_OECONF += " \
+EXTRA_OEMESON += " \
       -Daalib=disabled \
       -Ddirectsound=disabled \
       -Ddv=disabled \
@@ -64,7 +64,7 @@ EXTRA_OECONF += " \
       -Doss4=disabled \
       -Dosxaudio=disabled \
       -Dosxvideo=disabled \
-    -Dqt=disabled \
+    -Dqt5=disabled \

this perhaps should be a packageconfig so people using meta-qt5 can
enable it

Quoted 3 lines

Yes probably but in a separate change I think. This just ensures that
the right options are used and nothing else is changed.

perhaps no, since it will regress meta-qt5 which already does something
like this

Quoted 7 lines
Quoted 4 lines

https://github.com/meta-qt5/meta-qt5/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_%25.bbappend

this being wrong in OE-core was ok for meta-qt5.

Okay, should that PACKAGECONFIG be added here? I don't use or test qt so can't test the change.

thats fine, add it as a PACKAGECONFIG as done in bbappend and then we can eventually stop defining it from meta-qt5

Quoted 5 lines

Thanks,

Anuj