net/failsafe: don't double space warning
PATCH 1/1 net/failsafe: don't double space warning
Already get a newline from WARN() macro call.
Fixes 9dda3e3393c2 ("net/failsafe: add timestamp to stats snapshot")
Signed-off-by Stephen Hemminger <[email protected]>
--- drivers/net/failsafe/failsafe_ether.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/failsafe/failsafe_ether.c +2 -2
@@ -322,10 +322,10 @@ fs_dev_stats_save(struct sub_device *sdev)if (err) {uint64_t timestamp = sdev->stats_snapshot.timestamp; -WARN ("Could not access latest statistics from sub-device %d.\n" , +WARN ("Could not access latest statistics from sub-device %d." ,SUB_ID (sdev));if (timestamp !=0 ) -WARN ("Using latest snapshot taken before %" PRIu64" seconds.\n" , +WARN ("Using latest snapshot taken before %" PRIu64" seconds." , (rte_rdtsc () - timestamp) /rte_get_tsc_hz ()); } failsafe_stats_increment
Signature · 1 line
2.27.0
Quoted 5 lines · Stephen Hemminger
Already get a newline from
WARN()macro call.Fixes 9dda3e3393c2 ("net/failsafe: add timestamp to stats snapshot")Signed-off-by Stephen Hemminger <[email protected]>
Acked-by Gaetan Rivet <[email protected]>
Quoted 25 lines
--- drivers/net/failsafe/failsafe_ether.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/failsafe/failsafe_ether.c +2
-2@@ -322,10 +322,10 @@ fs_dev_stats_save(struct sub_device *sdev)if (err) {uint64_t timestamp = sdev->stats_snapshot.timestamp; -WARN ("Could not access latest statistics from sub-device %d.\n" , +WARN ("Could not access latest statistics from sub-device %d." ,SUB_ID (sdev));if (timestamp !=0 ) -WARN ("Using latest snapshot taken before %" PRIu64" seconds.\n" , +WARN ("Using latest snapshot taken before %" PRIu64" seconds." , (rte_rdtsc () - timestamp) /rte_get_tsc_hz ()); } failsafe_stats_incrementSignature · 1 line
2.27.0
Signature · 1 line
Gaëtan
Quoted 9 lines · Gaëtan Rivet
Quoted 5 lines · Stephen Hemminger
Already get a newline from
WARN()macro call.Fixes 9dda3e3393c2 ("net/failsafe: add timestamp to stats snapshot")Signed-off-by Stephen Hemminger <[email protected]>Acked-by Gaetan Rivet <[email protected]>
Ah, I forgot: the patch itself is fine, but it should be backported probably. Missing Cc: stable, Fixes, and the title should be reworded "fix double space warning" I think.
Quoted 28 lines
Quoted 25 lines
--- drivers/net/failsafe/failsafe_ether.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/failsafe/failsafe_ether.c +2
-2@@ -322,10 +322,10 @@ fs_dev_stats_save(struct sub_device *sdev)if (err) {uint64_t timestamp = sdev->stats_snapshot.timestamp; -WARN ("Could not access latest statistics from sub-device %d.\n" , +WARN ("Could not access latest statistics from sub-device %d." ,SUB_ID (sdev));if (timestamp !=0 ) -WARN ("Using latest snapshot taken before %" PRIu64" seconds.\n" , +WARN ("Using latest snapshot taken before %" PRIu64" seconds." , (rte_rdtsc () - timestamp) /rte_get_tsc_hz ()); } failsafe_stats_incrementSignature · 1 line
2.27.0Signature · 1 line
Gaëtan
Signature · 1 line
Gaëtan
Ferruh Yigit
AppliedQuoted 8 lines · Gaëtan Rivet
Quoted 7 lines · Gaëtan Rivet
Quoted 5 lines · Stephen Hemminger
Already get a newline from
WARN()macro call.Fixes 9dda3e3393c2 ("net/failsafe: add timestamp to stats snapshot")Signed-off-by Stephen Hemminger <[email protected]>
Quoted 7 lines
Quoted 2 lines
Acked-by Gaetan Rivet <[email protected]>Ah, I forgot: the patch itself is fine, but it should be backported probably. Missing Cc: stable, Fixes, and the title should be reworded "fix double space warning" I think.
Applied to dpdk-next-net/main, thanks.
(stable tag added, title updated as suggested)