Skip to contentSkip to conversation

Please pull u-boot-i2c master

DISCUSSION Heiko Schocher 4 participants 6 messages Jul 17, 2025 – Jul 22, 2025

lore
Share & tools
lore
#0 lore raw

Hello Tom,

The following changes since commit 53bd87651e45b32efa398dd5e433d8b93d781445:

block: sandbox: Add support for SYS_64BIT_LBA (2025-07-11 11:33:25 -0600)

are available in the Git repository at:

https://source.denx.de/u-boot/custodians/u-boot-i2c.git i2c-for-2025.10

for you to fetch changes up to 5e80c6757378d09950235083533e7a7c3aeae3be:

configs: agilex5_defconfig: Enable i3c configs for agilex5 (2025-07-16 09:33:54 +0200)

----------------------------------------------------------------
i2c updates for v2025.10

- i2c Kconfig updates from Tom
- add some driver dependencies
- added missing include delay.h in iproc_i2c.c

- i2c: muxes: Add PCA9541 i2c arbitrator driver
from Padmarao Begari

- pca954x: add pca9545 support
from Frank Wunderlich

- cmd: i2c: fix build when CFG_SYS_I2C_NOPROBES defined with DM_I2C From Holger Brunck

- added i3c support to U-Boot and enable it for agilex5 board from Dinesh Maniyam

----------------------------------------------------------------
Dinesh Maniyam (12):
drivers: i3c: Add new i3c uclass id
drivers: i3c: Add driver for MIPI DWI3C
drivers: i3c: Add i3c uclass driver.
drivers: Enabled Kconfig and Makefile for i3c support
drivers: i3c: Enabled Kconfig and Makefile for DWI3C
drivers: i3c: Add i3c sandbox simple test.
drivers: i3c: master: Enable probe i3c without slave device
i3c: master: dw-i3c-master: Fix OD_TIMING for spike filter
cmd: Add i3c command support.
test: cmd: Add simple test for i3c
configs: sandbox_defconfig: Enable configs for sandbox i3c
configs: agilex5_defconfig: Enable i3c configs for agilex5

Frank Wunderlich (1):

      i2c: muxes: pca954x: add pca9545 support

Holger Brunck (1):
cmd: i2c: fix build when CFG_SYS_I2C_NOPROBES defined with DM_I2C

Padmarao Begari (1):
i2c: muxes: Add PCA9541 i2c arbitrator driver

Tom Rini (2):
i2c: Add missing <linux/delay.h> to iproc_i2c.c
i2c: Kconfig: Tighten some i2c driver dependencies

 MAINTAINERS                        |    7 +
 arch/sandbox/dts/test.dts          |    8 +
 cmd/Kconfig                        |    6 +
 cmd/Makefile                       |    1 +
 cmd/i2c.c                          |    6 +-
 cmd/i3c.c                          |  271 +++++++++++++++++++
 configs/sandbox_defconfig          |    4 +
 configs/socfpga_agilex5_defconfig  |    3 +
 doc/api/i3c.rst                    |    8 +
 doc/api/index.rst                  |    1 +
 doc/usage/cmd/i3c.rst              |  146 +++++++++++
 doc/usage/index.rst                |    1 +
 drivers/Kconfig                    |    2 +
 drivers/Makefile                   |    1 +
 drivers/i2c/Kconfig                |   11 +-
 drivers/i2c/iproc_i2c.c            |    1 +
 drivers/i2c/muxes/Kconfig          |    7 +
 drivers/i2c/muxes/Makefile         |    1 +
 drivers/i2c/muxes/pca9541.c        |  297 +++++++++++++++++++++
 drivers/i2c/muxes/pca954x.c        |    6 +
 drivers/i3c/Kconfig                |   27 ++
 drivers/i3c/Makefile               |    5 +
 drivers/i3c/device.c               |  262 +++++++++++++++++++
 drivers/i3c/i3c-uclass.c           |   38 +++
 drivers/i3c/internals.h            |   26 ++
 drivers/i3c/master.c               | 2070 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/i3c/master/Kconfig         |   11 +
 drivers/i3c/master/Makefile        |    3 +
 drivers/i3c/master/dw-i3c-master.c | 1062 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/i3c/sandbox_i3c.c          |   56 ++++
 include/dm/device.h                |    2 +
 include/dm/uclass-id.h             |    1 +
 include/dw-i3c.h                   |  252 ++++++++++++++++++
 include/i3c.h                      |   93 +++++++
 include/linux/i3c/ccc.h            |  385 +++++++++++++++++++++++++++
 include/linux/i3c/device.h         |  286 +++++++++++++++++++++
 include/linux/i3c/master.h         |  698 +++++++++++++++++++++++++++++++++++++++++++++++++
 test/cmd/Makefile                  |    1 +
 test/cmd/i3c.c                     |   50 ++++
 test/dm/Makefile                   |    1 +
 test/dm/i3c.c                      |   34 +++
 41 files changed, 6145 insertions(+), 6 deletions(-)
 create mode 100644 cmd/i3c.c
 create mode 100644 doc/api/i3c.rst
 create mode 100644 doc/usage/cmd/i3c.rst
 create mode 100644 drivers/i2c/muxes/pca9541.c
 create mode 100644 drivers/i3c/Kconfig
 create mode 100644 drivers/i3c/Makefile
 create mode 100644 drivers/i3c/device.c
 create mode 100644 drivers/i3c/i3c-uclass.c
 create mode 100644 drivers/i3c/internals.h
 create mode 100644 drivers/i3c/master.c
 create mode 100644 drivers/i3c/master/Kconfig
 create mode 100644 drivers/i3c/master/Makefile
 create mode 100644 drivers/i3c/master/dw-i3c-master.c
 create mode 100644 drivers/i3c/sandbox_i3c.c
 create mode 100644 include/dw-i3c.h
 create mode 100644 include/i3c.h
 create mode 100644 include/linux/i3c/ccc.h
 create mode 100644 include/linux/i3c/device.h
 create mode 100644 include/linux/i3c/master.h
 create mode 100644 test/cmd/i3c.c
 create mode 100644 test/dm/i3c.c

Thanks!

Azure build shows an error:

https://dev.azure.com/hs0298/hs/_build/results?buildId=180&view=results

https://dev.azure.com/hs0298/hs/_build/results?buildId=180&view=logs&j=6be877ff-932d-5d95-9b1f-9903312b5111&t=a6f13977-3537-5140-4cdf-3c258dd9359a&l=346

! _pytest.outcomes.Exit: Lab timeout: Marking connection bad - no other tests will run !

So, I think, it is not a problem with pull request...

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Johanna Denk, Tabea Lutz
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]
#1 lore raw
Quoted 24 lines · Heiko Schocher

Hello Tom,

The following changes since commit 53bd87651e45b32efa398dd5e433d8b93d781445:

block: sandbox: Add support for SYS_64BIT_LBA (2025-07-11 11:33:25 -0600)

are available in the Git repository at:

https://source.denx.de/u-boot/custodians/u-boot-i2c.git i2c-for-2025.10

for you to fetch changes up to 5e80c6757378d09950235083533e7a7c3aeae3be:

configs: agilex5_defconfig: Enable i3c configs for agilex5 (2025-07-16 09:33:54 +0200)

----------------------------------------------------------------
i2c updates for v2025.10

- i2c Kconfig updates from Tom
- add some driver dependencies
- added missing include delay.h in iproc_i2c.c

- i2c: muxes: Add PCA9541 i2c arbitrator driver
from Padmarao Begari

Quoted 8 lines

- pca954x: add pca9545 support
from Frank Wunderlich

- cmd: i2c: fix build when CFG_SYS_I2C_NOPROBES defined with DM_I2C From Holger Brunck

- added i3c support to U-Boot and enable it for agilex5 board from Dinesh Maniyam

Unfortunately the i3c support leads to this in coreboot:
https://source.denx.de/u-boot/u-boot/-/jobs/1202949/raw

Which looks like coreboot just gets stuck in a loop? And in turn, that lead me to do this locally:
commit 03e9d5f4c61cba5d8e1db81d759fefd622b3ad49

Author: Tom Rini <[email protected]>
Date:   Thu Jul 17 15:22:08 2025 -0600

hack drop generic changes

include/dm/device.h +0 -2
index c5cfa18d09d6..678cd83c2716 100644
@@ -169,7 +169,6 @@ enum {
  * @dma_offset: Offset between the physical address space (CPU's) and the
  *		device's bus address space
  * @iommu: IOMMU device associated with this device
- * @of_node: Associated device tree node
  */
 struct udevice {
 	const struct driver *driver;
@@ -202,7 +201,6 @@ struct udevice {
 #if CONFIG_IS_ENABLED(IOMMU)
 	struct udevice *iommu;
 #endif
-	struct device_node	*of_node;
 };
 
 static inline int dm_udevice_size(void)

Which leads me (a) being concerned about what our coreboot support is up to and (b) why i3c needs this generic change? And I don't just want to see CONFIG_IS_ENABLED()'ing it, why do we have to handle the device tree that way and is there no standard mechanism we can use?

Signature · 1 line
Tom
#2 lore raw

Hello Tom,

Quoted 61 lines · Tom Rini
Quoted 24 lines · Heiko Schocher

Hello Tom,

The following changes since commit 53bd87651e45b32efa398dd5e433d8b93d781445:

   block: sandbox: Add support for SYS_64BIT_LBA (2025-07-11 11:33:25 -0600)

are available in the Git repository at:

   https://source.denx.de/u-boot/custodians/u-boot-i2c.git i2c-for-2025.10

for you to fetch changes up to 5e80c6757378d09950235083533e7a7c3aeae3be:

   configs: agilex5_defconfig: Enable i3c configs for agilex5 (2025-07-16 09:33:54 +0200)

----------------------------------------------------------------
i2c updates for v2025.10

- i2c Kconfig updates from Tom
- add some driver dependencies
- added missing include delay.h in iproc_i2c.c

- i2c: muxes: Add PCA9541 i2c arbitrator driver
from Padmarao Begari

Quoted 8 lines

- pca954x: add pca9545 support
from Frank Wunderlich

- cmd: i2c: fix build when CFG_SYS_I2C_NOPROBES defined with DM_I2C From Holger Brunck

- added i3c support to U-Boot and enable it for agilex5 board from Dinesh Maniyam

Unfortunately the i3c support leads to this in coreboot:
https://source.denx.de/u-boot/u-boot/-/jobs/1202949/raw

Which looks like coreboot just gets stuck in a loop? And in turn, that lead me to do this locally:
commit 03e9d5f4c61cba5d8e1db81d759fefd622b3ad49

Author: Tom Rini <[email protected]>
Date:   Thu Jul 17 15:22:08 2025 -0600

hack drop generic changes

include/dm/device.h +0 -1
index c5cfa18d09d6..678cd83c2716 100644
@@ -169,7 +169,6 @@ enum {
   * @dma_offset: Offset between the physical address space (CPU's) and the
   *		device's bus address space
   * @iommu: IOMMU device associated with this device
- * @of_node: Associated device tree node
   */
  struct udevice {
  	const struct driver *driver;

include/dm/device.h struct udevice { · line 206

Quoted 7 lines
include/dm/device.h +0 -1
@@ -202,7 +201,6 @@ struct udevice {
  #if CONFIG_IS_ENABLED(IOMMU)
  	struct udevice *iommu;
  #endif
-	struct device_node	*of_node;
  };
 
  static inline int dm_udevice_size(void)

Uff.. yep, overseen this change...

Quoted 5 lines

Which leads me (a) being concerned about what our coreboot support is up to and (b) why i3c needs this generic change? And I don't just want to see CONFIG_IS_ENABLED()'ing it, why do we have to handle the device tree that way and is there no standard mechanism we can use?

@dinesh: why do you need this?

It should be possible in the master driver to get the of pointer with

ofnode node = dev_ofnode(dev);

and if you really need it in drivers/i3c/master.c pass it to the functions you call... ah, no, as you already save the udevice in i3c_master_controller, you can simply use

dev_ofnode(dev)

in it!

You can simply drop of_node from generic file, and use dev_ofnode(dev) in your driver/i3c code ... may you save the udevice in private data or in your i3c_dev_boardinfo struct instead if really needed, so please rework that part.

@Tom: I will drop i3c support from my pull request and send a new one

And yes, the question a) remains ...

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Johanna Denk, Tabea Lutz
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]
#3 lore raw
Quoted 120 lines

-----Original Message-----
From: Heiko Schocher <[email protected]>
Sent: Saturday, 19 July 2025 12:21 pm
To: Tom Rini <[email protected]>
Cc: [email protected]; Frank Wunderlich <[email protected]>; Padmarao Begari <[email protected]>; Maniyam, Dinesh <[email protected]>; Holger Brunck <holger.brunck@hitachi- powergrids.com>
Subject: Re: Please pull u-boot-i2c master

[CAUTION: This email is from outside your organization. Unless you trust the sender, do not click on links or open attachments as it may be a fraudulent email attempting to steal your information and/or compromise your computer.]

Hello Tom,

Quoted 5 lines · Tom Rini
Quoted 3 lines · Heiko Schocher

Hello Tom,

The following changes since commit

53bd87651e45b32efa398dd5e433d8b93d781445:

Quoted 10 lines
Quoted 10 lines

block: sandbox: Add support for SYS_64BIT_LBA (2025-07-11 11:33:25
-0600)

are available in the Git repository at:

https://source.denx.de/u-boot/custodians/u-boot-i2c.git
i2c-for-2025.10

for you to fetch changes up to

5e80c6757378d09950235083533e7a7c3aeae3be:

Quoted 49 lines
Quoted 14 lines

configs: agilex5_defconfig: Enable i3c configs for agilex5
(2025-07-16 09:33:54 +0200)

----------------------------------------------------------------
i2c updates for v2025.10

- i2c Kconfig updates from Tom
- add some driver dependencies
- added missing include delay.h in iproc_i2c.c

- i2c: muxes: Add PCA9541 i2c arbitrator driver
from Padmarao Begari

Quoted 8 lines

- pca954x: add pca9545 support
from Frank Wunderlich

- cmd: i2c: fix build when CFG_SYS_I2C_NOPROBES defined with DM_I2C From Holger Brunck

- added i3c support to U-Boot and enable it for agilex5 board from Dinesh Maniyam

Unfortunately the i3c support leads to this in coreboot:
https://source.denx.de/u-boot/u-boot/-/jobs/1202949/raw

Which looks like coreboot just gets stuck in a loop? And in turn, that lead me to do this locally:
commit 03e9d5f4c61cba5d8e1db81d759fefd622b3ad49

Author: Tom Rini <[email protected]>
Date:   Thu Jul 17 15:22:08 2025 -0600

hack drop generic changes

include/dm/device.h index renamed from include/dm/device.h +0 -0

c5cfa18d09d6..678cd83c2716 100644

include/dm/device.h +0 -1
@@ -169,7 +169,6 @@ enum {
   * @dma_offset: Offset between the physical address space (CPU's) and the
   *          device's bus address space
   * @iommu: IOMMU device associated with this device
- * @of_node: Associated device tree node
   */
  struct udevice {
      const struct driver *driver;

include/dm/device.h struct udevice { · line 206

Quoted 7 lines
include/dm/device.h +0 -1
@@ -202,7 +201,6 @@ struct udevice {
  #if CONFIG_IS_ENABLED(IOMMU)
      struct udevice *iommu;
  #endif
-     struct device_node      *of_node;
  };
 
  static inline int dm_udevice_size(void)

Uff.. yep, overseen this change...

Quoted 5 lines

Which leads me (a) being concerned about what our coreboot support is up to and (b) why i3c needs this generic change? And I don't just want to see CONFIG_IS_ENABLED()'ing it, why do we have to handle the device tree that way and is there no standard mechanism we can use?

@dinesh: why do you need this?

It should be possible in the master driver to get the of pointer with

ofnode node = dev_ofnode(dev);

and if you really need it in drivers/i3c/master.c pass it to the functions you call... ah, no, as you already save the udevice in i3c_master_controller, you can simply use

dev_ofnode(dev)

in it!

You can simply drop of_node from generic file, and use dev_ofnode(dev) in your driver/i3c code ... may you save the udevice in private data or in your i3c_dev_boardinfo struct instead if really needed, so please rework that part.

Quoted 8 lines

@Tom: I will drop i3c support from my pull request and send a new one

And yes, the question a) remains ...

Thanks!

bye,
Heiko

Yes agreed! I can use dev_ofnode(dev) and will quickly rework on this part.

Thanks
Dinesh

Quoted 4 lines

--
DENX Software Engineering GmbH, Managing Director: Johanna Denk, Tabea Lutz HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]

#4 lore raw

Hi,

Quoted 138 lines

-----Original Message-----
From: Maniyam, Dinesh
Sent: Saturday, 19 July 2025 1:02 pm
To: [email protected]; Tom Rini <[email protected]>
Cc: [email protected]; Frank Wunderlich <[email protected]>; Padmarao Begari <[email protected]>; Holger Brunck <holger.brunck@hitachi- powergrids.com>
Subject: RE: Please pull u-boot-i2c master

Quoted 112 lines

-----Original Message-----
From: Heiko Schocher <[email protected]>
Sent: Saturday, 19 July 2025 12:21 pm
To: Tom Rini <[email protected]>
Cc: [email protected]; Frank Wunderlich <[email protected]>; Padmarao Begari <[email protected]>; Maniyam, Dinesh <[email protected]>; Holger Brunck <holger.brunck@hitachi- powergrids.com>
Subject: Re: Please pull u-boot-i2c master

[CAUTION: This email is from outside your organization. Unless you trust the sender, do not click on links or open attachments as it may be a fraudulent email attempting to steal your information and/or compromise your computer.]

Hello Tom,

Quoted 5 lines · Tom Rini
Quoted 3 lines · Heiko Schocher

Hello Tom,

The following changes since commit

53bd87651e45b32efa398dd5e433d8b93d781445:

Quoted 11 lines
Quoted 11 lines

block: sandbox: Add support for SYS_64BIT_LBA (2025-07-11
11:33:25
-0600)

are available in the Git repository at:

https://source.denx.de/u-boot/custodians/u-boot-i2c.git
i2c-for-2025.10

for you to fetch changes up to

5e80c6757378d09950235083533e7a7c3aeae3be:

Quoted 49 lines
Quoted 14 lines

configs: agilex5_defconfig: Enable i3c configs for agilex5
(2025-07-16 09:33:54 +0200)

----------------------------------------------------------------
i2c updates for v2025.10

- i2c Kconfig updates from Tom
- add some driver dependencies
- added missing include delay.h in iproc_i2c.c

- i2c: muxes: Add PCA9541 i2c arbitrator driver
from Padmarao Begari

Quoted 8 lines

- pca954x: add pca9545 support
from Frank Wunderlich

- cmd: i2c: fix build when CFG_SYS_I2C_NOPROBES defined with DM_I2C From Holger Brunck

- added i3c support to U-Boot and enable it for agilex5 board from Dinesh Maniyam

Unfortunately the i3c support leads to this in coreboot:
https://source.denx.de/u-boot/u-boot/-/jobs/1202949/raw

Which looks like coreboot just gets stuck in a loop? And in turn, that lead me to do this locally:
commit 03e9d5f4c61cba5d8e1db81d759fefd622b3ad49

Author: Tom Rini <[email protected]>
Date:   Thu Jul 17 15:22:08 2025 -0600

hack drop generic changes

include/dm/device.h index renamed from include/dm/device.h +0 -0

c5cfa18d09d6..678cd83c2716 100644

include/dm/device.h +0 -1
@@ -169,7 +169,6 @@ enum {
   * @dma_offset: Offset between the physical address space (CPU's) and the
   *          device's bus address space
   * @iommu: IOMMU device associated with this device
- * @of_node: Associated device tree node
   */
  struct udevice {
      const struct driver *driver;

include/dm/device.h struct udevice { · line 206

Quoted 7 lines
include/dm/device.h +0 -1
@@ -202,7 +201,6 @@ struct udevice {
  #if CONFIG_IS_ENABLED(IOMMU)
      struct udevice *iommu;
  #endif
-     struct device_node      *of_node;
  };
 
  static inline int dm_udevice_size(void)

Uff.. yep, overseen this change...

Quoted 5 lines

Which leads me (a) being concerned about what our coreboot support is up to and (b) why i3c needs this generic change? And I don't just want to see CONFIG_IS_ENABLED()'ing it, why do we have to handle the device tree that way and is there no standard mechanism we can use?

@dinesh: why do you need this?

It should be possible in the master driver to get the of pointer with

ofnode node = dev_ofnode(dev);

and if you really need it in drivers/i3c/master.c pass it to the functions you call... ah, no, as you already save the udevice in i3c_master_controller, you can simply use

Quoted 7 lines

dev_ofnode(dev)

in it!

You can simply drop of_node from generic file, and use dev_ofnode(dev) in your driver/i3c code ... may you save the udevice in private data or in your i3c_dev_boardinfo struct instead if really needed, so please rework

that part.

Quoted 7 lines

@Tom: I will drop i3c support from my pull request and send a new one

And yes, the question a) remains ...

Thanks!

Quoted 8 lines
Quoted 2 lines

bye,
Heiko

Yes agreed! I can use dev_ofnode(dev) and will quickly rework on this part.

Thanks
Dinesh

I have done the rework, tried to run the CI in github before submitting to denx.
https://github.com/u-boot/u-boot/pull/802

However,

Facing some failure due to :
Cloning into '/tmp/uboot-test-hooks'...
fatal: unable to access 'https://source.denx.de/u-boot/u-boot-test-hooks/': The requested URL returned error: 502

seems like denx upstream server issue!

Regards,
Dinesh

Quoted 4 lines
Quoted 4 lines

--
DENX Software Engineering GmbH, Managing Director: Johanna Denk, Tabea Lutz HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]

#5 lore raw

Am 22. Juli 2025 07:10:00 MESZ schrieb "Maniyam, Dinesh" <[email protected]>:
...

Quoted 11 lines

I have done the rework, tried to run the CI in github before submitting to denx.
https://github.com/u-boot/u-boot/pull/802

However,

Facing some failure due to :
Cloning into '/tmp/uboot-test-hooks'...
fatal: unable to access 'https://source.denx.de/u-boot/u-boot-test-hooks/': The requested URL returned error: 502

seems like denx upstream server issue!

Yes see here: <https://lists.denx.de/pipermail/u-boot/2025-July/594708.html>

Quoted 2 lines

Regards,
Dinesh

regards Frank