Skip to contentSkip to conversation

ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi

PATCH New Sylwester Nawrocki 2 participants 2 messages Jan 15, 2015 – Feb 3, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi

Assign proper FIMC-IS UART gate clock in the device DT node and not use the SRC_MASK gate. This fixes regression introduced in commit a37c82a3b3c0910019abfd22a97be1f ("clk: samsung: exynos4: Remove SRC_MASK_ISP gates").

Without this change exynos4 fimc-is driver fails to probe with an error log:

[    1.842447] ERROR: could not get clock /camera/fimc-is at 12000000:uart(13)
[    1.848529] exynos4-fimc-is 12000000.fimc-is: failed to get clock: uart
[    1.855275] exynos4-fimc-is: probe of 12000000.fimc-is failed with error -2

---

Kukjin, could you take this patch into your tree ? I have been applying it for several kernel releases now to get the Exynos4 FIMC driver even passing probing.

Thanks,
Sylwester

 arch/arm/boot/dts/exynos4x12.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4x12.dtsi +1 -1
index 93b7040..86e1800 100644
@@ -225,7 +225,7 @@
 				 <&clock CLK_DIV_ISP0>,<&clock CLK_DIV_ISP1>,
 				 <&clock CLK_DIV_MCUISP0>,
 				 <&clock CLK_DIV_MCUISP1>,
-				 <&clock CLK_SCLK_UART_ISP>,
+				 <&clock CLK_UART_ISP_SCLK>,
 				 <&clock CLK_ACLK200>, <&clock CLK_DIV_ACLK200>,
 				 <&clock CLK_ACLK400_MCUISP>,
 				 <&clock CLK_DIV_ACLK400_MCUISP>;

--
1.7.9.5

Applied
#1 lore raw

PATCH 1/1 ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi

Quoted 30 lines · Sylwester Nawrocki

Assign proper FIMC-IS UART gate clock in the device DT node and not use the SRC_MASK gate. This fixes regression introduced in commit a37c82a3b3c0910019abfd22a97be1f ("clk: samsung: exynos4: Remove SRC_MASK_ISP gates").

Without this change exynos4 fimc-is driver fails to probe with an error log:

[    1.842447] ERROR: could not get clock /camera/fimc-is at 12000000:uart(13)
[    1.848529] exynos4-fimc-is 12000000.fimc-is: failed to get clock: uart
[    1.855275] exynos4-fimc-is: probe of 12000000.fimc-is failed with error -2

---

Kukjin, could you take this patch into your tree ? I have been applying it for several kernel releases now to get the Exynos4 FIMC driver even passing probing.

Thanks,
Sylwester

 arch/arm/boot/dts/exynos4x12.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4x12.dtsi +0 -0
index 93b7040..86e1800 100644

arch/arm/boot/dts/exynos4x12.dtsi

Quoted 9 lines
arch/arm/boot/dts/exynos4x12.dtsi +1 -2
@@ -225,7 +225,7 @@
 				 <&clock CLK_DIV_ISP0>,<&clock CLK_DIV_ISP1>,
 				 <&clock CLK_DIV_MCUISP0>,
 				 <&clock CLK_DIV_MCUISP1>,
-				 <&clock CLK_SCLK_UART_ISP>,
+				 <&clock CLK_UART_ISP_SCLK>,
 				 <&clock CLK_ACLK200>, <&clock CLK_DIV_ACLK200>,
 				 <&clock CLK_ACLK400_MCUISP>,
 				 <&clock CLK_DIV_ACLK400_MCUISP>;
--

Applied, thanks.

- Kukjin