Skip to contentSkip to conversation

ipv6: anycast: use call_rcu_hurry() in aca_put()

PATCH Applied Eric Dumazet 3 participants 3 messages Apr 29, 2024 – May 1, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipv6: anycast: use call_rcu_hurry() in aca_put()

This is a followup of commit b5327b9a300e ("ipv6: use call_rcu_hurry() in fib6_info_release()").

I had another pmtu.sh failure, and found another lazy call_rcu() causing this failure.

aca_free_rcu() calls fib6_info_release() which releases devices references.

We must not delay it too much or risk unregister_netdevice/ref_tracker traces because references to netdev are not released in time.

This should speedup device/netns dismantles when CONFIG_RCU_LAZY=y

---
 net/ipv6/anycast.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
net/ipv6/anycast.c +2 -3
index 0f2506e3535925468dcc5fa6cc30ae0952a67ea7..0627c4c18d1a5067a668da778ad444855194cbeb 100644
@@ -252,9 +252,8 @@ static void aca_free_rcu(struct rcu_head *h)
 
 static void aca_put(struct ifacaddr6 *ac)
 {
-	if (refcount_dec_and_test(&ac->aca_refcnt)) {
-		call_rcu(&ac->rcu, aca_free_rcu);
-	}
+	if (refcount_dec_and_test(&ac->aca_refcnt))
+		call_rcu_hurry(&ac->rcu, aca_free_rcu);
 }
 
 static struct ifacaddr6 *aca_alloc(struct fib6_info *f6i,
Signature · 1 line
2.44.0.769.g3c40516874-goog
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Eric Dumazet

This is a followup of commit b5327b9a300e ("ipv6: use call_rcu_hurry() in fib6_info_release()").

I had another pmtu.sh failure, and found another lazy call_rcu() causing this failure.

aca_free_rcu() calls fib6_info_release() which releases devices references.

We must not delay it too much or risk unregister_netdevice/ref_tracker traces because references to netdev are not released in time.

Quoted 7 lines

This should speedup device/netns dismantles when CONFIG_RCU_LAZY=y

---
 net/ipv6/anycast.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
#2 lore raw
In reply to Eric Dumazet
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Quoted 10 lines · On Mon, 29 Apr 2024 18:36:43 +0000 you wrote:

This is a followup of commit b5327b9a300e ("ipv6: use call_rcu_hurry() in fib6_info_release()").

I had another pmtu.sh failure, and found another lazy call_rcu() causing this failure.

aca_free_rcu() calls fib6_info_release() which releases devices references.

[...]

Here is the summary with links:
- [net-next] ipv6: anycast: use call_rcu_hurry() in aca_put()
https://git.kernel.org/netdev/net-next/c/fff6e6accdb7

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html