nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS
Subsystems (2)
Jeff Layton
maintainerPATCH 1/1 nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS
The client doesn't properly request FATTR4_OPEN_ARGUMENTS in the initial SERVER_CAPS getattr. Add FATTR4_WORD2_OPEN_ARGUMENTS to the initial request.
--- fs/nfs/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/nfs4proc.c +1 -1
@@ -3931,7 +3931,7 @@ static int _nfs4_server_capabilities(struct nfs_server *server, struct nfs_fh *fFATTR4_WORD0_CASE_INSENSITIVE |FATTR4_WORD0_CASE_PRESERVING ;if (minorversion) - bitmask[2 ] =FATTR4_WORD2_SUPPATTR_EXCLCREAT ; + bitmask[2 ] =FATTR4_WORD2_SUPPATTR_EXCLCREAT |FATTR4_WORD2_OPEN_ARGUMENTS ; status =nfs4_call_sync (server->client, server, &msg, &args.seq_args, &res.seq_res,0 );if (status ==0 ) {
Signature · 1 line
2.46.0
Jeff Layton
maintainerQuoted 15 lines · Jeff Layton
The client doesn't properly request
FATTR4_OPEN_ARGUMENTSin the initialSERVER_CAPSgetattr. AddFATTR4_WORD2_OPEN_ARGUMENTSto the initial request.Fixes 707f13b3d081 (NFSv4: Add support for the FATTR4_OPEN_ARGUMENTS attribute)Signed-off-by Jeff Layton <[email protected]>--- fs/nfs/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/nfs/nfs4proc.c +0
-0
fs/nfs/nfs4proc.c static int _nfs4_server_capabilities(struct nfs_server *server, struct nfs_fh *f · line 3937
Quoted 8 lines
fs/nfs/nfs4proc.c +1
-1@@ -3931,7 +3931,7 @@ static int _nfs4_server_capabilities(struct nfs_server *server, struct nfs_fh *fFATTR4_WORD0_CASE_INSENSITIVE |FATTR4_WORD0_CASE_PRESERVING ;if (minorversion) - bitmask[2 ] =FATTR4_WORD2_SUPPATTR_EXCLCREAT ; + bitmask[2 ] =FATTR4_WORD2_SUPPATTR_EXCLCREAT |FATTR4_WORD2_OPEN_ARGUMENTS ; status =nfs4_call_sync (server->client, server, &msg, &args.seq_args, &res.seq_res,0 );if (status ==0 ) {
Ping? It would be nice to have this fixed before v6.11 ships.
Signature · 1 line
Jeff Layton <[email protected]>
Anna Schumaker
maintainerQuoted 23 lines · Jeff Layton
Quoted 21 lines · Jeff Layton
The client doesn't properly request
FATTR4_OPEN_ARGUMENTSin the initialSERVER_CAPSgetattr. AddFATTR4_WORD2_OPEN_ARGUMENTSto the initial request.Fixes 707f13b3d081 (NFSv4: Add support for the FATTR4_OPEN_ARGUMENTS attribute)Signed-off-by Jeff Layton <[email protected]>--- fs/nfs/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/nfs/nfs4proc.c +1
-1@@ -3931,7 +3931,7 @@ static int _nfs4_server_capabilities(struct nfs_server *server, struct nfs_fh *fFATTR4_WORD0_CASE_INSENSITIVE |FATTR4_WORD0_CASE_PRESERVING ;if (minorversion) - bitmask[2 ] =FATTR4_WORD2_SUPPATTR_EXCLCREAT ; + bitmask[2 ] =FATTR4_WORD2_SUPPATTR_EXCLCREAT |FATTR4_WORD2_OPEN_ARGUMENTS ;
Quoted 4 lines
fs/nfs/nfs4proc.c static int _nfs4_server_capabilities(struct nfs_server *server, struct nfs_fh *f · line 3937
Quoted 2 lines
fs/nfs/nfs4proc.c +0
-0status =nfs4_call_sync (server->client, server, &msg, &args.seq_args, &res.seq_res,0 );if (status ==0 ) {Ping? It would be nice to have this fixed before v6.11 ships.
This and your other patch both look good to me. I'll try to get out a bugfixes pull request by the end of the week!
Anna
Quoted 2 lines
--
Jeff Layton <[email protected]>
Quoted 6 lines · Jeff Layton
The client doesn't properly request
FATTR4_OPEN_ARGUMENTSin the initialSERVER_CAPSgetattr. AddFATTR4_WORD2_OPEN_ARGUMENTSto the initial request.Fixes 707f13b3d081 (NFSv4: Add support for the FATTR4_OPEN_ARGUMENTS attribute)Signed-off-by Jeff Layton <[email protected]>
Clearly correct, save for slight style mismatch.
Ben
Jeff Layton
maintainerQuoted 11 lines · Benjamin Coddington
Quoted 8 lines · Jeff Layton
The client doesn't properly request
FATTR4_OPEN_ARGUMENTSin the initialSERVER_CAPSgetattr. AddFATTR4_WORD2_OPEN_ARGUMENTSto the initial request.Fixes 707f13b3d081 (NFSv4: Add support for the
FATTR4_OPEN_ARGUMENTSattribute)Signed-off-by Jeff Layton <[email protected]>
Quoted 6 lines
Clearly correct, save for slight style mismatch.
Reviewed-by Benjamin Coddington <[email protected]>Ben
Thanks. I noticed that after sending it. No objection if you want to fix that up before merging.
Signature · 1 line
Jeff Layton <[email protected]>
Quoted 15 lines · Jeff Layton
Quoted 14 lines · Benjamin Coddington
Quoted 9 lines · Jeff Layton
The client doesn't properly request
FATTR4_OPEN_ARGUMENTSin the initialSERVER_CAPSgetattr. AddFATTR4_WORD2_OPEN_ARGUMENTSto the initial
request.Fixes 707f13b3d081 (NFSv4: Add support for the
FATTR4_OPEN_ARGUMENTSattribute)Signed-off-by Jeff Layton <[email protected]>Clearly correct, save for slight style mismatch.
Quoted 7 lines
Quoted 4 lines
Reviewed-by Benjamin Coddington <[email protected]>Ben
Thanks. I noticed that after sending it. No objection if you want to fix that up before merging.
Ack to this too.
Signature · 3 lines
Trond Myklebust Linux NFS client maintainer, Hammerspace [email protected]