configure options & install targets
Noticed a few questionable things the wrapper makefiles do (in this example package/bison/bison.mk) and wonder:
,----
| --- package/bison/bison.mk (revision 19307) | +++ package/bison/bison.mk (working copy) |
The canonical place for man, info and doc is under /usr/share, isn't it?
| --sysconfdir=/etc \ | --datadir=/usr/share \ | --localstatedir=/var \ | - --mandir=/usr/man \ | - --infodir=/usr/info \ | + --mandir=/usr/share/man \ | + --infodir=/usr/share/info \
Stuff is removed using a machete instead of knife :( See example below. Is that the intended behavior?
| $(TARGET_DIR)/$(BISON_TARGET_BINARY): $(BISON_DIR)/$(BISON_BINARY) | $(MAKE) DESTDIR=$(TARGET_DIR) CC=$(TARGET_CC) -C $(BISON_DIR) install | - rm -rf $(TARGET_DIR)/share/locale $(TARGET_DIR)/usr/info \ | - $(TARGET_DIR)/usr/man $(TARGET_DIR)/usr/share/doc | + rm -f $(TARGET_DIR)/share/locale/*/LC_MESSAGES/bison* | + rm -f $(TARGET_DIR)/usr/info/bison* | + rm -f $(TARGET_DIR)/usr/share/man/man?/bison* | + rm -rf $(TARGET_DIR)/usr/share/bison* | + rm -rf $(TARGET_DIR)/usr/share/doc/bison*
`----
Cheers,
Signature · 8 lines
Cristian -------------- next part -------------- A non-text attachment was scrubbed... Name: bison.mk.patch Type: text/x-diff Size: 1576 bytes Desc: Url : http://busybox.net/lists/buildroot/attachments/20070812/4cbcd867/attachment.bin
Quoted 9 lines · Cristian Ionescu-Idbohrn
Noticed a few questionable things the wrapper makefiles do (in this example
package/bison/bison.mk) and wonder:,----
| --- package/bison/bison.mk (revision 19307) | +++ package/bison/bison.mk (working copy) |The canonical place for man, info and doc is under
/usr/share, isn't it?
That would be right, but read below
Quoted 11 lines
| --sysconfdir=/etc \ | --datadir=/usr/share \ | --localstatedir=/var \ | - --mandir=/usr/man \ | - --infodir=/usr/info \ | + --mandir=/usr/share/man \ | + --infodir=/usr/share/info \Stuff is removed using a machete instead of knife :( See example below. Is that the intended behavior?
The advantage of the machete is that really all installed man and info-pages get destroyed. Since there is no support for any of the tools up to now, you don't get stuff you can't used.
Quoted 10 lines
| $(TARGET_DIR)/$(BISON_TARGET_BINARY): $(BISON_DIR)/$(BISON_BINARY) | $(MAKE) DESTDIR=$(TARGET_DIR) CC=$(TARGET_CC) -C $(BISON_DIR) install | - rm -rf $(TARGET_DIR)/share/locale $(TARGET_DIR)/usr/info \ | - $(TARGET_DIR)/usr/man $(TARGET_DIR)/usr/share/doc | + rm -f $(TARGET_DIR)/share/locale/*/LC_MESSAGES/bison* | + rm -f $(TARGET_DIR)/usr/info/bison* | + rm -f $(TARGET_DIR)/usr/share/man/man?/bison* | + rm -rf $(TARGET_DIR)/usr/share/bison* | + rm -rf $(TARGET_DIR)/usr/share/doc/bison*
Quoted 3 lines
`----
regards,
Benjamin
Quoted 52 lines
Cheers,
Signature · 3 lines
Cristian Index: package/bison/bison.mk ===================================================================bison/bison.mk +10
-7@@ -19,7 +19,7 @@ $(BISON_DIR)/.unpacked: $(DL_DIR)/$(BISON_SOURCE) $(BISON_CAT) $(DL_DIR)/$(BISON_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) - $(CONFIG_UPDATE) $(BISON_DIR)/build-aux - touch $(BISON_DIR)/.unpacked + touch $@ $(BISON_DIR)/.configured: $(BISON_DIR)/.unpacked (cd $(BISON_DIR); rm -rf config.cache; \@@ -39,20 +39,23 @@ --sysconfdir=/etc \ --datadir=/usr/share \ --localstatedir=/var \ - --mandir=/usr/man \ - --infodir=/usr/info \ + --mandir=/usr/share/man \ + --infodir=/usr/share/info \ $(DISABLE_NLS) \ - ); + ) echo 'all install:' > $(BISON_DIR)/examples/Makefile - touch $(BISON_DIR)/.configured + touch $@ $(BISON_DIR)/$(BISON_BINARY): $(BISON_DIR)/.configured $(MAKE) CC=$(TARGET_CC) -C $(BISON_DIR) $(TARGET_DIR)/$(BISON_TARGET_BINARY): $(BISON_DIR)/$(BISON_BINARY) $(MAKE) DESTDIR=$(TARGET_DIR) CC=$(TARGET_CC) -C $(BISON_DIR) install - rm -rf $(TARGET_DIR)/share/locale $(TARGET_DIR)/usr/info \ - $(TARGET_DIR)/usr/man $(TARGET_DIR)/usr/share/doc + rm -f $(TARGET_DIR)/share/locale/*/LC_MESSAGES/bison* + rm -f $(TARGET_DIR)/usr/info/bison* + rm -f $(TARGET_DIR)/usr/share/man/man?/bison* + rm -rf $(TARGET_DIR)/usr/share/bison* + rm -rf $(TARGET_DIR)/usr/share/doc/bison* cp -a package/bison/yacc $(TARGET_DIR)/usr/bin/yacc bison: uclibc $(TARGET_DIR)/$(BISON_TARGET_BINARY)_______________________________________________
buildroot mailing list
buildroot at uclibc.org
http://busybox.net/mailman/listinfo/buildroot