clk: imx8mp: Fix 32k clock name
Subsystems (3)
PATCH 1/1 clk: imx8mp: Fix 32k clock name
The 32 kHz oscillator clock name is 'clock-osc-32k' instead of 'osc_32k'. Fix the name to prevent the following warning:
"clk_register: failed to get osc_32k device (parent of usb_root_clk) "
--- drivers/clk/imx/clk-imx8mp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/imx/clk-imx8mp.c +1 -1
@@ -300,7 +300,7 @@ static int imx8mp_clk_probe(struct udevice *dev)clk_dm (IMX8MP_CLK_UART2_ROOT ,imx_clk_gate4 ("uart2_root_clk" ,"uart2" , base +0x44a0 ,0 ));clk_dm (IMX8MP_CLK_UART3_ROOT ,imx_clk_gate4 ("uart3_root_clk" ,"uart3" , base +0x44b0 ,0 ));clk_dm (IMX8MP_CLK_UART4_ROOT ,imx_clk_gate4 ("uart4_root_clk" ,"uart4" , base +0x44c0 ,0 )); -clk_dm (IMX8MP_CLK_USB_ROOT ,imx_clk_gate4 ("usb_root_clk" ,"osc_32k" , base +0x44d0 ,0 )); +clk_dm (IMX8MP_CLK_USB_ROOT ,imx_clk_gate4 ("usb_root_clk" ,"clock-osc-32k" , base +0x44d0 ,0 ));clk_dm (IMX8MP_CLK_USB_PHY_ROOT ,imx_clk_gate4 ("usb_phy_root_clk" ,"usb_phy_ref" , base +0x44f0 ,0 ));clk_dm (IMX8MP_CLK_USDHC1_ROOT ,imx_clk_gate4 ("usdhc1_root_clk" ,"usdhc1" , base +0x4510 ,0 ));clk_dm (IMX8MP_CLK_USDHC2_ROOT ,imx_clk_gate4 ("usdhc2_root_clk" ,"usdhc2" , base +0x4520 ,0 ));
Signature · 1 line
2.35.1
Hello Marek,
Quoted 15 lines
-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Marek Vasut
Sent: Monday, June 13, 2022 3:22 PM
To: [email protected]
Cc: Marek Vasut <[email protected]>; Fabio Estevam <[email protected]>; Peng Fan <[email protected]>; Stefano Babic <[email protected]>
Subject: [PATCH] clk: imx8mp: Fix 32k clock nameThe 32 kHz oscillator clock name is 'clock-osc-32k' instead of '
osc_32k'. Fix the name to prevent the following warning:"
clk_register: failed to getosc_32kdevice (parent ofusb_root_clk) "
Quoted 5 lines
Fixes 7a2c3be95a5 ("clk: imx8mp: Fill in DWC3 USB, USB PHY, HSIOMIX clock")Signed-off-by Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>Cc Peng Fan <[email protected]>Cc Stefano Babic <[email protected]>
I've already submitted a series to address this issue and the one for ECSPI clocks, see [1].
You're also on Cc: to that series, so you can take a look at it and decide whether it is suitable or not.
Quoted 19 lines
--- drivers/clk/imx/clk-imx8mp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/imx/clk-imx8mp.c +2
-1@@ -300,7 +300,7 @@ static int imx8mp_clk_probe(struct udevice *dev)clk_dm (IMX8MP_CLK_UART2_ROOT ,imx_clk_gate4 ("uart2_root_clk" ,"uart2" , base +0x44a0 ,0 ));clk_dm (IMX8MP_CLK_UART3_ROOT ,imx_clk_gate4 ("uart3_root_clk" ,"uart3" , base +0x44b0 ,0 ));clk_dm (IMX8MP_CLK_UART4_ROOT ,imx_clk_gate4 ("uart4_root_clk" ,"uart4" , base +0x44c0 ,0 )); - clk_dm(IMX8MP_CLK_USB_ROOT, imx_clk_gate4("usb_root_clk", "osc_32k", base + 0x44d0, 0)); + clk_dm(IMX8MP_CLK_USB_ROOT, imx_clk_gate4("usb_root_clk", "clock-osc-32k",base +
0x44d0, 0));
Quoted 8 lines
clk_dm(IMX8MP_CLK_USB_PHY_ROOT, imx_clk_gate4("usb_phy_root_clk",
"usb_phy_ref", base +0x44f0, 0));
clk_dm(IMX8MP_CLK_USDHC1_ROOT, imx_clk_gate4("usdhc1_root_clk", "usdhc1",
base +0x4510, 0));
clk_dm(IMX8MP_CLK_USDHC2_ROOT, imx_clk_gate4("usdhc2_root_clk", "usdhc2",
base +0x4520, 0));
--
2.35.1
-- andrey
Quoted 23 lines · ZHIZHIKIN Andrey
Hello Marek,
Quoted 15 lines
-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Marek Vasut
Sent: Monday, June 13, 2022 3:22 PM
To: [email protected]
Cc: Marek Vasut <[email protected]>; Fabio Estevam <[email protected]>; Peng Fan <[email protected]>; Stefano Babic <[email protected]>
Subject: [PATCH] clk: imx8mp: Fix 32k clock nameThe 32 kHz oscillator clock name is 'clock-osc-32k' instead of '
osc_32k'. Fix the name to prevent the following warning:"
clk_register: failed to getosc_32kdevice (parent ofusb_root_clk) "Quoted 5 lines
Fixes 7a2c3be95a5 ("clk: imx8mp: Fill in DWC3 USB, USB PHY, HSIOMIX clock")Signed-off-by Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>Cc Peng Fan <[email protected]>Cc Stefano Babic <[email protected]>
Quoted 5 lines
I've already submitted a series to address this issue and the one for ECSPI clocks, see [1].
You're also on Cc: to that series, so you can take a look at it and decide whether it is suitable or not.
Even better, thanks.