Skip to contentSkip to conversation

netfs: Fix errors in cache.h The following checkpatch errors are removed: ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar"

PATCH In review [email protected] 2 participants 2 messages Jul 19, 2023 – Jul 20, 2023 1 message not in the archive Ceph client

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 netfs: Fix errors in cache.h The following checkpatch errors are removed: ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar"

---
 fs/ceph/cache.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
fs/ceph/cache.h +6 -6
index dc502daac49a..b9fb1d1b21a1 100644
@@ -14,11 +14,11 @@
 #ifdef CONFIG_CEPH_FSCACHE
 #include <linux/fscache.h>
 
-int ceph_fscache_register_fs(struct ceph_fs_client* fsc, struct fs_context *fc);
-void ceph_fscache_unregister_fs(struct ceph_fs_client* fsc);
+int ceph_fscache_register_fs(struct ceph_fs_client *fsc, struct fs_context *fc);
+void ceph_fscache_unregister_fs(struct ceph_fs_client *fsc);
 
 void ceph_fscache_register_inode_cookie(struct inode *inode);
-void ceph_fscache_unregister_inode_cookie(struct ceph_inode_info* ci);
+void ceph_fscache_unregister_inode_cookie(struct ceph_inode_info *ci);
 
 void ceph_fscache_use_cookie(struct inode *inode, bool will_modify);
 void ceph_fscache_unuse_cookie(struct inode *inode, bool update);
@@ -76,13 +76,13 @@ static inline void ceph_fscache_note_page_release(struct inode *inode)
     fscache_note_page_release(ceph_fscache_cookie(ci));
 }
 #else /* CONFIG_CEPH_FSCACHE */
-static inline int ceph_fscache_register_fs(struct ceph_fs_client* fsc,
+static inline int ceph_fscache_register_fs(struct ceph_fs_client *fsc,
                        struct fs_context *fc)
 {
     return 0;
 }
 
-static inline void ceph_fscache_unregister_fs(struct ceph_fs_client* fsc)
+static inline void ceph_fscache_unregister_fs(struct ceph_fs_client *fsc)
 {
 }
 
@@ -90,7 +90,7 @@ static inline void ceph_fscache_register_inode_cookie(struct inode *inode)
 {
 }
 
-static inline void ceph_fscache_unregister_inode_cookie(struct ceph_inode_info* ci)
+static inline void ceph_fscache_unregister_inode_cookie(struct ceph_inode_info *ci)
 {
 }
#2 lore raw

Hi ZhiHu

This looks good to me.

Could you restructure the patch title and commit comment ?

Thanks

- Xiubo

Quoted 57 lines · On 7/19/23 19:10, [email protected] wrote:

---
 fs/ceph/cache.h | 12 ++++++------

 1 file changed, 6 insertions(+), 6 deletions(-)
fs/ceph/cache.h +3 -3
index dc502daac49a..b9fb1d1b21a1 100644
@@ -14,11 +14,11 @@
  #ifdef CONFIG_CEPH_FSCACHE
  #include <linux/fscache.h>
 
-int ceph_fscache_register_fs(struct ceph_fs_client* fsc, struct 
 fs_context *fc);
-void ceph_fscache_unregister_fs(struct ceph_fs_client* fsc);
+int ceph_fscache_register_fs(struct ceph_fs_client *fsc, struct 
 fs_context *fc);
+void ceph_fscache_unregister_fs(struct ceph_fs_client *fsc);
 
  void ceph_fscache_register_inode_cookie(struct inode *inode);
-void ceph_fscache_unregister_inode_cookie(struct ceph_inode_info* ci);
+void ceph_fscache_unregister_inode_cookie(struct ceph_inode_info *ci);
 

 void ceph_fscache_use_cookie(struct inode *inode, bool will_modify); void ceph_fscache_unuse_cookie(struct inode *inode, bool update);

fs/ceph/cache.h +2 -2
@@ -76,13 +76,13 @@ static inline void 
 ceph_fscache_note_page_release(struct inode *inode)
      fscache_note_page_release(ceph_fscache_cookie(ci));
  }
  #else /* CONFIG_CEPH_FSCACHE */
-static inline int ceph_fscache_register_fs(struct ceph_fs_client* fsc,
+static inline int ceph_fscache_register_fs(struct ceph_fs_client *fsc,
                         struct fs_context *fc)
  {
      return 0;
  }
 
-static inline void ceph_fscache_unregister_fs(struct ceph_fs_client* 
 fsc)
+static inline void ceph_fscache_unregister_fs(struct ceph_fs_client 
 *fsc)

 {
 }

fs/ceph/cache.h +1 -1
@@ -90,7 +90,7 @@ static inline void 
 ceph_fscache_register_inode_cookie(struct inode *inode)
  {
  }
 
-static inline void ceph_fscache_unregister_inode_cookie(struct 
 ceph_inode_info* ci)
+static inline void ceph_fscache_unregister_inode_cookie(struct 
 ceph_inode_info *ci)

 {
 }