netfs: Fix errors in cache.h The following checkpatch errors are removed: ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar"
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 netfs: Fix errors in cache.h The following checkpatch errors are removed: ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar"
Signed-off-by ZhiHu <[email protected]>
--- fs/ceph/cache.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
fs/ceph/cache.h +6 -6
@@ -14,11 +14,11 @@#ifdef CONFIG_CEPH_FSCACHE #include <linux/fscache.h> -int ceph_fscache_register_fs (struct ceph_fs_client * fsc,struct fs_context *fc); -void ceph_fscache_unregister_fs (struct ceph_fs_client * fsc); +int ceph_fscache_register_fs (struct ceph_fs_client *fsc,struct fs_context *fc); +void ceph_fscache_unregister_fs (struct ceph_fs_client *fsc);void ceph_fscache_register_inode_cookie (struct inode *inode); -void ceph_fscache_unregister_inode_cookie (struct ceph_inode_info * ci); +void ceph_fscache_unregister_inode_cookie (struct ceph_inode_info *ci);void ceph_fscache_use_cookie (struct inode *inode,bool will_modify);void ceph_fscache_unuse_cookie (struct inode *inode,bool update);
@@ -76,13 +76,13 @@ static inline void ceph_fscache_note_page_release(struct inode *inode) fscache_note_page_release(ceph_fscache_cookie(ci)); }#else /* CONFIG_CEPH_FSCACHE */ -static inline int ceph_fscache_register_fs (struct ceph_fs_client * fsc, +static inline int ceph_fscache_register_fs (struct ceph_fs_client *fsc,struct fs_context *fc) {return 0 ; } -static inline void ceph_fscache_unregister_fs (struct ceph_fs_client * fsc) +static inline void ceph_fscache_unregister_fs (struct ceph_fs_client *fsc) { }
@@ -90,7 +90,7 @@ static inline void ceph_fscache_register_inode_cookie(struct inode *inode) { } -static inline void ceph_fscache_unregister_inode_cookie (struct ceph_inode_info * ci) +static inline void ceph_fscache_unregister_inode_cookie (struct ceph_inode_info *ci) { }
Hi ZhiHu
This looks good to me.
Could you restructure the patch title and commit comment ?
Thanks
- Xiubo
Quoted 57 lines · On 7/19/23 19:10, [email protected] wrote:
Signed-off-by ZhiHu <[email protected]>---
fs/ceph/cache.h | 12 ++++++------1 file changed, 6 insertions(+), 6 deletions(-)fs/ceph/cache.h +3
-3@@ -14,11 +14,11 @@ #ifdef CONFIG_CEPH_FSCACHE #include <linux/fscache.h> -int ceph_fscache_register_fs (struct ceph_fs_client * fsc,struct fs_context *fc); -void ceph_fscache_unregister_fs (struct ceph_fs_client * fsc); +int ceph_fscache_register_fs (struct ceph_fs_client *fsc,struct fs_context *fc); +void ceph_fscache_unregister_fs (struct ceph_fs_client *fsc); void ceph_fscache_register_inode_cookie(struct inode *inode); -void ceph_fscache_unregister_inode_cookie (struct ceph_inode_info * ci); +void ceph_fscache_unregister_inode_cookie (struct ceph_inode_info *ci);void
ceph_fscache_use_cookie(struct inode *inode, bool will_modify); voidceph_fscache_unuse_cookie(struct inode *inode, bool update);fs/ceph/cache.h +2
-2@@ -76,13 +76,13 @@ static inline void ceph_fscache_note_page_release(struct inode *inode) fscache_note_page_release(ceph_fscache_cookie(ci)); } #else /* CONFIG_CEPH_FSCACHE */ -static inline int ceph_fscache_register_fs (struct ceph_fs_client * fsc, +static inline int ceph_fscache_register_fs (struct ceph_fs_client *fsc, struct fs_context *fc) { return 0; } -static inline void ceph_fscache_unregister_fs(struct ceph_fs_client* fsc) +static inline void ceph_fscache_unregister_fs(struct ceph_fs_client *fsc){
}fs/ceph/cache.h +1
-1@@ -90,7 +90,7 @@ static inline void ceph_fscache_register_inode_cookie(struct inode *inode) { } -static inline void ceph_fscache_unregister_inode_cookie(struct ceph_inode_info* ci) +static inline void ceph_fscache_unregister_inode_cookie (struct ceph_inode_info *ci){
}