Skip to contentSkip to conversation

serial: 8520_ce4100: Reuse mem_serial_in() in ce4100_mem_serial_in()

PATCH In review Andy Shevchenko 2 participants 2 messages Jul 1, 2025 – Jul 2, 2025 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 serial: 8520_ce4100: Reuse mem_serial_in() in ce4100_mem_serial_in()

In one place in ce4100_mem_serial_in() the code may be replaced with mem_serial_in() call. Do it so and collapse two conditionals into one.

---

v2: fixed condition (Jiri)

 drivers/tty/serial/8250/8250_ce4100.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/tty/serial/8250/8250_ce4100.c +2 -7
index 3dd88f372a51..81dfb2adbabd 100644
@@ -35,13 +35,8 @@ static u32 ce4100_mem_serial_in(struct uart_port *p, unsigned int offset)
 {
 	u32 ret, ier, lsr;
 
-	if (offset != UART_IIR)
-		return mem_serial_in(p, offset);
-
-	offset <<= p->regshift;
-
-	ret = readl(p->membase + offset);
-	if (!(ret & UART_IIR_NO_INT))
+	ret = mem_serial_in(p, offset);
+	if (offset != UART_IIR || !(ret & UART_IIR_NO_INT))
 		return ret;
 
 	/* see if the TX interrupt should have really set */
Signature · 1 line
2.47.2