Skip to contentSkip to conversation

tests/qtest: do not list ahci-test twice

PATCH In review Paolo Bonzini 3 participants 3 messages Sep 4, 2020 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/qtest: do not list ahci-test twice

This is caught by "meson test", which complains about two tests with the same name.

---
 tests/qtest/meson.build | 1 -
 1 file changed, 1 deletion(-)
tests/qtest/meson.build +0 -1
index 8f8fdb1336..874b5be62b 100644
@@ -49,7 +49,6 @@ qtests_i386 = \
   qtests_pci +                                                                              \
   ['fdc-test',
    'ide-test',
-   'ahci-test',
    'hd-geo-test',
    'boot-order-test',
    'bios-tables-test',
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Paolo Bonzini

This is caught by "meson test", which complains about two tests with the same name.

---
 tests/qtest/meson.build | 1 -
 1 file changed, 1 deletion(-)
tests/qtest/meson.build +0 -0
index 8f8fdb1336..874b5be62b 100644

tests/qtest/meson.build qtests_i386 = \ · line 54

Quoted 7 lines
tests/qtest/meson.build +0 -1
@@ -49,7 +49,6 @@ qtests_i386 = \
   qtests_pci +                                                                              \
   ['fdc-test',
    'ide-test',
-   'ahci-test',
    'hd-geo-test',
    'boot-order-test',
    'bios-tables-test',

... and since you just sent your meson PR without this, I can also take it through my qtest-next tree.

Reviewed-by on v1 1/1
#2 lore raw
In reply to Paolo Bonzini
Quoted 14 lines · Paolo Bonzini

This is caught by "meson test", which complains about two tests with the same name.

---
 tests/qtest/meson.build | 1 -
 1 file changed, 1 deletion(-)
tests/qtest/meson.build +0 -0
index 8f8fdb1336..874b5be62b 100644

tests/qtest/meson.build qtests_i386 = \ · line 54

Quoted 7 lines
tests/qtest/meson.build +0 -1
@@ -49,7 +49,6 @@ qtests_i386 = \
   qtests_pci +                                                                              \
   ['fdc-test',
    'ide-test',
-   'ahci-test',
    'hd-geo-test',
    'boot-order-test',
    'bios-tables-test',
Fixes a2ce7dbd917 ("meson: convert tests/qtest to meson")