pinctrl: amd: Clear GPIO debounce for suspend
Subsystems (3)
PATCH v2 1/1 pinctrl: amd: Clear GPIO debounce for suspend
From: Mario Limonciello <[email protected]>
soc-button-array hardcodes a debounce value by means of gpio_keys which uses pinctrl-amd as a backend to program debounce for a GPIO.
This hardcoded value doesn't match what the firmware intended to be programmed in _AEI. The hardcoded debounce leads to problems waking from suspend. There isn't appetite to conditionalize the behavior in soc-button-array or gpio-keys so clear it when the system suspends to avoid problems with being able to resume.
---
v2:
* clarify comment for pinctrl (Hans)
--- drivers/pinctrl/pinctrl-amd.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/pinctrl/pinctrl-amd.c +11 -0
@@ -979,6 +979,17 @@ static int amd_gpio_suspend_hibernate_common(struct device *dev, bool is_suspend pin, is_suspend ? "suspend" : "hibernate"); } +/* +* debounce enabled over suspend has shown issues with a GPIO +* being unable to wake the system, as we're only interested in +* the actual wakeup event, clear it. +*/ +if (gpio_dev->saved_regs[i] & (DB_CNTRl_MASK <<DB_CNTRL_OFF )) { +amd_gpio_set_debounce (gpio_dev, pin,0 ); +pm_pr_dbg ("Clearing debounce for GPIO #%d during %s.\n" , + pin, is_suspend ?"suspend" :"hibernate" ); + } +raw_spin_unlock_irqrestore (&gpio_dev->lock, flags); }
Signature · 1 line
2.43.0
Hi,
Quoted 17 lines · Mario Limonciello
From: Mario Limonciello <[email protected]>
soc-button-array hardcodes a debounce value by means of
gpio_keyswhich uses pinctrl-amd as a backend to program debounce for a GPIO.This hardcoded value doesn't match what the firmware intended to be programmed in
_AEI. The hardcoded debounce leads to problems waking from suspend. There isn't appetite to conditionalize the behavior in soc-button-array or gpio-keys so clear it when the system suspends to avoid problems with being able to resume.Cc Dmitry Torokhov <[email protected]>Cc Hans de Goede <[email protected]>Fixes 5c4fa2a6da7fb ("Input: soc_button_array - debounce the buttons")Link https://lore.kernel.org/linux-input/mkgtrb5gt7miyg6kvqdlbu4nj3elym6ijudobpdi26gp4xxay5@rsa6ytrjvj2q/ open hereSigned-off-by Mario Limonciello <[email protected]>
Quoted 3 lines
---
v2:
* clarify comment for pinctrl (Hans)
Thanks, patch looks good to me:
Regards,
Hans
Quoted 26 lines
--- drivers/pinctrl/pinctrl-amd.c | 11 +++++++++++ 1 file changed, 11 insertions(+)drivers/pinctrl/pinctrl-amd.c +11
-0@@ -979,6 +979,17 @@ static int amd_gpio_suspend_hibernate_common(struct device *dev, bool is_suspend pin, is_suspend ? "suspend" : "hibernate"); } +/* +* debounce enabled over suspend has shown issues with a GPIO +* being unable to wake the system, as we're only interested in +* the actual wakeup event, clear it. +*/ +if (gpio_dev->saved_regs[i] & (DB_CNTRl_MASK <<DB_CNTRL_OFF )) { +amd_gpio_set_debounce (gpio_dev, pin,0 ); +pm_pr_dbg ("Clearing debounce for GPIO #%d during %s.\n" , + pin, is_suspend ?"suspend" :"hibernate" ); + } +raw_spin_unlock_irqrestore (&gpio_dev->lock, flags); }
Quoted 11 lines · Mario Limonciello
From: Mario Limonciello <[email protected]>
soc-button-array hardcodes a debounce value by means of
gpio_keyswhich uses pinctrl-amd as a backend to program debounce for a GPIO.This hardcoded value doesn't match what the firmware intended to be programmed in
_AEI. The hardcoded debounce leads to problems waking from suspend. There isn't appetite to conditionalize the behavior in soc-button-array or gpio-keys so clear it when the system suspends to avoid problems with being able to resume.
Quoted 6 lines
Cc Dmitry Torokhov <[email protected]>Cc Hans de Goede <[email protected]>Fixes 5c4fa2a6da7fb ("Input: soc_button_array - debounce the buttons")Link https://lore.kernel.org/linux-input/mkgtrb5gt7miyg6kvqdlbu4nj3elym6ijudobpdi26gp4xxay5@rsa6ytrjvj2q/ open hereSigned-off-by Mario Limonciello <[email protected]>
Patch applied for fixes!
Yours,
Linus Walleij