Skip to contentSkip to conversation

net: ftgmac100: select FIXED_PHY

PATCH In review Heiner Kallweit 1 participant 2 messages Jun 16, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ftgmac100: select FIXED_PHY

Depending on e.g. DT configuration this driver uses a fixed link. So we shouldn't rely on the user to enable FIXED_PHY, select it in Kconfig instead. We may end up with a non-functional driver otherwise.

Fixes 38561ded50d0 ("net: ftgmac100: support fixed link")
---
 drivers/net/ethernet/faraday/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/faraday/Kconfig +1 -0
index c699bd6bc..474073c7f 100644
@@ -31,6 +31,7 @@ config FTGMAC100
 	depends on ARM || COMPILE_TEST
 	depends on !64BIT || BROKEN
 	select PHYLIB
+	select FIXED_PHY
 	select MDIO_ASPEED if MACH_ASPEED_G6
 	select CRC32
 	help
Signature · 1 line
2.49.0
#1 lore raw
Quoted 16 lines · Heiner Kallweit

Depending on e.g. DT configuration this driver uses a fixed link. So we shouldn't rely on the user to enable FIXED_PHY, select it in Kconfig instead. We may end up with a non-functional driver otherwise.

Fixes 38561ded50d0 ("net: ftgmac100: support fixed link")
---
 drivers/net/ethernet/faraday/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/faraday/Kconfig +0 -0
index c699bd6bc..474073c7f 100644

drivers/net/ethernet/faraday/Kconfig config FTGMAC100 · line 37

Quoted 7 lines
drivers/net/ethernet/faraday/Kconfig +1 -0
@@ -31,6 +31,7 @@ config FTGMAC100
 	depends on ARM || COMPILE_TEST
 	depends on !64BIT || BROKEN
 	select PHYLIB
+	select FIXED_PHY
 	select MDIO_ASPEED if MACH_ASPEED_G6
 	select CRC32
 	help

Two blamed authors missing, will resubmit.
---
pw-bot: cr