selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
PATCH 1/1 selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
From: Hongfu Li <[email protected]>
mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice. The second run repeats all assertions with no benefit. Drop the duplicate call.
--- tools/testing/selftests/mm/mseal_test.c | 1 - 1 file changed, 1 deletion(-)
tools/testing/selftests/mm/mseal_test.c +0 -1
@@ -1913,7 +1913,6 @@ int main(void)test_seal_mprotect_partial_mprotect (false);test_seal_mprotect_partial_mprotect (true); -test_seal_mprotect_two_vma_with_gap ();test_seal_mprotect_two_vma_with_gap ();test_seal_mprotect_merge (false);
Signature · 1 line
2.54.0
Quoted 7 lines · Hongfu Li
From: Hongfu Li <[email protected]>
mseal_testmain()invokestest_seal_mprotect_two_vma_with_gap()twice. The second run repeats all assertions with no benefit. Drop the duplicate call.Signed-off-by Hongfu Li <[email protected]>
:))
LGTM so
Quoted 17 lines
--- tools/testing/selftests/mm/mseal_test.c | 1 - 1 file changed, 1 deletion(-)tools/testing/selftests/mm/mseal_test.c +0
-2@@ -1913,7 +1913,6 @@ int main(void)test_seal_mprotect_partial_mprotect (false);test_seal_mprotect_partial_mprotect (true); -test_seal_mprotect_two_vma_with_gap ();test_seal_mprotect_two_vma_with_gap ();test_seal_mprotect_merge (false); --
Quoted 2 lines
2.54.0
--
Cheers, Lorenzo
Lorenzo Stoakes (ARM)
reviewerQuoted 7 lines · Lorenzo Stoakes (ARM)
Quoted 6 lines · Hongfu Li
From: Hongfu Li <[email protected]>
mseal_testmain()invokestest_seal_mprotect_two_vma_with_gap()twice. The second run repeats all assertions with no benefit. Drop the duplicate call.
Quoted 7 lines
Quoted 1 line
Signed-off-by Hongfu Li <[email protected]>:))
LGTM so
Reviewed-by Lorenzo Stoakes (ARM) <[email protected]>
Sorry Pedro mentioned off-list that you need to update the number of tests specified, e.g.:
- ksft_set_plan(88);
+ ksft_set_plan(87);
In main().
Update that and send a respin and you can attach my tag to it.
Quoted 16 lines
Quoted 16 lines
--- tools/testing/selftests/mm/mseal_test.c | 1 - 1 file changed, 1 deletion(-)tools/testing/selftests/mm/mseal_test.c +0
-1@@ -1913,7 +1913,6 @@ int main(void)test_seal_mprotect_partial_mprotect (false);test_seal_mprotect_partial_mprotect (true); -test_seal_mprotect_two_vma_with_gap ();test_seal_mprotect_two_vma_with_gap ();
Quoted 7 lines
Quoted 4 lines
tools/testing/selftests/mm/mseal_test.c +0
-1test_seal_mprotect_merge (false); --2.54.0
--
Cheers, Lorenzo
--
Cheers, Lorenzo
Quoted 20 lines · Lorenzo Stoakes (ARM)
Quoted 7 lines · Lorenzo Stoakes (ARM)
Quoted 6 lines · Hongfu Li
From: Hongfu Li <[email protected]>
mseal_testmain()invokestest_seal_mprotect_two_vma_with_gap()twice. The second run repeats all assertions with no benefit. Drop the duplicate call.Quoted 6 lines
Quoted 1 line
Signed-off-by Hongfu Li <[email protected]>:))
LGTM so
Reviewed-by Lorenzo Stoakes (ARM) <[email protected]>Sorry Pedro mentioned off-list that you need to update the number of tests specified, e.g.:
(quoted diff) +1
-1- ksft_set_plan(88); + ksft_set_plan(87);
Quoted 3 lines
In
main().Update that and send a respin and you can attach my tag to it.
Thanks a lot for your review. I will adjust ksft_set_plan() from 88 to 87 in main() and send a respin carrying your Reviewed-by.
Signature · 2 lines
Best regards, Hongfu
Quoted 11 lines · Hongfu Li
Quoted 9 lines · Lorenzo Stoakes (ARM)
Quoted 5 lines · Lorenzo Stoakes (ARM)
:))
LGTM so
Reviewed-by Lorenzo Stoakes (ARM) <[email protected]>Sorry Pedro mentioned off-list that you need to update the number of tests specified, e.g.:
Quoted 9 lines
Quoted 6 lines
-
ksft_set_plan(88);
+ksft_set_plan(87);In
main().Update that and send a respin and you can attach my tag to it.
Thanks a lot for your review. I will adjust
ksft_set_plan()from 88 to 87 inmain()and send a respin carrying your Reviewed-by.
Feel free to add
to the respin.
Signature · 3 lines
Cheers, David