Skip to contentSkip to conversation

f2fs: Avoid double lock for cp_rwsem during checkpoint

PATCH Markus Elfring 3 participants 4 messages Apr 27, 2020 – Apr 29, 2020 Kernel janitors

lore
Share & tools
lore
#0 lore raw
Quoted 3 lines

… This results in deadlock as
iput() tries to hold cp_rwsem, which is already held at the beginning by checkpoint->block_operations().

Will another imperative wording become helpful besides the provided information for this change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6a8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151

Would you like to add the tag “Fixes” because of adjustments for the data synchronisation?

Regards,
Markus

#1 lore raw

Hi Markus

Quoted 9 lines · Markus Elfring
Quoted 3 lines

… This results in deadlock as
iput() tries to hold cp_rwsem, which is already held at the beginning by checkpoint->block_operations().

Will another imperative wording become helpful besides the provided information for this change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6a8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151

Would you like to add the tag “Fixes” because of adjustments for the data synchronisation?

I couldn't find any past commit which suits to be added under "Fixes" here. Let me know if you have any other comment.

Quoted 3 lines

Regards,
Markus

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

#2 lore raw
Quoted 10 lines · Sayali Lokhande

Hi Markus

Quoted 7 lines · Markus Elfring
Quoted 3 lines

… This results in deadlock as
iput() tries to hold cp_rwsem, which is already held at the beginning by checkpoint->block_operations().

Will another imperative wording become helpful besides the provided information for this change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?idj8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151

Quoted 5 lines
Quoted 2 lines

Would you like to add the tag “Fixes” because of adjustments for the data synchronisation?

I couldn't find any past commit which suits to be added under "Fixes" here. Let me know if you have any other comment.

This looks really old. Maybe commit 399368372ed9 ("f2fs: introduce a new global lock scheme")?

regards,
dan carpenter

#3 lore raw
Quoted 11 lines · Dan Carpenter
Quoted 10 lines · Sayali Lokhande

Hi Markus

Quoted 7 lines · Markus Elfring
Quoted 3 lines

… This results in deadlock as
iput() tries to hold cp_rwsem, which is already held at the beginning by checkpoint->block_operations().

Will another imperative wording become helpful besides the provided information for this change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6a8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Would you like to add the tag “Fixes” because of adjustments for the data synchronisation?

I couldn't find any past commit which suits to be added under "Fixes" here. Let me know if you have any other comment.

This looks really old. Maybe commit 399368372ed9 ("f2fs: introduce a new global lock scheme")?

Yes. Let me update it in Fixes tag in V3 and post it. Thanks for pointing it.

Quoted 4 lines

regards,
dan carpenter

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel