Skip to contentSkip to conversation

firmware: tegra: bpmp: Return directly after a failed kzalloc() in get_filename()

PATCH Applied Markus Elfring 2 participants 2 messages Dec 25, 2023 – Feb 21, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: tegra: bpmp: Return directly after a failed kzalloc() in get_filename()

From: Markus Elfring <[email protected]>
Date: Mon, 25 Dec 2023 20:03:56 +0100

The kfree() function was called in one case by the get_filename() function during error handling even if the passed variable contained a null pointer. This issue was detected by using the Coccinelle software.

Thus return directly after a call of the function “kzalloc” failed at the beginning.

---
 drivers/firmware/tegra/bpmp-debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/tegra/bpmp-debugfs.c +1 -1
index bbcdd9fed3fb..4221fed70ad4 100644
@@ -77,7 +77,7 @@ static const char *get_filename(struct tegra_bpmp *bpmp,
 
 	root_path_buf = kzalloc(root_path_buf_len, GFP_KERNEL);
 	if (!root_path_buf)
-		goto out;
+		return NULL;
 
 	root_path = dentry_path(bpmp->debugfs_mirror, root_path_buf,
 				root_path_buf_len);

--
2.43.0

#1 lore raw

From: Thierry Reding <[email protected]>

Quoted 9 lines · Markus Elfring

The kfree() function was called in one case by the get_filename() function during error handling even if the passed variable contained a null pointer. This issue was detected by using the Coccinelle software.

Thus return directly after a call of the function “kzalloc” failed at the beginning.

[...]

Applied, thanks!

[1/1] firmware: tegra: bpmp: Return directly after a failed kzalloc() in get_filename()

      commit: 1315848f1f8a0100cb6f8a7187bc320c5d98947f

Best regards,

Signature · 1 line
Thierry Reding <[email protected]>