Skip to contentSkip to conversation

Add support for Atmel flash

PATCH New Ulf Samuelsson 5 participants 8 messages Apr 12, 2008 – Apr 18, 2008

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 Add support for Atmel flash

Le samedi 12 avril 2008 ? 21:03 +0200, Ulf Samuelsson a ?crit :

Quoted 1 line

Add ID codes for most recent Atmel NOR flashes

Is there any added value on using the atmel flash driver instead of the standard CFI driver ? It surely doesn't have any on the SAM9/CAP9 boards, but I'm not sure of the older AT91RM9200.

Thanks,

Signature · 1 line
Stelian Pop <[email protected]>
#2 lore raw

PATCH 1/1 Add support for Atmel flash

Quoted 11 lines

Le samedi 12 avril 2008 ? 21:03 +0200, Ulf Samuelsson a ?crit :

Quoted 1 line

Add ID codes for most recent Atmel NOR flashes

Is there any added value on using the atmel flash driver instead of the standard CFI driver ? It surely doesn't have any on the SAM9/CAP9 boards, but I'm not sure of the older AT91RM9200.

Thanks,

Signature · 1 line
Stelian Pop <[email protected]>

It is mainly time related.
This flash driver is well tested on the AT91RM9200EK. The standard CFI driver is not.
While CFI should work, I do not have time to make a thorough test.

Best Regards
Ulf Samuelsson

#3 lore raw

PATCH 1/1 Add support for Atmel flash

Le lundi 14 avril 2008 ? 08:00 +0200, Ulf Samuelsson a ?crit :

Quoted 13 lines
Quoted 11 lines

Le samedi 12 avril 2008 ? 21:03 +0200, Ulf Samuelsson a ?crit :

Quoted 1 line

Add ID codes for most recent Atmel NOR flashes

Is there any added value on using the atmel flash driver instead of the standard CFI driver ? It surely doesn't have any on the SAM9/CAP9 boards, but I'm not sure of the older AT91RM9200.

Thanks,

Signature · 1 line
Stelian Pop <[email protected]>
Quoted 4 lines

It is mainly time related.
This flash driver is well tested on the AT91RM9200EK. The standard CFI driver is not.
While CFI should work, I do not have time to make a thorough test.

Linux seems to use the CFI driver, just like every other SAM/CAP board, so it should be safe to switch to the standard CFI driver.

The only remaining issue is testing, and I was hoping you could do this as part of the new board porting. :)

Thanks,

Signature · 1 line
Stelian Pop <[email protected]>
#4 lore raw

PATCH 1/1 Add support for Atmel flash

Quoted 21 lines

Le lundi 14 avril 2008 ? 08:00 +0200, Ulf Samuelsson a ?crit :

Quoted 13 lines
Quoted 11 lines

Le samedi 12 avril 2008 ? 21:03 +0200, Ulf Samuelsson a ?crit :

Quoted 1 line

Add ID codes for most recent Atmel NOR flashes

Is there any added value on using the atmel flash driver instead of the standard CFI driver ? It surely doesn't have any on the SAM9/CAP9 boards, but I'm not sure of the older AT91RM9200.

Thanks,

Signature · 1 line
Stelian Pop <[email protected]>
Quoted 4 lines

It is mainly time related.
This flash driver is well tested on the AT91RM9200EK. The standard CFI driver is not.
While CFI should work, I do not have time to make a thorough test.

Quoted 6 lines

Linux seems to use the CFI driver, just like every other SAM/CAP board, so it should be safe to switch to the standard CFI driver.

The only remaining issue is testing, and I was hoping you could do this as part of the new board porting. :)

This is not "porting of a new board".
This board support has existed for 3-4 years in the Atmel U-Boot.

Best Regards
Ulf Samuelsson

#5 lore raw

PATCH 1/1 Add support for Atmel flash

In reply to Stelian Pop
Quoted 15 lines · Stelian Pop

Le lundi 14 avril 2008 ? 08:00 +0200, Ulf Samuelsson a ?crit :

Quoted 13 lines
Quoted 11 lines

Le samedi 12 avril 2008 ? 21:03 +0200, Ulf Samuelsson a ?crit :

Quoted 1 line

Add ID codes for most recent Atmel NOR flashes

Is there any added value on using the atmel flash driver instead of the standard CFI driver ? It surely doesn't have any on the SAM9/CAP9 boards, but I'm not sure of the older AT91RM9200.

Thanks,

Signature · 1 line
Stelian Pop <[email protected]>
Quoted 7 lines
Quoted 4 lines

It is mainly time related.
This flash driver is well tested on the AT91RM9200EK. The standard CFI driver is not.
While CFI should work, I do not have time to make a thorough test.

Linux seems to use the CFI driver, just like every other SAM/CAP board, so it should be safe to switch to the standard CFI driver.

I agree with Stelian, I prefer you use the CFI driver, but I known that there is somme difference between then. Untill you've test and qualify the CFI driver for the AT91RM9200EK. I'll ack your patch.

Best Regards,
J.

#6 lore raw

PATCH 1/1 Add support for Atmel flash

In reply to Stelian Pop
Quoted 7 lines · In message <[email protected]> you wrote:

Le samedi 12 avril 2008 =E0 21:03 +0200, Ulf Samuelsson a =E9crit :

Quoted 1 line

Add ID codes for most recent Atmel NOR flashes

Is there any added value on using the atmel flash driver instead of the standard CFI driver ? It surely doesn't have any on the SAM9/CAP9 boards, but I'm not sure of the older AT91RM9200.

I don't think there is.

For the existing boards, the already exisitng values should be sufficient, and for new boards we should use the CFI driver.

I intend to NAK new boards with CFI conformant flashes that don't use the CFI driver unless thay have very good reasons.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The more data I punch in this card,  the lighter it becomes, and the
lower the mailing cost."
                     - Stan Kelly-Bootle, "The Devil's DP Dictionary"
#7 lore raw

PATCH 1/1 Add support for Atmel flash

In reply to Ulf Samuelsson
Quoted 4 lines · In message <[email protected]> you wrote:

Add ID codes for most recent Atmel NOR flashes

Rejected. Please use the CFI driver for newly added code. For this, such defines are not needed.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There is such a fine line between genius and stupidity."
- David St. Hubbins, "Spinal Tap"