Skip to contentSkip to conversation

platform/x86: intel_pmc_core: Mark local function static

PATCH In review Guenter Roeck 3 participants 5 messages Mar 26, 2019 – Apr 5, 2019 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: intel_pmc_core: Mark local function static

0day reports:

drivers/platform/x86/intel_pmc_core.c:833:5: sparse:
symbol 'quirk_xtal_ignore' was not declared. Should it be static?

Mark the function static since it is indeed only called locally.

Cc Rajneesh Bhardwaj <[email protected]>
Fixes 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown")
---
 drivers/platform/x86/intel_pmc_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel_pmc_core.c +1 -1
index f2c621b55f49..9908d233305e 100644
@@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
  * the platform BIOS enforces 24Mhx Crystal to shutdown
  * before PMC can assert SLP_S0#.
  */
-int quirk_xtal_ignore(const struct dmi_system_id *id)
+static int quirk_xtal_ignore(const struct dmi_system_id *id)
 {
 	struct pmc_dev *pmcdev = &pmc;
 	u32 value;
Signature · 1 line
2.7.4
#1 lore raw
Quoted 4 lines · Guenter Roeck

0day reports:

drivers/platform/x86/intel_pmc_core.c:833:5: sparse:
symbol 'quirk_xtal_ignore' was not declared. Should it be static?

Looks good to me.

Quoted 22 lines

Mark the function static since it is indeed only called locally.

Cc Rajneesh Bhardwaj <[email protected]>
Fixes 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown")
---
  drivers/platform/x86/intel_pmc_core.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel_pmc_core.c +1 -1
index f2c621b55f49..9908d233305e 100644
@@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
   * the platform BIOS enforces 24Mhx Crystal to shutdown
   * before PMC can assert SLP_S0#.
   */
-int quirk_xtal_ignore(const struct dmi_system_id *id)
+static int quirk_xtal_ignore(const struct dmi_system_id *id)
  {
  	struct pmc_dev *pmcdev = &pmc;
  	u32 value;
#2 lore raw
Quoted 9 lines · Rajneesh
Quoted 4 lines · Guenter Roeck

0day reports:

drivers/platform/x86/intel_pmc_core.c:833:5: sparse:
symbol 'quirk_xtal_ignore' was not declared. Should it be static?

Looks good to me.

Please, give a corresponding tag.
Meanwhile I will apply it to my review and testing queue for robots to play with, thanks!

Quoted 23 lines
Quoted 23 lines

Mark the function static since it is indeed only called locally.

Cc Rajneesh Bhardwaj <[email protected]>
Fixes 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown")
---
  drivers/platform/x86/intel_pmc_core.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel_pmc_core.c +1 -1
index f2c621b55f49..9908d233305e 100644
@@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
   * the platform BIOS enforces 24Mhx Crystal to shutdown
   * before PMC can assert SLP_S0#.
   */
-int quirk_xtal_ignore(const struct dmi_system_id *id)
+static int quirk_xtal_ignore(const struct dmi_system_id *id)
  {
      struct pmc_dev *pmcdev = &pmc;
      u32 value;
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw

Sending again as i got delivery failure notification from the mailing list for some reason.

Quoted 4 lines · Andy Shevchenko
Quoted 2 lines · Rajneesh

On 27-Mar-19 1:59 AM, Guenter Roeck wrote:

Quoted 8 lines
Quoted 5 lines
Quoted 4 lines

0day reports:

drivers/platform/x86/intel_pmc_core.c:833:5: sparse:
symbol 'quirk_xtal_ignore' was not declared. Should it be static?

Looks good to me.

Please, give a corresponding tag.
Meanwhile I will apply it to my review and testing queue for robots to play with, thanks!

Sure.

Quoted 24 lines
Quoted 22 lines
Quoted 22 lines

Mark the function static since it is indeed only called locally.

Cc Rajneesh Bhardwaj <[email protected]>
Fixes 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown")
---
   drivers/platform/x86/intel_pmc_core.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel_pmc_core.c +1 -1
index f2c621b55f49..9908d233305e 100644
@@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
    * the platform BIOS enforces 24Mhx Crystal to shutdown
    * before PMC can assert SLP_S0#.
    */
-int quirk_xtal_ignore(const struct dmi_system_id *id)
+static int quirk_xtal_ignore(const struct dmi_system_id *id)
   {
       struct pmc_dev *pmcdev = &pmc;
       u32 value;
#4 lore raw
Quoted 2 lines · Rajneesh

Sending again as i got delivery failure notification from the mailing list for some reason.

Mailing list doesn't accept HTML as was your previous message.

Signature · 2 lines
With Best Regards,
Andy Shevchenko