file-posix: fix zone write granularity assignment for zoned block devices
PATCH 1/1 file-posix: fix zone write granularity assignment for zoned block devices
In the ZBC and ZAC specifications, the requirement is that the write granularity matches the physical block size.
However, in the ZNS specification, the requirement is simply that the write granularity matches the logical block size.
In Linux, there is a zone_write_granularity sysfs property which abstracts this away by providing, so let's make use of it.
Currently, it is theoretically possible that QEMU presents an inflated write granularity for NVMe devices where the physical block size is larger than the logical block size.
--- block/file-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
block/file-posix.c +1 -1
@@ -1495,7 +1495,7 @@ static void raw_refresh_zoned_limits(BlockDriverState *bs, struct stat *st, bs->bl.max_append_sectors = ret >>BDRV_SECTOR_BITS ; } - ret =get_sysfs_long_val (st,"physical_block_size" ); + ret =get_sysfs_long_val (st,"zone_write_granularity" );if (ret >=0 ) { bs->bl.write_granularity = ret; }
Signature · 1 line
2.55.0
Quoted 11 lines · Niklas Cassel
In the ZBC and ZAC specifications, the requirement is that the write granularity matches the physical block size.
However, in the ZNS specification, the requirement is simply that the write granularity matches the logical block size.
In Linux, there is a
zone_write_granularitysysfs property which abstracts this away by providing, so let's make use of it.
nit:
this away, so let's make use of it.
Quoted 11 lines · Niklas Cassel
In the ZBC and ZAC specifications, the requirement is that the write granularity matches the physical block size.
However, in the ZNS specification, the requirement is simply that the write granularity matches the logical block size.
In Linux, there is a
zone_write_granularitysysfs property which abstracts this away by providing, so let's make use of it.
s/by providing// ? Seems like the sentence is not complete otherwise...
Quoted 7 lines
Currently, it is theoretically possible that QEMU presents an inflated write granularity for NVMe devices where the physical block size is larger than the logical block size.
Fixes a3c41f06d5a8 ("file-posix: add tracking of the zone write pointers")Signed-off-by Niklas Cassel <[email protected]>
Other than that, looks OK to me.
Signature · 2 lines
Damien Le Moal Western Digital Research
Quoted 16 lines · Niklas Cassel
In the ZBC and ZAC specifications, the requirement is that the write granularity matches the physical block size.
However, in the ZNS specification, the requirement is simply that the write granularity matches the logical block size.
In Linux, there is a
zone_write_granularitysysfs property which abstracts this away by providing, so let's make use of it.Currently, it is theoretically possible that QEMU presents an inflated write granularity for NVMe devices where the physical block size is larger than the logical block size.
Quoted 5 lines
Fixes a3c41f06d5a8 ("file-posix: add tracking of the zone write pointers")Signed-off-by Niklas Cassel <[email protected]>--- block/file-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)