Skip to contentSkip to conversation

MAINTAINERS: Update remaining @linux.vnet.ibm.com addresses

PATCH Applied Lukas Bulwahn 5 participants 8 messages Apr 11, 2019 – Apr 21, 2019 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Update remaining @linux.vnet.ibm.com addresses

Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com to @linux.ibm.com in commit 1dfddcdb95c4
("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but some still remained.

We update the remaining email addresses in MAINTAINERS, hopefully finally catching all cases for good.

Fixes 1dfddcdb95c4 ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com")

---

Tyrel, please take this patch. Thanks.

 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
MAINTAINERS +3 -3
index 2359e12e4c41..454b3cf36aa4 100644
@@ -7439,14 +7439,14 @@ F:	drivers/crypto/vmx/ghash*
 F:	drivers/crypto/vmx/ppc-xlate.pl
 
 IBM Power PCI Hotplug Driver for RPA-compliant PPC64 platform
-M:	Tyrel Datwyler <[email protected]>
+M:	Tyrel Datwyler <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Supported
 F:	drivers/pci/hotplug/rpaphp*
 
 IBM Power IO DLPAR Driver for RPA-compliant PPC64 platform
-M:	Tyrel Datwyler <[email protected]>
+M:	Tyrel Datwyler <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Supported
@@ -10388,7 +10388,7 @@ F:	arch/arm/mach-mmp/
 
 MMU GATHER AND TLB INVALIDATION
 M:	Will Deacon <[email protected]>
-M:	"Aneesh Kumar K.V" <[email protected]>
+M:	"Aneesh Kumar K.V" <[email protected]>
 M:	Andrew Morton <[email protected]>
 M:	Nick Piggin <[email protected]>
 M:	Peter Zijlstra <[email protected]>
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Lukas Bulwahn

Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com to @linux.ibm.com in commit 1dfddcdb95c4
("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but some still remained.

We update the remaining email addresses in MAINTAINERS, hopefully finally catching all cases for good.

Fixes 1dfddcdb95c4 ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com")

For whatever it is worth:

Quoted 40 lines

---

Tyrel, please take this patch. Thanks.

 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
MAINTAINERS +3 -3
index 2359e12e4c41..454b3cf36aa4 100644
@@ -7439,14 +7439,14 @@ F:	drivers/crypto/vmx/ghash*
 F:	drivers/crypto/vmx/ppc-xlate.pl
 
 IBM Power PCI Hotplug Driver for RPA-compliant PPC64 platform
-M:	Tyrel Datwyler <[email protected]>
+M:	Tyrel Datwyler <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Supported
 F:	drivers/pci/hotplug/rpaphp*
 
 IBM Power IO DLPAR Driver for RPA-compliant PPC64 platform
-M:	Tyrel Datwyler <[email protected]>
+M:	Tyrel Datwyler <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Supported
@@ -10388,7 +10388,7 @@ F:	arch/arm/mach-mmp/
 
 MMU GATHER AND TLB INVALIDATION
 M:	Will Deacon <[email protected]>
-M:	"Aneesh Kumar K.V" <[email protected]>
+M:	"Aneesh Kumar K.V" <[email protected]>
 M:	Andrew Morton <[email protected]>
 M:	Nick Piggin <[email protected]>
 M:	Peter Zijlstra <[email protected]>
Signature · 1 line
2.17.1
#2 lore raw
In reply to Lukas Bulwahn
Quoted 7 lines · Lukas Bulwahn

Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com to @linux.ibm.com in commit 1dfddcdb95c4
("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but some still remained.

We update the remaining email addresses in MAINTAINERS, hopefully finally catching all cases for good.

Perhaps update all the similar addresses in other files too

$ git grep --name-only 'linux\.vnet\.ibm\.com' | wc -l
315
#3 lore raw
Quoted 6 lines · Joe Perches
Quoted 5 lines · Lukas Bulwahn

Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com to @linux.ibm.com in commit 1dfddcdb95c4
("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but some still remained.

Quoted 7 lines
Quoted 2 lines

We update the remaining email addresses in MAINTAINERS, hopefully finally catching all cases for good.

Perhaps update all the similar addresses in other files too

$ git grep --name-only 'linux\.vnet\.ibm\.com' | wc -l
315

A good number of them are no longer valid. So I'm not sure it's worth updating them en masse to addresses that won't ever work.

We have git now, we don't need email addresses in files, they're just prone to bitrot like this.

Should we just change them all like so?

-arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer <[email protected]> +arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer (IBM)

To indicate the author was at IBM when they wrote it?

Or should we try and update them with current addresses? Though then the authors might start getting mails they don't want.

cheers

#4 lore raw
Quoted 21 lines · Michael Ellerman
Quoted 6 lines · Joe Perches
Quoted 5 lines · Lukas Bulwahn

Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com to @linux.ibm.com in commit 1dfddcdb95c4
("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but some still remained.

Quoted 7 lines
Quoted 2 lines

We update the remaining email addresses in MAINTAINERS, hopefully finally catching all cases for good.

Perhaps update all the similar addresses in other files too

$ git grep --name-only 'linux\.vnet\.ibm\.com' | wc -l
315

A good number of them are no longer valid. So I'm not sure it's worth updating them en masse to addresses that won't ever work.

We have git now, we don't need email addresses in files, they're just prone to bitrot like this.

Quoted 6 lines

Should we just change them all like so?

-arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer <[email protected]> +arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer (IBM)

To indicate the author was at IBM when they wrote it?

If that's desired, perhaps:

$ git grep -P --name-only '<?[\w\.]+(?:@| at )linux\.vnet\.ibm\.com>?' | \
  grep -vP '\.mailmap|MAINTAINERS' | \
  xargs perl -p -i -e 's/<?[\w\.]+(?:@|\ at\ )linux\.vnet\.ibm\.com>?/(IBM)/g'
Quoted 2 lines

Or should we try and update them with current addresses? Though then the authors might start getting mails they don't want.

That'd be my preference.

If authors get emails they don't want, then those contact emails should be removed.

#5 lore raw
Quoted 35 lines · Joe Perches
Quoted 21 lines · Michael Ellerman
Quoted 6 lines · Joe Perches
Quoted 5 lines · Lukas Bulwahn

Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com to @linux.ibm.com in commit 1dfddcdb95c4
("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but some still remained.

Quoted 7 lines
Quoted 2 lines

We update the remaining email addresses in MAINTAINERS, hopefully finally catching all cases for good.

Perhaps update all the similar addresses in other files too

$ git grep --name-only 'linux\.vnet\.ibm\.com' | wc -l
315

A good number of them are no longer valid. So I'm not sure it's worth updating them en masse to addresses that won't ever work.

We have git now, we don't need email addresses in files, they're just prone to bitrot like this.

Quoted 6 lines

Should we just change them all like so?

-arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer <[email protected]> +arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer (IBM)

To indicate the author was at IBM when they wrote it?

If that's desired, perhaps:

$ git grep -P --name-only '<?[\w\.]+(?:@| at )linux\.vnet\.ibm\.com>?' | \
  grep -vP '\.mailmap|MAINTAINERS' | \
  xargs perl -p -i -e 's/<?[\w\.]+(?:@|\ at\ )linux\.vnet\.ibm\.com>?/(IBM)/g'
Quoted 7 lines
Quoted 2 lines

Or should we try and update them with current addresses? Though then the authors might start getting mails they don't want.

That'd be my preference.

If authors get emails they don't want, then those contact emails should be removed.

I have updated most of mine, with one more installment of patches to go into the next merge window and another into the merge window after that. More churn than I would have expected, though. If my email address were to change again, I would instead go with the "(IBM)" approach and let the git log and MAINTAINERS file keep the contact information. Not that we get to update the git log, of course. ;-)

I might not have bothered except for combining with the SPDX-tag commits.

Thanx, Paul

#6 lore raw
Quoted 4 lines · Paul E. McKenney

If my email address were
to change again, I would instead go with the "(IBM)" approach and let the git log and MAINTAINERS file keep the contact information. Not that we get to update the git log, of course. ;-)

Add entries to .mailmap works too.

#7 lore raw
In reply to Lukas Bulwahn
Quoted 11 lines · Lukas Bulwahn

Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com to @linux.ibm.com in commit 1dfddcdb95c4
("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but some still remained.

We update the remaining email addresses in MAINTAINERS, hopefully finally catching all cases for good.

Fixes 1dfddcdb95c4 ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com")

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/0235854e1c25069d14512a35ea5cd053

cheers