Skip to contentSkip to conversation

drm/amdkfd: fix double assign skip process context clear

PATCH In review Jonathan Kim 2 participants 2 messages Aug 10, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdkfd: fix double assign skip process context clear

Remove redundant assignment when skipping process ctx clear.

---
 drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c +0 -1
index aa5091f18681..89c2bfcb36ce 100644
@@ -227,7 +227,6 @@ static int add_queue_mes(struct device_queue_manager *dqm, struct queue *q,
 	queue_input.tba_addr = qpd->tba_addr;
 	queue_input.tma_addr = qpd->tma_addr;
 	queue_input.trap_en = !kfd_dbg_has_cwsr_workaround(q->device);
-	queue_input.skip_process_ctx_clear = qpd->pqm->process->debug_trap_enabled;
 	queue_input.skip_process_ctx_clear = qpd->pqm->process->debug_trap_enabled ||
 					     kfd_dbg_has_ttmps_always_setup(q->device);
 
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Jonathan Kim

Remove redundant assignment when skipping process ctx clear.

Quoted 16 lines
---
  drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 1 -
  1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c +0 -1
index aa5091f18681..89c2bfcb36ce 100644
@@ -227,7 +227,6 @@ static int add_queue_mes(struct device_queue_manager *dqm, struct queue *q,
  	queue_input.tba_addr = qpd->tba_addr;
  	queue_input.tma_addr = qpd->tma_addr;
  	queue_input.trap_en = !kfd_dbg_has_cwsr_workaround(q->device);
-	queue_input.skip_process_ctx_clear = qpd->pqm->process->debug_trap_enabled;
  	queue_input.skip_process_ctx_clear = qpd->pqm->process->debug_trap_enabled ||
  					     kfd_dbg_has_ttmps_always_setup(q->device);