reset: ti: syscon: remove unneeded call to platform_set_drvdata()
PATCH 1/1 reset: ti: syscon: remove unneeded call to platform_set_drvdata()
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
--- drivers/reset/reset-ti-syscon.c | 2 -- 1 file changed, 2 deletions(-)
drivers/reset/reset-ti-syscon.c +0 -2
@@ -204,8 +204,6 @@ static int ti_syscon_reset_probe(struct platform_device *pdev) data->controls = controls; data->nr_controls = nr_controls; -platform_set_drvdata (pdev, data); -return devm_reset_controller_register (dev, &data->rcdev); }
Signature · 1 line
2.34.1
Quoted 6 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
// also adding the people listed as MODULE_AUTHOR
// the list seems a bit short otherwise; no idea if these emails work
Quoted 21 lines
Signed-off-by Andrei Coardos <[email protected]>--- drivers/reset/reset-ti-syscon.c | 2 -- 1 file changed, 2 deletions(-)drivers/reset/reset-ti-syscon.c +0
-3@@ -204,8 +204,6 @@ static int ti_syscon_reset_probe(struct platform_device *pdev) data->controls = controls; data->nr_controls = nr_controls; -platform_set_drvdata (pdev, data); -return devm_reset_controller_register (dev, &data->rcdev); } --2.34.1
Andrew Davis
Acked-byQuoted 8 lines · Alexandru Ardelean
Quoted 6 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
Quoted 7 lines
Reviewed-by Alexandru Ardelean <[email protected]>// also adding the people listed as
MODULE_AUTHOR
// the list seems a bit short otherwise; no idea if these emails workQuoted 2 lines
Signed-off-by Andrei Coardos <[email protected]>---
LGTM,
Quoted 19 lines
Quoted 19 lines
drivers/reset/reset-ti-syscon.c | 2 -- 1 file changed, 2 deletions(-)drivers/reset/reset-ti-syscon.c +0
-3@@ -204,8 +204,6 @@ static int ti_syscon_reset_probe(struct platform_device *pdev) data->controls = controls; data->nr_controls = nr_controls; -platform_set_drvdata (pdev, data); -return devm_reset_controller_register (dev, &data->rcdev); } --2.34.1
Quoted 6 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.Signed-off-by Andrei Coardos <[email protected]>
Thank you, applied to reset/next.
regards
Philipp