Skip to contentSkip to conversation

dt-bindings: platform: Add bindings for Lenovo Yoga Slim 7x EC

PATCH In review Maya Matuszczyk 7 participants 11 messages Sep 27, 2024 – Oct 1, 2024

Subsystems (5)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support x86 platform drivers +1 more subsystems
lore
Share & tools
lore

Maya Matuszczyk

author
#0 lore raw

PATCH 1/3 dt-bindings: platform: Add bindings for Lenovo Yoga Slim 7x EC

This patch adds devicetree binding documentation for Lenovo Yoga Slim 7x EC driver.

Signed-off-by Maya Matuszczyk <[email protected]>
---
 .../platform/lenovo,yoga-slim7x-ec.yaml       | 50 +++++++++++++++++++
 MAINTAINERS                                   |  5 ++
 2 files changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml
Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml new file +50 -0
new file mode 100644
index 000000000000..32f8a0b5d667
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/platform/lenovo,yoga-slim7x-ec.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Lenovo Yoga Slim 7x Embedded Controller.
+
+maintainers:
+  - Maya Matuszczyk <[email protected]>
+
+description:
+  The Lenovo Yoga Slim 7x has an EC which handles some minor functions, like
+  power LED or some special keys on the keyboard. This bindings describes
+  how it is connected
+
+properties:
+  compatible:
+    const: lenovo,yoga-slim7x-ec
+
+  reg:
+    const: 0x76
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |+
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c5 {
+        clock-frequency = <400000>;
+
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        embedded-controller@76 {
+            compatible = "lenovo,yoga-slim7x-ec";
+            reg = <0x76>;
+
+            interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_HIGH>;
+        };
+    };
+...
MAINTAINERS +5 -0
index 00716c1faff6..0d4bfdde166d 100644
@@ -12902,6 +12902,11 @@ S:	Maintained
 W:	http://legousb.sourceforge.net/
 F:	drivers/usb/misc/legousbtower.c
 
+LENOVO YOGA SLIM 7X EC DRIVER
+M:	Maya Matuszczyk <[email protected]>
+S:	Maintained
+F:	Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml
+
 LETSKETCH HID TABLET DRIVER
 M:	Hans de Goede <[email protected]>
 L:	[email protected]
Signature · 1 line
2.45.2
author
#1 lore raw

PATCH 2/3 platform: arm64: Add driver for Lenovo Yoga Slim 7x's EC

This patch adds a basic driver for the EC in Qualcomm Snapdragon X1 Elite-based Lenovo Yoga Slim 7x.

For now it supports only reporting that the AP is going to suspend and the microphone mute button, however the EC seems to also support reading fan information, other key combinations and thermal data.

Signed-off-by Maya Matuszczyk <[email protected]>
---
 MAINTAINERS                                 |   1 +
 drivers/platform/arm64/Kconfig              |  12 ++
 drivers/platform/arm64/Makefile             |   1 +
 drivers/platform/arm64/lenovo-yoga-slim7x.c | 202 ++++++++++++++++++++
 4 files changed, 216 insertions(+)
 create mode 100644 drivers/platform/arm64/lenovo-yoga-slim7x.c
MAINTAINERS +1 -0
index 0d4bfdde166d..f689cba80fa3 100644
@@ -12906,6 +12906,7 @@ LENOVO YOGA SLIM 7X EC DRIVER
 M:	Maya Matuszczyk <[email protected]>
 S:	Maintained
 F:	Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml
+F:	drivers/platform/arm64/lenovo-yoga-slim7x.c
 
 LETSKETCH HID TABLET DRIVER
 M:	Hans de Goede <[email protected]>
drivers/platform/arm64/Kconfig +12 -0
index f88395ea3376..9ceae50f8b4e 100644
@@ -49,4 +49,16 @@ config EC_LENOVO_YOGA_C630
 
 	  Say M or Y here to include this support.
 
+config EC_LENOVO_YOGA_SLIM7X
+	tristate "Lenovo Yoga Slim 7x Embedded Controller driver"
+	depends on ARCH_QCOM || COMPILE_TEST
+	depends on I2C
+	help
+	  Select this option to enable driver for the EC found in the Lenovo
+	  Yoga Slim 7x.
+
+	  This driver currently supports reporting input event for microphone
+	  mute button, and reporting device suspend to the EC so it can take
+	  appropriate actions.
+
 endif # ARM64_PLATFORM_DEVICES
drivers/platform/arm64/Makefile +1 -0
index b2ae9114fdd8..70dfc1fb979d 100644
@@ -7,3 +7,4 @@
 
 obj-$(CONFIG_EC_ACER_ASPIRE1)	+= acer-aspire1-ec.o
 obj-$(CONFIG_EC_LENOVO_YOGA_C630) += lenovo-yoga-c630.o
+obj-$(CONFIG_EC_LENOVO_YOGA_SLIM7X) += lenovo-yoga-slim7x.o
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +202 -0

202 lines not on this page · raw message

Signature · 1 line
2.45.2
Tested-by on v1 2/3
#2 lore raw

Re: [PATCH 2/3] platform: arm64: Add driver for Lenovo Yoga Slim 7x's EC

Dear Maya,

Quoted 3 lines

For now it supports only reporting that the AP is going to suspend and the microphone mute button, however the EC seems to also support reading fan information, other key combinations and thermal data.

I tested the following:
- When I suspend the laptop, the keyboard backlight turns off, and the power button LED starts blinking.
- When I press the Fn+F4 key combo, the KEY_MICMUTE event is correctly reported to userspace.

drivers/platform/arm64/lenovo-yoga-slim7x.c line 33

Quoted 3 lines
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +2 -0
+// These are the registers that i know about available from SMBUS
 
+// These are the values in EC_IRQ_REASON_REG that i could find in DSDT

Nitpick: capitalize "I" if you create a v2

Tested-by György Kurucz <[email protected]>

Best regards,
György

#3 lore raw

Re: [PATCH 2/3] platform: arm64: Add driver for Lenovo Yoga Slim 7x's EC

In reply to Maya Matuszczyk

Hi Maya,

Thank you for your patch. It is great to so people working on supporting more ARM64 based laptop ECs.

Note not a full review just one remark from a quick scan of the driver.

Quoted 143 lines · Maya Matuszczyk

This patch adds a basic driver for the EC in Qualcomm Snapdragon X1 Elite-based Lenovo Yoga Slim 7x.

For now it supports only reporting that the AP is going to suspend and the microphone mute button, however the EC seems to also support reading fan information, other key combinations and thermal data.

Signed-off-by Maya Matuszczyk <[email protected]>
---
 MAINTAINERS                                 |   1 +
 drivers/platform/arm64/Kconfig              |  12 ++
 drivers/platform/arm64/Makefile             |   1 +
 drivers/platform/arm64/lenovo-yoga-slim7x.c | 202 ++++++++++++++++++++
 4 files changed, 216 insertions(+)
 create mode 100644 drivers/platform/arm64/lenovo-yoga-slim7x.c
MAINTAINERS +1 -0
index 0d4bfdde166d..f689cba80fa3 100644
@@ -12906,6 +12906,7 @@ LENOVO YOGA SLIM 7X EC DRIVER
 M:	Maya Matuszczyk <[email protected]>
 S:	Maintained
 F:	Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml
+F:	drivers/platform/arm64/lenovo-yoga-slim7x.c
 
 LETSKETCH HID TABLET DRIVER
 M:	Hans de Goede <[email protected]>
drivers/platform/arm64/Kconfig +12 -0
index f88395ea3376..9ceae50f8b4e 100644
@@ -49,4 +49,16 @@ config EC_LENOVO_YOGA_C630
 
 	  Say M or Y here to include this support.
 
+config EC_LENOVO_YOGA_SLIM7X
+	tristate "Lenovo Yoga Slim 7x Embedded Controller driver"
+	depends on ARCH_QCOM || COMPILE_TEST
+	depends on I2C
+	help
+	  Select this option to enable driver for the EC found in the Lenovo
+	  Yoga Slim 7x.
+
+	  This driver currently supports reporting input event for microphone
+	  mute button, and reporting device suspend to the EC so it can take
+	  appropriate actions.
+
 endif # ARM64_PLATFORM_DEVICES
drivers/platform/arm64/Makefile +1 -0
index b2ae9114fdd8..70dfc1fb979d 100644
@@ -7,3 +7,4 @@
 
 obj-$(CONFIG_EC_ACER_ASPIRE1)	+= acer-aspire1-ec.o
 obj-$(CONFIG_EC_LENOVO_YOGA_C630) += lenovo-yoga-c630.o
+obj-$(CONFIG_EC_LENOVO_YOGA_SLIM7X) += lenovo-yoga-slim7x.o
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +79 -0
new file mode 100644
index 000000000000..8f6d523395bc
@@ -0,0 +1,202 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (c) 2024 Maya Matuszczyk <[email protected]>
+ */
+#include <linux/auxiliary_bus.h>
+#include <linux/cleanup.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/i2c.h>
+#include <linux/irqreturn.h>
+#include <linux/lockdep.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/notifier.h>
+#include <linux/slab.h>
+#include <linux/input.h>
+//#include <linux/platform_data/lenovo-yoga-slim7x.h>
+
+// These are the registers that i know about available from SMBUS
+#define EC_IRQ_REASON_REG 0x05
+#define EC_SUSPEND_RESUME_REG 0x23
+#define EC_IRQ_ENABLE_REG 0x35
+#define EC_BACKLIGHT_STATUS_REG 0x83
+#define EC_MIC_MUTE_LED_REG 0x84
+#define EC_AC_STATUS_REG 0x90
+
+// Valid values for EC_SUSPEND_RESUME_REG
+#define EC_NOTIFY_SUSPEND_ENTER 0x01
+#define EC_NOTIFY_SUSPEND_EXIT 0x00
+#define EC_NOTIFY_SCREEN_OFF 0x03
+#define EC_NOTIFY_SCREEN_ON 0x04
+
+// These are the values in EC_IRQ_REASON_REG that i could find in DSDT
+#define EC_IRQ_MICMUTE_BUTTON 0x04
+#define EC_IRQ_FAN1_STATUS_CHANGE 0x30
+#define EC_IRQ_FAN2_STATUS_CHANGE 0x31
+#define EC_IRQ_FAN1_SPEED_CHANGE 0x32
+#define EC_IRQ_FAN2_SPEED_CHANGE 0x33
+#define EC_IRQ_COMPLETED_LUT_UPDATE 0x34
+#define EC_IRQ_COMPLETED_FAN_PROFILE_SWITCH 0x35
+#define EC_IRQ_THERMISTOR_1_TEMP_THRESHOLD_CROSS 0x36
+#define EC_IRQ_THERMISTOR_2_TEMP_THRESHOLD_CROSS 0x37
+#define EC_IRQ_THERMISTOR_3_TEMP_THRESHOLD_CROSS 0x38
+#define EC_IRQ_THERMISTOR_4_TEMP_THRESHOLD_CROSS 0x39
+#define EC_IRQ_THERMISTOR_5_TEMP_THRESHOLD_CROSS 0x3a
+#define EC_IRQ_THERMISTOR_6_TEMP_THRESHOLD_CROSS 0x3b
+#define EC_IRQ_THERMISTOR_7_TEMP_THRESHOLD_CROSS 0x3c
+#define EC_IRQ_RECOVERED_FROM_RESET 0x3d
+#define EC_IRQ_LENOVO_SUPPORT_KEY 0x90
+#define EC_IRQ_FN_Q 0x91
+#define EC_IRQ_FN_M 0x92
+#define EC_IRQ_FN_SPACE 0x93
+#define EC_IRQ_FN_R 0x94
+#define EC_IRQ_FNLOCK_ON 0x95
+#define EC_IRQ_FNLOCK_OFF 0x96
+#define EC_IRQ_FN_N 0x97
+#define EC_IRQ_AI 0x9a
+#define EC_IRQ_NPU 0x9b
+
+struct yoga_slim7x_ec {
+	struct i2c_client *client;
+	struct input_dev *idev;
+	struct mutex lock;
+};
+
+static irqreturn_t yoga_slim7x_ec_irq(int irq, void *data)
+{
+	struct yoga_slim7x_ec *ec = data;
+	struct device *dev = &ec->client->dev;
+	int val;
+
+	guard(mutex)(&ec->lock);
+
+	val = i2c_smbus_read_byte_data(ec->client, EC_IRQ_REASON_REG);
+	if (val < 0) {
+		dev_err(dev, "Failed to get EC IRQ reason: %d\n", val);
+		return IRQ_HANDLED;
+	}
+

drivers/platform/arm64/lenovo-yoga-slim7x.c line 89

Quoted 10 lines
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +10 -0
+	switch (val) {
+	case EC_IRQ_MICMUTE_BUTTON:
+		input_report_key(ec->idev, KEY_MICMUTE, 1);
+		input_sync(ec->idev);
+		input_report_key(ec->idev, KEY_MICMUTE, 0);
+		input_sync(ec->idev);
+		break;
+	default:
+		dev_info(dev, "Unhandled EC IRQ reason: %d\n", val);
+	}

I strongly suggest to use include/linux/input/sparse-keymap.h functionality here. This will make adding new keys a lot easier and will allow re-mapping codes from userspace.

E.g. replace the whole switch-case with:

	if (!sparse_keymap_report_event(ec->idev, val, 1, true))
		dev_info(dev, "Unhandled EC IRQ reason: %d\n", val);

This takes care of mapping val -> KEY_MICMUTE, and doing all the reporting (after calling sparse_keymap_setup() with an appropriate keymap from probe()).

Quoted 13 lines
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +13 -0
+
+	return IRQ_HANDLED;
+}
+
+static int yoga_slim7x_ec_probe(struct i2c_client *client)
+{
+	struct device *dev = &client->dev;
+	struct yoga_slim7x_ec *ec;
+	int ret;
+
+	ec = devm_kzalloc(dev, sizeof(*ec), GFP_KERNEL);
+	if (!ec)
+		return -ENOMEM;

drivers/platform/arm64/lenovo-yoga-slim7x.c line 112

Quoted 10 lines
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +10 -0
+
+	mutex_init(&ec->lock);
+	ec->client = client;
+
+	ec->idev = devm_input_allocate_device(dev);
+	if (!ec->idev)
+		return -ENOMEM;
+	ec->idev->name = "yoga-slim7x-ec";
+	ec->idev->phys = "yoga-slim7x-ec/input0";
+	input_set_capability(ec->idev, EV_KEY, KEY_MICMUTE);

Same here, please use sparse_keymap_setup() here to have it setup capabilities for all keys in your (to be defined)

const struct key_entry yoga_slim7x_ec_keymap[]

This way you only need to add new mappings in the keymap and then both the capability setting as well as the reporting in the irq-handler will be taken care of by the sparse-keymap helpers.

Other then that the overall structure of the driver looks good (again this is not a full review, just a quick scan).

Regards,

Hans

Quoted 90 lines
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +90 -0
+
+	ret = input_register_device(ec->idev);
+	if (ret < 0)
+		return dev_err_probe(dev, ret, "Failed to register input device\n");
+
+	ret = devm_request_threaded_irq(dev, client->irq,
+					NULL, yoga_slim7x_ec_irq,
+					IRQF_ONESHOT, "yoga_slim7x_ec", ec);
+	if (ret < 0)
+		return dev_err_probe(dev, ret, "Unable to request irq\n");
+
+	ret = i2c_smbus_write_byte_data(client, EC_IRQ_ENABLE_REG, 0x01);
+	if (ret < 0)
+		return dev_err_probe(dev, ret, "Failed to enable interrupts\n");
+
+	return 0;
+}
+
+static void yoga_slim7x_ec_remove(struct i2c_client *client)
+{
+	struct device *dev = &client->dev;
+	int ret;
+
+	ret = i2c_smbus_write_byte_data(client, EC_IRQ_ENABLE_REG, 0x00);
+	if (ret < 0)
+		dev_err(dev, "Failed to disable interrupts: %d\n", ret);
+}
+
+static int yoga_slim7x_ec_suspend(struct device *dev)
+{
+	struct i2c_client *client = to_i2c_client(dev);
+	int ret;
+
+	ret = i2c_smbus_write_byte_data(client, EC_SUSPEND_RESUME_REG, EC_NOTIFY_SCREEN_OFF);
+	if (ret)
+		return ret;
+
+	ret = i2c_smbus_write_byte_data(client, EC_SUSPEND_RESUME_REG, EC_NOTIFY_SUSPEND_ENTER);
+	if (ret)
+		return ret;
+
+	return 0;
+}
+
+static int yoga_slim7x_ec_resume(struct device *dev)
+{
+	struct i2c_client *client = to_i2c_client(dev);
+	int ret;
+
+	ret = i2c_smbus_write_byte_data(client, EC_SUSPEND_RESUME_REG, EC_NOTIFY_SUSPEND_EXIT);
+	if (ret)
+		return ret;
+
+	ret = i2c_smbus_write_byte_data(client, EC_SUSPEND_RESUME_REG, EC_NOTIFY_SCREEN_ON);
+	if (ret)
+		return ret;
+
+	return 0;
+}
+
+static const struct of_device_id yoga_slim7x_ec_of_match[] = {
+	{ .compatible = "lenovo,yoga-slim7x-ec" },
+	{}
+};
+MODULE_DEVICE_TABLE(of, yoga_slim7x_ec_of_match);
+
+static const struct i2c_device_id yoga_slim7x_ec_i2c_id_table[] = {
+	{ "yoga-slim7x-ec", },
+	{}
+};
+MODULE_DEVICE_TABLE(i2c, yoga_slim7x_ec_i2c_id_table);
+
+static DEFINE_SIMPLE_DEV_PM_OPS(yoga_slim7x_ec_pm_ops,
+		yoga_slim7x_ec_suspend,
+		yoga_slim7x_ec_resume);
+
+static struct i2c_driver yoga_slim7x_ec_i2c_driver = {
+	.driver = {
+		.name = "yoga-slim7x-ec",
+		.of_match_table = yoga_slim7x_ec_of_match,
+		.pm = &yoga_slim7x_ec_pm_ops
+	},
+	.probe = yoga_slim7x_ec_probe,
+	.remove = yoga_slim7x_ec_remove,
+	.id_table = yoga_slim7x_ec_i2c_id_table,
+};
+module_i2c_driver(yoga_slim7x_ec_i2c_driver);
+
+MODULE_DESCRIPTION("Lenovo Yoga Slim 7x Embedded Controller");
+MODULE_LICENSE("GPL");
author
#4 lore raw

Re: [PATCH 2/3] platform: arm64: Add driver for Lenovo Yoga Slim 7x's EC

Hi, thanks for taking a look at this driver.

sob., 28 wrz 2024 o 17:53 Hans de Goede <[email protected]> napisał(a):

Quoted 167 lines

Hi Maya,

Thank you for your patch. It is great to so people working on supporting more ARM64 based laptop ECs.

Note not a full review just one remark from a quick scan of the driver.

Quoted 143 lines · Maya Matuszczyk

This patch adds a basic driver for the EC in Qualcomm Snapdragon X1 Elite-based Lenovo Yoga Slim 7x.

For now it supports only reporting that the AP is going to suspend and the microphone mute button, however the EC seems to also support reading fan information, other key combinations and thermal data.

Signed-off-by Maya Matuszczyk <[email protected]>
---
 MAINTAINERS                                 |   1 +
 drivers/platform/arm64/Kconfig              |  12 ++
 drivers/platform/arm64/Makefile             |   1 +
 drivers/platform/arm64/lenovo-yoga-slim7x.c | 202 ++++++++++++++++++++
 4 files changed, 216 insertions(+)
 create mode 100644 drivers/platform/arm64/lenovo-yoga-slim7x.c
MAINTAINERS +1 -0
index 0d4bfdde166d..f689cba80fa3 100644
@@ -12906,6 +12906,7 @@ LENOVO YOGA SLIM 7X EC DRIVER
 M:   Maya Matuszczyk <[email protected]>
 S:   Maintained
 F:   Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml
+F:   drivers/platform/arm64/lenovo-yoga-slim7x.c
 
 LETSKETCH HID TABLET DRIVER
 M:   Hans de Goede <[email protected]>
drivers/platform/arm64/Kconfig +12 -0
index f88395ea3376..9ceae50f8b4e 100644
@@ -49,4 +49,16 @@ config EC_LENOVO_YOGA_C630
 
        Say M or Y here to include this support.
 
+config EC_LENOVO_YOGA_SLIM7X
+     tristate "Lenovo Yoga Slim 7x Embedded Controller driver"
+     depends on ARCH_QCOM || COMPILE_TEST
+     depends on I2C
+     help
+       Select this option to enable driver for the EC found in the Lenovo
+       Yoga Slim 7x.
+
+       This driver currently supports reporting input event for microphone
+       mute button, and reporting device suspend to the EC so it can take
+       appropriate actions.
+
 endif # ARM64_PLATFORM_DEVICES
drivers/platform/arm64/Makefile +1 -0
index b2ae9114fdd8..70dfc1fb979d 100644
@@ -7,3 +7,4 @@
 
 obj-$(CONFIG_EC_ACER_ASPIRE1)        += acer-aspire1-ec.o
 obj-$(CONFIG_EC_LENOVO_YOGA_C630) += lenovo-yoga-c630.o
+obj-$(CONFIG_EC_LENOVO_YOGA_SLIM7X) += lenovo-yoga-slim7x.o
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +79 -0
new file mode 100644
index 000000000000..8f6d523395bc
@@ -0,0 +1,202 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (c) 2024 Maya Matuszczyk <[email protected]>
+ */
+#include <linux/auxiliary_bus.h>
+#include <linux/cleanup.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/i2c.h>
+#include <linux/irqreturn.h>
+#include <linux/lockdep.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/notifier.h>
+#include <linux/slab.h>
+#include <linux/input.h>
+//#include <linux/platform_data/lenovo-yoga-slim7x.h>
+
+// These are the registers that i know about available from SMBUS
+#define EC_IRQ_REASON_REG 0x05
+#define EC_SUSPEND_RESUME_REG 0x23
+#define EC_IRQ_ENABLE_REG 0x35
+#define EC_BACKLIGHT_STATUS_REG 0x83
+#define EC_MIC_MUTE_LED_REG 0x84
+#define EC_AC_STATUS_REG 0x90
+
+// Valid values for EC_SUSPEND_RESUME_REG
+#define EC_NOTIFY_SUSPEND_ENTER 0x01
+#define EC_NOTIFY_SUSPEND_EXIT 0x00
+#define EC_NOTIFY_SCREEN_OFF 0x03
+#define EC_NOTIFY_SCREEN_ON 0x04
+
+// These are the values in EC_IRQ_REASON_REG that i could find in DSDT
+#define EC_IRQ_MICMUTE_BUTTON 0x04
+#define EC_IRQ_FAN1_STATUS_CHANGE 0x30
+#define EC_IRQ_FAN2_STATUS_CHANGE 0x31
+#define EC_IRQ_FAN1_SPEED_CHANGE 0x32
+#define EC_IRQ_FAN2_SPEED_CHANGE 0x33
+#define EC_IRQ_COMPLETED_LUT_UPDATE 0x34
+#define EC_IRQ_COMPLETED_FAN_PROFILE_SWITCH 0x35
+#define EC_IRQ_THERMISTOR_1_TEMP_THRESHOLD_CROSS 0x36
+#define EC_IRQ_THERMISTOR_2_TEMP_THRESHOLD_CROSS 0x37
+#define EC_IRQ_THERMISTOR_3_TEMP_THRESHOLD_CROSS 0x38
+#define EC_IRQ_THERMISTOR_4_TEMP_THRESHOLD_CROSS 0x39
+#define EC_IRQ_THERMISTOR_5_TEMP_THRESHOLD_CROSS 0x3a
+#define EC_IRQ_THERMISTOR_6_TEMP_THRESHOLD_CROSS 0x3b
+#define EC_IRQ_THERMISTOR_7_TEMP_THRESHOLD_CROSS 0x3c
+#define EC_IRQ_RECOVERED_FROM_RESET 0x3d
+#define EC_IRQ_LENOVO_SUPPORT_KEY 0x90
+#define EC_IRQ_FN_Q 0x91
+#define EC_IRQ_FN_M 0x92
+#define EC_IRQ_FN_SPACE 0x93
+#define EC_IRQ_FN_R 0x94
+#define EC_IRQ_FNLOCK_ON 0x95
+#define EC_IRQ_FNLOCK_OFF 0x96
+#define EC_IRQ_FN_N 0x97
+#define EC_IRQ_AI 0x9a
+#define EC_IRQ_NPU 0x9b
+
+struct yoga_slim7x_ec {
+     struct i2c_client *client;
+     struct input_dev *idev;
+     struct mutex lock;
+};
+
+static irqreturn_t yoga_slim7x_ec_irq(int irq, void *data)
+{
+     struct yoga_slim7x_ec *ec = data;
+     struct device *dev = &ec->client->dev;
+     int val;
+
+     guard(mutex)(&ec->lock);
+
+     val = i2c_smbus_read_byte_data(ec->client, EC_IRQ_REASON_REG);
+     if (val < 0) {
+             dev_err(dev, "Failed to get EC IRQ reason: %d\n", val);
+             return IRQ_HANDLED;
+     }
+

drivers/platform/arm64/lenovo-yoga-slim7x.c line 89

Quoted 10 lines
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +10 -0
+     switch (val) {
+     case EC_IRQ_MICMUTE_BUTTON:
+             input_report_key(ec->idev, KEY_MICMUTE, 1);
+             input_sync(ec->idev);
+             input_report_key(ec->idev, KEY_MICMUTE, 0);
+             input_sync(ec->idev);
+             break;
+     default:
+             dev_info(dev, "Unhandled EC IRQ reason: %d\n", val);
+     }

I strongly suggest to use include/linux/input/sparse-keymap.h functionality here. This will make adding new keys a lot easier and will allow re-mapping codes from userspace.

Quoted 8 lines

E.g. replace the whole switch-case with:

        if (!sparse_keymap_report_event(ec->idev, val, 1, true))
                dev_info(dev, "Unhandled EC IRQ reason: %d\n", val);

This takes care of mapping val -> KEY_MICMUTE, and doing all the reporting (after calling sparse_keymap_setup() with an appropriate keymap from probe())

Thank you for the suggestion. I'm not sure how to handle the non-key related IRQs, like fan status changes.
Do you think they should be filtered out like this:
if (val == 0x04 || (val >= 0x90 && val <= 0x97))

Best Regards,
Maya Matuszczyk.

Quoted 139 lines
Quoted 16 lines
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +13 -0
+
+     return IRQ_HANDLED;
+}
+
+static int yoga_slim7x_ec_probe(struct i2c_client *client)
+{
+     struct device *dev = &client->dev;
+     struct yoga_slim7x_ec *ec;
+     int ret;
+
+     ec = devm_kzalloc(dev, sizeof(*ec), GFP_KERNEL);
+     if (!ec)
+             return -ENOMEM;

drivers/platform/arm64/lenovo-yoga-slim7x.c line 112

Quoted 10 lines
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +10 -0
+
+     mutex_init(&ec->lock);
+     ec->client = client;
+
+     ec->idev = devm_input_allocate_device(dev);
+     if (!ec->idev)
+             return -ENOMEM;
+     ec->idev->name = "yoga-slim7x-ec";
+     ec->idev->phys = "yoga-slim7x-ec/input0";
+     input_set_capability(ec->idev, EV_KEY, KEY_MICMUTE);

Same here, please use sparse_keymap_setup() here to have it setup capabilities for all keys in your (to be defined)

const struct key_entry yoga_slim7x_ec_keymap[]

This way you only need to add new mappings in the keymap and then both the capability setting as well as the reporting in the irq-handler will be taken care of by the sparse-keymap helpers.

Other then that the overall structure of the driver looks good (again this is not a full review, just a quick scan).

Regards,

Hans

Quoted 90 lines
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +90 -0
+
+     ret = input_register_device(ec->idev);
+     if (ret < 0)
+             return dev_err_probe(dev, ret, "Failed to register input device\n");
+
+     ret = devm_request_threaded_irq(dev, client->irq,
+                                     NULL, yoga_slim7x_ec_irq,
+                                     IRQF_ONESHOT, "yoga_slim7x_ec", ec);
+     if (ret < 0)
+             return dev_err_probe(dev, ret, "Unable to request irq\n");
+
+     ret = i2c_smbus_write_byte_data(client, EC_IRQ_ENABLE_REG, 0x01);
+     if (ret < 0)
+             return dev_err_probe(dev, ret, "Failed to enable interrupts\n");
+
+     return 0;
+}
+
+static void yoga_slim7x_ec_remove(struct i2c_client *client)
+{
+     struct device *dev = &client->dev;
+     int ret;
+
+     ret = i2c_smbus_write_byte_data(client, EC_IRQ_ENABLE_REG, 0x00);
+     if (ret < 0)
+             dev_err(dev, "Failed to disable interrupts: %d\n", ret);
+}
+
+static int yoga_slim7x_ec_suspend(struct device *dev)
+{
+     struct i2c_client *client = to_i2c_client(dev);
+     int ret;
+
+     ret = i2c_smbus_write_byte_data(client, EC_SUSPEND_RESUME_REG, EC_NOTIFY_SCREEN_OFF);
+     if (ret)
+             return ret;
+
+     ret = i2c_smbus_write_byte_data(client, EC_SUSPEND_RESUME_REG, EC_NOTIFY_SUSPEND_ENTER);
+     if (ret)
+             return ret;
+
+     return 0;
+}
+
+static int yoga_slim7x_ec_resume(struct device *dev)
+{
+     struct i2c_client *client = to_i2c_client(dev);
+     int ret;
+
+     ret = i2c_smbus_write_byte_data(client, EC_SUSPEND_RESUME_REG, EC_NOTIFY_SUSPEND_EXIT);
+     if (ret)
+             return ret;
+
+     ret = i2c_smbus_write_byte_data(client, EC_SUSPEND_RESUME_REG, EC_NOTIFY_SCREEN_ON);
+     if (ret)
+             return ret;
+
+     return 0;
+}
+
+static const struct of_device_id yoga_slim7x_ec_of_match[] = {
+     { .compatible = "lenovo,yoga-slim7x-ec" },
+     {}
+};
+MODULE_DEVICE_TABLE(of, yoga_slim7x_ec_of_match);
+
+static const struct i2c_device_id yoga_slim7x_ec_i2c_id_table[] = {
+     { "yoga-slim7x-ec", },
+     {}
+};
+MODULE_DEVICE_TABLE(i2c, yoga_slim7x_ec_i2c_id_table);
+
+static DEFINE_SIMPLE_DEV_PM_OPS(yoga_slim7x_ec_pm_ops,
+             yoga_slim7x_ec_suspend,
+             yoga_slim7x_ec_resume);
+
+static struct i2c_driver yoga_slim7x_ec_i2c_driver = {
+     .driver = {
+             .name = "yoga-slim7x-ec",
+             .of_match_table = yoga_slim7x_ec_of_match,
+             .pm = &yoga_slim7x_ec_pm_ops
+     },
+     .probe = yoga_slim7x_ec_probe,
+     .remove = yoga_slim7x_ec_remove,
+     .id_table = yoga_slim7x_ec_i2c_id_table,
+};
+module_i2c_driver(yoga_slim7x_ec_i2c_driver);
+
+MODULE_DESCRIPTION("Lenovo Yoga Slim 7x Embedded Controller");
+MODULE_LICENSE("GPL");
#5 lore raw

Re: [PATCH 2/3] platform: arm64: Add driver for Lenovo Yoga Slim 7x's EC

Hi,

Quoted 175 lines · Maya Matuszczyk

Hi, thanks for taking a look at this driver.

sob., 28 wrz 2024 o 17:53 Hans de Goede <[email protected]> napisał(a):

Quoted 172 lines

Hi Maya,

Thank you for your patch. It is great to so people working on supporting more ARM64 based laptop ECs.

Note not a full review just one remark from a quick scan of the driver.

Quoted 143 lines · Maya Matuszczyk

This patch adds a basic driver for the EC in Qualcomm Snapdragon X1 Elite-based Lenovo Yoga Slim 7x.

For now it supports only reporting that the AP is going to suspend and the microphone mute button, however the EC seems to also support reading fan information, other key combinations and thermal data.

Signed-off-by Maya Matuszczyk <[email protected]>
---
 MAINTAINERS                                 |   1 +
 drivers/platform/arm64/Kconfig              |  12 ++
 drivers/platform/arm64/Makefile             |   1 +
 drivers/platform/arm64/lenovo-yoga-slim7x.c | 202 ++++++++++++++++++++
 4 files changed, 216 insertions(+)
 create mode 100644 drivers/platform/arm64/lenovo-yoga-slim7x.c
MAINTAINERS +1 -0
index 0d4bfdde166d..f689cba80fa3 100644
@@ -12906,6 +12906,7 @@ LENOVO YOGA SLIM 7X EC DRIVER
 M:   Maya Matuszczyk <[email protected]>
 S:   Maintained
 F:   Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml
+F:   drivers/platform/arm64/lenovo-yoga-slim7x.c
 
 LETSKETCH HID TABLET DRIVER
 M:   Hans de Goede <[email protected]>
drivers/platform/arm64/Kconfig +12 -0
index f88395ea3376..9ceae50f8b4e 100644
@@ -49,4 +49,16 @@ config EC_LENOVO_YOGA_C630
 
        Say M or Y here to include this support.
 
+config EC_LENOVO_YOGA_SLIM7X
+     tristate "Lenovo Yoga Slim 7x Embedded Controller driver"
+     depends on ARCH_QCOM || COMPILE_TEST
+     depends on I2C
+     help
+       Select this option to enable driver for the EC found in the Lenovo
+       Yoga Slim 7x.
+
+       This driver currently supports reporting input event for microphone
+       mute button, and reporting device suspend to the EC so it can take
+       appropriate actions.
+
 endif # ARM64_PLATFORM_DEVICES
drivers/platform/arm64/Makefile +1 -0
index b2ae9114fdd8..70dfc1fb979d 100644
@@ -7,3 +7,4 @@
 
 obj-$(CONFIG_EC_ACER_ASPIRE1)        += acer-aspire1-ec.o
 obj-$(CONFIG_EC_LENOVO_YOGA_C630) += lenovo-yoga-c630.o
+obj-$(CONFIG_EC_LENOVO_YOGA_SLIM7X) += lenovo-yoga-slim7x.o
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +79 -0
new file mode 100644
index 000000000000..8f6d523395bc
@@ -0,0 +1,202 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (c) 2024 Maya Matuszczyk <[email protected]>
+ */
+#include <linux/auxiliary_bus.h>
+#include <linux/cleanup.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/i2c.h>
+#include <linux/irqreturn.h>
+#include <linux/lockdep.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/notifier.h>
+#include <linux/slab.h>
+#include <linux/input.h>
+//#include <linux/platform_data/lenovo-yoga-slim7x.h>
+
+// These are the registers that i know about available from SMBUS
+#define EC_IRQ_REASON_REG 0x05
+#define EC_SUSPEND_RESUME_REG 0x23
+#define EC_IRQ_ENABLE_REG 0x35
+#define EC_BACKLIGHT_STATUS_REG 0x83
+#define EC_MIC_MUTE_LED_REG 0x84
+#define EC_AC_STATUS_REG 0x90
+
+// Valid values for EC_SUSPEND_RESUME_REG
+#define EC_NOTIFY_SUSPEND_ENTER 0x01
+#define EC_NOTIFY_SUSPEND_EXIT 0x00
+#define EC_NOTIFY_SCREEN_OFF 0x03
+#define EC_NOTIFY_SCREEN_ON 0x04
+
+// These are the values in EC_IRQ_REASON_REG that i could find in DSDT
+#define EC_IRQ_MICMUTE_BUTTON 0x04
+#define EC_IRQ_FAN1_STATUS_CHANGE 0x30
+#define EC_IRQ_FAN2_STATUS_CHANGE 0x31
+#define EC_IRQ_FAN1_SPEED_CHANGE 0x32
+#define EC_IRQ_FAN2_SPEED_CHANGE 0x33
+#define EC_IRQ_COMPLETED_LUT_UPDATE 0x34
+#define EC_IRQ_COMPLETED_FAN_PROFILE_SWITCH 0x35
+#define EC_IRQ_THERMISTOR_1_TEMP_THRESHOLD_CROSS 0x36
+#define EC_IRQ_THERMISTOR_2_TEMP_THRESHOLD_CROSS 0x37
+#define EC_IRQ_THERMISTOR_3_TEMP_THRESHOLD_CROSS 0x38
+#define EC_IRQ_THERMISTOR_4_TEMP_THRESHOLD_CROSS 0x39
+#define EC_IRQ_THERMISTOR_5_TEMP_THRESHOLD_CROSS 0x3a
+#define EC_IRQ_THERMISTOR_6_TEMP_THRESHOLD_CROSS 0x3b
+#define EC_IRQ_THERMISTOR_7_TEMP_THRESHOLD_CROSS 0x3c
+#define EC_IRQ_RECOVERED_FROM_RESET 0x3d
+#define EC_IRQ_LENOVO_SUPPORT_KEY 0x90
+#define EC_IRQ_FN_Q 0x91
+#define EC_IRQ_FN_M 0x92
+#define EC_IRQ_FN_SPACE 0x93
+#define EC_IRQ_FN_R 0x94
+#define EC_IRQ_FNLOCK_ON 0x95
+#define EC_IRQ_FNLOCK_OFF 0x96
+#define EC_IRQ_FN_N 0x97
+#define EC_IRQ_AI 0x9a
+#define EC_IRQ_NPU 0x9b
+
+struct yoga_slim7x_ec {
+     struct i2c_client *client;
+     struct input_dev *idev;
+     struct mutex lock;
+};
+
+static irqreturn_t yoga_slim7x_ec_irq(int irq, void *data)
+{
+     struct yoga_slim7x_ec *ec = data;
+     struct device *dev = &ec->client->dev;
+     int val;
+
+     guard(mutex)(&ec->lock);
+
+     val = i2c_smbus_read_byte_data(ec->client, EC_IRQ_REASON_REG);
+     if (val < 0) {
+             dev_err(dev, "Failed to get EC IRQ reason: %d\n", val);
+             return IRQ_HANDLED;
+     }
+

drivers/platform/arm64/lenovo-yoga-slim7x.c line 89

Quoted 10 lines
drivers/platform/arm64/lenovo-yoga-slim7x.c new file +10 -0
+     switch (val) {
+     case EC_IRQ_MICMUTE_BUTTON:
+             input_report_key(ec->idev, KEY_MICMUTE, 1);
+             input_sync(ec->idev);
+             input_report_key(ec->idev, KEY_MICMUTE, 0);
+             input_sync(ec->idev);
+             break;
+     default:
+             dev_info(dev, "Unhandled EC IRQ reason: %d\n", val);
+     }

I strongly suggest to use include/linux/input/sparse-keymap.h functionality here. This will make adding new keys a lot easier and will allow re-mapping codes from userspace.

E.g. replace the whole switch-case with:

        if (!sparse_keymap_report_event(ec->idev, val, 1, true))
                dev_info(dev, "Unhandled EC IRQ reason: %d\n", val);
Quoted 8 lines
Quoted 3 lines

This takes care of mapping val -> KEY_MICMUTE, and doing all the reporting (after calling sparse_keymap_setup() with an appropriate keymap from probe())

Thank you for the suggestion. I'm not sure how to handle the non-key related IRQs, like fan status changes.
Do you think they should be filtered out like this:
if (val == 0x04 || (val >= 0x90 && val <= 0x97))

Yes drivers like this typically first check for special values like above and then either do an early "return" or have a structure like this:

	if (val == special)
		...
	else if (val == other-special)
		...
	else {
	        if (!sparse_keymap_report_event(ec->idev, val, 1, true))
	                dev_info(dev, "Unhandled EC IRQ reason: %d\n", val);	
	}

The top-level if () ... else if () ... else may also be replaced with a switch () { case : ... case : ... }.

Note that if you just want to ignore the values you can also do this in the keymap and generally speaking that is better, only adding special cases like above if the driver actually needs to undertake some special action in response to the IRQ.

static const struct key_entry keymap[] = {
	{ KE_KEY, EC_IRQ_MICMUTE_BUTTON, { KEY_MICMUTE } },
	{ KE_IGNORE, 0x04, { KEY_RESERVED } }, /* Fan status change */
	{ KE_IGNORE, 0x90, { KEY_RESERVED } }, /* Fan status change */
	{ KE_IGNORE, 0x91, { KEY_RESERVED } }, /* Fan status change */
	{ KE_IGNORE, 0x92, { KEY_RESERVED } }, /* Fan status change */
	{ KE_IGNORE, 0x93, { KEY_RESERVED } }, /* Fan status change */
	{ KE_IGNORE, 0x94, { KEY_RESERVED } }, /* Fan status change */
	{ KE_IGNORE, 0x95, { KEY_RESERVED } }, /* Fan status change */
	{ KE_IGNORE, 0x96, { KEY_RESERVED } }, /* Fan status change */
	{ KE_IGNORE, 0x97, { KEY_RESERVED } }, /* Fan status change */
	{ KE_END }
};

In this case with the 0x90 - 0x97 range that is not really pretty, but it probably still is best to keep the code consistent.

Regards,

Hans

build bot
#6 lore raw

Re: [PATCH 2/3] platform: arm64: Add driver for Lenovo Yoga Slim 7x's EC

In reply to Maya Matuszczyk
kernel test robot noticed the following build errors:

Hi Maya,

kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.12-rc1 next-20241001] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Maya-Matuszczyk/platform-arm64-Add-driver-for-Lenovo-Yoga-Slim-7x-s-EC/20240928-025757
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20240927185345.3680-2-maccraft123mc%40gmail.com
patch subject: [PATCH 2/3] platform: arm64: Add driver for Lenovo Yoga Slim 7x's EC
config: sh-randconfig-002-20241001 (https://download.01.org/0day-ci/archive/20241001/[email protected]/config)
compiler: sh4-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241001/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> ERROR: modpost: "devm_input_allocate_device" [drivers/platform/arm64/lenovo-yoga-slim7x.ko] undefined!
>> ERROR: modpost: "input_register_device" [drivers/platform/arm64/lenovo-yoga-slim7x.ko] undefined!
>> ERROR: modpost: "input_set_capability" [drivers/platform/arm64/lenovo-yoga-slim7x.ko] undefined!
>> ERROR: modpost: "input_event" [drivers/platform/arm64/lenovo-yoga-slim7x.ko] undefined!
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
author
#7 lore raw

PATCH 3/3 arm64: dts: qcom: Add EC to Lenovo Yoga Slim 7x

In reply to Maya Matuszczyk

This device has an EC on i2c5 bus at address 0x76, driver for the EC was added in a previous patch.

Signed-off-by Maya Matuszczyk <[email protected]>
---
 .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts  | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +22 -0
index 3c13331a9ef4..63b627f60ec7 100644
@@ -536,6 +536,22 @@ keyboard@3a {
 	};
 };
 
+&i2c5 {
+	clock-frequency = <400000>;
+
+	status = "okay";
+
+	embedded-controller@76 {
+		compatible = "lenovo,yoga-slim7x-ec";
+		reg = <0x76>;
+
+		interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>;
+
+		pinctrl-0 = <&ec_int_n_default>;
+		pinctrl-names = "default";
+	};
+};
+
 &i2c8 {
 	clock-frequency = <400000>;
 

@@ -794,6 +810,12 @@ &tlmm {
 			       <44 4>, /* SPI (TPM) */
 			       <238 1>; /* UFS Reset */
 
+	ec_int_n_default: ec-int-n-state {
+		pins = "gpio66";
+		function = "gpio";
+		bias-disable;
+	};
+
 	edp_reg_en: edp-reg-en-state {
 		pins = "gpio70";
 		function = "gpio";
Signature · 1 line
2.45.2
maintainer
#8 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: Add EC to Lenovo Yoga Slim 7x

Quoted 3 lines · Maya Matuszczyk

This device has an EC on i2c5 bus at address 0x76, driver for the EC was added in a previous patch.

No concerns with this patch, but please Cc: at least all the mailing lists on each patch, so that I get all the patches in the series.

Or better yet, take a look at
https://b4.docs.kernel.org/en/latest/contributor/overview.html which magically handles this for you (b4 prep --auto-to-cc).

Regards,
Bjorn

Quoted 48 lines
Signed-off-by Maya Matuszczyk <[email protected]>
---
 .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts  | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +22 -0
index 3c13331a9ef4..63b627f60ec7 100644
@@ -536,6 +536,22 @@ keyboard@3a {
 	};
 };
 
+&i2c5 {
+	clock-frequency = <400000>;
+
+	status = "okay";
+
+	embedded-controller@76 {
+		compatible = "lenovo,yoga-slim7x-ec";
+		reg = <0x76>;
+
+		interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>;
+
+		pinctrl-0 = <&ec_int_n_default>;
+		pinctrl-names = "default";
+	};
+};
+
 &i2c8 {
 	clock-frequency = <400000>;
 

@@ -794,6 +810,12 @@ &tlmm {
 			       <44 4>, /* SPI (TPM) */
 			       <238 1>; /* UFS Reset */
 
+	ec_int_n_default: ec-int-n-state {
+		pins = "gpio66";
+		function = "gpio";
+		bias-disable;
+	};
+
 	edp_reg_en: edp-reg-en-state {
 		pins = "gpio70";
 		function = "gpio";
Signature · 1 line
2.45.2
maintainer
#10 lore raw
In reply to Maya Matuszczyk
Quoted 41 lines · Maya Matuszczyk

This patch adds devicetree binding documentation for Lenovo Yoga Slim 7x EC driver.

Signed-off-by Maya Matuszczyk <[email protected]>
---
 .../platform/lenovo,yoga-slim7x-ec.yaml       | 50 +++++++++++++++++++
 MAINTAINERS                                   |  5 ++
 2 files changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml
Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml new file +25 -0
new file mode 100644
index 000000000000..32f8a0b5d667
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/platform/lenovo,yoga-slim7x-ec.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Lenovo Yoga Slim 7x Embedded Controller.
+
+maintainers:
+  - Maya Matuszczyk <[email protected]>
+
+description:
+  The Lenovo Yoga Slim 7x has an EC which handles some minor functions, like
+  power LED or some special keys on the keyboard. This bindings describes
+  how it is connected
+
+properties:
+  compatible:
+    const: lenovo,yoga-slim7x-ec
+
+  reg:
+    const: 0x76
+
+  interrupts:
+    maxItems: 1

Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml line 35

Quoted 10 lines
Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml new file +10 -0
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |+

Drop the '+'

Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml line 37

Quoted 2 lines
Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml new file +2 -0
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c5 {

i2c {

Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml line 38

Quoted 1 line
Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml new file +1 -0
+        clock-frequency = <400000>;

Not really relevant for the example.

Quoted 31 lines
Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml new file +12 -0
+
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        embedded-controller@76 {
+            compatible = "lenovo,yoga-slim7x-ec";
+            reg = <0x76>;
+
+            interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_HIGH>;
+        };
+    };
+...
MAINTAINERS +5 -0
index 00716c1faff6..0d4bfdde166d 100644
@@ -12902,6 +12902,11 @@ S:	Maintained
 W:	http://legousb.sourceforge.net/
 F:	drivers/usb/misc/legousbtower.c
 
+LENOVO YOGA SLIM 7X EC DRIVER
+M:	Maya Matuszczyk <[email protected]>
+S:	Maintained
+F:	Documentation/devicetree/bindings/platform/lenovo,yoga-slim7x-ec.yaml
+
 LETSKETCH HID TABLET DRIVER
 M:	Hans de Goede <[email protected]>
 L:	[email protected]
Signature · 1 line
2.45.2