Skip to contentSkip to conversation

UDLFB: Make sure to get correct endian keys from vendor descriptor

PATCH Ben Collins 1 participant 1 message Feb 16, 2012 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

The driver was not using le16_to_cpu when reading keys from the vendor descriptor, causing incorrect parsing. Mainly, sku_pixel_limit was not being parsed on big-endian systems. This left udlfb most certainly broken on low level chips as the driver allows modes that are too high for the chip by default.

drivers/video/udlfb.c +1 -1
index a197731..0319593 100644
@@ -1537,7 +1537,7 @@ static int dlfb_parse_vendor_descriptor(struct dlfb_data *dev,
 			u8 length;
 			u16 key;
 
-			key = *((u16 *) desc);
+			key = le16_to_cpu(*((u16 *) desc));
 			desc += sizeof(u16);
 			length = *desc;
 			desc++;

--
Bluecherry: http://www.bluecherrydvr.com/
SwissDisk : http://www.swissdisk.com/
Ubuntu : http://www.ubuntu.com/
My Blog : http://ben-collins.blogspot.com/