KVM: x86: Fix warning due to implicit truncation on 32-bit KVM
PATCH 1/1 KVM: x86: Fix warning due to implicit truncation on 32-bit KVM
Explicitly cast the integer literal to an unsigned long when stuffing a non-canonical value into the host virtual address during private memslot deletion. The explicit cast fixes a warning that gets promoted to an error when running with KVM's newfangled -Werror setting.
arch/x86/kvm/x86.c:9739:9: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
--- arch/x86/kvm/x86.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
arch/x86/kvm/x86.c +6 -2
@@ -9735,8 +9735,12 @@ int __x86_set_memory_region(struct kvm *kvm, int id, gpa_t gpa, u32 size)if (!slot || !slot->npages)return 0 ; -/* Stuff a non-canonical value to catch use-after-delete. */ - hva =0xdeadull <<48 ; +/* +* Stuff a non-canonical value to catch use-after-delete. This +* ends up being 0 on 32-bit KVM, but there's no better +* alternative. +*/ + hva = (unsigned long )(0xdeadull <<48 ); old_npages = slot->npages; }
Signature · 1 line
2.24.1
Quoted 9 lines · Sean Christopherson
Explicitly cast the integer literal to an unsigned long when stuffing a non-canonical value into the host virtual address during private memslot deletion. The explicit cast fixes a warning that gets promoted to an error when running with KVM's newfangled -Werror setting.
arch/x86/kvm/x86.c:9739:9: error: large integer implicitly truncated to unsigned type [-Werror=overflow]Fixes a3e967c0b87d3 ("KVM: Terminate memslot walks via used_slots"
Missing ')'
Quoted 13 lines
Signed-off-by Sean Christopherson <[email protected]>--- arch/x86/kvm/x86.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)arch/x86/kvm/x86.c +0
-0@@ -9735,8 +9735,12 @@ int __x86_set_memory_region(struct kvm *kvm, int id, gpa_t gpa, u32 size)if (!slot || !slot->npages)return 0 ;
arch/x86/kvm/x86.c int __x86_set_memory_region(struct kvm *kvm, int id, gpa_t gpa, u32 size) · line 9745
Quoted 10 lines
arch/x86/kvm/x86.c +6
-2-/* Stuff a non-canonical value to catch use-after-delete. */ - hva =0xdeadull <<48 ; +/* +* Stuff a non-canonical value to catch use-after-delete. This +* ends up being 0 on 32-bit KVM, but there's no better +* alternative. +*/ + hva = (unsigned long )(0xdeadull <<48 ); old_npages = slot->npages; }
Signature · 1 line
Vitaly
Quoted 7 lines · Vitaly Kuznetsov
Quoted 5 lines · Sean Christopherson
Explicitly cast the integer literal to an unsigned long when stuffing a non-canonical value into the host virtual address during private memslot deletion. The explicit cast fixes a warning that gets promoted to an error when running with KVM's newfangled -Werror setting.
Quoted 6 lines
Quoted 4 lines
arch/x86/kvm/x86.c:9739:9: error: large integer implicitly truncated to unsigned type [-Werror=overflow]Fixes a3e967c0b87d3 ("KVM: Terminate memslot walks via used_slots"Missing ')'
Hrm, surprised checkpatch didn't catch that.
Quoted 24 lines · Sean Christopherson
Explicitly cast the integer literal to an unsigned long when stuffing a non-canonical value into the host virtual address during private memslot deletion. The explicit cast fixes a warning that gets promoted to an error when running with KVM's newfangled -Werror setting.
arch/x86/kvm/x86.c:9739:9: error: large integer implicitly truncated to unsigned type [-Werror=overflow]Fixes a3e967c0b87d3 ("KVM: Terminate memslot walks via used_slots"Signed-off-by Sean Christopherson <[email protected]>--- arch/x86/kvm/x86.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)arch/x86/kvm/x86.c +0
-1@@ -9735,8 +9735,12 @@ int __x86_set_memory_region(struct kvm *kvm, int id, gpa_t gpa, u32 size)if (!slot || !slot->npages)return 0 ; -/* Stuff a non-canonical value to catch use-after-delete. */
arch/x86/kvm/x86.c int __x86_set_memory_region(struct kvm *kvm, int id, gpa_t gpa, u32 size) · line 9746
Quoted 10 lines
arch/x86/kvm/x86.c +6
-1- hva =0xdeadull <<48 ; +/* +* Stuff a non-canonical value to catch use-after-delete. This +* ends up being 0 on 32-bit KVM, but there's no better +* alternative. +*/ + hva = (unsigned long )(0xdeadull <<48 ); old_npages = slot->npages; }
Queued, thanks.
Paolo