Skip to contentSkip to conversation

nvme sensors

DISCUSSION Vijay Khemka 6 participants 19 messages Apr 15, 2020 – Apr 17, 2020

lore
Share & tools
lore
#0 lore raw

Hi James,
Do we have support for NVME sensors in dbus sensors? I see phosphor-nvme repo which needs configuration from yaml file, is it possible to integrate this with entity manager?

Regards
-Vijay

#1 lore raw

Sorry, please ignore this, I found NVME in dbus-sensors. I needed to update repo in local workspace.

Regards
-Vijay

From: Vijay Khemka <[email protected]>
Date: Wednesday, April 15, 2020 at 5:07 AM
To: "[email protected]" <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: nvme sensors

Hi James,
Do we have support for NVME sensors in dbus sensors? I see phosphor-nvme repo which needs configuration from yaml file, is it possible to integrate this with entity manager?

Regards
-Vijay

#2 lore raw

Hi Vijay,

Are they implemented over MCTP over SMBUS?

Neeraj

From: openbmc <[email protected]> On Behalf Of Vijay Khemka
Sent: Wednesday, April 15, 2020 5:28 AM
To: [email protected]
Cc: [email protected]
Subject: [EXTERNAL] Re: nvme sensors

Sorry, please ignore this, I found NVME in dbus-sensors. I needed to update repo in local workspace.

Regards
-Vijay

From: Vijay Khemka <mailto:[email protected]>
Date: Wednesday, April 15, 2020 at 5:07 AM
To: "mailto:[email protected]" <mailto:[email protected]>
Cc: "mailto:[email protected]" <mailto:[email protected]>
Subject: nvme sensors

Hi James,
Do we have support for NVME sensors in dbus sensors? I see phosphor-nvme repo which needs configuration from yaml file, is it possible to integrate this with entity manager?
Regards
-Vijay

#3 lore raw

Yes there is a support for MCTP also in code but I have not tested this feature so can't comment.

On 4/15/20, 10:59 AM, "Neeraj Ladkani" <[email protected]> wrote:

Hi Vijay,

Are they implemented over MCTP over SMBUS?

Neeraj

From: openbmc <[email protected]> On Behalf Of Vijay Khemka
Sent: Wednesday, April 15, 2020 5:28 AM
To: [email protected]
Cc: [email protected]
Subject: [EXTERNAL] Re: nvme sensors

Sorry, please ignore this, I found NVME in dbus-sensors. I needed to update repo in local workspace.

Regards
-Vijay

From: Vijay Khemka <mailto:[email protected]>
Date: Wednesday, April 15, 2020 at 5:07 AM
To: "mailto:[email protected]" <mailto:[email protected]>
Cc: "mailto:[email protected]" <mailto:[email protected]>
Subject: nvme sensors

Hi James,
Do we have support for NVME sensors in dbus sensors? I see phosphor-nvme repo which needs configuration from yaml file, is it possible to integrate this with entity manager?

Regards
-Vijay

#4 lore raw

Thanks Vijay.

Can anyone comment on MCTP feature completeness on OpenBMC? I reviewed libMCTP and some of bindings but its not clear who is using that?

Neeraj

-----Original Message-----
From: Vijay Khemka <[email protected]>
Sent: Wednesday, April 15, 2020 11:50 AM
To: Neeraj Ladkani <[email protected]>; [email protected]
Cc: [email protected]
Subject: [EXTERNAL] Re: nvme sensors

Yes there is a support for MCTP also in code but I have not tested this feature so can't comment.

On 4/15/20, 10:59 AM, "Neeraj Ladkani" <[email protected]> wrote:

Hi Vijay,

Are they implemented over MCTP over SMBUS?

Neeraj

From: openbmc <[email protected]> On Behalf Of Vijay Khemka
Sent: Wednesday, April 15, 2020 5:28 AM
To: [email protected]
Cc: [email protected]
Subject: [EXTERNAL] Re: nvme sensors

Sorry, please ignore this, I found NVME in dbus-sensors. I needed to update repo in local workspace.

Regards
-Vijay

From: Vijay Khemka <mailto:[email protected]>
Date: Wednesday, April 15, 2020 at 5:07 AM
To: "mailto:[email protected]" <mailto:[email protected]>
Cc: "mailto:[email protected]" <mailto:[email protected]>
Subject: nvme sensors

Hi James,
Do we have support for NVME sensors in dbus sensors? I see phosphor-nvme repo which needs configuration from yaml file, is it possible to integrate this with entity manager?

Regards
-Vijay

#5 lore raw
Quoted 3 lines · Neeraj Ladkani

Thanks Vijay.

Can anyone comment on MCTP feature completeness on OpenBMC?

What features are you looking for? Keen to see discussion about people's MCTP needs.

Anyway, OpenBMC's MCTP support is in progress but fairly immature. Part of the plan is to move MCTP support into the kernel. If you're making use of MCTP then I'd like to hear your use-cases so I can make sure the kernel interface meets everyone's requirements.

Quoted 2 lines

I reviewed
libMCTP and some of bindings but its not clear who is using that?

IBM is using libmctp in both BMC and host firmware, and Intel is working on it for use in their BMCs (but not host firmware).

Andrew

#6 lore raw

NVMe-MI. Over MCTP. This gets you into a broad range of SSDs for management.
Also would like to look to I3C Basic for MCTP in the future, and I know DMTF is looking at this. They have a Redfish Device Enablement method for getting an NVMe drive to respond with Redfish.

— mark

Quoted 5 lines · Andrew Jeffery

If you're making
use of MCTP then I'd like to hear your use-cases so I can make sure the kernel interface meets everyone's requirements.

#7 lore raw

Hi Mark,

Quoted 2 lines · Mark Carlson

NVMe-MI. Over MCTP. This gets you into a broad range of SSDs for management.

As mentioned in other replies in this thread you may want to check out Intel's dbus-sensors or the phosphor-nvme repos.

https://lists.ozlabs.org/pipermail/openbmc/2020-April/021288.html

Quoted 4 lines

Also would like to look to I3C Basic for MCTP in the future, and I know DMTF is looking at this. They have a Redfish Device Enablement method for getting an NVMe drive to respond with Redfish.

Cheers,

Andrew

#8 lore raw
In reply to Andrew Jeffery

Some of use cases:

- Standard MCTP message handling
- MCTP bridging
- Support SMBUS ( PCIe in future)
- MCTP tool( from console) that can be used to send any MCTP messages to a device and read responses, discovery etc.

Can you explain what are problems with libmctp(SMBUS binding ) with current implementation?

Neeraj

-----Original Message-----
From: Andrew Jeffery <[email protected]>
Sent: Wednesday, April 15, 2020 7:40 PM
To: Neeraj Ladkani <[email protected]>; Vijay Khemka <[email protected]>; James Feist <[email protected]>
Cc: [email protected]
Subject: [EXTERNAL] Re: nvme sensors

Quoted 3 lines · Neeraj Ladkani

Thanks Vijay.

Can anyone comment on MCTP feature completeness on OpenBMC?

What features are you looking for? Keen to see discussion about people's MCTP needs.

Anyway, OpenBMC's MCTP support is in progress but fairly immature.
Part of the plan is to move MCTP support into the kernel. If you're making use of MCTP then I'd like to hear your use-cases so I can make sure the kernel interface meets everyone's requirements.

Quoted 2 lines

I reviewed
libMCTP and some of bindings but its not clear who is using that?

IBM is using libmctp in both BMC and host firmware, and Intel is working on it for use in their BMCs (but not host firmware).

Andrew

#9 lore raw
Quoted 3 lines · Neeraj Ladkani

Some of use cases:

- Standard MCTP message handling

This can be split into a few parts:

1. MCTP binding implementations
2. MCTP message packetisation
3. APIs to expose the control commands defined in the DSP0236

Regarding 1, we have a couple of bindings in upstream libmctp:

a. The standard serial binding (DSP0253)
b. A vendor-defined (IBM) LPC binding (i.e. this is not the standard KCS binding).

As mentioned elsewhere in this thread Intel have a lot of out-of-tree code that enables the SMBus binding. Some of the difficulties with upstreaming this code are addressed by moving MCTP into the kernel and exposing a socket interface.

Regarding 2, this is already reasonably well handled by libmctp.

Regarding 3, I'm working through some of the details with Richard and Sumanth from Intel at the moment about how we best support the base control commands and the effects they can have on binding instances in libmctp. One of the issues to highlight here is the split between in-band data and out-of-band notifications. Currently libmctp's mctp-demux-daemon does not have a good story around out-of-band notifications.

Regarding the planned kernel implementation, 1 and 2 will happen in-kernel, while 3 will remain in userspace. The plan is to implement a netlink interface to control configuration of the MCTP network, which will allow userspace to communicate out-of-band data from the standard commands to the kernel.

Quoted 1 line

- MCTP bridging

There is some support in libmctp for bridging but it would currently require an application to explicitly exploit it. For instance it's not exploited by the mctp-demux-daemon (in utils/).

Supporting MCTP bridging is definitely on my radar for the kernel implementation.

Quoted 1 line

- Support SMBUS ( PCIe in future)

The motivation behind the kernel implementation is to hide the specifics of applying a binding specification to a piece of hardware from userspace, which removes the currently problem of needing to create bespoke userspace interfaces to expose the hardware capabilities out to userspace. Once I have the in-kernel interfaces going for MCTP then adding support for SMBus and PCIe bindings should be the same amount of effort as implementing a device driver.

Quoted 2 lines

- MCTP tool( from console) that can be used to send any MCTP messages to a device and read responses, discovery etc.

Yep, I intend to write one as part of supporting the kernel implementation. This would be usable with the socket interface provided by the mctp-demux-daemon.

Quoted 3 lines

Can you explain what are problems with libmctp(SMBUS binding ) with current implementation?

That might best be left to the Intel people who have already done some work in this area.

Thanks for the response. Hope my replies help.

Andrew

#10 lore raw
In reply to Andrew Jeffery

Currently, dbus-sensors support reading NVME sensors via mctp only. It uses libmctp and some of smbus patch from Intel. It also uses slave mqueue mctp kernel driver which is not upstream.

So currently it is not matured and fully upstreamed.

James, how can we use this without mctp. I don't see any non mctp support like Sending direct smbus command, please advise if I missed it.

Regards
-Vijay

#11 lore raw
Quoted 9 lines · Vijay Khemka

Currently, dbus-sensors support reading NVME sensors via mctp only. It uses libmctp and some of smbus patch from Intel. It also uses slave mqueue mctp kernel driver which is not upstream.

So currently it is not matured and fully upstreamed.

James, how can we use this without mctp. I don't see any non mctp support like Sending direct smbus command, please advise if I missed it.

If you want to use NVME-MI without MCTP, this use case is supported by phosphor-nvme. It makes direct SMBus calls.

Quoted 5 lines

Regards
-Vijay

#12 lore raw

On 4/16/20, 4:35 PM, "Benjamin Fair" <[email protected]> wrote:

On Thu, 16 Apr 2020 at 16:15, Vijay Khemka <[email protected]> wrote:
>
> Currently, dbus-sensors support reading NVME sensors via mctp only. It uses > libmctp and some of smbus patch from Intel. It also uses slave mqueue mctp > kernel driver which is not upstream.
>
> So currently it is not matured and fully upstreamed.
>
> James, how can we use this without mctp. I don't see any non mctp support like > Sending direct smbus command, please advise if I missed it.

If you want to use NVME-MI without MCTP, this use case is supported by phosphor-nvme. It makes direct SMBus calls.

Ben, thanks I see that but it needs certain GPIOs like PwrGd, presence and I am trying to find if Our platform support any such GPIOs.

Quoted 5 lines

Regards
-Vijay

#13 lore raw
Quoted 13 lines · Vijay Khemka

On 4/16/20, 4:35 PM, "Benjamin Fair" <[email protected]> wrote:

On Thu, 16 Apr 2020 at 16:15, Vijay Khemka <[email protected]> wrote:
>
> Currently, dbus-sensors support reading NVME sensors via mctp only. It uses > libmctp and some of smbus patch from Intel. It also uses slave mqueue mctp > kernel driver which is not upstream.
>
> So currently it is not matured and fully upstreamed.
>

Quoted 8 lines

> James, how can we use this without mctp. I don't see any non mctp support like > Sending direct smbus command, please advise if I missed it.

If you want to use NVME-MI without MCTP, this use case is supported by phosphor-nvme. It makes direct SMBus calls.

Ben, thanks I see that but it needs certain GPIOs like PwrGd, presence and I am trying to find if Our platform support any such GPIOs.

If your platform doesn't have these GPIOs, we should be able to make phosphor-nvme more flexible and not require them. It was designed for one system at first with the expectation that it could become more general over time.

Quoted 8 lines
Quoted 6 lines

Regards
-Vijay

#14 lore raw

On 4/17/20, 11:11 AM, "Benjamin Fair" <[email protected]> wrote:

On Fri, 17 Apr 2020 at 11:05, Vijay Khemka <[email protected]> wrote:
>
>
>
> On 4/16/20, 4:35 PM, "Benjamin Fair" <[email protected]> wrote:
>
> On Thu, 16 Apr 2020 at 16:15, Vijay Khemka <[email protected]> wrote:
> >
> > Currently, dbus-sensors support reading NVME sensors via mctp only. It uses
> > libmctp and some of smbus patch from Intel. It also uses slave mqueue mctp
> > kernel driver which is not upstream.
> >
> > So currently it is not matured and fully upstreamed.
> >
> > James, how can we use this without mctp. I don't see any non mctp support like
> > Sending direct smbus command, please advise if I missed it.
>
> If you want to use NVME-MI without MCTP, this use case is supported by
> phosphor-nvme. It makes direct SMBus calls.
>
> Ben, thanks I see that but it needs certain GPIOs like PwrGd, presence and I am trying to find if > Our platform support any such GPIOs.

If your platform doesn't have these GPIOs, we should be able to make phosphor-nvme more flexible and not require them. It was designed for one system at first with the expectation that it could become more general over time.

Cool, That will be great. I also don't see recipe file for this. And how easy/hard to integrate this with entity manager as we use entity manager to list all sensors.

Quoted 8 lines
Quoted 6 lines

Regards
-Vijay

#15 lore raw
Quoted 28 lines · Vijay Khemka

On 4/17/20, 11:11 AM, "Benjamin Fair" <[email protected]> wrote:

On Fri, 17 Apr 2020 at 11:05, Vijay Khemka <[email protected]> wrote:
>
>
>
> On 4/16/20, 4:35 PM, "Benjamin Fair" <[email protected]> wrote:
>
> On Thu, 16 Apr 2020 at 16:15, Vijay Khemka <[email protected]> wrote:
> >
> > Currently, dbus-sensors support reading NVME sensors via mctp only. It uses
> > libmctp and some of smbus patch from Intel. It also uses slave mqueue mctp
> > kernel driver which is not upstream.
> >
> > So currently it is not matured and fully upstreamed.
> >
> > James, how can we use this without mctp. I don't see any non mctp support like
> > Sending direct smbus command, please advise if I missed it.
>
> If you want to use NVME-MI without MCTP, this use case is supported by
> phosphor-nvme. It makes direct SMBus calls.
>
> Ben, thanks I see that but it needs certain GPIOs like PwrGd, presence and I am trying to find if > Our platform support any such GPIOs.

Quoted 6 lines

If your platform doesn't have these GPIOs, we should be able to make phosphor-nvme more flexible and not require them. It was designed for one system at first with the expectation that it could become more general over time.

Cool, That will be great. I also don't see recipe file for this.

The recipe file is at meta-phosphor/recipes-phosphor/sensors/phosphor-nvme_git.bb

Quoted 2 lines

And how easy/hard to integrate this
with entity manager as we use entity manager to list all sensors.

I'm not familiar enough with entity-manager to say for sure.

Quoted 11 lines
Quoted 9 lines
Quoted 7 lines

Regards
-Vijay

#16 lore raw

On 4/17/20, 11:58 AM, "Benjamin Fair" <[email protected]> wrote:

On Fri, 17 Apr 2020 at 11:42, Vijay Khemka <[email protected]> wrote:
>
>
>
> On 4/17/20, 11:11 AM, "Benjamin Fair" <[email protected]> wrote:
>
> On Fri, 17 Apr 2020 at 11:05, Vijay Khemka <[email protected]> wrote:
> >
> >
> >
> > On 4/16/20, 4:35 PM, "Benjamin Fair" <[email protected]> wrote:
> >
> > On Thu, 16 Apr 2020 at 16:15, Vijay Khemka <[email protected]> wrote:
> > >
> > > Currently, dbus-sensors support reading NVME sensors via mctp only. It uses
> > > libmctp and some of smbus patch from Intel. It also uses slave mqueue mctp
> > > kernel driver which is not upstream.
> > >
> > > So currently it is not matured and fully upstreamed.
> > >
> > > James, how can we use this without mctp. I don't see any non mctp support like
> > > Sending direct smbus command, please advise if I missed it.
> >
> > If you want to use NVME-MI without MCTP, this use case is supported by
> > phosphor-nvme. It makes direct SMBus calls.
> >
> > Ben, thanks I see that but it needs certain GPIOs like PwrGd, presence and I am trying to find if
> > Our platform support any such GPIOs.
>
> If your platform doesn't have these GPIOs, we should be able to make
> phosphor-nvme more flexible and not require them. It was designed for
> one system at first with the expectation that it could become more
> general over time.
>
> Cool, That will be great. I also don't see recipe file for this.

The recipe file is at meta-phosphor/recipes-phosphor/sensors/phosphor-nvme_git.bb
Thanks

Quoted 2 lines

And how easy/hard to integrate this
with entity manager as we use entity manager to list all sensors.

I'm not familiar enough with entity-manager to say for sure.

>
> >
> > >
> > > Regards
> > > -Vijay
> > >
> > >
> >
> >
>
>

#17 lore raw
In reply to Vijay Khemka
Quoted 8 lines · Vijay Khemka

Currently, dbus-sensors support reading NVME sensors via mctp only. It uses libmctp and some of smbus patch from Intel. It also uses slave mqueue mctp kernel driver which is not upstream.

So currently it is not matured and fully upstreamed.

James, how can we use this without mctp. I don't see any non mctp support like Sending direct smbus command, please advise if I missed it.

Currently it only supports MCTP. Should be easy to change it to support both with some flag if you require it.

Quoted 5 lines

Regards
-Vijay

#18 lore raw

On 4/17/20, 11:47 AM, "James Feist" <[email protected]> wrote:

On 4/16/2020 4:15 PM, Vijay Khemka wrote:
> Currently, dbus-sensors support reading NVME sensors via mctp only. It uses > libmctp and some of smbus patch from Intel. It also uses slave mqueue mctp > kernel driver which is not upstream.
>
> So currently it is not matured and fully upstreamed.
>
> James, how can we use this without mctp. I don't see any non mctp support like > Sending direct smbus command, please advise if I missed it.

Currently it only supports MCTP. Should be easy to change it to support both with some flag if you require it.

Thanks James, I will look into change as it doesn’t even build currently with libmctp dependency and Intel's patch. I will see how can it be modified not to link mctp based on config.

Quoted 5 lines

Regards
-Vijay