common/iavf: add QFI fields for GTPU UL and DL
PATCH 1/4 common/iavf: add QFI fields for GTPU UL and DL
From: Junfeng Guo <[email protected]>
Add virtchnl fields QFI of GTPU UL/DL for AVF FDIR.
--- drivers/common/iavf/virtchnl.h | 5 +++++ 1 file changed, 5 insertions(+)
drivers/common/iavf/virtchnl.h +5 -0
@@ -1642,6 +1642,11 @@ enum virtchnl_proto_hdr_field {/* IPv6 Extension Fragment */ VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG_PKID =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG ), +/* GTPU_DWN/UP */ +VIRTCHNL_PROTO_HDR_GTPU_DWN_QFI = +PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_DWN ), +VIRTCHNL_PROTO_HDR_GTPU_UP_QFI = + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_UP), }; struct virtchnl_proto_hdr {
Signature · 1 line
2.33.0
PATCH 2/4 common/iavf: add proto hdr field support for L4 checksum
From: Alvin Zhang <[email protected]>
Add TCP/UDP/SCTP header checksum field selectors.
--- drivers/common/iavf/virtchnl.h | 3 +++ 1 file changed, 3 insertions(+)
drivers/common/iavf/virtchnl.h +3 -0
@@ -1598,14 +1598,17 @@ enum virtchnl_proto_hdr_field {VIRTCHNL_PROTO_HDR_TCP_SRC_PORT =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_TCP ),VIRTCHNL_PROTO_HDR_TCP_DST_PORT , +VIRTCHNL_PROTO_HDR_TCP_CHKSUM ,/* UDP */ VIRTCHNL_PROTO_HDR_UDP_SRC_PORT =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_UDP ),VIRTCHNL_PROTO_HDR_UDP_DST_PORT , +VIRTCHNL_PROTO_HDR_UDP_CHKSUM ,/* SCTP */ VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_SCTP ),VIRTCHNL_PROTO_HDR_SCTP_DST_PORT , +VIRTCHNL_PROTO_HDR_SCTP_CHKSUM ,/* GTPU_IP */ VIRTCHNL_PROTO_HDR_GTPU_IP_TEID = PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_IP),
Signature · 1 line
2.33.0
Re: [dpdk-dev] [PATCH v1 2/4] common/iavf: add proto hdr field support for L4 checksum
Quoted 12 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Haiyue Wang
Sent: Tuesday, August 17, 2021 3:17 PM
To: [email protected]
Cc: Zhang, AlvinX <[email protected]>; Wang, Haiyue <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: [dpdk-dev] [PATCH v1 2/4] common/iavf: add proto hdr field support for L4 checksum
Quoted 6 lines
From: Alvin Zhang <[email protected]>
Add TCP/UDP/SCTP header checksum field selectors.
Signed-off-by Alvin Zhang <[email protected]>Signed-off-by Haiyue Wang <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi
Re: [dpdk-dev] [PATCH v1 2/4] common/iavf: add proto hdr field support for L4 checksum
In reply to Haiyue WangQuoted 4 lines · Haiyue Wang
From: Alvin Zhang <[email protected]>
Add TCP/UDP/SCTP header checksum field selectors.
Hi Alvin, Haiyue,
Can you please describe a little more, what is the impact of adding proto hdr checksum field selector?
Is this also something related to the flow director as other patches in this set?
Thanks,
ferruh
Quoted 29 lines
Signed-off-by Alvin Zhang <[email protected]>Signed-off-by Haiyue Wang <[email protected]>--- drivers/common/iavf/virtchnl.h | 3 +++ 1 file changed, 3 insertions(+)drivers/common/iavf/virtchnl.h +3
-0@@ -1598,14 +1598,17 @@ enum virtchnl_proto_hdr_field {VIRTCHNL_PROTO_HDR_TCP_SRC_PORT =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_TCP ),VIRTCHNL_PROTO_HDR_TCP_DST_PORT , +VIRTCHNL_PROTO_HDR_TCP_CHKSUM ,/* UDP */ VIRTCHNL_PROTO_HDR_UDP_SRC_PORT =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_UDP ),VIRTCHNL_PROTO_HDR_UDP_DST_PORT , +VIRTCHNL_PROTO_HDR_UDP_CHKSUM ,/* SCTP */ VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_SCTP ),VIRTCHNL_PROTO_HDR_SCTP_DST_PORT , +VIRTCHNL_PROTO_HDR_SCTP_CHKSUM ,/* GTPU_IP */ VIRTCHNL_PROTO_HDR_GTPU_IP_TEID = PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_IP),
PATCH 3/4 common/iavf: remove the FDIR query opcode
In reply to Haiyue WangThe VIRTCHNL_OP_QUERY_FDIR_FILTER opcode is not used, so remove it.
--- drivers/common/iavf/virtchnl.h | 38 ---------------------------------- 1 file changed, 38 deletions(-)
drivers/common/iavf/virtchnl.h +0 -38
@@ -146,7 +146,6 @@ enum virtchnl_ops {VIRTCHNL_OP_DEL_RSS_CFG =46 ,VIRTCHNL_OP_ADD_FDIR_FILTER =47 ,VIRTCHNL_OP_DEL_FDIR_FILTER =48 , -VIRTCHNL_OP_QUERY_FDIR_FILTER =49 ,VIRTCHNL_OP_GET_MAX_RSS_QREGION =50 ,VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS =51 , VIRTCHNL_OP_ADD_VLAN_V2 = 52,
@@ -244,8 +243,6 @@ static inline const char *virtchnl_op_str(enum virtchnl_ops v_opcode)return "VIRTCHNL_OP_ADD_FDIR_FILTER" ;case VIRTCHNL_OP_DEL_FDIR_FILTER :return "VIRTCHNL_OP_DEL_FDIR_FILTER" ; -case VIRTCHNL_OP_QUERY_FDIR_FILTER : -return "VIRTCHNL_OP_QUERY_FDIR_FILTER" ;case VIRTCHNL_OP_GET_MAX_RSS_QREGION :return "VIRTCHNL_OP_GET_MAX_RSS_QREGION" ;case VIRTCHNL_OP_ENABLE_QUEUES_V2 :
@@ -1733,20 +1730,6 @@ struct virtchnl_fdir_rule {VIRTCHNL_CHECK_STRUCT_LEN (2604 , virtchnl_fdir_rule); -/* query information to retrieve fdir rule counters. -* PF will fill out this structure to reset counter. -*/ -struct virtchnl_fdir_query_info { -u32 match_packets_valid:1 ; -u32 match_bytes_valid:1 ; -u32 reserved:30 ;/* Reserved, must be zero. */ -u32 pad; -u64 matched_packets;/* Number of packets for this rule. */ -u64 matched_bytes;/* Number of bytes through this rule. */ -}; - -VIRTCHNL_CHECK_STRUCT_LEN (24 , virtchnl_fdir_query_info); -/* Status returned to VF after VF requests FDIR commands * VIRTCHNL_FDIR_SUCCESS * VF FDIR related request is successfully done by PF
@@ -1879,24 +1862,6 @@ struct virtchnl_queue_tc_mapping {VIRTCHNL_CHECK_STRUCT_LEN (12 , virtchnl_queue_tc_mapping); -/* VIRTCHNL_OP_QUERY_FDIR_FILTER -* VF sends this request to PF by filling out vsi_id, -* flow_id and reset_counter. PF will return query_info -* and query_status to VF. -*/ -struct virtchnl_fdir_query { -u16 vsi_id;/* INPUT */ -u16 pad1[3 ]; -u32 flow_id;/* INPUT */ -u32 reset_counter:1 ;/* INPUT */ -struct virtchnl_fdir_query_info query_info;/* OUTPUT */ - -/* see enum virtchnl_fdir_prgm_status; OUTPUT */ -s32 status; -u32 pad2; -}; - -VIRTCHNL_CHECK_STRUCT_LEN (48 , virtchnl_fdir_query);/* TX and RX queue types are valid in legacy as well as split queue models. * With Split Queue model, 2 additional types are introduced - TX_COMPLETION
@@ -2254,9 +2219,6 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,case VIRTCHNL_OP_DEL_FDIR_FILTER : valid_len =sizeof (struct virtchnl_fdir_del );break ; -case VIRTCHNL_OP_QUERY_FDIR_FILTER : - valid_len =sizeof (struct virtchnl_fdir_query ); -break ;case VIRTCHNL_OP_GET_QOS_CAPS :break ;case VIRTCHNL_OP_CONFIG_QUEUE_TC_MAP :
Signature · 1 line
2.33.0
Re: [dpdk-dev] [PATCH v1 3/4] common/iavf: remove the FDIR query opcode
Quoted 11 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Haiyue Wang
Sent: Tuesday, August 17, 2021 3:17 PM
To: [email protected]
Cc: Wang, Haiyue <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: [dpdk-dev] [PATCH v1 3/4] common/iavf: remove the FDIR query opcode
Quoted 3 lines
The
VIRTCHNL_OP_QUERY_FDIR_FILTERopcode is not used, so remove it.Signed-off-by Haiyue Wang <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi
PATCH 4/4 common/iavf: update the driver version
In reply to Haiyue WangUpdate the driver version to trace the change.
--- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/common/iavf/README +1 -1
@@ -6,7 +6,7 @@ Intel® IAVF driver ================= This directory contains source code of FreeBSD IAVF driver of version -cid-avf.2021.04.29.tar.gz released by the team which develops +cid-avf.2021.08.16.tar.gz released by the team which develops basic drivers for any IAVF NIC. The directory of base/ contains the original source package.
Signature · 1 line
2.33.0
Re: [dpdk-dev] [PATCH v1 4/4] common/iavf: update the driver version
Quoted 10 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Haiyue Wang
Sent: Tuesday, August 17, 2021 3:17 PM
To: [email protected]
Cc: Wang, Haiyue <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: [dpdk-dev] [PATCH v1 4/4] common/iavf: update the driver version
Quoted 3 lines
Update the driver version to trace the change.
Signed-off-by Haiyue Wang <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi
Quoted 12 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Haiyue Wang
Sent: Tuesday, August 17, 2021 3:17 PM
To: [email protected]
Cc: Guo, Junfeng <[email protected]>; Wang, Haiyue <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: [dpdk-dev] [PATCH v1 1/4] common/iavf: add QFI fields for GTPU UL and DL
Quoted 6 lines
From: Junfeng Guo <[email protected]>
Add virtchnl fields QFI of GTPU UL/DL for AVF FDIR.
Signed-off-by Junfeng Guo <[email protected]>Signed-off-by Haiyue Wang <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi
Quoted 3 lines · Haiyue Wang
From: Junfeng Guo <[email protected]>
Add virtchnl fields QFI of GTPU UL/DL for AVF FDIR.
Can you please put what 'QFI' stands for in the commit log, I assume it is "QoS Flow Identifier"?
What does it mean to add new protocol fields to the virtchnl?
And commit log mentions from 'FDIR', is this change updates anything in the flow director support of the driver?
Quoted 24 lines
Signed-off-by Junfeng Guo <[email protected]>Signed-off-by Haiyue Wang <[email protected]>--- drivers/common/iavf/virtchnl.h | 5 +++++ 1 file changed, 5 insertions(+)drivers/common/iavf/virtchnl.h +5
-0@@ -1642,6 +1642,11 @@ enum virtchnl_proto_hdr_field {/* IPv6 Extension Fragment */ VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG_PKID =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG ), +/* GTPU_DWN/UP */ +VIRTCHNL_PROTO_HDR_GTPU_DWN_QFI = +PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_DWN ), +VIRTCHNL_PROTO_HDR_GTPU_UP_QFI = + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_UP), }; struct virtchnl_proto_hdr {
v2 cover iavf base code update
In reply to Haiyue Wangv2: update the commit message.
Alvin Zhang (1):
common/iavf: add proto hdr field support for L4 checksum
Haiyue Wang (2):
common/iavf: remove the FDIR query opcode
common/iavf: update the driver version
Junfeng Guo (1):
common/iavf: add QFI fields for GTPU UL and DL
drivers/common/iavf/README | 2 +- drivers/common/iavf/virtchnl.h | 46 ++++++---------------------------- 2 files changed, 9 insertions(+), 39 deletions(-)
Signature · 1 line
2.33.0
PATCH v2 1/4 common/iavf: add QFI fields for GTPU UL and DL
From: Junfeng Guo <[email protected]>
The QFI is 6-bit "QoS Flow Identifier" within the GTPU Extension Header. Add virtchnl fields QFI of GTPU UL/DL for supporting the AVF FDIR.
--- drivers/common/iavf/virtchnl.h | 5 +++++ 1 file changed, 5 insertions(+)
drivers/common/iavf/virtchnl.h +5 -0
@@ -1642,6 +1642,11 @@ enum virtchnl_proto_hdr_field {/* IPv6 Extension Fragment */ VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG_PKID =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG ), +/* GTPU_DWN/UP */ +VIRTCHNL_PROTO_HDR_GTPU_DWN_QFI = +PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_DWN ), +VIRTCHNL_PROTO_HDR_GTPU_UP_QFI = + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_UP), }; struct virtchnl_proto_hdr {
Signature · 1 line
2.33.0
PATCH v2 2/4 common/iavf: add proto hdr field support for L4 checksum
In reply to Haiyue WangFrom: Alvin Zhang <[email protected]>
Add TCP/UDP/SCTP header checksum field selectors, they can be used in creating FDIR or RSS rules related to TCP/UDP/SCTP header checksum.
--- drivers/common/iavf/virtchnl.h | 3 +++ 1 file changed, 3 insertions(+)
drivers/common/iavf/virtchnl.h +3 -0
@@ -1598,14 +1598,17 @@ enum virtchnl_proto_hdr_field {VIRTCHNL_PROTO_HDR_TCP_SRC_PORT =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_TCP ),VIRTCHNL_PROTO_HDR_TCP_DST_PORT , +VIRTCHNL_PROTO_HDR_TCP_CHKSUM ,/* UDP */ VIRTCHNL_PROTO_HDR_UDP_SRC_PORT =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_UDP ),VIRTCHNL_PROTO_HDR_UDP_DST_PORT , +VIRTCHNL_PROTO_HDR_UDP_CHKSUM ,/* SCTP */ VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_SCTP ),VIRTCHNL_PROTO_HDR_SCTP_DST_PORT , +VIRTCHNL_PROTO_HDR_SCTP_CHKSUM ,/* GTPU_IP */ VIRTCHNL_PROTO_HDR_GTPU_IP_TEID = PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_IP),
Signature · 1 line
2.33.0
PATCH v2 3/4 common/iavf: remove the FDIR query opcode
In reply to Haiyue WangThe VIRTCHNL_OP_QUERY_FDIR_FILTER opcode is not used, so remove it.
--- drivers/common/iavf/virtchnl.h | 38 ---------------------------------- 1 file changed, 38 deletions(-)
drivers/common/iavf/virtchnl.h +0 -38
@@ -146,7 +146,6 @@ enum virtchnl_ops {VIRTCHNL_OP_DEL_RSS_CFG =46 ,VIRTCHNL_OP_ADD_FDIR_FILTER =47 ,VIRTCHNL_OP_DEL_FDIR_FILTER =48 , -VIRTCHNL_OP_QUERY_FDIR_FILTER =49 ,VIRTCHNL_OP_GET_MAX_RSS_QREGION =50 ,VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS =51 , VIRTCHNL_OP_ADD_VLAN_V2 = 52,
@@ -244,8 +243,6 @@ static inline const char *virtchnl_op_str(enum virtchnl_ops v_opcode)return "VIRTCHNL_OP_ADD_FDIR_FILTER" ;case VIRTCHNL_OP_DEL_FDIR_FILTER :return "VIRTCHNL_OP_DEL_FDIR_FILTER" ; -case VIRTCHNL_OP_QUERY_FDIR_FILTER : -return "VIRTCHNL_OP_QUERY_FDIR_FILTER" ;case VIRTCHNL_OP_GET_MAX_RSS_QREGION :return "VIRTCHNL_OP_GET_MAX_RSS_QREGION" ;case VIRTCHNL_OP_ENABLE_QUEUES_V2 :
@@ -1733,20 +1730,6 @@ struct virtchnl_fdir_rule {VIRTCHNL_CHECK_STRUCT_LEN (2604 , virtchnl_fdir_rule); -/* query information to retrieve fdir rule counters. -* PF will fill out this structure to reset counter. -*/ -struct virtchnl_fdir_query_info { -u32 match_packets_valid:1 ; -u32 match_bytes_valid:1 ; -u32 reserved:30 ;/* Reserved, must be zero. */ -u32 pad; -u64 matched_packets;/* Number of packets for this rule. */ -u64 matched_bytes;/* Number of bytes through this rule. */ -}; - -VIRTCHNL_CHECK_STRUCT_LEN (24 , virtchnl_fdir_query_info); -/* Status returned to VF after VF requests FDIR commands * VIRTCHNL_FDIR_SUCCESS * VF FDIR related request is successfully done by PF
@@ -1879,24 +1862,6 @@ struct virtchnl_queue_tc_mapping {VIRTCHNL_CHECK_STRUCT_LEN (12 , virtchnl_queue_tc_mapping); -/* VIRTCHNL_OP_QUERY_FDIR_FILTER -* VF sends this request to PF by filling out vsi_id, -* flow_id and reset_counter. PF will return query_info -* and query_status to VF. -*/ -struct virtchnl_fdir_query { -u16 vsi_id;/* INPUT */ -u16 pad1[3 ]; -u32 flow_id;/* INPUT */ -u32 reset_counter:1 ;/* INPUT */ -struct virtchnl_fdir_query_info query_info;/* OUTPUT */ - -/* see enum virtchnl_fdir_prgm_status; OUTPUT */ -s32 status; -u32 pad2; -}; - -VIRTCHNL_CHECK_STRUCT_LEN (48 , virtchnl_fdir_query);/* TX and RX queue types are valid in legacy as well as split queue models. * With Split Queue model, 2 additional types are introduced - TX_COMPLETION
@@ -2254,9 +2219,6 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,case VIRTCHNL_OP_DEL_FDIR_FILTER : valid_len =sizeof (struct virtchnl_fdir_del );break ; -case VIRTCHNL_OP_QUERY_FDIR_FILTER : - valid_len =sizeof (struct virtchnl_fdir_query ); -break ;case VIRTCHNL_OP_GET_QOS_CAPS :break ;case VIRTCHNL_OP_CONFIG_QUEUE_TC_MAP :
Signature · 1 line
2.33.0
PATCH v2 4/4 common/iavf: update the driver version
In reply to Haiyue WangUpdate the driver version to trace the change.
--- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/common/iavf/README +1 -1
@@ -6,7 +6,7 @@ Intel® IAVF driver ================= This directory contains source code of FreeBSD IAVF driver of version -cid-avf.2021.04.29.tar.gz released by the team which develops +cid-avf.2021.08.16.tar.gz released by the team which develops basic drivers for any IAVF NIC. The directory of base/ contains the original source package.
Signature · 1 line
2.33.0
v3 cover iavf base code update
In reply to Haiyue Wangv3: adjust the commit title.
v2: update the commit message.
Alvin Zhang (1):
common/iavf: enable hash calculation based on L4 checksum
Haiyue Wang (2):
common/iavf: remove the FDIR query opcode
common/iavf: update the driver version
Junfeng Guo (1):
common/iavf: add QFI fields for GTPU UL and DL
drivers/common/iavf/README | 2 +- drivers/common/iavf/virtchnl.h | 46 ++++++---------------------------- 2 files changed, 9 insertions(+), 39 deletions(-)
Signature · 1 line
2.33.0
PATCH v3 1/4 common/iavf: add QFI fields for GTPU UL and DL
From: Junfeng Guo <[email protected]>
The QFI is 6-bit "QoS Flow Identifier" within the GTPU Extension Header. Add virtchnl fields QFI of GTPU UL/DL for supporting the AVF FDIR.
--- drivers/common/iavf/virtchnl.h | 5 +++++ 1 file changed, 5 insertions(+)
drivers/common/iavf/virtchnl.h +5 -0
@@ -1642,6 +1642,11 @@ enum virtchnl_proto_hdr_field {/* IPv6 Extension Fragment */ VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG_PKID =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG ), +/* GTPU_DWN/UP */ +VIRTCHNL_PROTO_HDR_GTPU_DWN_QFI = +PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_DWN ), +VIRTCHNL_PROTO_HDR_GTPU_UP_QFI = + PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_UP), }; struct virtchnl_proto_hdr {
Signature · 1 line
2.33.0
PATCH v3 2/4 common/iavf: enable hash calculation based on L4 checksum
In reply to Haiyue WangFrom: Alvin Zhang <[email protected]>
Add TCP/UDP/SCTP header checksum field selectors, they can be used in creating FDIR or RSS rules related to TCP/UDP/SCTP header checksum.
--- drivers/common/iavf/virtchnl.h | 3 +++ 1 file changed, 3 insertions(+)
drivers/common/iavf/virtchnl.h +3 -0
@@ -1598,14 +1598,17 @@ enum virtchnl_proto_hdr_field {VIRTCHNL_PROTO_HDR_TCP_SRC_PORT =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_TCP ),VIRTCHNL_PROTO_HDR_TCP_DST_PORT , +VIRTCHNL_PROTO_HDR_TCP_CHKSUM ,/* UDP */ VIRTCHNL_PROTO_HDR_UDP_SRC_PORT =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_UDP ),VIRTCHNL_PROTO_HDR_UDP_DST_PORT , +VIRTCHNL_PROTO_HDR_UDP_CHKSUM ,/* SCTP */ VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT =PROTO_HDR_FIELD_START (VIRTCHNL_PROTO_HDR_SCTP ),VIRTCHNL_PROTO_HDR_SCTP_DST_PORT , +VIRTCHNL_PROTO_HDR_SCTP_CHKSUM ,/* GTPU_IP */ VIRTCHNL_PROTO_HDR_GTPU_IP_TEID = PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_IP),
Signature · 1 line
2.33.0
PATCH v3 3/4 common/iavf: remove the FDIR query opcode
In reply to Haiyue WangThe VIRTCHNL_OP_QUERY_FDIR_FILTER opcode is not used, so remove it.
--- drivers/common/iavf/virtchnl.h | 38 ---------------------------------- 1 file changed, 38 deletions(-)
drivers/common/iavf/virtchnl.h +0 -38
@@ -146,7 +146,6 @@ enum virtchnl_ops {VIRTCHNL_OP_DEL_RSS_CFG =46 ,VIRTCHNL_OP_ADD_FDIR_FILTER =47 ,VIRTCHNL_OP_DEL_FDIR_FILTER =48 , -VIRTCHNL_OP_QUERY_FDIR_FILTER =49 ,VIRTCHNL_OP_GET_MAX_RSS_QREGION =50 ,VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS =51 , VIRTCHNL_OP_ADD_VLAN_V2 = 52,
@@ -244,8 +243,6 @@ static inline const char *virtchnl_op_str(enum virtchnl_ops v_opcode)return "VIRTCHNL_OP_ADD_FDIR_FILTER" ;case VIRTCHNL_OP_DEL_FDIR_FILTER :return "VIRTCHNL_OP_DEL_FDIR_FILTER" ; -case VIRTCHNL_OP_QUERY_FDIR_FILTER : -return "VIRTCHNL_OP_QUERY_FDIR_FILTER" ;case VIRTCHNL_OP_GET_MAX_RSS_QREGION :return "VIRTCHNL_OP_GET_MAX_RSS_QREGION" ;case VIRTCHNL_OP_ENABLE_QUEUES_V2 :
@@ -1733,20 +1730,6 @@ struct virtchnl_fdir_rule {VIRTCHNL_CHECK_STRUCT_LEN (2604 , virtchnl_fdir_rule); -/* query information to retrieve fdir rule counters. -* PF will fill out this structure to reset counter. -*/ -struct virtchnl_fdir_query_info { -u32 match_packets_valid:1 ; -u32 match_bytes_valid:1 ; -u32 reserved:30 ;/* Reserved, must be zero. */ -u32 pad; -u64 matched_packets;/* Number of packets for this rule. */ -u64 matched_bytes;/* Number of bytes through this rule. */ -}; - -VIRTCHNL_CHECK_STRUCT_LEN (24 , virtchnl_fdir_query_info); -/* Status returned to VF after VF requests FDIR commands * VIRTCHNL_FDIR_SUCCESS * VF FDIR related request is successfully done by PF
@@ -1879,24 +1862,6 @@ struct virtchnl_queue_tc_mapping {VIRTCHNL_CHECK_STRUCT_LEN (12 , virtchnl_queue_tc_mapping); -/* VIRTCHNL_OP_QUERY_FDIR_FILTER -* VF sends this request to PF by filling out vsi_id, -* flow_id and reset_counter. PF will return query_info -* and query_status to VF. -*/ -struct virtchnl_fdir_query { -u16 vsi_id;/* INPUT */ -u16 pad1[3 ]; -u32 flow_id;/* INPUT */ -u32 reset_counter:1 ;/* INPUT */ -struct virtchnl_fdir_query_info query_info;/* OUTPUT */ - -/* see enum virtchnl_fdir_prgm_status; OUTPUT */ -s32 status; -u32 pad2; -}; - -VIRTCHNL_CHECK_STRUCT_LEN (48 , virtchnl_fdir_query);/* TX and RX queue types are valid in legacy as well as split queue models. * With Split Queue model, 2 additional types are introduced - TX_COMPLETION
@@ -2254,9 +2219,6 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,case VIRTCHNL_OP_DEL_FDIR_FILTER : valid_len =sizeof (struct virtchnl_fdir_del );break ; -case VIRTCHNL_OP_QUERY_FDIR_FILTER : - valid_len =sizeof (struct virtchnl_fdir_query ); -break ;case VIRTCHNL_OP_GET_QOS_CAPS :break ;case VIRTCHNL_OP_CONFIG_QUEUE_TC_MAP :
Signature · 1 line
2.33.0
PATCH v3 4/4 common/iavf: update the driver version
In reply to Haiyue WangUpdate the driver version to trace the change.
--- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/common/iavf/README +1 -1
@@ -6,7 +6,7 @@ Intel® IAVF driver ================= This directory contains source code of FreeBSD IAVF driver of version -cid-avf.2021.04.29.tar.gz released by the team which develops +cid-avf.2021.08.16.tar.gz released by the team which develops basic drivers for any IAVF NIC. The directory of base/ contains the original source package.
Signature · 1 line
2.33.0
Re: [dpdk-dev] [PATCH v3 0/4] iavf base code update
In reply to Haiyue WangQuoted 22 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Haiyue Wang
Sent: Tuesday, September 7, 2021 3:33 PM
To: [email protected]
Cc: Wang, Haiyue <[email protected]>
Subject: [dpdk-dev] [PATCH v3 0/4] iavf base code updatev3: adjust the commit title.
v2: update the commit message.Alvin Zhang (1):
common/iavf: enable hash calculation based on L4 checksumHaiyue Wang (2):
common/iavf: remove the FDIR query opcode
common/iavf: update the driver versionJunfeng Guo (1):
common/iavf: add QFI fields for GTPU UL and DL
Quoted 6 lines
drivers/common/iavf/README | 2 +- drivers/common/iavf/virtchnl.h | 46 ++++++---------------------------- 2 files changed, 9 insertions(+), 39 deletions(-)--
2.33.0
Applied to dpdk-next-net-intel.
Thanks
Qi