iommu: arm-smmu: disable large page mappings for Nvidia arm-smmu
Subsystems (4)
PATCH v2 1/1 iommu: arm-smmu: disable large page mappings for Nvidia arm-smmu
Tegra194 and Tegra234 SoCs have the erratum that causes walk cache entries to not be invalidated correctly. The problem is that the walk cache index generated for IOVA is not same across translation and invalidation requests. This is leading to page faults when PMD entry is released during unmap and populated with new PTE table during subsequent map request. Disabling large page mappings avoids the release of PMD entry and avoid translations seeing stale PMD entry in walk cache. Fix this by limiting the page mappings to PAGE_SIZE for Tegra194 and Tegra234 devices. This is recommended fix from Tegra hardware design team.
---
Changes in v2:
- Using init_context() to override pgsize_bitmap instead of new function
drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c | 30 ++++++++++++++++++++ 1 file changed, 30 insertions(+)
drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c +30 -0
@@ -258,6 +258,34 @@ static void nvidia_smmu_probe_finalize(struct arm_smmu_device *smmu, struct devi dev_name(dev), err); } +static int nvidia_smmu_init_context (struct arm_smmu_domain *smmu_domain, +struct io_pgtable_cfg *pgtbl_cfg, +struct device *dev) +{ +struct arm_smmu_device *smmu = smmu_domain->smmu; +const struct device_node *np = smmu->dev->of_node; + +/* +* Tegra194 and Tegra234 SoCs have the erratum that causes walk cache +* entries to not be invalidated correctly. The problem is that the walk +* cache index generated for IOVA is not same across translation and +* invalidation requests. This is leading to page faults when PMD entry +* is released during unmap and populated with new PTE table during +* subsequent map request. Disabling large page mappings avoids the +* release of PMD entry and avoid translations seeing stale PMD entry in +* walk cache. +* Fix this by limiting the page mappings to PAGE_SIZE on Tegra194 and +* Tegra234. +*/ +if (of_device_is_compatible (np,"nvidia,tegra234-smmu" ) || +of_device_is_compatible (np,"nvidia,tegra194-smmu" )) { + smmu->pgsize_bitmap =PAGE_SIZE ; + pgtbl_cfg->pgsize_bitmap = smmu->pgsize_bitmap; + } + +return 0 ; +} +static const struct arm_smmu_impl nvidia_smmu_impl = { .read_reg = nvidia_smmu_read_reg, .write_reg = nvidia_smmu_write_reg,
@@ -268,10 +296,12 @@ static const struct arm_smmu_impl nvidia_smmu_impl = { .global_fault = nvidia_smmu_global_fault, .context_fault = nvidia_smmu_context_fault, .probe_finalize = nvidia_smmu_probe_finalize, + .init_context = nvidia_smmu_init_context, };static const struct arm_smmu_impl nvidia_smmu_single_impl = { .probe_finalize = nvidia_smmu_probe_finalize, + .init_context = nvidia_smmu_init_context, };struct arm_smmu_device *nvidia_smmu_impl_init (struct arm_smmu_device *smmu)
Signature · 1 line
2.17.1
Quoted 10 lines · Ashish Mhetre
Tegra194 and Tegra234 SoCs have the erratum that causes walk cache entries to not be invalidated correctly. The problem is that the walk cache index generated for IOVA is not same across translation and invalidation requests. This is leading to page faults when PMD entry is released during unmap and populated with new PTE table during subsequent map request. Disabling large page mappings avoids the release of PMD entry and avoid translations seeing stale PMD entry in walk cache. Fix this by limiting the page mappings to
PAGE_SIZEfor Tegra194 and Tegra234 devices. This is recommended fix from Tegra hardware design team.
Quoted 62 lines
Co-developed-by Pritesh Raithatha <[email protected]>Signed-off-by Pritesh Raithatha <[email protected]>Signed-off-by Ashish Mhetre <[email protected]>---
Changes in v2:
- Usinginit_context()to overridepgsize_bitmapinstead of new functiondrivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c | 30 ++++++++++++++++++++ 1 file changed, 30 insertions(+)drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c +30
-0@@ -258,6 +258,34 @@ static void nvidia_smmu_probe_finalize(struct arm_smmu_device *smmu, struct devi dev_name(dev), err); } +static int nvidia_smmu_init_context (struct arm_smmu_domain *smmu_domain, +struct io_pgtable_cfg *pgtbl_cfg, +struct device *dev) +{ +struct arm_smmu_device *smmu = smmu_domain->smmu; +const struct device_node *np = smmu->dev->of_node; + +/* +* Tegra194 and Tegra234 SoCs have the erratum that causes walk cache +* entries to not be invalidated correctly. The problem is that the walk +* cache index generated for IOVA is not same across translation and +* invalidation requests. This is leading to page faults when PMD entry +* is released during unmap and populated with new PTE table during +* subsequent map request. Disabling large page mappings avoids the +* release of PMD entry and avoid translations seeing stale PMD entry in +* walk cache. +* Fix this by limiting the page mappings to PAGE_SIZE on Tegra194 and +* Tegra234. +*/ +if (of_device_is_compatible (np,"nvidia,tegra234-smmu" ) || +of_device_is_compatible (np,"nvidia,tegra194-smmu" )) { + smmu->pgsize_bitmap =PAGE_SIZE ; + pgtbl_cfg->pgsize_bitmap = smmu->pgsize_bitmap; + } + +return 0 ; +} +static const struct arm_smmu_impl nvidia_smmu_impl = { .read_reg = nvidia_smmu_read_reg, .write_reg = nvidia_smmu_write_reg,@@ -268,10 +296,12 @@ static const struct arm_smmu_impl nvidia_smmu_impl = { .global_fault = nvidia_smmu_global_fault, .context_fault = nvidia_smmu_context_fault, .probe_finalize = nvidia_smmu_probe_finalize, + .init_context = nvidia_smmu_init_context, };static const struct arm_smmu_impl nvidia_smmu_single_impl = { .probe_finalize = nvidia_smmu_probe_finalize, + .init_context = nvidia_smmu_init_context, };struct arm_smmu_device *nvidia_smmu_impl_init (struct arm_smmu_device *smmu)
Quoted 67 lines
Tegra194 and Tegra234 SoCs have the erratum that causes walk cache entries to not be invalidated correctly. The problem is that the walk cache index generated for IOVA is not same across translation and invalidation requests. This is leading to page faults when PMD entry is released during unmap and populated with new PTE table during subsequent map request. Disabling large page mappings avoids the release of PMD entry and avoid translations seeing stale PMD entry in walk cache.
Fix this by limiting the page mappings toPAGE_SIZEfor Tegra194 and Tegra234 devices. This is recommended fix from Tegra hardware design team.Co-developed-by Pritesh Raithatha <[email protected]>Signed-off-by Pritesh Raithatha <[email protected]>Signed-off-by Ashish Mhetre <[email protected]>---
Changes in v2:
- Usinginit_context()to overridepgsize_bitmapinstead of new functiondrivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c | 30 ++++++++++++++++++++ 1 file changed, 30 insertions(+)drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c +0
-0@@ -258,6 +258,34 @@ static void nvidia_smmu_probe_finalize(struct
arm_smmu_device*smmu, struct devidrivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c +1
-0dev_name(dev), err); } +static int nvidia_smmu_init_context(struct arm_smmu_domain
*smmu_domain,drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c +8
-0+struct io_pgtable_cfg *pgtbl_cfg, + struct device *dev) +{ + struct arm_smmu_device *smmu = smmu_domain->smmu; +const struct device_node *np = smmu->dev->of_node; + +/* +* Tegra194 and Tegra234 SoCs have the erratum that causes walk cache
drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c +19
-0+* entries to not be invalidated correctly. The problem is that the walk +* cache index generated for IOVA is not same across translation and +* invalidation requests. This is leading to page faults when PMD entry +* is released during unmap and populated with new PTE table during +* subsequent map request. Disabling large page mappings avoids the +* release of PMD entry and avoid translations seeing stale PMD entry in +* walk cache. +* Fix this by limiting the page mappings to PAGE_SIZE on Tegra194 and +* Tegra234. +*/ +if (of_device_is_compatible (np,"nvidia,tegra234-smmu" ) || +of_device_is_compatible (np,"nvidia,tegra194-smmu" )) { + smmu->pgsize_bitmap =PAGE_SIZE ; + pgtbl_cfg->pgsize_bitmap = smmu->pgsize_bitmap; + } + +return 0 ; +} +static const struct arm_smmu_impl nvidia_smmu_impl = { .read_reg = nvidia_smmu_read_reg, .write_reg = nvidia_smmu_write_reg,@@ -268,10 +296,12 @@ static const struct arm_smmu_impl nvidia_smmu_impl = { .global_fault = nvidia_smmu_global_fault,
drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c static const struct arm_smmu_impl · line 307
Quoted 10 lines
drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c +2
-0.context_fault = nvidia_smmu_context_fault, .probe_finalize = nvidia_smmu_probe_finalize, + .init_context = nvidia_smmu_init_context, };static const struct arm_smmu_impl nvidia_smmu_single_impl = { .probe_finalize = nvidia_smmu_probe_finalize, + .init_context = nvidia_smmu_init_context, };
-KR
Quoted 11 lines · Ashish Mhetre
Tegra194 and Tegra234 SoCs have the erratum that causes walk cache entries to not be invalidated correctly. The problem is that the walk cache index generated for IOVA is not same across translation and invalidation requests. This is leading to page faults when PMD entry is released during unmap and populated with new PTE table during subsequent map request. Disabling large page mappings avoids the release of PMD entry and avoid translations seeing stale PMD entry in walk cache. Fix this by limiting the page mappings to
PAGE_SIZEfor Tegra194 and Tegra234 devices. This is recommended fix from Tegra hardware design team.
Quoted 1 line
[...]
Applied to will (for-joerg/arm-smmu/fixes), thanks!
[1/1] iommu: arm-smmu: disable large page mappings for Nvidia arm-smmu
https://git.kernel.org/will/c/4a25f2ea0e03
Cheers,
Signature · 5 lines
Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev
Hi Will,
Quoted 12 lines · Will Deacon
Quoted 11 lines · Ashish Mhetre
Tegra194 and Tegra234 SoCs have the erratum that causes walk cache entries to not be invalidated correctly. The problem is that the walk cache index generated for IOVA is not same across translation and invalidation requests. This is leading to page faults when PMD entry is released during unmap and populated with new PTE table during subsequent map request. Disabling large page mappings avoids the release of PMD entry and avoid translations seeing stale PMD entry in walk cache. Fix this by limiting the page mappings to
PAGE_SIZEfor Tegra194 and Tegra234 devices. This is recommended fix from Tegra hardware design team.
Quoted 7 lines
Quoted 1 line
[...]
Applied to will (for-joerg/arm-smmu/fixes), thanks!
[1/1] iommu: arm-smmu: disable large page mappings for Nvidia arm-smmu
https://git.kernel.org/will/c/4a25f2ea0e03
Thanks for applying. Sorry to be late to the party, but feel free to add my ...
Also any chance we could tag for stable? Probably the most appropriate fixes-tag would be ...
Thanks!
Jon
Signature · 5 lines
nvpublic _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu