Skip to contentSkip to conversation

coccinelle: misc: Add array_size_dup script to detect missed overflow checks

PATCH Markus Elfring 1 participant 1 message Jun 17, 2020

lore
Share & tools
lore
#0 lore raw

I propose once more to avoid a typo in the previous patch subject.

…

Quoted 10 lines

(
- size = E1 * E2;
+ size = array_size(E1, E2);
|
- size = E1 * E2 * E3;
+ size = array3_size(E1, E2, E3);
|
- size = E1 * E2 + E3;
+ size = struct_size(E1, E2, E3);
)

How do you think about to use SmPL disjunctions like the following?

size =
(
- (E1) * (E2)
+ array_size(E1, E2)
|
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
|
- (E1) * (E2) + (E3)
+ struct_size(E1, E2, E3)
);

Quoted 2 lines

... when != size = E4

      when != size += E4

…

Can it become helpful to express a constraint for a metavariable of the type “assignment operator”?

Quoted 7 lines

(
* size = E1 * E2;@p
|
* size = E1 * E2 * E3;@p
|
* size = E1 * E2 + E3;@p
)

*size =@p \( (E1) * (E2) \| (E1) * (E2) * (E3) \| (E1) * (E2) + (E3) \)

Regards,
Markus