Skip to contentSkip to conversation

mime,mime-xdg: Conflict with allarch

PATCH In review Khem Raj 3 participants 6 messages Feb 25, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 mime,mime-xdg: Conflict with allarch

mime and mime-xdb classes add dependencies ( both runtime and buildtime ) on target packages, therefore recipes using allarch should not inherit mime/mime-xdg or vice-versa, this fixes subtle sstate mismatches

[YOCTO #13805]

Cc Andreas Müller <[email protected]>
---
 meta/classes/mime-xdg.bbclass | 5 +++++
 meta/classes/mime.bbclass     | 5 +++++
 2 files changed, 10 insertions(+)
meta/classes/mime-xdg.bbclass +5 -0
index 63169e990d..c175291814 100644
@@ -14,6 +14,11 @@ DESKTOPDIR = "${datadir}/applications"
 # skipped for MIME_XDG_PACKAGES not empty
 MIME_XDG_PACKAGES ?= ""
 
+python __anonymous() {
+    if bb.data.inherits_class('allarch', d):
+        bb.fatal("allarch and mime-xdg can not be inherited together")
+}
+
 mime_xdg_postinst() {
 if [ "x$D" != "x" ]; then
 	$INTERCEPT_DIR/postinst_intercept update_desktop_database ${PKG} \
meta/classes/mime.bbclass +5 -0
index c9072adf3b..f4ccac7bd4 100644
@@ -6,6 +6,11 @@ DEPENDS += "${@bb.utils.contains('BPN', 'shared-mime-info', '', 'shared-mime-inf
 PACKAGE_WRITE_DEPS += "shared-mime-info-native"
 MIMEDIR = "${datadir}/mime"
 
+python __anonymous() {
+    if bb.data.inherits_class('allarch', d):
+        bb.fatal("allarch and mime can not be inherited together")
+}
+
 mime_postinst() {
 if [ "x$D" != "x" ]; then
 	$INTERCEPT_DIR/postinst_intercept update_mime_database ${PKG} \
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · Khem Raj

mime and mime-xdb classes add dependencies ( both runtime and buildtime
) on target packages, therefore recipes using allarch should not inherit
mime/mime-xdg or vice-versa, this fixes subtle sstate mismatches

Quoted 8 lines

[YOCTO #13805]

Cc Andreas Müller <[email protected]>
---
 meta/classes/mime-xdg.bbclass | 5 +++++
 meta/classes/mime.bbclass     | 5 +++++
 2 files changed, 10 insertions(+)

Is this the right way to fix this? mime info probably is arch independent, so should we be whitelisting some of the dependencies?

Cheers,

Richard

#2 lore raw
Quoted 17 lines · Richard Purdie
Quoted 6 lines · Khem Raj

mime and mime-xdb classes add dependencies ( both runtime and buildtime
) on target packages, therefore recipes using allarch should not inherit
mime/mime-xdg or vice-versa, this fixes subtle sstate mismatches

Quoted 8 lines

[YOCTO #13805]

Cc Andreas Müller <[email protected]>
---
 meta/classes/mime-xdg.bbclass | 5 +++++
 meta/classes/mime.bbclass     | 5 +++++
 2 files changed, 10 insertions(+)
Quoted 7 lines

Is this the right way to fix this? mime info probably is arch independent, so should we be whitelisting some of the dependencies?

Cheers,

Richard

Khem and I had a short discussion about this [1]. His first approach was to remove DEPENDS. As far as I remember the deps were added to avoid QA warning.

Honestly I never understood why these are spawned. If there is a fix / workaround this could be reduced to rdeps which an be handled for allarch.

[1] https://github.com/YoeDistro/openembedded-core/commit/5605a9cf78c3731e2cc055cd4f8cc88a0b3d7e26

Andreas

#3 lore raw
Quoted 29 lines · Andreas Müller
Quoted 16 lines · Richard Purdie
Quoted 6 lines · Khem Raj

mime and mime-xdb classes add dependencies ( both runtime and buildtime
) on target packages, therefore recipes using allarch should not inherit
mime/mime-xdg or vice-versa, this fixes subtle sstate mismatches

Quoted 8 lines

[YOCTO #13805]

Cc Andreas Müller <[email protected]>
---
 meta/classes/mime-xdg.bbclass | 5 +++++
 meta/classes/mime.bbclass     | 5 +++++
 2 files changed, 10 insertions(+)
Quoted 7 lines

Is this the right way to fix this? mime info probably is arch independent, so should we be whitelisting some of the dependencies?

Cheers,

Richard

Khem and I had a short discussion about this [1]. His first approach was to remove DEPENDS. As far as I remember the deps were added to avoid QA warning.

Quoted 5 lines

Honestly I never understood why these are spawned. If there is a fix / workaround this could be reduced to rdeps which an be handled for allarch.

[1] https://github.com/YoeDistro/openembedded-core/commit/5605a9cf78c3731e2cc055cd4f8cc88a0b3d7e26

I'd guess something like:

SIGGEN_EXCLUDERECIPES_ABISAFE += "\
shared-mime-info \
desktop-file-utils \
"

in layer.conf might be the correct fix. The other approach is just a workaround.

Cheers,

Richard

#4 lore raw
Quoted 39 lines · Richard Purdie
Quoted 29 lines · Andreas Müller
Quoted 16 lines · Richard Purdie
Quoted 6 lines · Khem Raj

mime and mime-xdb classes add dependencies ( both runtime and buildtime
) on target packages, therefore recipes using allarch should not inherit
mime/mime-xdg or vice-versa, this fixes subtle sstate mismatches

Quoted 8 lines

[YOCTO #13805]

Cc Andreas Müller <[email protected]>
---
 meta/classes/mime-xdg.bbclass | 5 +++++
 meta/classes/mime.bbclass     | 5 +++++
 2 files changed, 10 insertions(+)
Quoted 7 lines

Is this the right way to fix this? mime info probably is arch independent, so should we be whitelisting some of the dependencies?

Cheers,

Richard

Khem and I had a short discussion about this [1]. His first approach was to remove DEPENDS. As far as I remember the deps were added to avoid QA warning.

Quoted 5 lines

Honestly I never understood why these are spawned. If there is a fix / workaround this could be reduced to rdeps which an be handled for allarch.

[1] https://github.com/YoeDistro/openembedded-core/commit/5605a9cf78c3731e2cc055cd4f8cc88a0b3d7e26

I'd guess something like:

Quoted 7 lines

SIGGEN_EXCLUDERECIPES_ABISAFE += "\
shared-mime-info \
desktop-file-utils \
"

in layer.conf might be the correct fix. The other approach is just a workaround.

That would fix rdeps allarch -> cross only - right?. How to get rid of the deps warning? @Khem: Do you have some logs showing what warning it was exactly?

Andreas

Quoted 7 lines

Cheers,

Richard

author
#5 lore raw
In reply to Richard Purdie
Quoted 38 lines · Richard Purdie
Quoted 29 lines · Andreas Müller
Quoted 16 lines · Richard Purdie
Quoted 6 lines · Khem Raj

mime and mime-xdb classes add dependencies ( both runtime and buildtime
) on target packages, therefore recipes using allarch should not inherit
mime/mime-xdg or vice-versa, this fixes subtle sstate mismatches

Quoted 8 lines

[YOCTO #13805]

Cc Andreas Müller <[email protected]>
---
  meta/classes/mime-xdg.bbclass | 5 +++++
  meta/classes/mime.bbclass     | 5 +++++
  2 files changed, 10 insertions(+)
Quoted 7 lines

Is this the right way to fix this? mime info probably is arch independent, so should we be whitelisting some of the dependencies?

Cheers,

Richard

Khem and I had a short discussion about this [1]. His first approach was to remove DEPENDS. As far as I remember the deps were added to avoid QA warning.

Quoted 5 lines

Honestly I never understood why these are spawned. If there is a fix / workaround this could be reduced to rdeps which an be handled for allarch.

[1] https://github.com/YoeDistro/openembedded-core/commit/5605a9cf78c3731e2cc055cd4f8cc88a0b3d7e26

I'd guess something like:

Quoted 7 lines
SIGGEN_EXCLUDERECIPES_ABISAFE += "\
   shared-mime-info \
   desktop-file-utils \

"

in layer.conf might be the correct fix. The other approach is just a workaround.

yeah, I am testing something like this.

Quoted 7 lines

Cheers,

Richard