Skip to contentSkip to conversation

dt-bindings: arm: pmu: Add Cortex-A520, Cortex-A715, and Cortex-A720

PATCH Superseded Rob Herring 4 participants 6 messages Jun 30, 2023 – Jul 5, 2023

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/2 dt-bindings: arm: pmu: Add Cortex-A520, Cortex-A715, and Cortex-A720

Add compatible strings for the Arm Cortex-A520, Cortex-A715, and Cortex-A720 CPU PMUs.

---
 Documentation/devicetree/bindings/arm/pmu.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/arm/pmu.yaml +3 -0
index e14358bf0b9c..0cc468d6c372 100644
@@ -49,7 +49,10 @@ properties:
           - arm,cortex-a77-pmu
           - arm,cortex-a78-pmu
           - arm,cortex-a510-pmu
+          - arm,cortex-a520-pmu
           - arm,cortex-a710-pmu
+          - arm,cortex-a715-pmu
+          - arm,cortex-a720-pmu
           - arm,cortex-x1-pmu
           - arm,cortex-x2-pmu
           - arm,neoverse-e1-pmu
Signature · 1 line
2.40.1
author maintainer
#1 lore raw

PATCH 2/2 perf: pmuv3: Add Cortex-A520, Cortex-A715, and Cortex-A720 PMUs

Add support for the Arm Cortex-A520, Cortex-A715, and Cortex-A720 CPU PMUs. They are straight-forward additions with just new compatible strings.

---
 drivers/perf/arm_pmuv3.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/perf/arm_pmuv3.c +6 -0
index 08b3a1bf0ef6..0bf522b05dc3 100644
@@ -1266,7 +1266,10 @@ PMUV3_INIT_SIMPLE(armv8_cortex_a76)
 PMUV3_INIT_SIMPLE(armv8_cortex_a77)
 PMUV3_INIT_SIMPLE(armv8_cortex_a78)
 PMUV3_INIT_SIMPLE(armv9_cortex_a510)
+PMUV3_INIT_SIMPLE(armv9_cortex_a520)
 PMUV3_INIT_SIMPLE(armv9_cortex_a710)
+PMUV3_INIT_SIMPLE(armv9_cortex_a715)
+PMUV3_INIT_SIMPLE(armv9_cortex_a720)
 PMUV3_INIT_SIMPLE(armv8_cortex_x1)
 PMUV3_INIT_SIMPLE(armv9_cortex_x2)
 PMUV3_INIT_SIMPLE(armv8_neoverse_e1)
@@ -1334,7 +1337,10 @@ static const struct of_device_id armv8_pmu_of_device_ids[] = {
 	{.compatible = "arm,cortex-a77-pmu",	.data = armv8_cortex_a77_pmu_init},
 	{.compatible = "arm,cortex-a78-pmu",	.data = armv8_cortex_a78_pmu_init},
 	{.compatible = "arm,cortex-a510-pmu",	.data = armv9_cortex_a510_pmu_init},
+	{.compatible = "arm,cortex-a520-pmu",	.data = armv9_cortex_a520_pmu_init},
 	{.compatible = "arm,cortex-a710-pmu",	.data = armv9_cortex_a710_pmu_init},
+	{.compatible = "arm,cortex-a715-pmu",	.data = armv9_cortex_a715_pmu_init},
+	{.compatible = "arm,cortex-a720-pmu",	.data = armv9_cortex_a720_pmu_init},
 	{.compatible = "arm,cortex-x1-pmu",	.data = armv8_cortex_x1_pmu_init},
 	{.compatible = "arm,cortex-x2-pmu",	.data = armv9_cortex_x2_pmu_init},
 	{.compatible = "arm,neoverse-e1-pmu",	.data = armv8_neoverse_e1_pmu_init},
Signature · 1 line
2.40.1
maintainer Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] perf: pmuv3: Add Cortex-A520, Cortex-A715, and Cortex-A720 PMUs

Quoted 5 lines · Rob Herring

Add support for the Arm Cortex-A520, Cortex-A715, and Cortex-A720 CPU PMUs. They are straight-forward additions with just new compatible strings.

Mark.

Quoted 33 lines
---
 drivers/perf/arm_pmuv3.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/perf/arm_pmuv3.c +6 -0
index 08b3a1bf0ef6..0bf522b05dc3 100644
@@ -1266,7 +1266,10 @@ PMUV3_INIT_SIMPLE(armv8_cortex_a76)
 PMUV3_INIT_SIMPLE(armv8_cortex_a77)
 PMUV3_INIT_SIMPLE(armv8_cortex_a78)
 PMUV3_INIT_SIMPLE(armv9_cortex_a510)
+PMUV3_INIT_SIMPLE(armv9_cortex_a520)
 PMUV3_INIT_SIMPLE(armv9_cortex_a710)
+PMUV3_INIT_SIMPLE(armv9_cortex_a715)
+PMUV3_INIT_SIMPLE(armv9_cortex_a720)
 PMUV3_INIT_SIMPLE(armv8_cortex_x1)
 PMUV3_INIT_SIMPLE(armv9_cortex_x2)
 PMUV3_INIT_SIMPLE(armv8_neoverse_e1)
@@ -1334,7 +1337,10 @@ static const struct of_device_id armv8_pmu_of_device_ids[] = {
 	{.compatible = "arm,cortex-a77-pmu",	.data = armv8_cortex_a77_pmu_init},
 	{.compatible = "arm,cortex-a78-pmu",	.data = armv8_cortex_a78_pmu_init},
 	{.compatible = "arm,cortex-a510-pmu",	.data = armv9_cortex_a510_pmu_init},
+	{.compatible = "arm,cortex-a520-pmu",	.data = armv9_cortex_a520_pmu_init},
 	{.compatible = "arm,cortex-a710-pmu",	.data = armv9_cortex_a710_pmu_init},
+	{.compatible = "arm,cortex-a715-pmu",	.data = armv9_cortex_a715_pmu_init},
+	{.compatible = "arm,cortex-a720-pmu",	.data = armv9_cortex_a720_pmu_init},
 	{.compatible = "arm,cortex-x1-pmu",	.data = armv8_cortex_x1_pmu_init},
 	{.compatible = "arm,cortex-x2-pmu",	.data = armv9_cortex_x2_pmu_init},
 	{.compatible = "arm,neoverse-e1-pmu",	.data = armv8_neoverse_e1_pmu_init},
Signature · 1 line
2.40.1
#4 lore raw
In reply to Rob Herring
Quoted 13 lines · Rob Herring

Add compatible strings for the Arm Cortex-A520, Cortex-A715, and Cortex-A720 CPU PMUs.

---
  Documentation/devicetree/bindings/arm/pmu.yaml | 3 +++
  1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/arm/pmu.yaml +0 -0
index e14358bf0b9c..0cc468d6c372 100644

Documentation/devicetree/bindings/arm/pmu.yaml properties: · line 57

Quoted 9 lines
Documentation/devicetree/bindings/arm/pmu.yaml +3 -0
@@ -49,7 +49,10 @@ properties:
            - arm,cortex-a77-pmu
            - arm,cortex-a78-pmu
            - arm,cortex-a510-pmu
+          - arm,cortex-a520-pmu
            - arm,cortex-a710-pmu
+          - arm,cortex-a715-pmu
+          - arm,cortex-a720-pmu
            - arm,cortex-x1-pmu
            - arm,cortex-x2-pmu

Should we catch up on Cortex-X (3 and 4 now) while we're at it?

Cheers,
Robin.

Quoted 1 line
Documentation/devicetree/bindings/arm/pmu.yaml +0 -0
            - arm,neoverse-e1-pmu
author maintainer
#5 lore raw
Quoted 10 lines · Robin Murphy
Quoted 8 lines · Rob Herring

Add compatible strings for the Arm Cortex-A520, Cortex-A715, and Cortex-A720 CPU PMUs.

---
  Documentation/devicetree/bindings/arm/pmu.yaml | 3 +++
  1 file changed, 3 insertions(+)
Quoted 16 lines
Quoted 5 lines
Documentation/devicetree/bindings/arm/pmu.yaml +0 -0
index e14358bf0b9c..0cc468d6c372 100644

Documentation/devicetree/bindings/arm/pmu.yaml properties: · line 57

Quoted 9 lines
Documentation/devicetree/bindings/arm/pmu.yaml +3 -0
@@ -49,7 +49,10 @@ properties:
            - arm,cortex-a77-pmu
            - arm,cortex-a78-pmu
            - arm,cortex-a510-pmu
+          - arm,cortex-a520-pmu
            - arm,cortex-a710-pmu
+          - arm,cortex-a715-pmu
+          - arm,cortex-a720-pmu
            - arm,cortex-x1-pmu
            - arm,cortex-x2-pmu

Should we catch up on Cortex-X (3 and 4 now) while we're at it?

Yes. I'll add those.

Looking a bit further at this, it seems a bunch of platforms (including a Cortex-X3 based one) are just using "arm,armv8-pmuv3". That's supposed to be just for s/w models, but it's not enforceable.

Rob