leds: LP55XX_COMMON needs to depend on LEDS_CLASS
PATCH 1/1 leds: LP55XX_COMMON needs to depend on LEDS_CLASS
From: Randy Dunlap <[email protected]>
With these kernel configs:CONFIG_LEDS_CLASS=m
# CONFIG_LEDS_CLASS_MULTICOLOR is not setCONFIG_LEDS_LP55XX_COMMON=yCONFIG_LEDS_LP5521=mCONFIG_LEDS_LP5562=m
leds-lp55xx-common.c has a build error because it is builtin and calls an interface that is built as a loadable module (due to LEDS_CLASS=m). By making LEDS_LP55XX_COMMON depend on LEDS_CLASS, this config combination cannot happen, thus preventing the build error.
ld: drivers/leds/leds-lp55xx-common.o: in function `lp55xx_register_leds':
leds-lp55xx-common.c:(.text+0xc5f): undefined reference to `devm_led_classdev_register_ext'
---
The Fixes: tag might be incorrect... I also considered:92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
drivers/leds/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/leds/Kconfig +1 -0
@@ -397,6 +397,7 @@ config LEDS_LP3952 config LEDS_LP55XX_COMMON tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501" + depends on LEDS_CLASS depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR depends on OF depends on I2C
Hi!
Quoted 23 lines
From: Randy Dunlap <[email protected]>
With these kernel configs:
CONFIG_LEDS_CLASS=m
#CONFIG_LEDS_CLASS_MULTICOLORis not setCONFIG_LEDS_LP55XX_COMMON=yCONFIG_LEDS_LP5521=mCONFIG_LEDS_LP5562=m
leds-lp55xx-common.chas a build error because it is builtin and calls an interface that is built as a loadable module (due to LEDS_CLASS=m). By makingLEDS_LP55XX_COMMONdepend onLEDS_CLASS, this config combination cannot happen, thus preventing the build error.ld:
drivers/leds/leds-lp55xx-common.o: in function `lp55xx_register_leds':
leds-lp55xx-common.c:(.text+0xc5f): undefined reference to `devm_led_classdev_register_ext'Fixes 33b3a561f417 ("leds: support new LP8501 device - another LP55xx common")Signed-off-by Randy Dunlap <[email protected]>Cc Pavel Machek <[email protected]>Cc Dan Murphy <[email protected]>Cc Milo Kim <[email protected]>
Quoted 4 lines
---
The Fixes: tag might be incorrect... I also considered:92a81562e695("leds: lp55xx: Add multicolor framework support to lp55xx")
Thanks, makes sense, I'll take this one. I believe the second fixes tag is correct; not that it matters.
Thanks and best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html