EDAC/xgene: Use devm_platform_get_and_ioremap_resource() in xgene_edac_probe()
Subsystems (3)
PATCH 1/1 EDAC/xgene: Use devm_platform_get_and_ioremap_resource() in xgene_edac_probe()
From: Markus Elfring <[email protected]>
Date: Mon, 5 Feb 2024 08:12:24 +0100
A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6 ("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.
This issue was detected by using the Coccinelle software.
--- drivers/edac/xgene_edac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/edac/xgene_edac.c +1 -2
@@ -1903,8 +1903,7 @@ static int xgene_edac_probe(struct platform_device *pdev) edac->rb_map =NULL ; } - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - edac->pcp_csr =devm_ioremap_resource (&pdev->dev, res); + edac->pcp_csr =devm_platform_get_and_ioremap_resource (pdev,0 , &res);if (IS_ERR (edac->pcp_csr)) {dev_err (&pdev->dev,"no PCP resource address\n" ); rc =PTR_ERR (edac->pcp_csr);
--
2.43.0
PATCH v2 1/1 EDAC/xgene: Use devm_platform_ioremap_resource() in xgene_edac_probe()
From: Markus Elfring <[email protected]>
Date: Tue, 6 Feb 2024 17:30:11 +0100
A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 ("drivers: provide devm_platform_ioremap_resource()").
* Thus reuse existing functionality instead of keeping duplicate source code.
* Delete a local variable which became unnecessary with this refactoring.
This issue was transformed by using the Coccinelle software.
---
v2:
The transformation pattern was adjusted based on advices by known contributors.
Examples:
* Doug Anderson
* Geert Uytterhoeven
* Robin Murphy
drivers/edac/xgene_edac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/edac/xgene_edac.c +1 -3
@@ -1845,7 +1845,6 @@ static int xgene_edac_probe(struct platform_device *pdev) {struct xgene_edac *edac;struct device_node *child; -struct resource *res;int rc; edac =devm_kzalloc (&pdev->dev,sizeof (*edac),GFP_KERNEL );
@@ -1903,8 +1902,7 @@ static int xgene_edac_probe(struct platform_device *pdev) edac->rb_map =NULL ; } - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - edac->pcp_csr =devm_ioremap_resource (&pdev->dev, res); + edac->pcp_csr =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (edac->pcp_csr)) {dev_err (&pdev->dev,"no PCP resource address\n" ); rc =PTR_ERR (edac->pcp_csr);
--
2.43.0