iommu/arm-smmu: Make remove callback message more informative
Subsystems (2)
PATCH v2 1/1 iommu/arm-smmu: Make remove callback message more informative
Currently on reboot/shutdown, the following messages are displayed on the console as error messages before the system reboots/shutdown as part of remove callback.
On SC7180:
arm-smmu 15000000.iommu: removing device with active domains! arm-smmu 5040000.iommu: removing device with active domains!
Make this error message more informative and less scary.
--- drivers/iommu/arm-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/arm-smmu.c +1 -1
@@ -2244,7 +2244,7 @@ static int arm_smmu_device_remove(struct platform_device *pdev)return -ENODEV ;if (!bitmap_empty (smmu->context_map,ARM_SMMU_MAX_CBS )) -dev_err (&pdev->dev,"removing device with active domains!\n" ); +dev_info (&pdev->dev,"disabling translation\n" );arm_smmu_bus_init (NULL );iommu_device_unregister (&smmu->iommu);
Signature · 6 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Hi,
Quoted 10 lines · Sai Prakash Ranjan
Currently on reboot/shutdown, the following messages are displayed on the console as error messages before the system reboots/shutdown as part of remove callback.
On SC7180:
arm-smmu 15000000.iommu: removing device with active domains! arm-smmu 5040000.iommu: removing device with active domains!
Quoted 8 lines
Make this error message more informative and less scary.
Reported-by Douglas Anderson <[email protected]>Suggested-by Robin Murphy <[email protected]>Signed-off-by Sai Prakash Ranjan <[email protected]>--- drivers/iommu/arm-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Hi,
Quoted 17 lines · Doug Anderson
Hi,
Quoted 12 lines · Sai Prakash Ranjan
Currently on reboot/shutdown, the following messages are displayed on the console as error messages before the system reboots/shutdown as part of remove callback.
On SC7180:
arm-smmu 15000000.iommu: removing device with active domains! arm-smmu 5040000.iommu: removing device with active domains!
Make this error message more informative and less scary.
Quoted 8 lines
Quoted 6 lines
Reported-by Douglas Anderson <[email protected]>Suggested-by Robin Murphy <[email protected]>Signed-off-by Sai Prakash Ranjan <[email protected]>--- drivers/iommu/arm-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Reviewed-by Douglas Anderson <[email protected]>
Is this patch waiting on anything in particular now? Do we need reviews from Robin and/or Will?
-Doug
Hi,
Quoted 27 lines · Doug Anderson
Hi,
Quoted 24 lines · Doug Anderson
Hi,
Quoted 18 lines · Sai Prakash Ranjan
Currently on reboot/shutdown, the following messages are displayed on the console as error messages before the system reboots/shutdown as part of remove callback.
On SC7180:
arm-smmu 15000000.iommu: removing device with active domains! arm-smmu 5040000.iommu: removing device with active domains!
Make this error message more informative and less scary.
Reported-by Douglas Anderson <[email protected]>Suggested-by Robin Murphy <[email protected]>Signed-off-by Sai Prakash Ranjan <[email protected]>--- drivers/iommu/arm-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines
Quoted 1 line
Reviewed-by Douglas Anderson <[email protected]>Is this patch waiting on anything in particular now? Do we need reviews from Robin and/or Will?
Waiting for their reviews as they are the maintainers/reviewers :)
-Sai
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Robin Murphy
reviewerQuoted 30 lines · Sai Prakash Ranjan
Hi,
Quoted 27 lines · Doug Anderson
Hi,
Quoted 24 lines · Doug Anderson
Hi,
Quoted 18 lines · Sai Prakash Ranjan
Currently on reboot/shutdown, the following messages are displayed on the console as error messages before the system reboots/shutdown as part of remove callback.
On SC7180:
arm-smmu 15000000.iommu: removing device with active domains! arm-smmu 5040000.iommu: removing device with active domains!
Make this error message more informative and less scary.
Reported-by Douglas Anderson <[email protected]>Suggested-by Robin Murphy <[email protected]>Signed-off-by Sai Prakash Ranjan <[email protected]>---
drivers/iommu/arm-smmu.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Reviewed-by Douglas Anderson <[email protected]>Is this patch waiting on anything in particular now? Do we need reviews from Robin and/or Will?
Waiting for their reviews as they are the maintainers/reviewers :)
Sorry, this did register at the time, I just felt that it's a bit redundant to give a review tag to say "yes, this is exactly what I suggested" :)
That said, I do wish I hadn't forgotten about the dev_notice message level, but I think that lies over in the conceptual purity corner rather than making any practical difference, so I'm still OK with the patch as-is. Will?
Robin.
p.s. whoever has this entry in their address book for the IOMMU list (Doug?):
"[email protected]:IOMMU DRIVERS <[email protected]>, Joerg Roedel <[email protected]>," <[email protected]>
it really messes up Thunderbird's ability to generate working headers for a reply ;)
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 39 lines · Robin Murphy
Quoted 30 lines · Sai Prakash Ranjan
Hi,
Quoted 27 lines · Doug Anderson
Hi,
Quoted 24 lines · Doug Anderson
Hi,
Quoted 18 lines · Sai Prakash Ranjan
Currently on reboot/shutdown, the following messages are displayed on the console as error messages before the system reboots/shutdown as part of remove callback.
On SC7180:
arm-smmu 15000000.iommu: removing device with active domains! arm-smmu 5040000.iommu: removing device with active domains!
Make this error message more informative and less scary.
Reported-by Douglas Anderson <[email protected]>Suggested-by Robin Murphy <[email protected]>Signed-off-by Sai Prakash Ranjan <[email protected]>---
drivers/iommu/arm-smmu.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Reviewed-by Douglas Anderson <[email protected]>Is this patch waiting on anything in particular now? Do we need reviews from Robin and/or Will?
Waiting for their reviews as they are the maintainers/reviewers :)
Quoted 9 lines
Sorry, this did register at the time, I just felt that it's a bit redundant to give a review tag to say "yes, this is exactly what I suggested" :)
That said, I do wish I hadn't forgotten about the
dev_noticemessage level, but I think that lies over in the conceptual purity corner rather than making any practical difference, so I'm still OK with the patch as-is. Will?
I can change to dev_notice if you have strong preference for that. I chose dev_info since we see the messages on every reboot and that makes it more informational than something to notice everytime.
Quoted 8 lines
p.s. whoever has this entry in their address book for the IOMMU list (Doug?):
"[email protected]:IOMMU DRIVERS <[email protected]>, Joerg Roedel <[email protected]>," <[email protected]>
it really messes up Thunderbird's ability to generate working headers for a reply ;)
Not me ;)
Thanks,
Sai
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 10 lines · Sai Prakash Ranjan
Currently on reboot/shutdown, the following messages are displayed on the console as error messages before the system reboots/shutdown as part of remove callback.
On SC7180:
arm-smmu 15000000.iommu: removing device with active domains! arm-smmu 5040000.iommu: removing device with active domains!
[...]
Applied to will (for-joerg/arm-smmu/updates), thanks!
[1/1] iommu/arm-smmu: Make remove callback message more informative
https://git.kernel.org/will/c/02782f3d60f1
Cheers,
Signature · 5 lines
Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev