Skip to contentSkip to conversation

ARM: dts: stm32: Add display support on stm32f469-disco

PATCH In review Philippe Cornu 3 participants 6 messages Feb 15, 2018 – May 3, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover ARM: dts: stm32: Add display support on stm32f469-disco

This serie adds the mipi dsi support to stm32f469 and enables it on the stm32f469-disco board.

Philippe CORNU (1):
ARM: dts: stm32: Add display support on stm32f469-disco

Philippe Cornu (2):
ARM: dts: stm32: Add dt-bindings gpio.h include on stm32f469-disco
ARM: dts: stm32: Add new stm32f469 dtsi file with mipi dsi

 arch/arm/boot/dts/stm32f469-disco.dts | 54 +++++++++++++++++++++++++++++++++--
 arch/arm/boot/dts/stm32f469.dtsi      | 19 ++++++++++++
 2 files changed, 71 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/boot/dts/stm32f469.dtsi
Signature · 1 line
2.15.1
#1 lore raw

PATCH 1/3 ARM: dts: stm32: Add dt-bindings gpio.h include on stm32f469-disco

Add dt-bindings/gpio/gpio.h include and use it on vcc5v_otg.

---
 arch/arm/boot/dts/stm32f469-disco.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/stm32f469-disco.dts +2 -1
index bdd03ac7a4b5..7d53b794d27b 100644
@@ -48,6 +48,7 @@
 /dts-v1/;
 #include "stm32f429.dtsi"
 #include "stm32f469-pinctrl.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "STMicroelectronics STM32F469i-DISCO board";
@@ -74,7 +75,7 @@
 	vcc5v_otg: vcc5v-otg-regulator {
 		compatible = "regulator-fixed";
 		enable-active-high;
-		gpio = <&gpiob 2 0>;
+		gpio = <&gpiob 2 GPIO_ACTIVE_HIGH>;
 		regulator-name = "vcc5_host1";
 		regulator-always-on;
 	};
Signature · 1 line
2.15.1
#2 lore raw

PATCH 2/3 ARM: dts: stm32: Add new stm32f469 dtsi file with mipi dsi

In reply to Philippe Cornu

In the stm32f4 family, mipi dsi is only supported on stm32f469. So add a new stm32f469 dtsi file & add mipi dsi support inside.

---
 arch/arm/boot/dts/stm32f469.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 arch/arm/boot/dts/stm32f469.dtsi
arch/arm/boot/dts/stm32f469.dtsi new file +19 -0
new file mode 100644
index 000000000000..5ae5213f68cb
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
+/* Copyright (C) STMicroelectronics 2017 - All Rights Reserved */
+
+#include "stm32f429.dtsi"
+
+/ {
+	soc {
+		dsi: dsi at 40016c00 {
+			compatible = "st,stm32-dsi";
+			reg = <0x40016c00 0x800>;
+			interrupts = <92>;
+			resets = <&rcc STM32F4_APB2_RESET(DSI)>;
+			reset-names = "apb";
+			clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
+			clock-names = "pclk", "ref";
+			status = "disabled";
+		};
+	};
+};
Signature · 1 line
2.15.1
#3 lore raw

PATCH 3/3 ARM: dts: stm32: Add display support on stm32f469-disco

In reply to Philippe Cornu

From: Philippe CORNU <[email protected]>

Add display support on the stm32f469-disco board.

---
 arch/arm/boot/dts/stm32f469-disco.dts | 51 ++++++++++++++++++++++++++++++++++-
 1 file changed, 50 insertions(+), 1 deletion(-)
arch/arm/boot/dts/stm32f469-disco.dts +50 -1
index 7d53b794d27b..9bfb040e9909 100644
@@ -46,7 +46,7 @@
  */
 
 /dts-v1/;
-#include "stm32f429.dtsi"
+#include "stm32f469.dtsi"
 #include "stm32f469-pinctrl.dtsi"
 #include <dt-bindings/gpio/gpio.h>
 
@@ -89,6 +89,55 @@
 	clock-frequency = <8000000>;
 };
 
+&dsi {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";
+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port at 0 {
+			reg = <0>;
+			dsi_in: endpoint {
+				remote-endpoint = <&ltdc_out_dsi>;
+			};
+		};
+
+		port at 1 {
+			reg = <1>;
+			dsi_out: endpoint {
+				remote-endpoint = <&dsi_panel_in>;
+			};
+		};
+	};
+
+	panel-dsi at 0 {
+		compatible = "orisetech,otm8009a";
+		reg = <0>; /* dsi virtual channel (0..3) */
+		reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>;
+		status = "okay";
+
+		port {
+			dsi_panel_in: endpoint {
+				remote-endpoint = <&dsi_out>;
+			};
+		};
+	};
+};
+
+&ltdc {
+	dma-ranges;
+	status = "okay";
+
+	port {
+		ltdc_out_dsi: endpoint at 0 {
+			remote-endpoint = <&dsi_in>;
+		};
+	};
+};
+
 &rtc {
 	status = "okay";
 };
Signature · 1 line
2.15.1
#4 lore raw
Thank you for the patch! Yet something to improve:

Hi Philippe,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.16-rc1 next-20180216]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Philippe-Cornu/ARM-dts-stm32-Add-display-support-on-stm32f469-disco/20180218-052546
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-at91_dt_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0

reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/stm32f469.dtsi:14.21-22 syntax error

FATAL ERROR: Unable to parse input tree

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 23600 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180218/8e12c2c1/attachment-0001.gz>

#5 lore raw
In reply to Philippe Cornu

Hi Philippe

Quoted 6 lines · Philippe Cornu

This serie adds the mipi dsi support to stm32f469 and enables it on the stm32f469-disco board.

Philippe CORNU (1):
ARM: dts: stm32: Add display support on stm32f469-disco

Quoted 9 lines

Philippe Cornu (2):
ARM: dts: stm32: Add dt-bindings gpio.h include on stm32f469-disco
ARM: dts: stm32: Add new stm32f469 dtsi file with mipi dsi

  arch/arm/boot/dts/stm32f469-disco.dts | 54 +++++++++++++++++++++++++++++++++--
  arch/arm/boot/dts/stm32f469.dtsi      | 19 ++++++++++++
  2 files changed, 71 insertions(+), 2 deletions(-)

create mode 100644 arch/arm/boot/dts/stm32f469.dtsi

Thanks for new dtsi file. Series applied on stm32-next.

Regards
Alex