Skip to contentSkip to conversation

ALSA: hda: Increase default bdl_pos_adj for Apollo Lake

PATCH In review Rui Salvaterra 2 participants 3 messages Jan 22, 2024 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda: Increase default bdl_pos_adj for Apollo Lake

Apollo Lake seems to also suffer from IRQ timing issues. After being up for ~4 minutes, a Pentium N4200 system ends up falling back to workqueue-based IRQ handling:

[  208.019906] snd_hda_intel 0000:00:0e.0: IRQ timing workaround is activated

for card #0. Suggest a bigger bdl_pos_adj.

Unfortunately, the Baytrail and Braswell workaround value of 32 samples isn't enough to fix the issue here. Default to 64 samples.

---
 sound/pci/hda/hda_intel.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/hda_intel.c +2 -0
index 2276adc84478..9fb54813693c 100644
@@ -1732,6 +1732,8 @@ static int default_bdl_pos_adj(struct azx *chip)
 		case 0x0f04: /* Baytrail */
 		case 0x2284: /* Braswell */
 			return 32;
+		case 0x5a98: /* Apollo Lake */
+			return 64;
 		}
 	}
 
Signature · 1 line
2.43.0
#1 lore raw
Quoted 20 lines · Rui Salvaterra

Apollo Lake seems to also suffer from IRQ timing issues. After being up for ~4 minutes, a Pentium N4200 system ends up falling back to workqueue-based IRQ handling:

[  208.019906] snd_hda_intel 0000:00:0e.0: IRQ timing workaround is activated

for card #0. Suggest a bigger bdl_pos_adj.

Unfortunately, the Baytrail and Braswell workaround value of 32 samples isn't enough to fix the issue here. Default to 64 samples.

---
  sound/pci/hda/hda_intel.c | 2 ++
  1 file changed, 2 insertions(+)
sound/pci/hda/hda_intel.c +0 -0
index 2276adc84478..9fb54813693c 100644

sound/pci/hda/hda_intel.c static int default_bdl_pos_adj(struct azx *chip) · line 1739

Quoted 8 lines
sound/pci/hda/hda_intel.c +2 -0
@@ -1732,6 +1732,8 @@ static int default_bdl_pos_adj(struct azx *chip)
  		case 0x0f04: /* Baytrail */
  		case 0x2284: /* Braswell */
  			return 32;
+		case 0x5a98: /* Apollo Lake */
+			return 64;
  		}
  	}
 

And seems like I've missed some IDs, when doing PCI IDs conversion. Anyway, can you use PCI_DEVICE_ID_INTEL_HDA_APL instead of 0x5a98 as it is self describing (no need for comment)?

And if you want more patches in kernel - convert first 0x0f04 & 0x2284 to PCI_DEVICE_ID_INTEL_HDA_BYT & PCI_DEVICE_ID_INTEL_HDA_BSW and then do the above change ;)

#2 lore raw

Hi, Amadeusz,

Quoted 1 line · Amadeusz Sławiński

[snipped]

Quoted 3 lines

And seems like I've missed some IDs, when doing PCI IDs conversion. Anyway, can you use PCI_DEVICE_ID_INTEL_HDA_APL instead of 0x5a98 as it is self describing (no need for comment)?

Oh, of course! I would have done it if I knew we had those constants defined. :)

Quoted 3 lines

And if you want more patches in kernel - convert first 0x0f04 & 0x2284 to PCI_DEVICE_ID_INTEL_HDA_BYT & PCI_DEVICE_ID_INTEL_HDA_BSW and then do the above change ;)

Killing magic numbers is always a worthwhile goal. Expect a two-patch series soon, then. ;)

Cheers,
Rui